On 20/02/2020 10:21, Carsten Klein wrote:
> Hi there,
>
> what to do next to get things moving? Seems like there's nothing more to
> implement for the addition right now. Should I just create a PR in the
> apache/tomcat repository? And/or post some lines to the dev mailing list?
Creating a PR not
Hi there,
what to do next to get things moving? Seems like there's nothing more to
implement for the addition right now. Should I just create a PR in the
apache/tomcat repository? And/or post some lines to the dev mailing list?
Carsten
---
Jonathan,
On Tue, Feb 18, 2020 at 5:29 PM Jonathan S. Fisher wrote:
For older versions of tomcat, I'd suggest adding an additional option that
causes GenericPrincipal to drop the password after authentication is
complete, by default if persistAuthentication is enabled, which alleviates
your conc
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Carsten,
On 2/19/20 09:45, Carsten Klein wrote:
> Chris,
>
> there is a new PR #2, I messed up my branch and had to setup a new
> one... Still a bit new to GIT...
>
> https://github.com/cklein05/tomcat/pull/2
Aha, okay. I think I've been commenting
Chris,
there is a new PR #2, I messed up my branch and had to setup a new
one... Still a bit new to GIT...
https://github.com/cklein05/tomcat/pull/2
Actually, I decided to just add the String array. That's not too bad
either, right? Have a look at the latest code and comment in PR #2.
Sorr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Carsten,
On 2/19/20 03:59, Carsten Klein wrote:
> Hi there,
>
> had to re-setup my branch... Nevertheless, updated PR is available
> now.
>
> Some last things...
>
> The pattern for default sessionAttributeValueClassNameFilter must
> even be extende
Hi there,
had to re-setup my branch... Nevertheless, updated PR is available now.
Some last things...
The pattern for default sessionAttributeValueClassNameFilter must even
be extended to match String arrays as well (roles are stored that way).
In order to keep the pattern smaller, one option
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Carsten,
On 2/18/20 12:47, Carsten Klein wrote:
> Hi there,
>
> most of the issues discussed with/suggested by Mark Thomas should
> be in place now. The renamed PR should now show a much better code
> basis for further discussions.
>
>> b) Please ad
Hi there,
most of the issues discussed with/suggested by Mark Thomas should be in
place now. The renamed PR should now show a much better code basis for
further discussions.
b) Please add a changelog entry for this addition.
Still looking for the change log file...
Carsten
--
j) At a minimum, new Manager attributes need to be added here:
https://github.com/apache/tomcat/blob/master/webapps/docs/config/manager.xml
Here's an online preview of the updated Manger documentation:
http://office.datagis.com/pub/tomcat-9.0.x/docs/config/manager.html
These are the changes
https://github.com/cklein05/tomcat/pull/1/files
Remy: Thank you for the feedback, but please see the other threads about
this. The feature is not there right now because not everyone can/wants to
use the Delta Session Manager. For instance, we do _not_ want a p2p
architecture as they create scala
Open the pull request in your own fork... this link should work:
https://github.com/cklein05/tomcat/compare/cklein05:master...cklein05:session-manager-persist-authentication?expand=1
Done.
Carsten
-
To unsubscribe, e-mail: use
Open the pull request in your own fork... this link should work:
https://github.com/cklein05/tomcat/compare/cklein05:master...cklein05:session-manager-persist-authentication?expand=1
On Tue, Feb 18, 2020 at 6:42 AM Carsten Klein wrote:
> Mark,
>
> > Please don't be put off by the number of comme
Mark,
Please don't be put off by the number of comments and suggested changes.
I think the core idea is sound and meets a valid requirement that some
users have. To some extent, the volume of comments reflects that fact
I'm responding to a clear proposal and explanation. This is a good thing
in
On Tue, Feb 18, 2020 at 9:19 AM Carsten Klein wrote:
Rémy,
Can you describe an actual use case for this ? Without clustering, I
don't
understand why the auth persistence is useful at all [when using
clustering, the delta manager persists that auth information]. To be
honest, that's also th
On 17/02/2020 17:31, Carsten Klein wrote:
> Hi there,
>
> finally, I got my first Tomcat enhancement ready. You can view its code
> at my Tomcat fork on GitHub:
>
> https://github.com/cklein05/tomcat/tree/session-manager-persist-authentication
>
>
> Before I'm opening an enhancement in Tomcat's
On Tue, Feb 18, 2020 at 9:19 AM Carsten Klein wrote:
> Rémy,
>
>
> > Can you describe an actual use case for this ? Without clustering, I
> don't
> > understand why the auth persistence is useful at all [when using
> > clustering, the delta manager persists that auth information]. To be
> > hones
Rémy,
Can you describe an actual use case for this ? Without clustering, I don't
understand why the auth persistence is useful at all [when using
clustering, the delta manager persists that auth information]. To be
honest, that's also the case for session persistence itself, which does not
prov
Jonathan,
I'm not quite sure whether it's not too early for a PR... :-) I was
waiting for some remarks on my code, prior to officially release a PR.
Can't you just do a Compare on GitHub?
Carsten
Can you open a PR so we can diff your changes? Very excited to see this! We
used a workaround
On Mon, Feb 17, 2020 at 6:31 PM Carsten Klein wrote:
> Hi there,
>
> finally, I got my first Tomcat enhancement ready. You can view its code
> at my Tomcat fork on GitHub:
>
>
> https://github.com/cklein05/tomcat/tree/session-manager-persist-authentication
>
> Before I'm opening an enhancement in
Can you open a PR so we can diff your changes? Very excited to see this! We
used a workaround in a Valve to add the authentication information into the
session.
On Mon, Feb 17, 2020 at 11:31 AM Carsten Klein wrote:
> Hi there,
>
> finally, I got my first Tomcat enhancement ready. You can view it
Hi there,
finally, I got my first Tomcat enhancement ready. You can view its code
at my Tomcat fork on GitHub:
https://github.com/cklein05/tomcat/tree/session-manager-persist-authentication
Before I'm opening an enhancement in Tomcat's Bugzilla, maybe, Mark and
Christopher (or whoever else i
22 matches
Mail list logo
