Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-26 Thread Mark Thomas
On 26/04/2019 21:07, Olivier Jaquemet wrote: > PS : completely unrelated to this matter, I just find out that the page > https://tomcat.apache.org/svn.html contains outdated information and > should probably removed as it as been replaced with > https://tomcat.apache.org/source.html There is me

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-26 Thread Olivier Jaquemet
On 26/04/2019 09:56, Mark Thomas wrote: There was an extra copy but Chris's suggestion got me thinking and I found a much better solution. The patch has been applied to 9.0.x and 8.5.x and will be in the next release of both. 7.0.x is not affected. The patch fixes the OutOfMemoryError and the

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-26 Thread Mark Thomas
On 25/04/2019 21:37, Mark Thomas wrote: > On 25/04/2019 21:16, Christopher Schultz wrote: >> On 4/25/19 15:55, Mark Thomas wrote: >> If the resources are caching-aware, then I think the DefaultServlet >> can just always use Resource.getInputStream. >> >> Hmm. That might cause a lot of unnecessar

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-25 Thread Mark Thomas
On 25/04/2019 21:16, Christopher Schultz wrote: > Mark, > > On 4/25/19 15:55, Mark Thomas wrote: >> On 23/04/2019 16:29, Olivier Jaquemet wrote: >>> On 23/04/2019 16:12, Christopher Schultz wrote: On 4/23/19 05:58, Olivier Jaquemet wrote: > >> > > * Add the following directive to conte

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/25/19 15:55, Mark Thomas wrote: > On 23/04/2019 16:29, Olivier Jaquemet wrote: >> On 23/04/2019 16:12, Christopher Schultz wrote: >>> On 4/23/19 05:58, Olivier Jaquemet wrote: > > > * Add the following directive to context.xml : >

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-25 Thread Mark Thomas
On 23/04/2019 16:29, Olivier Jaquemet wrote: > On 23/04/2019 16:12, Christopher Schultz wrote: >> On 4/23/19 05:58, Olivier Jaquemet wrote: >>> * Add the following directive to context.xml : >> cachingAllowed="false" /> >> Okay. Why context.xml, by the way? > I don't even know (yet...) why this

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-23 Thread Olivier Jaquemet
On 23/04/2019 16:12, Christopher Schultz wrote: Olivier, Hi Christopher, Thanks for you answer. On 4/23/19 05:58, Olivier Jaquemet wrote: Hi all, We were able to reproduce a OutOfMemory error when using AJP and the Resources cachingAllowed=false directive. It looks like a bug of AJP connector

Re: OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Olivier, On 4/23/19 05:58, Olivier Jaquemet wrote: > Hi all, > > We were able to reproduce a OutOfMemory error when using AJP and > the Resources cachingAllowed=false directive. It looks like a bug > of AJP connector(s), as it does not occurs with

OutOfMemory on large file download with AJP and cachingAllowed=false

2019-04-23 Thread Olivier Jaquemet
Hi all, We were able to reproduce a OutOfMemory error when using AJP and the Resources cachingAllowed=false directive. It looks like a bug of AJP connector(s), as it does not occurs with other HTTP connectors. Could you confirm the behavior described below is indeed bug ? (if you do, I'll cr