Re: Release WiQuery for Wicket 8

2018-06-07 Thread Thomas Heigl
Hi Emond, I did some exploratory testing against the current build. I checked Dialog, Autocomplete, Accordion, Slider, Sortable, and Tooltip and all seem to be working at first glance. All my tests pass as well. Best, Thomas On Wed, Jun 6, 2018 at 1:07 PM, Emond Papegaaij wrote: > I've fixed

Re: Release WiQuery for Wicket 8

2018-06-07 Thread Martin Grigorov
OK. I will make a release! On Thu, Jun 7, 2018 at 3:25 PM, Thomas Heigl wrote: > Hi Emond, > > I did some exploratory testing against the current build. I checked Dialog, > Autocomplete, Accordion, Slider, Sortable, and Tooltip and all seem to be > working at first glance. > > All my tests pass

ChainingModel warnings in Wicket 8

2018-06-07 Thread Thomas Heigl
Hi all, After porting our app to Wicket 8, I'm getting these warnings on my test environment: WAR o.a.w.model.ChainingModel It is not a good idea to reference a > non-serializable instance in models directly as it may lead to > serialization problems The warning is OK, but it gives me absolutel

Re: Release WiQuery for Wicket 8

2018-06-07 Thread Martin Grigorov
There are many javadoc related errors in this project. mvn install fails with: [WARNING] The requested profile "frontend" could not be activated because it does not exist. [WARNING] The requested profile "buildbot" could not be activated because it does not exist. [ERROR] Failed to execute goal or

Re: ChainingModel warnings in Wicket 8

2018-06-07 Thread Thomas Heigl
Also the warning is logged for `null` objects, which probably shouldn't happen. public ChainingModel(final Object modelObject) > { > if (modelObject instanceof Session) > { > LOG.warn("It is not a good idea to reference the ."); > } else if (modelObject instanceof Seria

Re: Release WiQuery for Wicket 8

2018-06-07 Thread Emond Papegaaij
I did not build the javadoc, but I actually don't know why. But as I don't care about these javadoc errors, I've disabled lint. You should be able to build now. Emond On donderdag 7 juni 2018 16:32:16 CEST Martin Grigorov wrote: > There are many javadoc related errors in this project. mvn insta

Re: Release WiQuery for Wicket 8

2018-06-07 Thread Martin Grigorov
8.0 is on its way to Maven Central! On Thu, Jun 7, 2018 at 5:46 PM, Emond Papegaaij wrote: > I did not build the javadoc, but I actually don't know why. But as I don't > care about these javadoc errors, I've disabled lint. You should be able to > build now. > > Emond > > On donderdag 7 juni 2018

Re: Debugging options

2018-06-07 Thread sorinev
I don't have an equals method for the class, and most of the classes I've come across in our code that are being used in Wicket components don't. Is a class supposed to? How does it work otherwise? Bit-by-bit comparison by the JVM? Anyhow, yeah debugging is what I've been doing but I've been getti

Re: Debugging options

2018-06-07 Thread Sven Meier
Hi, Wicket doesn't need any special equals() implementations. Debug AbstractSingleSelectChoice#getModelValue() and check what it does. Have fun Sven Am 07.06.2018 um 17:12 schrieb sorinev: I don't have an equals method for the class, and most of the classes I've come across in our code that a

Re: Debugging options

2018-06-07 Thread sorinev
It seems like nothing in that class is being called when I change the selection in the DropDownChoice. I'm setting it up like this: new DropDownChoice("account", new PropertyModel(this, "selectedAccount"), accountList, new ChoiceRenderer("name", "id")); But I've tried several other ways too, suc

Re: FormTester, FinishButton and Wicket 8.0

2018-06-07 Thread Sven Meier
Hi, I'm not able to run the test in Intellij nor in Eclipse: java.lang.NoSuchMethodError: org.junit.platform.commons.util.ReflectionUtils.getDefaultClassLoader I suspect your problem might be caused by WICKET-6541, but I don't see why the changes should fail during tests. Have fun Sven A

Re: Debugging options

2018-06-07 Thread sorinev
Ok, so I found out what it appears to be. My full code for the DropDownChoice I'm setting up is this: selectedAccountDropdown = new DropDownChoice("selectedAccount", new PropertyModel(this, "selectedAccount"), accountList, new ChoiceRenderer("name", "id")); selectedAccountDropdown.add(new AjaxForm

Re: Debugging options

2018-06-07 Thread Sven Meier
Hi, the value of the will not be sent when it is already disabled before Wicket serializes its value. You should use #getBeforeSendHandler() instead. Sven Am 07.06.2018 um 19:55 schrieb sorinev: Ok, so I found out what it appears to be. My full code for the DropDownChoice I'm setting up i

Re: Release WiQuery for Wicket 8

2018-06-07 Thread Emond Papegaaij
On donderdag 7 juni 2018 17:10:16 CEST Martin Grigorov wrote: > 8.0 is on its way to Maven Central! Thanks for the help with the release Martin, and Thomas thanks for testing! Emond - To unsubscribe, e-mail: users-unsubscr...@