RE: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-03 Thread David Leangen
> Also there is a complete rewrite of URL handling planned for 1.5 which > will allow much better control over URL generation and bookmarkability > in Wicket. Well, in that case, I won't press this any more. The current stuff is great, but there is indeed a lot of room for improvement. Will be l

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-02 Thread Matej Knopp
I'm not very eager about this. The interface listeners URLs are quite long, why making them even longer while bringing no additional benefit? Also are you sure thath your patch won't break under any circumstances relative urls? It took us a while to get relative URLs working reliably, I wouldn't wa

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-02 Thread Peter Ertl
However this will not be true if you change the render strategy *imho* getRequestCycleSettings ().setRenderStrategy(IRequestCycleSettings.ONE_PASS_RENDER) +1 for applying the patch as it's not only a matter of correctness but also of taste Am 02.07.2008 um 16:06 schrieb Johan Compagne

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-02 Thread Johan Compagner
what does it matter how the urls that are inside the html look like? Its all about how the urls look like in the browsers url bar right? On Wed, Jul 2, 2008 at 6:59 AM, David Leangen <[EMAIL PROTECTED]> wrote: > > once again, i dont see what this offers over the hybrid strategy. > > Maybe you can

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-02 Thread Erik van Oosten
Indeed. I would very welcome this capability. Regards, Erik. David Leangen wrote: once again, i dont see what this offers over the hybrid strategy. Maybe you can correct me if I'm wrong here... The hybrid stategy is only applied when the target is an IBookmarkablePageRequestTarget.

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-01 Thread David Leangen
> once again, i dont see what this offers over the hybrid strategy. Maybe you can correct me if I'm wrong here... The hybrid stategy is only applied when the target is an IBookmarkablePageRequestTarget. So, for normal bookmarkable pages, there is no problem, like you say. The issue only arises w

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-01 Thread Igor Vaynberg
TED]> wrote: > > A possible added bonus to this that it *might* be possible to catch a session > expired, and re-login to the bookmarkable page. > -- > View this message in context: > http://www.nabble.com/-PROPOSAL--Use-path-in-URL-when-target-is-instance-of-Bookm

RE: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-01 Thread Ned Collyer
A possible added bonus to this that it *might* be possible to catch a session expired, and re-login to the bookmarkable page. -- View this message in context: http://www.nabble.com/-PROPOSAL--Use-path-in-URL-when-target-is-instance-of-BookmarkablePageRequestTarget-tp18188845p18228914.html Sent

RE: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-01 Thread David Leangen
> >> I think stateless pages already do something like that. Also look at > >> hybrid url encoding that also preserves the bookmarkable url and makes > >> the url even prettier. > > > > That's possible. I haven't yet made my way into 1.4 waters yet. > > > none of this is 1.4 In any case, even if

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-07-01 Thread Igor Vaynberg
none of this is 1.4 -igor On Mon, Jun 30, 2008 at 11:50 PM, David Leangen <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-07-01 at 08:48 +0200, Johan Compagner wrote: >> I think stateless pages already do something like that. Also look at >> hybrid url encoding that also preserves the bookmarkable ur

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread David Leangen
On Tue, 2008-07-01 at 08:48 +0200, Johan Compagner wrote: > I think stateless pages already do something like that. Also look at > hybrid url encoding that also preserves the bookmarkable url and makes > the url even prettier. That's possible. I haven't yet made my way into 1.4 waters yet. -dml-

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread Johan Compagner
I think stateless pages already do something like that. Also look at hybrid url encoding that also preserves the bookmarkable url and makes the url even prettier. On 6/30/08, David Leangen <[EMAIL PROTECTED]> wrote: > > Currently, when a target is an instance of > IListenerInterfaceRequestTarget,

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread Bruno Borges
Just make sure you create a patch over the last version in trunk. Then send the diff file. :-) Good luck! -- Bruno Borges blog.brunoborges.com.br +55 21 76727099 "The glory of great men should always be measured by the means they have used to acquire it." - Francois de La Rochefoucauld On Mon,

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread David Leangen
> A good patch attached to an issue is always the best way to convince others > :-) Is there a formatting spec somewhere that I can use? Every time I try to create a patch, a lot of stuff in the file gets reformatted, so it's hard to see the relevant parts of the patch. -dml- --

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread Igor Vaynberg
not sure this will work for security since the mount is kept in the url until another bookmarkable url is visited. which means that you can get to any page from that particular mount as long as you use statefull links... -igor On Mon, Jun 30, 2008 at 7:28 AM, Peter Ertl <[EMAIL PROTECTED]> wrote:

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread Eelco Hillenius
> If you think this is a reasonable proposal, I will create an issue and > submit my patch. A good patch attached to an issue is always the best way to convince others :-) Eelco - To unsubscribe, e-mail: [EMAIL PROTECTED] For ad

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-30 Thread Peter Ertl
+1 -- sounds reasonable, doesn't break anything (hopefully :-), easier path-based security on apache front end proxy, Good work, David :-) Am 30.06.2008 um 07:33 schrieb David Leangen: Wouldn't this be useless except from the fact of been "pretty" ? Yes, it would indeed be "useles

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-29 Thread David Leangen
> Wouldn't this be useless except from the fact of been "pretty" ? Yes, it would indeed be "useless" in that functionally, it contributes nothing. It also takes nothing away. So by definition I guess that's a refactoring. The purpose of this refactoring, just like any other for that matter, is t

Re: [PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-29 Thread Bruno Borges
Wouldn't this be useless except from the fact of been "pretty" ? Bruno Borges blog.brunoborges.com.br +55 21 76727099 "The glory of great men should always be measured by the means they have used to acquire it." - Francois de La Rochefoucauld On Mon, Jun 30, 2008 at 2:12 AM, David Leangen <[EMAI

[PROPOSAL] Use path in URL when target is instance of BookmarkablePageRequestTarget

2008-06-29 Thread David Leangen
Currently, when a target is an instance of IListenerInterfaceRequestTarget, the URL gets "mounted" (so to speak) on the root of where the wicket application is located. So, if the servlet context path for the wicket application is set to /home/, then all targets (whether bookmarkable or not), are