NPE on session invalidation

2018-03-30 Thread Rakesh A
Wicket 6.29.0 has a fix for https://issues.apache.org/jira/browse/WICKET-6484 change-set of which can be see at - https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=blobdiff;f=wicket-core/src/main/java/org/apache/wicket/Session.java;h=21a9432a2c5d5005b215dd5d7c3b15bf87fda0ba;hp=5bab1c6bf5fd602

Re: NPE on session invalidation

2018-03-30 Thread Rakesh A
Did a quick test and logged an issue https://issues.apache.org/jira/browse/WICKET-6547 -- Sent from: http://apache-wicket.1842946.n4.nabble.com/Users-forum-f1842947.html - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.o

Re: NPE on session invalidation

2018-04-03 Thread Rakesh A
I see the ticket https://issues.apache.org/jira/browse/WICKET-6547 closed as 'resolved' with resolution 'not a problem'. Instead of reopening it I wanted to discuss the usecase here and decide on re-opening. Is is allowed to call 'Session.isSessionInvalidated()' from 'WebSession.onInvalidate()' ?

Re: NPE on session invalidation

2018-04-03 Thread Martin Grigorov
Hi, On Tue, Apr 3, 2018 at 3:24 PM, Rakesh A wrote: > I see the ticket https://issues.apache.org/jira/browse/WICKET-6547 closed > as > 'resolved' with resolution 'not a problem'. Instead of reopening it I > wanted > to discuss the usecase here and decide on re-opening. > > Is is allowed to call

Re: NPE on session invalidation

2018-04-03 Thread Rakesh A
Actually, we've bit more complex scenario I should say; we've multiple webapps running on tomcat with SSO valve configured; which means logout on one application kills the session on other applications and we've session implementation class with logout & session invalidation handling. In both cases

Re: NPE on session invalidation

2018-04-03 Thread Martin Grigorov
On Tue, Apr 3, 2018 at 4:17 PM, Rakesh A wrote: > Actually, we've bit more complex scenario I should say; we've multiple > webapps running on tomcat with SSO valve configured; which means logout on > one application kills the session on other applications and we've session > implementation class

Re: NPE on session invalidation

2018-04-03 Thread Emond Papegaaij
I think it should be enough to change the javadoc. The method returns true when the session was invalidated *during the current request*. Without a request there is no way of telling whether the session is invalidated or not. IMHO throwing an exception is fine, but this behavior should be documente

Re: NPE on session invalidation

2018-05-17 Thread Rakesh A
Hi, Sorry for a delayed reply, didn't had chance to work on it till today. Martin Grigorov-4 wrote > You didn't answer my question (or I didn't understand your answer). > Why do you need to use "isSessionInvalidated()" in your cleanup method ? > Is the cleanup method called in some other cases ? I