I'm skeptical this is the desireable way to move the code around.
Of course, for all such things, I am fine with whatever upstream likes.
But here are my concerns:
That is not friendly to git history at all. If you move big chunks of code
to different files, it's ideal to do it in a sequence of
On 10/27, Roland McGrath wrote:
I'm skeptical this is the desireable way to move the code around.
Of course, for all such things, I am fine with whatever upstream likes.
But here are my concerns:
I am not sure this is the best choice too.
That is not friendly to git history at all.
Yes, I
Not sure I understand. Do you mean it is possible to move the code from
the old file to the new one in a git-friendly manner? Afaics, there is no
way to do this, git can only hanlde renames. (but my git skills is close
to zero).
What I meant is a sequence of patches like:
1. move non-common
On 10/27, Roland McGrath wrote:
In this case kernelptrace.c becomes
... the context of kernel/ptrace-common.h ...
#ifndef CONFIG_UTRACE
... other code ...
#endif
and we don't need CONFIG_PTRACE_OLD.
Do you agree with approach?
That's what I had in mind.
