[v8-dev] Re: a tiny code review ([EMAIL PROTECTED]/cat-and-test-status)

2008-09-08 Thread Mads Sig Ager
LGTM On Mon, Sep 8, 2008 at 8:57 AM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch,

[v8-dev] [v8 commit] r187 - in changes/[EMAIL PROTECTED]/cat-and-test-status: . bleeding_edge bleedin...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Sun Sep 7 23:55:54 2008 New Revision: 187 Added: changes/[EMAIL PROTECTED]/cat-and-test-status/ changes/[EMAIL PROTECTED]/cat-and-test-status/bleeding_edge/ - copied from r183, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/ca

[v8-dev] [v8 commit] r188 - in changes/[EMAIL PROTECTED]/fix-issues-28-30/bleeding_edge: . include src

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Sun Sep 7 23:58:13 2008 New Revision: 188 Added: changes/[EMAIL PROTECTED]/fix-issues-28-30/bleeding_edge/ - copied from r184, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/fix-issues-28-30/bleeding_edge/include/v8-debug.h chang

[v8-dev] a wee code review ([EMAIL PROTECTED]/arm-debug-test-failure)

2008-09-08 Thread ager
Christian, I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL

[v8-dev] Issue 41 in v8: Master Password Protection for my saved password

2008-09-08 Thread codesite-noreply
Issue 41: Master Password Protection for my saved password http://code.google.com/p/v8/issues/detail?id=41 Comment #1 by sgjesse: This is not related to V8, but is a duplicate of the Chromium bug 53 (http://code.google.com/p/chromium/issues/detail?id=53). Issue attribute updates: Status

[v8-dev] [v8 commit] r189 - branches/bleeding_edge/include branches/bleeding_edge/src changes/[EMAIL PROTECTED]/fix...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:01:12 2008 New Revision: 189 Removed: changes/[EMAIL PROTECTED]/fix-issues-28-30/ Modified: branches/bleeding_edge/include/v8-debug.h branches/bleeding_edge/include/v8.h branches/bleeding_edge/src/api.cc Log: Fix issues 28 and 30 by c

[v8-dev] Issue 30 in v8: Include Guard v8.h: _V8 is a non allowed global Name.

2008-09-08 Thread codesite-noreply
Issue 30: Include Guard v8.h: _V8 is a non allowed global Name. http://code.google.com/p/v8/issues/detail?id=30 Comment #2 by [EMAIL PROTECTED]: Fixed on bleeding_edge branch in revision 189. Issue attribute updates: Status: Fixed -- You received this message because you are listed in

[v8-dev] a tiny code review ([EMAIL PROTECTED]/fix-broken-build)

2008-09-08 Thread kasperl
Mads, I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PRO

[v8-dev] Re: a tiny code review ([EMAIL PROTECTED]/fix-broken-build)

2008-09-08 Thread Mads Sig Ager
LGTM On Mon, Sep 8, 2008 at 9:18 AM, <[EMAIL PROTECTED]> wrote: > Mads, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change

[v8-dev] Issue 28 in v8: v8.h doesn't compile when DEBUG is defined

2008-09-08 Thread codesite-noreply
Issue 28: v8.h doesn't compile when DEBUG is defined http://code.google.com/p/v8/issues/detail?id=28 Comment #4 by [EMAIL PROTECTED]: Fixed on bleeding_edge branch in revision 189. Issue attribute updates: Status: Fixed -- You received this message because you are listed in the owner

[v8-dev] [v8 commit] r190 - branches/bleeding_edge/test/mjsunit branches/bleeding_edge/test/mozilla branches/bleeding_...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:04:22 2008 New Revision: 190 Removed: changes/[EMAIL PROTECTED]/cat-and-test-status/ Modified: branches/bleeding_edge/test/mjsunit/testcfg.py branches/bleeding_edge/test/mozilla/mozilla.status branches/bleeding_edge/test/mozilla/testcf

[v8-dev] [v8 commit] r191 - in changes/[EMAIL PROTECTED]/arm-debug-test-failure: . bleeding_edge bleeding_edge/test/mj...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:04:40 2008 New Revision: 191 Added: changes/[EMAIL PROTECTED]/arm-debug-test-failure/ changes/[EMAIL PROTECTED]/arm-debug-test-failure/bleeding_edge/ - copied from r184, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED

[v8-dev] [v8 commit] r192 - in changes/[EMAIL PROTECTED]/fix-broken-build: . bleeding_edge bleeding_edge/include bl...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:18:02 2008 New Revision: 192 Added: changes/[EMAIL PROTECTED]/fix-broken-build/ changes/[EMAIL PROTECTED]/fix-broken-build/bleeding_edge/ - copied from r184, /branches/bleeding_edge/ changes/[EMAIL PROTECTED]/fix-broken-build/bleedi

[v8-dev] Issue 44 in v8: return value handling odd

2008-09-08 Thread codesite-noreply
Issue 44: return value handling odd http://code.google.com/p/v8/issues/detail?id=44 New issue report by pete.gontier: After invoking a script, I attempt to evaluate the return value. As documented in the sample, returning a string works fine. However, I want to return an object. If I write this s

[v8-dev] Re: a wee code review ([EMAIL PROTECTED]/arm-debug-test-failure)

2008-09-08 Thread Christian Plesner Hansen
Maybe we should add a variable ($simulator = arm?) so we can continue to run the test on the simulator. On Mon, Sep 8, 2008 at 9:08 AM, <[EMAIL PROTECTED]> wrote: > Christian, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/sv

[v8-dev] [v8 commit] r193 - branches/bleeding_edge/include branches/bleeding_edge/src branches/bleeding_edge/test/ccte...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:24:10 2008 New Revision: 193 Removed: changes/[EMAIL PROTECTED]/fix-broken-build/ Modified: branches/bleeding_edge/include/v8.h branches/bleeding_edge/src/debug.h branches/bleeding_edge/src/v8threads.cc branches/bleeding_edge/test/

[v8-dev] Issue 44 in v8: return value handling odd

2008-09-08 Thread codesite-noreply
Issue 44: return value handling odd http://code.google.com/p/v8/issues/detail?id=44 Comment #1 by pete.gontier: It seems arrays do work, or at least this one does: [ 12,13,14 ] -- You received this message because you are listed in the owner or CC fields of this issue, or because you st

[v8-dev] Issue 44 in v8: return value handling odd

2008-09-08 Thread codesite-noreply
Issue 44: return value handling odd http://code.google.com/p/v8/issues/detail?id=44 Comment #2 by [EMAIL PROTECTED]: When evaluating { foo: 12 } it is evaluated as a block of code with a labeled statement. Therefore, the result is 12 and not an object with a foo property. Similarly, { foo:12

[v8-dev] Issue 36 in v8: Can't Build on Windows Vista 32-bit with VS 2008

2008-09-08 Thread codesite-noreply
Issue 36: Can't Build on Windows Vista 32-bit with VS 2008 http://code.google.com/p/v8/issues/detail?id=36 Comment #2 by autolysis: Thanks! I'll try the env.Dump() later today. But I'm using Visual Studio 2008 Team Suite (which is not the Express edition). So as per the wiki page, "If buildin

[v8-dev] Issue 44 in v8: return value handling odd

2008-09-08 Thread codesite-noreply
Issue 44: return value handling odd http://code.google.com/p/v8/issues/detail?id=44 Comment #3 by [EMAIL PROTECTED]: I should add that you can have it evaluated as an expression by wrapping it in parenthesis: ({foo:12}). -- You received this message because you are listed in the owner or CC

[v8-dev] [v8 commit] r194 - branches/bleeding_edge/test/mjsunit changes/[EMAIL PROTECTED]/arm-debug-test-failure

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:55:28 2008 New Revision: 194 Removed: changes/[EMAIL PROTECTED]/arm-debug-test-failure/ Modified: branches/bleeding_edge/test/mjsunit/mjsunit.status Log: Update mjsunit status file. The debugger does not currently work on ARM and all the tes

[v8-dev] [v8 commit] r195 - in branches/bleeding_edge: . src test/mjsunit/regress

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 00:58:54 2008 New Revision: 195 Added: branches/bleeding_edge/test/mjsunit/regress/regress-35.js Modified: branches/bleeding_edge/AUTHORS branches/bleeding_edge/src/parser.cc Log: Fix issue 35 by applying patch by Daniel James. Modified: br

[v8-dev] [v8 commit] r196 - branches/bleeding_edge

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 01:09:50 2008 New Revision: 196 Modified: branches/bleeding_edge/AUTHORS Log: Capitalize V8 in AUTHORS file. Modified: branches/bleeding_edge/AUTHORS == --- branches/bleedi

[v8-dev] Issue 45 in v8: combobox problem

2008-09-08 Thread codesite-noreply
Issue 45: combobox problem http://code.google.com/p/v8/issues/detail?id=45 New issue report by mr.zubair: Chrome is not displaying the extjs combobox while FF and IE have no problem with it. Issue attributes: Status: New Owner: -- You received this message because you are

[v8-dev] Issue 35 in v8: Need to check for end of string when parsing break or continue.

2008-09-08 Thread codesite-noreply
Issue 35: Need to check for end of string when parsing break or continue. http://code.google.com/p/v8/issues/detail?id=35 Comment #3 by [EMAIL PROTECTED]: Patch applied to bleeding_edge branch in revision 195. Thanks a lot. Cheers, Kasper Issue attribute updates: Status: Fixed -- You

[v8-dev] Issue 46 in v8: Regexp longer as 32767 chars

2008-09-08 Thread codesite-noreply
Issue 46: Regexp longer as 32767 chars http://code.google.com/p/v8/issues/detail?id=46 New issue report by kajman: Why is the restriction of regular expression to 32767 characters? Issue attributes: Status: New Owner: -- You received this message because you are listed i

[v8-dev] [v8 commit] r197 - in changes/[EMAIL PROTECTED]/fix-no-snapshot-tests: . bleeding_edge bleeding_edge/src b...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 02:12:37 2008 New Revision: 197 Added: changes/[EMAIL PROTECTED]/fix-no-snapshot-tests/ changes/[EMAIL PROTECTED]/fix-no-snapshot-tests/bleeding_edge/ - copied from r195, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/f

[v8-dev] Issue 29 in v8: tools don't build on 64

2008-09-08 Thread codesite-noreply
Issue 29: tools don't build on 64 http://code.google.com/p/v8/issues/detail?id=29 Comment #2 by bisqwit: You don't have 32-bit emulation libraries installed. If you have Debian GNU/Linux, install the package lib32stdc++6 and you should be fine. Not an error in V8. -- You received this mess

[v8-dev] Issue 22 in v8: Cannot compile v8 on ubuntu amd64 with GCC

2008-09-08 Thread codesite-noreply
Issue 22: Cannot compile v8 on ubuntu amd64 with GCC http://code.google.com/p/v8/issues/detail?id=22 Comment #5 by [EMAIL PROTECTED]: Could you try pulling from the latest on the bleeding_edge branch? -- You received this message because you are listed in the owner or CC fields of this issue

[v8-dev] Issue 42 in v8: when multiple tabs are open and i click close it does not give a warning

2008-09-08 Thread codesite-noreply
Issue 42: when multiple tabs are open and i click close it does not give a warning http://code.google.com/p/v8/issues/detail?id=42 Comment #1 by bisqwit: Misfiled report. This is not a Javascript engine bug. As for Chromium bugs, this is probably a "working as intended" issue; considering tha

[v8-dev] Re: a small code review ([EMAIL PROTECTED]/asian-letters)

2008-09-08 Thread Erik Corry
LGTM On Mon, Sep 8, 2008 at 11:26 AM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch

[v8-dev] Re: a small code review ([EMAIL PROTECTED]/fix-no-snapshot-tests)

2008-09-08 Thread Christian Plesner Hansen
lgtm On Mon, Sep 8, 2008 at 11:13 AM, <[EMAIL PROTECTED]> wrote: > Christian, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this

[v8-dev] [v8 commit] r201 - wiki

2008-09-08 Thread codesite-noreply
Author: christian.plesner.hansen Date: Mon Sep 8 03:53:05 2008 New Revision: 201 Added: wiki/Source.wiki Log: Added Source wiki page Added: wiki/Source.wiki == --- (empty file) +++ wiki/Source.wikiMon Sep 8 03

[v8-dev] Issue 23 in v8: Tests fail when running with snapshots in debug mode

2008-09-08 Thread codesite-noreply
Issue 23: Tests fail when running with snapshots in debug mode http://code.google.com/p/v8/issues/detail?id=23 Comment #1 by [EMAIL PROTECTED]: Fixed on bleeding_edge in revision 199. Issue attribute updates: Status: Fixed Owner: [EMAIL PROTECTED] -- You received this message

[v8-dev] Issue 40 in v8: Remove unused ProcessRuntimeFlags prototype from sample/shell.cc

2008-09-08 Thread codesite-noreply
Issue 40: Remove unused ProcessRuntimeFlags prototype from sample/shell.cc http://code.google.com/p/v8/issues/detail?id=40 Comment #1 by [EMAIL PROTECTED]: Fixed on bleeding_edge in revision 202. Issue attribute updates: Status: Fixed Owner: [EMAIL PROTECTED] Labels: Typ

[v8-dev] Re: a wee code review ([EMAIL PROTECTED]/update-mozilla-status)

2008-09-08 Thread Mads Sig Ager
LGTM On Mon, Sep 8, 2008 at 2:26 PM, <[EMAIL PROTECTED]> wrote: > Mads, > > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change

[v8-dev] [v8 commit] r204 - in changes/[EMAIL PROTECTED]/cgen-store/bleeding_edge: . src

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 05:34:09 2008 New Revision: 204 Added: changes/[EMAIL PROTECTED]/cgen-store/bleeding_edge/ - copied from r203, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/cgen-store/bleeding_edge/src/ast.h changes/[EMAIL PROTECTED]/

[v8-dev] [v8 commit] r205 - branches/bleeding_edge/test/mozilla changes/[EMAIL PROTECTED]/update-mozilla-status

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 05:37:10 2008 New Revision: 205 Removed: changes/[EMAIL PROTECTED]/update-mozilla-status/ Modified: branches/bleeding_edge/test/mozilla/mozilla.status Log: Add two more Mozilla tests that depend on GC timings to the list of flaky tests. Modifi

[v8-dev] a wee code review ([EMAIL PROTECTED]/sourcesignatures)

2008-09-08 Thread christian . plesner . hansen
I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PROTECTED]

[v8-dev] Re: a wee code review ([EMAIL PROTECTED]/sourcesignatures)

2008-09-08 Thread Kasper Lund
LGTM. On Mon, Sep 8, 2008 at 2:39 PM, <[EMAIL PROTECTED]> wrote: > I'd like you to do a code review. To review this change, run > > gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL > PROTECTED] > > Alternatively, to review the latest snapshot of this change > branch

[v8-dev] Issue 24 in v8: Javascript error from V8 inside of Chrome

2008-09-08 Thread codesite-noreply
Issue 24: Javascript error from V8 inside of Chrome http://code.google.com/p/v8/issues/detail?id=24 Comment #2 by getify: It happens reliably with all test cases of my open-source project (which all pass in pretty much every other browser/OS). I'm working on a simple page to demonstrate this

[v8-dev] a small code review ([EMAIL PROTECTED]/fix-no-snapshot-tests)

2008-09-08 Thread kasperl
Christian, I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL

[v8-dev] [v8 commit] r206 - in changes/[EMAIL PROTECTED]/sourcesignatures: . bleeding_edge

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 05:38:53 2008 New Revision: 206 Added: changes/[EMAIL PROTECTED]/sourcesignatures/ changes/[EMAIL PROTECTED]/sourcesignatures/bleeding_edge/ - copied from r202, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/sourcesig

[v8-dev] [v8 commit] r207 - wiki

2008-09-08 Thread codesite-noreply
Author: christian.plesner.hansen Date: Mon Sep 8 05:41:40 2008 New Revision: 207 Modified: wiki/Contributing.wiki Log: Fixed formatting on Contributing page Modified: wiki/Contributing.wiki == --- wiki/Contributing

[v8-dev] Issue 42 in v8: when multiple tabs are open and i click close it does not give a warning

2008-09-08 Thread codesite-noreply
Issue 42: when multiple tabs are open and i click close it does not give a warning http://code.google.com/p/v8/issues/detail?id=42 Comment #2 by [EMAIL PROTECTED]: (No comment was entered for this change.) Issue attribute updates: Status: Duplicate -- You received this message becau

[v8-dev] [v8 commit] r202 - branches/bleeding_edge/samples

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 03:58:46 2008 New Revision: 202 Modified: branches/bleeding_edge/samples/shell.cc Log: Fix issue 40. Modified: branches/bleeding_edge/samples/shell.cc == --- branches/bleed

[v8-dev] [v8 commit] r208 - wiki

2008-09-08 Thread codesite-noreply
Author: christian.plesner.hansen Date: Mon Sep 8 05:51:50 2008 New Revision: 208 Modified: wiki/Source.wiki Log: Edited wiki page through web user interface. Modified: wiki/Source.wiki == --- wiki/Source.wiki(o

[v8-dev] a wee code review ([EMAIL PROTECTED]/update-mozilla-status)

2008-09-08 Thread kasperl
Mads, I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PRO

[v8-dev] Issue 47 in v8: cpplint.py missing from repository?

2008-09-08 Thread codesite-noreply
Issue 47: cpplint.py missing from repository? http://code.google.com/p/v8/issues/detail?id=47 New issue report by mdmkolbe: The guide on contributing (http://code.google.com/p/v8/wiki/Contributing) says that one should run tools/presubmit.py before submitting. However, tools/presubmit.py tries t

[v8-dev] [v8 commit] r203 - in changes/[EMAIL PROTECTED]/update-mozilla-status: . bleeding_edge bleeding_edge/test/...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 05:26:39 2008 New Revision: 203 Added: changes/[EMAIL PROTECTED]/update-mozilla-status/ changes/[EMAIL PROTECTED]/update-mozilla-status/bleeding_edge/ - copied from r201, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/

[v8-dev] [v8 commit] r209 - wiki

2008-09-08 Thread codesite-noreply
Author: christian.plesner.hansen Date: Mon Sep 8 05:57:31 2008 New Revision: 209 Modified: wiki/Source.wiki Log: Edited wiki page through web user interface. Modified: wiki/Source.wiki == --- wiki/Source.wiki(o

[v8-dev] [v8 commit] r199 - branches/bleeding_edge/src branches/bleeding_edge/test/cctest branches/bleeding_edge/test/...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 02:26:02 2008 New Revision: 199 Removed: changes/[EMAIL PROTECTED]/fix-no-snapshot-tests/ Modified: branches/bleeding_edge/src/snapshot.h branches/bleeding_edge/test/cctest/test-api.cc branches/bleeding_edge/test/cctest/test-mark-compact.

[v8-dev] [v8 commit] r210 - branches/bleeding_edge changes/[EMAIL PROTECTED]/sourcesignatures

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 06:08:10 2008 New Revision: 210 Removed: changes/[EMAIL PROTECTED]/sourcesignatures/ Modified: branches/bleeding_edge/SConstruct Log: - Added option to set SourceSignatures in scons. Modified: branches/bleeding_edge/SConstruct ===

[v8-dev] a small code review ([EMAIL PROTECTED]/asian-letters)

2008-09-08 Thread christian . plesner . hansen
I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn [EMAIL PROTECTED]/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn review [EMAIL PROTECTED]

[v8-dev] [v8 commit] r198 - in changes/[EMAIL PROTECTED]/asian-letters: . bleeding_edge bleeding_edge...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 02:25:18 2008 New Revision: 198 Added: changes/[EMAIL PROTECTED]/asian-letters/ changes/[EMAIL PROTECTED]/asian-letters/bleeding_edge/ - copied from r197, /branches/bleeding_edge/ changes/[EMAIL PROTECTED]/asian-letters/bleeding_edg

[v8-dev] [v8 commit] r200 - branches/bleeding_edge/src branches/bleeding_edge/test/mjsunit/bugs branches/bleeding_edge...

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 03:45:01 2008 New Revision: 200 Added: branches/bleeding_edge/test/mjsunit/regress/regress-1346700.js (contents, props changed) - copied, changed from r197, /branches/bleeding_edge/test/mjsunit/bugs/bug-1346700.js Removed: branches/b

[v8-dev] Issue 48 in v8: v8 code is not const-correct.

2008-09-08 Thread codesite-noreply
Issue 48: v8 code is not const-correct. http://code.google.com/p/v8/issues/detail?id=48 New issue report by [EMAIL PROTECTED]: The v8 Code ist not const-correct. At least the API should provide const-correct behaviour or else it is hard to use it with any good C++ code. e.g. virtual int ScriptD

[v8-dev] Issue 48 in v8: v8 code is not const-correct.

2008-09-08 Thread codesite-noreply
Issue 48: v8 code is not const-correct. http://code.google.com/p/v8/issues/detail?id=48 Comment #1 by [EMAIL PROTECTED]: Sorry. Just saw that this is actually a duplicate of Issue 38. http://code.google.com/p/v8/issues/detail?id=38&colspec=ID%20Type%20Status%20Priority%20Owner%20Summary -- Yo

[v8-dev] Issue 49 in v8: v8 does not use correct Integer types.

2008-09-08 Thread codesite-noreply
Issue 49: v8 does not use correct Integer types. http://code.google.com/p/v8/issues/detail?id=49 New issue report by [EMAIL PROTECTED]: The v8 API is not consistent with the use of correct Integer types which especially leads to problems with 32bit/64bit portability and might lead to software bug

[v8-dev] [v8 commit] r211 - in changes/sgjesse/fix-env-overrides: . bleeding_edge bleeding_edge/samples

2008-09-08 Thread codesite-noreply
Author: sgjesse Date: Mon Sep 8 07:27:19 2008 New Revision: 211 Added: changes/sgjesse/fix-env-overrides/ changes/sgjesse/fix-env-overrides/bleeding_edge/ - copied from r210, /branches/bleeding_edge/ Modified: changes/sgjesse/fix-env-overrides/bleeding_edge/SConstruct chan

[v8-dev] Issue 36 in v8: Can't Build on Windows Vista 32-bit with VS 2008

2008-09-08 Thread codesite-noreply
Issue 36: Can't Build on Windows Vista 32-bit with VS 2008 http://code.google.com/p/v8/issues/detail?id=36 Comment #3 by sgjesse: Got hold of a Visual Studio 2008 installation (on Windows XP). It turns out the SCons cannot locate Visual Studio 2008. When passing PATH, INCLUDE and LIB through

[v8-dev] a tiny code review (sgjesse/fix-env-overrides)

2008-09-08 Thread sgjesse
I'd like you to do a code review. To review this change, run gvn review --project https://v8.googlecode.com/svn/branches/bleeding_edge sgjesse/[EMAIL PROTECTED] Alternatively, to review the latest snapshot of this change branch, run gvn --project https://v8.googlecode.com/svn/branches/ble

[v8-dev] Re: a tiny code review (sgjesse/fix-env-overrides)

2008-09-08 Thread Søren Gjesse
New snapshot with -sample_env['ENV'].update(**context.env_overrides) +context.ApplyEnvOverrides(sample_env) instead of -sample_env['ENV'].update(**context.env_overrides) +context.ApplyEnvOverrides(env) On Mon, Sep 8, 2008 at 5:16 PM, <[EMAIL PROTECTED]> wrote: > > I'd like you t

[v8-dev] Re: a tiny code review (sgjesse/fix-env-overrides)

2008-09-08 Thread Christian Plesner Hansen
Was ApplyEnvOverrides defined already? Lgtm. On Mon, Sep 8, 2008 at 5:20 PM, Søren Gjesse <[EMAIL PROTECTED]> wrote: > New snapshot with > -sample_env['ENV'].update(**context.env_overrides) > +context.ApplyEnvOverrides(sample_env) > instead of > -sample_env['ENV'].update(**context.en

[v8-dev] Re: a tiny code review (sgjesse/fix-env-overrides)

2008-09-08 Thread Søren Gjesse
On Mon, Sep 8, 2008 at 5:26 PM, Christian Plesner Hansen < [EMAIL PROTECTED]> wrote: > Was ApplyEnvOverrides defined already? Yes - when it was introduced I forgot to use it in one place. > > > Lgtm. > > On Mon, Sep 8, 2008 at 5:20 PM, Søren Gjesse <[EMAIL PROTECTED]> wrote: > > New snapshot wi

[v8-dev] Issue 51 in v8: Cannot build v8_mksnapshot with VS2005, LNK2005 error

2008-09-08 Thread codesite-noreply
Issue 51: Cannot build v8_mksnapshot with VS2005, LNK2005 error http://code.google.com/p/v8/issues/detail?id=51 New issue report by debnarayanb: Hi, I am trying to build Revision 197 on Microsoft Windows XP [Version 5.1.2600] (32 bit), scons 1.0.1, Python 2.5.2 using Visual Studio 2005. v8_base

[v8-dev] Issue 44 in v8: return value handling odd

2008-09-08 Thread codesite-noreply
Issue 44: return value handling odd http://code.google.com/p/v8/issues/detail?id=44 Comment #4 by pete.gontier: Thanks for #3, because that was my next question. This must be why the parens are generally recommended for evaluating JSON arriving via XHR. It seems this ought to be documented so

[v8-dev] Issue 48 in v8: v8 code is not const-correct.

2008-09-08 Thread codesite-noreply
Issue 48: v8 code is not const-correct. http://code.google.com/p/v8/issues/detail?id=48 Comment #2 by pete.gontier: While 48 may be a duplicate of 38, 48 contains valuable explanation and references which 38 should have included. -- You received this message because you are listed in the ow

[v8-dev] Issue 38 in v8: need more "const correctness"

2008-09-08 Thread codesite-noreply
Issue 38: need more "const correctness" http://code.google.com/p/v8/issues/detail?id=38 Comment #1 by pete.gontier: Issues 48 contains additional detail and references. -- You received this message because you are listed in the owner or CC f

[v8-dev] Issue 29 in v8: tools don't build on 64

2008-09-08 Thread codesite-noreply
Issue 29: tools don't build on 64 http://code.google.com/p/v8/issues/detail?id=29 Comment #3 by christian.plesner.hansen: I'm closing this issue as 'pending further information'. Please follow up if installing the 32-bit libraries doesn't solve the problem. Issue attribute updates:

[v8-dev] Issue 38 in v8: need more "const correctness"

2008-09-08 Thread codesite-noreply
Issue 38: need more "const correctness" http://code.google.com/p/v8/issues/detail?id=38 Comment #2 by pete.gontier: http://code.google.com/p/v8/issues/detail?id=48";>Issue 48 contains additional detail and references. -- You received this message because you are listed in the owner or CC fi

[v8-dev] Issue 38 in v8: need more "const correctness"

2008-09-08 Thread codesite-noreply
Issue 38: need more "const correctness" http://code.google.com/p/v8/issues/detail?id=38 Comment #3 by pete.gontier: Issue 48 contains additional detail and references. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issu

[v8-dev] Issue 33 in v8: API method to enumerate properties

2008-09-08 Thread codesite-noreply
Issue 33: API method to enumerate properties http://code.google.com/p/v8/issues/detail?id=33 Comment #1 by christian.plesner.hansen: We should have an API function for enumerating properties. Issue attribute updates: Status: Accepted Labels: Type-FeatureRequest Priority-Medium

[v8-dev] Issue 52 in v8: not possible to enumerate an object's properties

2008-09-08 Thread codesite-noreply
Issue 52: not possible to enumerate an object's properties http://code.google.com/p/v8/issues/detail?id=52 New issue report by pete.gontier: Date: Sun, 7 Sep 2008 21:17:22 -0700 (PDT) Subject: [v8-users] Re: enumerate properties From: CGamesPlay <[EMAIL PROTECTED]> To: v8-users <[EMAIL PROTECTED]

[v8-dev] [v8 commit] r214 - in branches/bleeding_edge: src test/cctest test/mjsunit

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 09:47:23 2008 New Revision: 214 Added: branches/bleeding_edge/test/mjsunit/number-string-index-call.js Modified: branches/bleeding_edge/src/ic.cc branches/bleeding_edge/src/ic.h branches/bleeding_edge/test/cctest/test-api.cc Log: Fix iss

[v8-dev] [v8 commit] r215 - wiki

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 09:51:53 2008 New Revision: 215 Modified: wiki/Source.wiki Log: Edited wiki page through web user interface. Modified: wiki/Source.wiki == --- wiki/Source.wiki(original

[v8-dev] Issue 32 in v8: Not a method exception

2008-09-08 Thread codesite-noreply
Issue 32: Not a method exception http://code.google.com/p/v8/issues/detail?id=32 Comment #2 by [EMAIL PROTECTED]: Fixed in r214. Issue attribute updates: Status: Fixed Owner: [EMAIL PROTECTED] -- You received this message because you are listed in the owner or CC fields of thi

[v8-dev] Issue 6 in v8: Chrome/V8 breaks Prototype JavaScript library

2008-09-08 Thread codesite-noreply
Issue 6: Chrome/V8 breaks Prototype JavaScript library http://code.google.com/p/v8/issues/detail?id=6 Comment #16 by [EMAIL PROTECTED]: The second jQuery issue was fixed. The first jQuery issue is fixed in WebKit trunk, and Chrome should pick it up in the next merge. I didn't hear anything fro

[v8-dev] Issue 19 in v8: XPathEvaluator.evalute() will throw "NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces

2008-09-08 Thread codesite-noreply
Issue 19: XPathEvaluator.evalute() will throw "NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces http://code.google.com/p/v8/issues/detail?id=19 Comment #2 by [EMAIL PROTECTED]: This is a bug in the binding code, not a V8 code. I am going to close this one, and track the bug

[v8-dev] Issue 52 in v8: not possible to enumerate an object's properties

2008-09-08 Thread codesite-noreply
Issue 52: not possible to enumerate an object's properties http://code.google.com/p/v8/issues/detail?id=52 Comment #1 by nicolas.alvarez: Duplicate of issue 33 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You m

[v8-dev] Issue 43 in v8: Exception is thrown when instantiate Image object if there is an element has id="Image" in HTML.

2008-09-08 Thread codesite-noreply
Issue 43: Exception is thrown when instantiate Image object if there is an element has id="Image" in HTML. http://code.google.com/p/v8/issues/detail?id=43 Comment #1 by nicolas.alvarez: Problem is in Chrome, not in V8. -- You received this message because you are listed in the owner or CC f

[v8-dev] Issue 53 in v8: Internal fields behave strangely on objects from a template

2008-09-08 Thread codesite-noreply
Issue 53: Internal fields behave strangely on objects from a template http://code.google.com/p/v8/issues/detail?id=53 New issue report by nicolas.alvarez: Handle template = ObjectTemplate::New(); template->SetInternalFieldCount(1); Handle obj = template->NewInstance(); std::cout << obj->Internal

[v8-dev] Issue 45 in v8: combobox problem

2008-09-08 Thread codesite-noreply
Issue 45: combobox problem http://code.google.com/p/v8/issues/detail?id=45 Comment #1 by nicolas.alvarez: Probably a Chrome bug, not V8. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue no

[v8-dev] Issue 48 in v8: v8 code is not const-correct.

2008-09-08 Thread codesite-noreply
Issue 48: v8 code is not const-correct. http://code.google.com/p/v8/issues/detail?id=48 Comment #3 by i3x171um: That would be quite a significant change to the public API of V8. As a third party user, I would much prefer this change be made sooner rather than later, if it is to be made at all

[v8-dev] [v8 commit] r216 - branches/bleeding_edge/test/mjsunit

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 11:56:27 2008 New Revision: 216 Modified: branches/bleeding_edge/test/mjsunit/mjsunit.status Log: Mark number-string-index-call.js as FAIL on ARM because it depends on the new calling convention. [EMAIL PROTECTED] Modified: branches/bleeding_edge

[v8-dev] Re: Fix issue http://code.google.com/p/v8/issues/detail?id=32...

2008-09-08 Thread feng
http://codereview.chromium.org/1604/diff/203/17 File src/ic.cc (right): http://codereview.chromium.org/1604/diff/203/17#newcode293 Line 293: if (result->IsJSFunction()) return result; It will fail in lookup step, a comment is sufficient, I think, instead of duplicating code here. On 2008/09/08

[v8-dev] Re: [v8 commit] r216 - branches/bleeding_edge/test/mjsunit

2008-09-08 Thread Ivan Posva
LGTM On Mon, Sep 8, 2008 at 11:57, <[EMAIL PROTECTED]> wrote: > > Author: [EMAIL PROTECTED] > Date: Mon Sep 8 11:56:27 2008 > New Revision: 216 > > Modified: >branches/bleeding_edge/test/mjsunit/mjsunit.status > > Log: > Mark number-string-index-call.js as FAIL on ARM because it depends on

[v8-dev] [v8 commit] r217 - in changes/[EMAIL PROTECTED]/explain-external-string-resource/bleeding_edge: . include

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 12:46:19 2008 New Revision: 217 Added: changes/[EMAIL PROTECTED]/explain-external-string-resource/bleeding_edge/ - copied from r216, /branches/bleeding_edge/ Modified: changes/[EMAIL PROTECTED]/explain-external-string-resource/bleedin

[v8-dev] [v8 commit] r218 - branches/bleeding_edge/include changes/[EMAIL PROTECTED]/explain-external-string-resource

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 12:46:49 2008 New Revision: 218 Removed: changes/[EMAIL PROTECTED]/explain-external-string-resource/ Modified: branches/bleeding_edge/include/v8.h Log: Explain better the constraints for external string resources. Modified: branches/bleeding_e

[v8-dev] Issue 27 in v8: no external string resource explicitly marked for UTF8

2008-09-08 Thread codesite-noreply
Issue 27: no external string resource explicitly marked for UTF8 http://code.google.com/p/v8/issues/detail?id=27 Comment #3 by erik.corry: Documentation fixed in bleeding edge version 218 -- You received this message because you are listed in the owner or CC fields of this issue, or because y

[v8-dev] Issue 6 in v8: Chrome/V8 breaks Prototype JavaScript library

2008-09-08 Thread codesite-noreply
Issue 6: Chrome/V8 breaks Prototype JavaScript library http://code.google.com/p/v8/issues/detail?id=6 Comment #17 by tomprogers: @ Comment 12: "No one should ever use a for..in loop on an array anyway." How else should I iterate over all and only the elements in a sparse array? -- You receiv

[v8-dev] Issue 6 in v8: Chrome/V8 breaks Prototype JavaScript library

2008-09-08 Thread codesite-noreply
Issue 6: Chrome/V8 breaks Prototype JavaScript library http://code.google.com/p/v8/issues/detail?id=6 Comment #18 by [EMAIL PROTECTED]: You can use for .. in on objects, but the order is not guaranteed. It is part of the spec. However, in practice, every browser enumerates properties in the a

[v8-dev] Issue 43 in v8: Exception is thrown when instantiate Image object if there is an element has id="Image" in HTML.

2008-09-08 Thread codesite-noreply
Issue 43: Exception is thrown when instantiate Image object if there is an element has id="Image" in HTML. http://code.google.com/p/v8/issues/detail?id=43 Comment #2 by [EMAIL PROTECTED]: I am going to take a look before moving to Chrome. Issue attribute updates: Status: Accepted

[v8-dev] Issue 36 in v8: Can't Build on Windows Vista 32-bit with VS 2008

2008-09-08 Thread codesite-noreply
Issue 36: Can't Build on Windows Vista 32-bit with VS 2008 http://code.google.com/p/v8/issues/detail?id=36 Comment #4 by autolysis: Using Visual C++ 2008 with Windows SDK for Windows Server 2008 and .NET Framework 3.5 You need to pass in the environment variables to scons as follows scons env

[v8-dev] Add codereview.settings file. Also use it as a self test.

2008-09-08 Thread feng
Reviewers: iposva, Message: v8-dev@googlegroups.com showed up as default in CC list. COOL. Next question: how to display issues that CC'ed to v8-dev@googlegroups.com TBR = [EMAIL PROTECTED] Description: Add codereview.settings file. Also use it as a self test. Please review this at http://c

[v8-dev] Re: Add codereview.settings file. Also use it as a self test.

2008-09-08 Thread iposva
LGTM Let's try this out with this self check. -Ivan http://codereview.chromium.org/1648 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] [v8 commit] r219 - branches/bleeding_edge/tools/v8.xcodeproj

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 20:08:23 2008 New Revision: 219 Modified: branches/bleeding_edge/tools/v8.xcodeproj/project.pbxproj Log: Submitting a revised Xcode project for Mark Mentovai ([EMAIL PROTECTED]). Reviewed here: http://codereview.chromium.org/1833 Modified: branc

[v8-dev] Re: Add codereview.settings file. Also use it as a self test.

2008-09-08 Thread jam
You can see the full list at http://codereview.chromium.org/user/v8-dev@googlegroups.com http://codereview.chromium.org/1648 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--

[v8-dev] Add support for setting the correct parameters for gcl and...

2008-09-08 Thread iposva
Reviewers: jam, Feng Qian, Description: Add support for setting the correct parameters for gcl and http://codereview.chromium.org Please review this at http://codereview.chromium.org/1835 Affected files: A codereview.settings Index: codereview.settings ==

[v8-dev] [v8 commit] r220 - branches/bleeding_edge

2008-09-08 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Sep 8 20:27:06 2008 New Revision: 220 Added: branches/bleeding_edge/codereview.settings Log: Add support for setting the correct parameters for gcl and http://codereview.chromium.org Review URL: http://codereview.chromium.org/1835 Added: branches/blee

  1   2   >