Issue 95: Mozilla test regress-360681-01 fails
http://code.google.com/p/v8/issues/detail?id=95
Comment #2 by olehougaard:
Fixed in r382
Issue attribute updates:
Status: Fixed
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you st
Reviewers: Christian Plesner Hansen,
Description:
Faster sort.
Using insertion sort below a certain threshold to give faster sorting of
arrays (esp. short ones).
Please review this at http://codereview.chromium.org/6006
Affected files:
M src/array.js
Index: src/array.js
==
Why 22?
On Tue, Sep 30, 2008 at 11:36 AM, <[EMAIL PROTECTED]> wrote:
>
> Reviewers: Christian Plesner Hansen,
>
> Description:
> Faster sort.
>
> Using insertion sort below a certain threshold to give faster sorting of
> arrays (esp. short ones).
>
> Please review this at http://codereview.chrom
That was the fastest on my computer. It's surprisingly high, though. Maybe
we should try experimenting on other setups.
On Tue, Sep 30, 2008 at 11:43 AM, Erik Corry <[EMAIL PROTECTED]> wrote:
>
> Why 22?
>
> On Tue, Sep 30, 2008 at 11:36 AM, <[EMAIL PROTECTED]> wrote:
> >
> > Reviewers: Christia
max = mid; is correct. The interval is up to but not including max. I've put
in a comment to that effect. The code style is fixed.
On Tue, Sep 30, 2008 at 11:50 AM, <[EMAIL PROTECTED]>wrote:
> There's a bit of odd code style and a possible +/-1. Otherwise lgtm.
>
>
> http://codereview.chromium.o
Author: olehougaard
Date: Tue Sep 30 02:58:22 2008
New Revision: 395
Modified:
branches/bleeding_edge/src/array.js
Log:
Faster sort.
Using insertion sort below a certain threshold to give faster sorting of
arrays (esp. short ones).
Review URL: http://codereview.chromium.org/6006
Modified
There's a bit of odd code style and a possible +/-1. Otherwise lgtm.
http://codereview.chromium.org/6006/diff/1/2
File src/array.js (right):
http://codereview.chromium.org/6006/diff/1/2#newcode673
Line 673: for(var i = from + 1; i < to; i++) {
There should be a space between 'for' and '('.
ht
Author: [EMAIL PROTECTED]
Date: Tue Sep 30 03:20:58 2008
New Revision: 396
Modified:
branches/bleeding_edge/test/cctest/test-assembler-arm.cc
Log:
Remove an ARM jump elimination test.
Modified: branches/bleeding_edge/test/cctest/test-assembler-arm.cc
Reviewers: Kasper Lund,
Message:
TBR to unbreak ARM tests.
Description:
Remove an ARM jump elimination test.
Please review this at http://codereview.chromium.org/5607
Affected files:
M test/cctest/test-assembler-arm.cc
Index: test/cctest/test-assembler-arm.cc
diff --git a/test/cctest/test
LGTM.
On 9/30/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Reviewers: Kasper Lund,
>
> Message:
> TBR to unbreak ARM tests.
>
> Description:
> Remove an ARM jump elimination test.
>
> Please review this at http://codereview.chromium.org/5607
>
> Affected files:
>M test/cctest/test-assem
Reviewers: Kasper Lund,
Message:
TBR. Blah, I swear it wasn't me mannn.
Description:
Remove some crzy trailing whitespace.
Please review this at http://codereview.chromium.org/6008
Affected files:
M src/assembler-arm.cc
Index: src/assembler-arm.cc
diff --git a/src/assembler-arm.cc b/
Issue 98: More parallelism in build / test
http://code.google.com/p/v8/issues/detail?id=98
New issue report by [EMAIL PROTECTED]:
We should be able to safely run the majority of tests in parallel. This
will help a lot on multi-core machines, but should also be beneficial on
single core. Right n
LGTM, but I would a couple of { } to make even more V8-awesome.
On 9/30/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Reviewers: Kasper Lund,
>
> Message:
> TBR. Blah, I swear it wasn't me mannn.
>
> Description:
> Remove some crzy trailing whitespace.
>
> Please review this at http://c
Author: [EMAIL PROTECTED]
Date: Tue Sep 30 04:41:58 2008
New Revision: 397
Modified:
branches/bleeding_edge/src/assembler-arm.cc
Log:
Remove some crzy trailing whitespace.
Modified: branches/bleeding_edge/src/assembler-arm.cc
=
Author: [EMAIL PROTECTED]
Date: Tue Sep 30 04:43:18 2008
New Revision: 398
Modified:
branches/bleeding_edge/include/v8.h
Log:
Disallow copy and assigning a few public objects.
BUG=97
Modified: branches/bleeding_edge/include/v8.h
=
Issue 97: copy constructors and assignment operators
http://code.google.com/p/v8/issues/detail?id=97
Comment #2 by [EMAIL PROTECTED]:
Fixed in bleeding_edge r398. Feel free to open another bug if there are
any other
objects that should have copy/assigning prevented.
Issue attribute updates:
fine by me
-Ivan
On Mon, Sep 29, 2008 at 12:48, Dean McNamee <[EMAIL PROTECTED]> wrote:
>
> I am seeing no code-size difference on ARM with and without the jump
> eliminator. I'm going to remove it, and replace it with an option to
> print unneeded jumps that we see while doing fixups.
>
> Than
Dean,
The last_pc_ is to track where the last instruction x86 instruction
started. If you can tell me how I can disassemble x86 code backwards I
would be happy to have ARM and x86 code more aligned. Until then I am
fine with this difference as the code is obviously machine dependent.
Cheers,
-Iv
Issue 98: More parallelism in build / test
http://code.google.com/p/v8/issues/detail?id=98
Comment #1 by christian.plesner.hansen:
I took a quick stab at this and it gives some impressive speedups
(basically as
expected: -jK gives a factor of K if K <= #cores). However, because of the
way
py
Issue 99: Detect whether g++ is installed
http://code.google.com/p/v8/issues/detail?id=99
New issue report by [EMAIL PROTECTED]:
If g++ is not installed running the SCons build produces strange error, as
the command executed is "o ..." not "g++ -o ...".
We should make sure that g++ is installed.
Kevin,
There is a whole set of comments I would like to add and agree upon
before we should go forward with this change and any other change in
this direction:
- We need to agree whether or not we should move away from the visitor
model of code gen. I do really dislike this creeping in of this ne
Reviewers: Dean McNamee,
Description:
Added option to parallelize test runs.
Please review this at http://codereview.chromium.org/6010
Affected files:
M tools/test.py
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com
Overall LGTM.
http://codereview.chromium.org/6010/diff/1/2
File tools/test.py (right):
http://codereview.chromium.org/6010/diff/1/2#newcode60
Line 60: self.queue.put_nowait(case)
Do you really want put_nowait, and not just put() ?
http://codereview.chromium.org/6010/diff/1/2#newcode79
Line 79:
Reviewers: Kasper Lund, iposva,
Message:
This is just for some initial feedback. I'm really not happy with the
ShortLabel approach overall, but it was the simplest to implement for
now.
Description:
A bad stab at short jump encoding by having a new ShortLabel.
Please review this at http://code
Author: [EMAIL PROTECTED]
Date: Tue Sep 30 08:32:07 2008
New Revision: 399
Modified:
branches/bleeding_edge/tools/test.py
Log:
Added option to parallelize test runs.
Modified: branches/bleeding_edge/tools/test.py
=
http://codereview.chromium.org/6010/diff/1/2
File tools/test.py (right):
http://codereview.chromium.org/6010/diff/1/2#newcode60
Line 60: self.queue.put_nowait(case)
This call should always succeed, but in case it doesn't I prefer
'put_nowait' because it fails with an exception rather than 'put'
On Dean's suggestion I've added a -j option to the test script that
will run (and build) the tests in parallel. On my machine (a four
core) running the default tests in release mode usually takes 30
seconds; with -j6 it takes 5. Running the mozilla tests with -j1
takes 4:30 whereas it takes 1:25
Issue 98: More parallelism in build / test
http://code.google.com/p/v8/issues/detail?id=98
Comment #2 by christian.plesner.hansen:
Implemented in bleeding edge r399.
Most of the time spent by presubmit.py is in cpplint.py so we would have to
parallelize that. Doing that would actually be enormo
Author: [EMAIL PROTECTED]
Date: Tue Sep 30 02:42:08 2008
New Revision: 394
Modified:
branches/bleeding_edge/src/assembler-arm.cc
branches/bleeding_edge/src/assembler-arm.h
branches/bleeding_edge/src/flag-definitions.h
Log:
Remove the ARM jump elimination. This completely removes jum
On Tue, Sep 30, 2008 at 4:18 PM, Marshall Greenblatt <[EMAIL PROTECTED]
> wrote:
> (Cross-listed to chromium-dev and v8-dev. Please CC me on any response.)
>
> Hi All,
>
> In the gears version of V8, we have the following method for retrieving a
> V8 context:
>
> v8::Local GetV8Context();
>
> It
Hi, Marshall,
I'm not quite sure what you are trying to do; a frame-independent script
object is generally something we'd try not to do. I admit, I'm not up to
speed with what Gears may have needed to do to support some of its
background workers, and maybe that is where you found this call.
Are y
(Cross-listed to chromium-dev and v8-dev. Please CC me on any response.)
Hi All,
In the gears version of V8, we have the following method for retrieving a V8
context:
v8::Local GetV8Context();
It was therefore hypothetically possible to create a Frame-independent
NPScriptObject instance using
Hi Mike,
On Tue, Sep 30, 2008 at 8:34 PM, Mike Belshe <[EMAIL PROTECTED]> wrote:
> Hi, Marshall,
> I'm not quite sure what you are trying to do; a frame-independent script
> object is generally something we'd try not to do. I admit, I'm not up to
> speed with what Gears may have needed to do to
Issue 100: WeakReferenceCallback vs Persistent
http://code.google.com/p/v8/issues/detail?id=100
New issue report by pete.gontier:
Persistent is declared as being derived from Handle .
WeakReferenceCallback takes Persistent rather than Persistent .
I don't know which is correct, but the fact th
Issue 86: Continuing a for-each loop in a finally clause exits the loop
http://code.google.com/p/v8/issues/detail?id=86
Comment #2 by [EMAIL PROTECTED]:
I'll take a look at this. Looks pretty weird.
Issue attribute updates:
Status: Assigned
Owner: [EMAIL PROTECTED]
Label
35 matches
Mail list logo
