Reviewers: Søren Gjesse,
Description:
Fixed a bunch of memory leaks in tests, including:
- String traversal test data (now in a zone)
- Debug message thread (now joined on exit)
- Threading test threads (now joined on exit)
- Changed message tests framework to cope with valgrind
Also, fixe
Author: ipo...@chromium.org
Date: Wed Mar 25 22:43:54 2009
New Revision: 1615
Modified:
branches/bleeding_edge/tools/v8.xcodeproj/project.pbxproj
Log:
- Add missing files to the Xcode project.
tbr=m...@chromium.org
Review URL: http://codereview.chromium.org/53087
Modified: branches/bleedin
Reviewers: Mark Mentovai,
Description:
- Add missing files to the Xcode project.
tbr=m...@chromium.org
Please review this at http://codereview.chromium.org/53087
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/v8.xcodeproj/project.pbxproj
Index:
Author: f...@chromium.org
Date: Wed Mar 25 11:23:04 2009
New Revision: 1614
Modified:
branches/bleeding_edge/src/assembler-arm.cc
branches/bleeding_edge/src/assembler-arm.h
branches/bleeding_edge/src/codegen-arm.cc
Log:
Fix and cleanup ARM port:
1) removed unused function, PcStoreOff
LGTM -ip
http://codereview.chromium.org/42610
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM -ip
http://codereview.chromium.org/53039
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Oh, and LGTM.
http://codereview.chromium.org/49029/diff/2007/2010
File src/virtual-frame.cc (right):
http://codereview.chromium.org/49029/diff/2007/2010#newcode216
Line 216: // [min(stack_pointer_,begin), end).
You mean min(stack_pointer + 1, begin)?
It might be better in the sense of avoiding
Inlined RawSyncElementAt at call sites, optimized by hand.
http://codereview.chromium.org/49029/diff/1/2
File src/virtual-frame-ia32.cc (right):
http://codereview.chromium.org/49029/diff/1/2#newcode67
Line 67: break; // The current value on the stack is some safe value.
On 2009/03/25 13:40:00,
LGTM.
http://codereview.chromium.org/42602
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kmilli...@chromium.org
Date: Wed Mar 25 07:08:41 2009
New Revision: 1613
Modified:
branches/bleeding_edge/src/codegen-ia32.cc
branches/bleeding_edge/src/virtual-frame-ia32.cc
branches/bleeding_edge/src/virtual-frame-ia32.h
branches/bleeding_edge/src/virtual-frame.cc
Log:
Author: mikhail.naga...@gmail.com
Date: Wed Mar 25 07:07:52 2009
New Revision: 1612
Modified:
branches/bleeding_edge/src/frames-inl.h
Log:
Add another check in profiler's stack iterator to ensure stability.
I made a test run of benchmarks and found another weak point. After
fixing it, benchm
>> reciever -> receiver (i before e except after c)
>
> I thought we had a spellchecker :)
We do. It's me.
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
On 2009/03/25 14:03:56, Kasper Lund wrote:
> LGTM as long as is_at_function() is only called from the safe iterator
which I
> think is the case.
Yes, you are right. It was added specifically for it.
http://codereview.chromium.org/53050
--~--~-~--~~~---~--~~
v8-de
On Wed, Mar 25, 2009 at 2:25 PM, wrote:
> LGTM. Maybe the register-pair-swapping could be generalized long term?
>
Yeah. There are a few other places where we do exactly the same thing. I
don't think we need to generalize it beyond two, either.
http://codereview.chromium.org/42602/diff/1/5
>
LGTM as long as is_at_function() is only called from the safe iterator
which I think is the case.
http://codereview.chromium.org/53050
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~--
Reviewers: Kasper Lund,
Description:
Add another check in profiler's stack iterator to ensure stability.
I made a test run of benchmarks and found another weak point. After
fixing it, benchmarks are able to run for a 100 times in a row
successfully in both builds.
Please review this at http://co
This looks good.
You might consider manually inlining RawSyncElementAt at its two call
sites and getting rid of its definition. Then, at the call site in
SyncRange (in the loop), you can probably simplify further to just call
the right one of the lower-level sync functions.
If you do that, I'd
LGTM. Maybe the register-pair-swapping could be generalized long term?
http://codereview.chromium.org/42602/diff/1/5
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/42602/diff/1/5#newcode5190
Line 5190: ? RelocInfo::CODE_TARGET_CONTEXT
4 space indent here?
http://codereview.ch
Author: mikhail.naga...@gmail.com
Date: Wed Mar 25 05:59:25 2009
New Revision: 1611
Modified:
branches/bleeding_edge/src/frames.cc
Log:
Added more checks to SafeStackFrameIterator to prevent crashes when
profiling.
Tested by profiling 3d-morph.js a 100 times both in debug and release
bui
Reviewers: Kasper Lund, William Hesse,
Message:
This is the first part of an attempt to simplify handling of calls.
Nothing needs to be changed for ARM yet. The #ifdef ARM is temporary.
Next steps are (1) handle the other code objects (JS functions and
constructor calls, call ICs), (2) handle th
Author: l...@chromium.org
Date: Wed Mar 25 05:37:49 2009
New Revision: 1610
Modified:
branches/bleeding_edge/src/jsregexp.cc
Log:
Move reference to variable that isn't used on ARM.
Modified: branches/bleeding_edge/src/jsregexp.cc
Reviewers: Kevin Millikin,
Description:
Inline part of RawSyncElementAt, improve PrepareForCall
Please review this at http://codereview.chromium.org/49029
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/virtual-frame-ia32.h
M src/virtual-frame
http://codereview.chromium.org/42600/diff/1/2
File src/frames.cc (right):
http://codereview.chromium.org/42600/diff/1/2#newcode234
Line 234: // see EntryFrame::GetCallerState
On 2009/03/25 11:17:13, Kasper Lund wrote:
> Capitalize see (see -> See) and terminate comment with . Maybe
consider
> ex
Quick LGTM
http://codereview.chromium.org/53048
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Erik Corry,
Message:
Quick review.
Description:
Move reference to variable that isn't used on ARM.
Please review this at http://codereview.chromium.org/53048
Affected files:
M src/jsregexp.cc
Index: src/jsregexp.cc
diff --git a/src/jsregexp.cc b/src/jsregexp.cc
index
7e40d7b0
Author: kasp...@chromium.org
Date: Wed Mar 25 05:14:13 2009
New Revision: 1609
Modified:
branches/bleeding_edge/tools/splaytree.py
branches/bleeding_edge/tools/tickprocessor.py
Log:
Introduce splaytree.KeyNotFoundError and use it for reporting
issues when removing non-existing nodes from
Author: l...@chromium.org
Date: Wed Mar 25 05:14:10 2009
New Revision: 1608
Modified:
branches/bleeding_edge/src/jsregexp.cc
branches/bleeding_edge/src/jsregexp.h
branches/bleeding_edge/src/platform-win32.cc
branches/bleeding_edge/src/regexp-macro-assembler-ia32.cc
branches/bl
LGTM
http://codereview.chromium.org/42599
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
STV!
http://codereview.chromium.org/53047/diff/1/8
File src/string.js (right):
http://codereview.chromium.org/53047/diff/1/8#newcode160
Line 160: // lastMatchInfo is defined in regexp-delay.js
full stop
http://codereview.chromium.org/53047
--~--~-~--~~~---~--~~
Reviewers: Erik Corry,
Message:
Review, please.
Description:
Moved String.prototype.match implementation to C++.
Some extra runtime assertions added.
Please review this at http://codereview.chromium.org/53047
Affected files:
M src/jsregexp.h
M src/jsregexp.cc
M src/platform-win32.cc
Author: kmilli...@chromium.org
Date: Wed Mar 25 04:05:36 2009
New Revision: 1607
Modified:
branches/bleeding_edge/src/codegen-arm.cc
branches/bleeding_edge/src/codegen-ia32.cc
branches/bleeding_edge/src/virtual-frame-ia32.cc
branches/bleeding_edge/src/virtual-frame.cc
Log:
The co
LGTM.
http://codereview.chromium.org/42600/diff/1/2
File src/frames.cc (right):
http://codereview.chromium.org/42600/diff/1/2#newcode234
Line 234: // see EntryFrame::GetCallerState
Capitalize see (see -> See) and terminate comment with . Maybe consider
explicitly describing that this is customi
Reviewers: Kasper Lund,
Description:
Added more checks to SafeStackFrameIterator to prevent crashes when
profiling.
Tested by profiling 3d-morph.js a 100 times both in debug and release
builds.
Please review this at http://codereview.chromium.org/42600
Affected files:
M src/frames.cc
Index
LGTM.
http://codereview.chromium.org/42598
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Introduce splaytree.KeyNotFoundError and use it for reporting
issues when removing non-existing nodes from a SplayTree.
Please review this at http://codereview.chromium.org/42599
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
Author: kasp...@chromium.org
Date: Wed Mar 25 03:29:22 2009
New Revision: 1606
Modified:
branches/bleeding_edge/src/assembler-ia32.cc
branches/bleeding_edge/tools/splaytree.py
Log:
Make sure to generate a CodeCreateEvent for the CPU features
probe code object, and really raise an excepti
Author: whe...@chromium.org
Date: Wed Mar 25 03:00:52 2009
New Revision: 1605
Modified:
branches/bleeding_edge/src/codegen-ia32.cc
branches/bleeding_edge/src/jump-target.cc
branches/bleeding_edge/src/register-allocator.cc
branches/bleeding_edge/src/virtual-frame-arm.h
branches
LGTM
http://codereview.chromium.org/42597
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: William Hesse,
Description:
The code generator doesn't need to put the argument count in eax for
call ICs. Refactor CallRuntime on ARM to match the structure of IA32.
Update some comments.
Please review this at http://codereview.chromium.org/42598
SVN Base: http://v8.googlecode.com/
Reviewers: Mikhail Naganov,
Description:
Make sure to generate a CodeCreateEvent for the CPU features
probe code object, and really raise an exception if SplayTree.Remove
is called with a key that cannot be found.
Please review this at http://codereview.chromium.org/42597
SVN Base: http://v8.go
Other than the issue mentioned below, it LGTM.
http://codereview.chromium.org/42565/diff/1004/1008
File src/virtual-frame.cc (right):
http://codereview.chromium.org/42565/diff/1004/1008#newcode189
Line 189: // in the CodeGenerator's Allocator must be above 0.
I don't like this comment. It's no
All recommended changes made.
http://codereview.chromium.org/42565/diff/1/2
File src/jump-target.cc (right):
http://codereview.chromium.org/42565/diff/1/2#newcode275
Line 275: // Set the register counts and indices.
On 2009/03/25 08:48:19, Kevin Millikin wrote:
> Update this comment to go with
Reviewers: Erik Corry,
Description:
Move time related functions to POSIX platform file.
The functions getrusage, gettimeofday and localtime are in POSIX.1-2001.
Please review this at http://codereview.chromium.org/53045
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected f
Author: mikhail.naga...@gmail.com
Date: Wed Mar 25 02:35:11 2009
New Revision: 1604
Modified:
branches/bleeding_edge/src/platform-win32.cc
Log:
Use OpenThread instead of DuplicateHandle in Win32 profiler implementation.
OpenThread doesn't fail in Chrome sandbox, while DuplicateHandle does.
http://codereview.chromium.org/49028/diff/1/2
File src/platform-win32.cc (right):
http://codereview.chromium.org/49028/diff/1/2#newcode1818
Line 1818: if (IsProfiling()) {
On 2009/03/25 09:18:00, Søren Gjesse wrote:
> I think the comment needs to be changed a bit as still says "duplicate
the
> ha
LGTM
This is great!
http://codereview.chromium.org/49028/diff/1/2
File src/platform-win32.cc (right):
http://codereview.chromium.org/49028/diff/1/2#newcode1818
Line 1818: if (IsProfiling()) {
I think the comment needs to be changed a bit as still says "duplicate
the handle". It could say "open
Reviewers: Søren Gjesse,
Description:
Use OpenThread instead of DuplicateHandle in Win32 profiler
implementation.
OpenThread doesn't fail in Chrome sandbox, while DuplicateHandle does.
Please review this at http://codereview.chromium.org/49028
Affected files:
M src/platform-win32.cc
Index:
This seems like a nice cleanup even if it doesn't make a noticeable
performance difference.
http://codereview.chromium.org/42565/diff/1/2
File src/jump-target.cc (right):
http://codereview.chromium.org/42565/diff/1/2#newcode275
Line 275: // Set the register counts and indices.
Update this comme
48 matches
Mail list logo
