Next round of comments. In short: You are still open to failure in case
of a thread_suspend failure.
-Ivan
http://codereview.chromium.org/147150/diff/1/2
File src/platform-macos.cc (right):
http://codereview.chromium.org/147150/diff/1/2#newcode542
Line 542: thread_resume(profiled_thread_);
On
Author: f...@chromium.org
Date: Mon Jun 29 14:15:03 2009
New Revision: 2299
Modified:
branches/bleeding_edge/src/heap.cc
branches/bleeding_edge/src/heap.h
Log:
Workaround a gcc 4.4 bug.
Gcc generates wrong vtable entries for certain code pattern. The change in
heap.cc has detailed exp
Rephrased comment and removed bug references.
On 2009/06/24 07:38:31, Erik Corry wrote:
> LGTM apart from the comments.
> http://codereview.chromium.org/147022/diff/1/2
> File src/heap.cc (right):
> http://codereview.chromium.org/147022/diff/1/2#newcode1291
> Line 1291: // gcc-4.4 has problem t
Reviewers: Søren Gjesse,
Description:
When Error.collectStackTraces is set to true all new instances of
Error, ReferenceError, etc. are given a stack property that gives a
stack trace. Here's an example stack trace:
ReferenceError: FAIL is not defined
at Constraint.execute (deltablue.js:527
Author: ipo...@chromium.org
Date: Mon Jun 29 10:07:30 2009
New Revision: 2298
Modified:
branches/bleeding_edge/src/codegen.h
branches/bleeding_edge/src/execution.cc
branches/bleeding_edge/src/frames-inl.h
branches/bleeding_edge/src/jsregexp.cc
branches/bleeding_edge/src/macro-
Author: whe...@chromium.org
Date: Mon Jun 29 08:04:24 2009
New Revision: 2297
Modified:
branches/bleeding_edge/src/bootstrapper.cc
branches/bleeding_edge/src/x64/codegen-x64.cc
branches/bleeding_edge/src/x64/codegen-x64.h
branches/bleeding_edge/src/x64/macro-assembler-x64.cc
b
Author: erik.co...@gmail.com
Date: Mon Jun 29 07:23:33 2009
New Revision: 2296
Modified:
branches/bleeding_edge/src/x64/codegen-x64.cc
Log:
Fix build on x64 after compare stub change.
Review URL: http://codereview.chromium.org/150022
Modified: branches/bleeding_edge/src/x64/codegen-x64.cc
=
LGTM, thanks for doing this.
http://codereview.chromium.org/150026
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
- Add a "#error Unsupported target architecture." where needed. A chain
of
platform dependent ifdefs is useless if it does not include an error
like
this. You will end up searching for the failure in all the wrong
places.
Please review this at http://code
STV!
http://codereview.chromium.org/151022
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/151022
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM.
http://codereview.chromium.org/150022
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM.
http://codereview.chromium.org/150022
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: William Hesse,
Description:
Fix build on x64 after compare stub change.
Please review this at http://codereview.chromium.org/150022
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/codegen-x64.cc
Index: src/x64/codegen-x64.cc
Author: erik.co...@gmail.com
Date: Mon Jun 29 06:52:13 2009
New Revision: 2295
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/codegen-arm.h
branches/bleeding_edge/src/arm/simulator-arm.cc
branches/bleeding_edge/src/assembler.cc
branches/
There is a security check issue with this change. Through the API, we
allow enabling access checks on the global object at any time. As we
discussed offline, we should perform a map check instead of identity
check.
http://codereview.chromium.org/151019/diff/1/11
File src/objects.h (right):
ht
On Mon, Jun 29, 2009 at 3:42 PM, wrote:
> On ARM the condition codes are in bits 28-31 so they have to be shifted
> down. On Intel the condition codes are already in the low bits.
Ah. Okay. Makes sense. LGTM.
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@goog
More tests added to boost coverage.
http://codereview.chromium.org/151003/diff/1/4
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/151003/diff/1/4#newcode7822
Line 7822: int CompareStub::MinorKey() {
On 2009/06/29 06:13:52, Kasper Lund wrote:
> Couldn't this go into codege
Reviewers: Lasse Reichstein,
Description:
X64: Remove temporary compiler and assembler tests, now that shell runs.
Please review this at http://codereview.chromium.org/151022
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/bootstrapper.cc
M sr
Author: kasp...@chromium.org
Date: Mon Jun 29 03:45:16 2009
New Revision: 2293
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/codegen-arm.h
branches/bleeding_edge/src/codegen.cc
branches/bleeding_edge/src/ia32/codegen-ia32.cc
branches/bl
Author: b...@chromium.org
Date: Mon Jun 29 05:41:18 2009
New Revision: 2294
Modified:
branches/bleeding_edge/src/date-delay.js
branches/bleeding_edge/src/macros.py
Log:
Replaced DateFromTime and isNaN with macro calls in date code.
Review URL: http://codereview.chromium.org/150021
Modi
Reviewers: Mads Ager,
Description:
X64: Fix error in FixedArray access, and blocker in IN operator.
Please review this at http://codereview.chromium.org/151021
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/runtime.js
M src/x64/codegen-x64.cc
LGTM.
http://codereview.chromium.org/151019/diff/1/18
File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/151019/diff/1/18#newcode76
Line 76: __ ldr(t0, FieldMemOperand(t1, JSObject::kMapOffset));
We're really loading the same map of bunch of times here...
http://codereview.chromium
Guys, may you have a look at another pass?
I think that no getter interceptor case should be lifted higher in the
stack (ic.cc) and this CL lacks tests and cleanups, but I'd like to get
your LGTM on stub part first.
tia and yours,
anton.
http://codereview.chromium.org/140069
--~--~-~--
http://codereview.chromium.org/150021/diff/1/3
File src/date-delay.js (right):
http://codereview.chromium.org/150021/diff/1/3#newcode44
Line 44: function ThrowTypeError() {
How about calling this something with Date in the name? It's pretty
specific to the date implementation.
http://codereview
LGTM
http://codereview.chromium.org/150021
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Kasper Lund, Mads Ager,
Description:
Changed the global object representation.
The global object is now always in dictionary (slow) mode with each of
its properties stored in a cell object. A cell object has one field
containing the actual value for the property. Inline caches for acc
Reviewers: Mads Ager,
Description:
Replaced DateFromTime and isNaN with macro calls in date code.
Please review this at http://codereview.chromium.org/150021
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/date-delay.js
M src/macros.py
--~
Ping!
http://codereview.chromium.org/147150
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM!
Nice cleanup as well.
http://codereview.chromium.org/151018
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Optimize %ClassOf() on IA-32 and use it instead of the
custom %HasXXXClass() calls.
Please review this at http://codereview.chromium.org/151018
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.h
M
Author: a...@chromium.org
Date: Mon Jun 29 01:12:02 2009
New Revision: 2289
Modified:
branches/bleeding_edge/ChangeLog
branches/bleeding_edge/src/version.cc
Log:
Prepare push of version 1.2.10 to trunk.
Review URL: http://codereview.chromium.org/151015
Modified: branches/bleeding_edge/C
Author: erik.co...@gmail.com
Date: Mon Jun 29 02:32:06 2009
New Revision: 2292
Modified:
branches/bleeding_edge/src/arm/assembler-arm.cc
branches/bleeding_edge/src/arm/disasm-arm.cc
branches/bleeding_edge/src/ia32/assembler-ia32.cc
branches/bleeding_edge/src/ia32/assembler-ia32.h
Author: whe...@chromium.org
Date: Mon Jun 29 01:04:39 2009
New Revision: 2287
Modified:
branches/bleeding_edge/src/objects-inl.h
branches/bleeding_edge/src/x64/builtins-x64.cc
branches/bleeding_edge/src/x64/codegen-x64.cc
branches/bleeding_edge/src/x64/ic-x64.cc
Log:
X64 Implemen
Author: b...@chromium.org
Date: Mon Jun 29 00:19:17 2009
New Revision: 2286
Modified:
branches/bleeding_edge/src/objects.cc
Log:
Changed HashTable::EnsureCapacity to gurantee at least 50% of the entries
are free (up from 25%).
This reduces the mount of probing in large hash tables.
Revie
As discussed offline some of the loose variables that are passed by
reference should be packed into an object.
http://codereview.chromium.org/149069/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/149069/diff/1/2#newcode376
Line 376: // Implement a stack of RegExpBuilder's f
Author: whe...@chromium.org
Date: Mon Jun 29 01:11:35 2009
New Revision: 2288
Modified:
branches/bleeding_edge/src/x64/codegen-x64.cc
Log:
X64: Fix error in running handlers, disable TakeValue optimization for
count operators.
Review URL: http://codereview.chromium.org/150007
Modified: br
LGTM!
http://codereview.chromium.org/150018/diff/17/1026
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/150018/diff/17/1026#newcode3334
Line 3334: Result answer =
frame_->CallRuntime(Runtime::kIsConstructCall, 0);
Maybe add a TODO here and also on ARM so we remember to opti
Author: kasp...@chromium.org
Date: Mon Jun 29 01:14:06 2009
New Revision: 2290
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/codegen-arm.h
branches/bleeding_edge/src/codegen.cc
branches/bleeding_edge/src/date-delay.js
branches/bleeding_
Committed with change http://codereview.chromium.org/147205 in revision
2287
http://codereview.chromium.org/151004
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~-
LGTM, but maybe you should mention the issue number for the fixed bug?
On Mon, Jun 29, 2009 at 10:05 AM, wrote:
> Reviewers: Kasper Lund,
>
> Description:
> Prepare push of version 1.2.10 to trunk.
>
> Please review this at http://codereview.chromium.org/151015
>
> SVN Base: http://v8.googlecode
Includes changelist from issue 151004 because 151004 was on a machine
that cannot commit. http://codereview.chromium.org/151004
http://codereview.chromium.org/147205/diff/1/2
File src/x64/builtins-x64.cc (right):
http://codereview.chromium.org/147205/diff/1/2#newcode185
Line 185: // +1 ~ return
Reviewers: Kasper Lund,
Description:
Prepare push of version 1.2.10 to trunk.
Please review this at http://codereview.chromium.org/151015
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: src/version.cc
==
Reviewers: Mads Ager,
Description:
Optimize %IsConstructCall() on IA-32.
Please review this at http://codereview.chromium.org/150018
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/codege
LGTM
http://codereview.chromium.org/150017
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
45 matches
Mail list logo
