Revision: 2868
Author: whe...@chromium.org
Date: Thu Sep 10 00:13:01 2009
Log: Use SSE2 instructions when available on ia32 platform.
Review URL: http://codereview.chromium.org/197057
http://code.google.com/p/v8/source/detail?r=2868
Modified:
/branches/bleeding_edge/src/ia32/assembler-ia32.cc
http://codereview.chromium.org/197057/diff/4001/4002
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/197057/diff/4001/4002#newcode6745
Line 6745: FloatingPointHelper::CheckFloatOperands(masm, &call_runtime,
ebx);
On 2009/09/09 15:09:55, Mark Mentovai wrote:
> Shouldn't this
Status: New
Owner:
CC: m...@chromium.org, a...@chromium.org, kasp...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 436 by m...@chromium.org: Numeric results are wrong on some
systems due to x87 extended double precision
http://code.google.com/p/v8/issues/detail?id=436
V8 for I
Reviewers: William Hesse,
Message:
Review, and any suggestions for abstracting indexing by a smi, please.
Description:
X64: Extract all smi operations into MacroAssembler macros.
First step in changing Smi representation.
Please review this at http://codereview.chromium.org/196077
Affected fil
LGTM. Is there a performance impact?
http://codereview.chromium.org/196077/diff/1/5
File src/x64/builtins-x64.cc (right):
http://codereview.chromium.org/196077/diff/1/5#newcode358
Line 358: __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rdx,
kPointerSizeLog2);
Does this assume that the smi is z
Reviewers: Lasse Reichstein,
Description:
Implement code patcher for x64.
Use the code patcher for the patching of the JS return sequence used by the
debugger.
Added explicit instruction cache flushing in a code patching section which
did
not have it for completeness, even though it is not re
Reviewers: Erik Corry,
Description:
Implemented missing pieces of the debugger for ARM.
The main piece of this change was to add support for break on return for
ARM. On
ARM the normal js function return consist of the following code sequence.
mov sp, fp
ldmia sp!, {fp, lr}
add sp, sp
Reviewers: Christian Plesner Hansen,
Description:
Add option --build-only to the test runner.
This new option is convenient for cross-compilation as actually running the
targets build does not make sense.
Please review this at http://codereview.chromium.org/200077
SVN Base: http://v8.googlecod
LGTM
http://codereview.chromium.org/203016/diff/1/3
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/203016/diff/1/3#newcode184
Line 184: patcher.masm()->call(r10);
Could you add a (debug only) assertion that the patcher's
masm's pc_offset is pc_+13 at this point?
http://c
Performance is approx. the same (~0.2% increase on V8 benchmark suite).
http://codereview.chromium.org/196077/diff/1/5
File src/x64/builtins-x64.cc (right):
http://codereview.chromium.org/196077/diff/1/5#newcode358
Line 358: __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rdx,
kPointerSizeLog2);
http://codereview.chromium.org/196077/diff/1/5
File src/x64/builtins-x64.cc (right):
http://codereview.chromium.org/196077/diff/1/5#newcode358
Line 358: __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rdx,
kPointerSizeLog2);
Ah, you were referring to the implementation. That did miss a zero
extens
Lgtm
http://codereview.chromium.org/200077
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/203016/diff/1/3
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/203016/diff/1/3#newcode184
Line 184: patcher.masm()->call(r10);
On 2009/09/10 12:33:12, Lasse Reichstein wrote:
> Could you add a (debug only) assertion that the patcher's
> masm'
Revision: 2870
Author: sgje...@chromium.org
Date: Thu Sep 10 05:59:01 2009
Log: Implement code patcher for x64.
Use the code patcher for the patching of the JS return sequence used by the
debugger.
Added explicit instruction cache flushing in a code patching section which
did not have it for
Revision: 2871
Author: sgje...@chromium.org
Date: Thu Sep 10 05:59:49 2009
Log: Add option --build-only to the test runner.
This new option is convenient for cross-compilation as actually running the
targets build does not make sense.
Review URL: http://codereview.chromium.org/200077
http://cod
Reviewers: ,
Description:
Fix IA32 build.
tbr=...@chromium.org
Please review this at http://codereview.chromium.org/201078
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/assembler-ia32.h
Index: src/ia32/assembler-ia32.h
=
Revision: 2872
Author: a...@chromium.org
Date: Thu Sep 10 06:27:00 2009
Log: Fix IA32 build.
tbr=...@chromium.org
Review URL: http://codereview.chromium.org/201078
http://code.google.com/p/v8/source/detail?r=2872
Modified:
/branches/bleeding_edge/src/ia32/assembler-ia32.h
Reviewers: Søren Gjesse,
Description:
Fix lint issue.
tbr=sgje...@chromium.org
Please review this at http://codereview.chromium.org/203017
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/assembler-ia32.cc
Index: src/ia32/assembler-ia32.cc
Revision: 2873
Author: a...@chromium.org
Date: Thu Sep 10 06:56:12 2009
Log: Fix lint issue.
tbr=sgje...@chromium.org
Review URL: http://codereview.chromium.org/203017
http://code.google.com/p/v8/source/detail?r=2873
Modified:
/branches/bleeding_edge/src/ia32/assembler-ia32.cc
===
Thanks, sorry, and LGTM.
On Thu, Sep 10, 2009 at 15:26, wrote:
>
> Reviewers: ,
>
> Description:
> Fix IA32 build.
>
> tbr=...@chromium.org
>
> Please review this at http://codereview.chromium.org/201078
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected files:
> M
LGTM, thanks for fixing this.
http://codereview.chromium.org/203017
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/201078
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
iirc none of the javascript implementations have had a working
mandelbrot program.
On Sep 9, 12:15 am, christian.plesner.han...@gmail.com wrote:
> As far as I can tell neither spidermonkey nor jsc implement this -- at
> least not the versions installed on my machine. How can it be required
> by
Status: New
Owner:
New issue 438 by vict...@chromium.org: Fix toString function in V8 to be
compatible with webkit JSC
http://code.google.com/p/v8/issues/detail?id=438
Layout test LayoutTests/fast/js/kde/inbuilt_function_tostring.html uses
toString function and fails in V8. This is becaus
Updates:
Status: Accepted
Labels: Priority-Low
Comment #1 on issue 438 by a...@chromium.org: Fix toString function in V8
to be compatible with webkit JSC
http://code.google.com/p/v8/issues/detail?id=438
(No comment was entered for this change.)
--
You received this message bec
STV!
http://codereview.chromium.org/199075/diff/4006/4015
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/199075/diff/4006/4015#newcode329
Line 329: __ add(sp, sp, Operand((scope_->num_parameters() + 1) *
kPointerSize));
The generated code coverage test relies on you using m
26 matches
Mail list logo
