Comment #14 on issue 573 by zastr...@gmail.com: non standard strings
allowed by JSON.parse()
http://code.google.com/p/v8/issues/detail?id=573
The general rule of thumb for interoperable web programming is
I agree except for when there is a standard. Which there is and therefore
chro
Comment #13 on issue 573 by vortexcortex: non standard strings allowed by
JSON.parse()
http://code.google.com/p/v8/issues/detail?id=573
I have to disagree. I don't think this is *bad* at all for Chrome or it's
image.
The general rule of thumb for interoperable web programming is, "Be len
Revision: 3699
Author: kasp...@chromium.org
Date: Mon Jan 25 22:37:45 2010
Log: Tagging version 2.0.6.4
http://code.google.com/p/v8/source/detail?r=3699
Added:
/tags/2.0.6.4
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 3698
Author: kasp...@chromium.org
Date: Mon Jan 25 22:37:00 2010
Log: Tagging version 2.0.6.3
http://code.google.com/p/v8/source/detail?r=3698
Added:
/tags/2.0.6.3
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 3697
Author: kasp...@chromium.org
Date: Mon Jan 25 22:35:47 2010
Log: Tagging version 2.0.6.2
http://code.google.com/p/v8/source/detail?r=3697
Added:
/tags/2.0.6.2
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Message:
Hi,
I have worked on your previous comments.
Thanks again to the reviewers.
This should be much cleaner now. I fear I might have left a few style errors
undetected by tools/presubmit.py. Now I know better Google style guidelines
I'll
remove them whenever I s
Revision: 3694
Author: kaznach...@chromium.org
Date: Mon Jan 25 09:03:34 2010
Log: Fixing an assertion fail introduced in 3692.
Also fixing some formatting issues.
Review URL: http://codereview.chromium.org/556002
http://code.google.com/p/v8/source/detail?r=3694
Modified:
/branches/bleeding_edge
LGTM
http://codereview.chromium.org/556002
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, erik.corry._gmail.com,
Description:
Fixing an assertion fail introduced in 3692.
Also fixing some formatting issues.
Please review this at http://codereview.chromium.org/556002
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32
Whoops, comitted in revision 3693.
-- Mads
On Mon, Jan 25, 2010 at 5:42 PM, Ryan Dahl wrote:
>> Thanks for the patch. Landed in V8 bleeding_edge revision 3688.
>
> It seems platform-solaris.cc did not get included?
>
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/grou
Revision: 3693
Author: a...@chromium.org
Date: Mon Jan 25 08:48:53 2010
Log: Actually land the platform-solaris.cc file for solaris support.
Review URL: http://codereview.chromium.org/545125
http://code.google.com/p/v8/source/detail?r=3693
Added:
/branches/bleeding_edge/src/platform-solaris.cc
> Thanks for the patch. Landed in V8 bleeding_edge revision 3688.
It seems platform-solaris.cc did not get included?
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/554062/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/554062/diff/1/2#newcode744
src/ia32/codegen-ia32.cc:744: enum ArgLocation {
It seems like this should be a member of FloatingPointHelper.
http://codereview.chromium.org/554062/di
http://codereview.chromium.org/554062/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/554062/diff/1/2#newcode7506
src/ia32/codegen-ia32.cc:7506: HasArgumentsReversed() ?
On 2010/01/25 15:44:03, Mads Ager wrote:
Indent by one more space. Looks like 3-space indent i
Revision: 3692
Author: kaznach...@chromium.org
Date: Mon Jan 25 08:00:03 2010
Log: Use registers to pass arguments to GenericBinaryOpStub.
Currently arguments are never passed on registers (due to the way
ArgsInRegistersSupported is written) and
if they were, the stub would break in several plac
LGTM
http://codereview.chromium.org/554062/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/554062/diff/1/2#newcode7506
src/ia32/codegen-ia32.cc:7506: HasArgumentsReversed() ?
Indent by one more space. Looks like 3-space indent instead of 4-space
indent?
http://co
Revision: 3691
Author: whe...@chromium.org
Date: Mon Jan 25 07:17:58 2010
Log: Make ARM assembler VFP3 test pass on machines without VFP3 floating
point hardware.
Review URL: http://codereview.chromium.org/543187
http://code.google.com/p/v8/source/detail?r=3691
Modified:
/branches/bleeding_ed
LGTM
http://codereview.chromium.org/543187
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: fschneider,
Message:
A fix to make the tree green again.
Description:
Make ARM assembler VFP3 test pass on machines without VFP3 floating point
hardware.
Please review this at http://codereview.chromium.org/543187
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affec
Reviewers: Kevin Millikin, Mads Ager, Erik Corry,
Description:
Use registers to pass arguments to GenericBinaryOpStub.
Currently arguments are never passed on registers (due to the way
ArgsInRegistersSupported is written) and
if they were, the stub would break in several places because registers
Reviewers: antonm,
Description:
Fix stack overflow in cctest/test-api/Threadin2 after r3613.
r3613 started wrapping all builtins in extra call in debug mode so it
became easier to cause stack overflow especially in 64-bit build.
Please review this at http://codereview.chromium.org/546129
Affec
On 2010/01/25 13:01:40, Søren Gjesse wrote:
LGTM with a style comment:
In the V8 code base we always have explicit check against NULL, so
while (HeapObject* obj = it.next()) {
needs to be
while ((HeapObject* obj = it.next()) != NULL) {
As the while with != NULL check requires
Revision: 3690
Author: a...@chromium.org
Date: Mon Jan 25 05:24:36 2010
Log: Merge v8 bleeding_edge revision 3689 to trunk. This fixes issue with
character ranges in regexp engine.
Review URL: http://codereview.chromium.org/548138
http://code.google.com/p/v8/source/detail?r=3690
Modified:
/tr
LGTM
http://codereview.chromium.org/548138
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On Mon, Jan 25, 2010 at 3:41 PM, wrote:
> This is an interesting aproach to changing the code of a running function.
>
> However there are several issues which are somewhat troublesome. There are
> bound
> to be a large number of cornercases for a feature like this. Also there is
> bound
> to be
Reviewers: Lasse Reichstein,
Description:
Merge v8 bleeding_edge revision 3689 to trunk. This fixes issue with
character ranges in regexp engine.
Please review this at http://codereview.chromium.org/548138
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/jsregexp.cc
Sure, will fix. Thanks a lot for review.
yours,
anton.
On Mon, Jan 25, 2010 at 4:01 PM, wrote:
> LGTM with a style comment:
>
> In the V8 code base we always have explicit check against NULL, so
>
> while (HeapObject* obj = it.next()) {
>
> needs to be
>
> while ((HeapObject* obj = it.next()
LGTM with a style comment:
In the V8 code base we always have explicit check against NULL, so
while (HeapObject* obj = it.next()) {
needs to be
while ((HeapObject* obj = it.next()) != NULL) {
http://codereview.chromium.org/555072
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Revision: 3689
Author: l...@chromium.org
Date: Mon Jan 25 04:56:49 2010
Log: Fix bug in character-set merging. Add test case.
See Chromium bug 32637.
Review URL: http://codereview.chromium.org/553067
http://code.google.com/p/v8/source/detail?r=3689
Modified:
/branches/bleeding_edge/src/jsregexp
LGTM
http://codereview.chromium.org/553067
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Message:
Small review.
Description:
Fix bug in character-set merging. Add test case.
See Chromium bug 32647.
Please review this at http://codereview.chromium.org/553067
Affected files:
M src/jsregexp.cc
M test/cctest/test-regexp.cc
--
v8-dev mailing list
v8-dev@goog
This is an interesting aproach to changing the code of a running function.
However there are several issues which are somewhat troublesome. There are
bound
to be a large number of cornercases for a feature like this. Also there is
bound
to be some constraints to when this will be possible. I
Thanks for the patch. Landed in V8 bleeding_edge revision 3688.
http://codereview.chromium.org/545125
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 3688
Author: a...@chromium.org
Date: Mon Jan 25 04:37:31 2010
Log: Land patch to add Solaris platform support.
Patch by Erich Ocean and Ryan Dahl.
Review URL: http://codereview.chromium.org/545125
http://code.google.com/p/v8/source/detail?r=3688
Modified:
/branches/bleeding_edge/AUTH
Revision: 3687
Author: whe...@chromium.org
Date: Mon Jan 25 03:54:10 2010
Log: Add vstr and vldr floating point load and store to ARM assembler,
disassembler, and simulator.
Review URL: http://codereview.chromium.org/545155
http://code.google.com/p/v8/source/detail?r=3687
Modified:
/branches/
http://codereview.chromium.org/545155/diff/6001/6003
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/545155/diff/6001/6003#newcode1376
src/arm/assembler-arm.cc:1376: int offset,
On 2010/01/22 14:29:13, Erik Corry wrote:
I feel strongly that the offset should be byte orient
Revision: 3686
Author: kasp...@chromium.org
Date: Mon Jan 25 03:02:06 2010
Log: Merge r3655, r3657, and r3672 from bleeding_edge to
trunk to fix issues with the new map space compaction
code.
Merge r3680 from bleeding_edge to trunk to fix issue 589.
Review URL: http://codereview.chromium.org/5481
The rest is LGTM. Thanks for merging it.
yours,
anton.
On Mon, Jan 25, 2010 at 1:51 PM, Kasper Lund wrote:
> After chatting with Anton, I'm un-merging the fix for issue 582 since
> the problem doesn't exist on trunk (introduced in r3613).
>
> On Mon, Jan 25, 2010 at 11:36 AM, wrote:
>> LGTM
>
After chatting with Anton, I'm un-merging the fix for issue 582 since
the problem doesn't exist on trunk (introduced in r3613).
On Mon, Jan 25, 2010 at 11:36 AM, wrote:
> LGTM
>
> http://codereview.chromium.org/548136
>
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
LGTM
http://codereview.chromium.org/548136
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, antonm,
Description:
Merge r3643 and r3659 from bleeding_edge to trunk to
fix issue 582.
Merge r3655, r3657, and r3672 from bleeding_edge to
trunk to fix issues with the new map space compaction
code.
Merge r3680 from bleeding_edge to trunk to fix issue 589.
Please review
Reviewers: Søren Gjesse, Erik Corry,
Message:
Just FYI. I tried to unify PageIterator, but there are couple of places
where
has_next is used to determine if that's the last page.
And actually I placed two unnecessary .has_next's before when iterating by
PageIterator, they are removed now.
D
LGTM too.
http://codereview.chromium.org/555073
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/555073
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, Kevin Millikin,
Description:
Merge r3610, r3611, r3612, r3630, r3636, r3640, and r3664
from bleeding_edge to trunk version 2.0.6.2.
Please review this at http://codereview.chromium.org/555073
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/arm/fa
Revision: 3684
Author: ant...@chromium.org
Date: Mon Jan 25 01:01:08 2010
Log: Bring a fix for v8 bug 589 and Chromium bug 27967 to 1.3.
Fixed on bleeding_edge in revision 3680.
Review URL: http://codereview.chromium.org/549132
http://code.google.com/p/v8/source/detail?r=3684
Modified:
/branch
http://codereview.chromium.org/546125/diff/4001/4003
File src/runtime.cc (right):
http://codereview.chromium.org/546125/diff/4001/4003#newcode7956
src/runtime.cc:7956: delete[] buffer;
An alternative (and widely used in V8) approach is to make 2 passes and
avoid re-allocation (or even avoid temp
Revision: 3683
Author: l...@chromium.org
Date: Mon Jan 25 00:55:08 2010
Log: Ported SubStringStub to X64.
Review URL: http://codereview.chromium.org/555049
http://code.google.com/p/v8/source/detail?r=3683
Modified:
/branches/bleeding_edge/src/x64/assembler-x64.cc
/branches/bleeding_edge/src/x6
http://codereview.chromium.org/555049/diff/1/4
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/555049/diff/1/4#newcode8185
src/x64/codegen-x64.cc:8185: if (!ascii) {
It's not really the size of short ints that matter, but the size of UC16
(or really, the size of characters in
LGTM
http://codereview.chromium.org/555049/diff/1/4
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/555049/diff/1/4#newcode8185
src/x64/codegen-x64.cc:8185: if (!ascii) {
ASSERT(kShortSize == 2);
http://codereview.chromium.org/555049/diff/1/4#newcode8197
src/x64/codegen-x64
Revision: 3682
Author: kasp...@chromium.org
Date: Mon Jan 25 00:28:39 2010
Log: Change the candidate version on bleeding_edge from 2.0.7 to
2.1.0. This means that the next version pushed to trunk will
be the first version in the 2.1.x series.
Review URL: http://codereview.chromium.org/551139
http:
LGTM
http://codereview.chromium.org/551139
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Change the candidate version on bleeding_edge from 2.0.7 to
2.1.0. This means that the next version pushed to trunk will
be the first version in the 2.1.x series.
Please review this at http://codereview.chromium.org/551139
SVN Base: http://v8.googlecode.com/sv
53 matches
Mail list logo
