LGTM
http://codereview.chromium.org/2824001/diff/1/2
File ChangeLog (right):
http://codereview.chromium.org/2824001/diff/1/2#newcode5
ChangeLog:5: Improved heap profiling support.
I don't think these changes are actually "available" yet. The API still
needs updating to expose them.
http://code
On 2010/06/14 07:13:31, Søren Gjesse wrote:
LGTM
http://codereview.chromium.org/2824001/diff/1/2
File ChangeLog (right):
http://codereview.chromium.org/2824001/diff/1/2#newcode5
ChangeLog:5: Improved heap profiling support.
I don't think these changes are actually "available" yet. The API s
Revision: 4850
Author: a...@chromium.org
Date: Mon Jun 14 00:27:25 2010
Log: Prepare push to trunk. We are now working on version 2.2.18.
Review URL: http://codereview.chromium.org/2824001
http://code.google.com/p/v8/source/detail?r=4850
Modified:
/branches/bleeding_edge/ChangeLog
/branches/bl
Reviewers: Søren Gjesse,
Description:
ARM: Be more smart about switching instructions when immediates
don't fit in the instruction. Use ubfx and sbfx more.
Please review this at http://codereview.chromium.org/2826001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected
I think you can already set these parameters through the API. That seems
like
the right way forward, rather than using build-time macros.
http://codereview.chromium.org/2737002/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 4852
Author: a...@chromium.org
Date: Mon Jun 14 00:37:06 2010
Log: Tag version 2.2.17.
http://code.google.com/p/v8/source/detail?r=4852
Added:
/tags/2.2.17
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/2772004/diff/5001/6001
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288
src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1); // Extract bit 2 of
r0 to bit 0 of r3.
On 2010/06/11 14:26:15, Lasse Reichstein wrote:
LGTM, with comments.
http://codereview.chromium.org/2826001/diff/1/2
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/2826001/diff/1/2#newcode660
src/arm/assembler-arm.cc:660: // If the opcode is one with a
complementary version and the complementary
Shouldn't we have some
Reviewers: Kasper Lund,
Description:
Only update the stub cache tables with monomorphic stubs used by
megamorphic call sites. This removes a lot of contention in the
tables.
Please review this at http://codereview.chromium.org/2813002/show
SVN Base: http://v8.googlecode.com/svn/branches/bleedi
Revision: 4853
Author: a...@chromium.org
Date: Mon Jun 14 03:10:42 2010
Log: Only update the stub cache tables with monomorphic stubs used by
megamorphic call sites. This removes a lot of contention in the
tables.
Review URL: http://codereview.chromium.org/2813002
http://code.google.com/p/v8/sour
LGTM!
http://codereview.chromium.org/2813002/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Erik Corry,
Description:
ARM: Change code generation for function return
Generating code for function return on ARM is now aligned with the other
platforms. The first non-shadowed return statement encountered will emit
code
for function return and all other returns including the fa
http://codereview.chromium.org/2772004/diff/5001/6001
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288
src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1); // Extract bit 2 of
r0 to bit 0 of r3.
On 2010/06/11 14:26:15, Lasse Reichstein wrote:
Revision: 4854
Author: whe...@chromium.org
Date: Mon Jun 14 03:21:24 2010
Log: Change tests for string type in RegExpExecStub on all platforms.
Review URL: http://codereview.chromium.org/2772004
http://code.google.com/p/v8/source/detail?r=4854
Modified:
/branches/bleeding_edge/src/arm/codegen-ar
Status: Accepted
Owner: sgje...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 737 by sgje...@chromium.org: Access to backing store of the
indexed properties managed by the embedding layer
http://code.google.com/p/v8/issues/detail?id=737
If an object is created with the backing store
LGTM!
http://codereview.chromium.org/2815003/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 4855
Author: erik.co...@gmail.com
Date: Mon Jun 14 04:20:36 2010
Log: ARM: Be more smart about switching instructions when immediates
don't fit in the instruction. Use ubfx and sbfx more.
Review URL: http://codereview.chromium.org/2826001
http://code.google.com/p/v8/source/detail?r=4855
Reviewers: Mads Ager,
Description:
Add support for elements and array indices in Object.defineProperty
(fixes bug 619).
This also fixes a bug in GetOwnProperty in runtime.cc discovered by
the new test cases. That part of the code was not testable before
since we had no way of correctly defining
Revision: 4856
Author: sgje...@chromium.org
Date: Mon Jun 14 04:37:05 2010
Log: ARM: Change code generation for function return
Generating code for function return on ARM is now aligned with the other
platforms. The first non-shadowed return statement encountered will emit
code for function r
Reviewers: Erik Corry,
Description:
Remove direct reference from builtins code to global object. Load the
global object through the context instead.
Please review this at http://codereview.chromium.org/2822003/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
LGTM
http://codereview.chromium.org/2832001/diff/4001/5002
File src/runtime.cc (right):
http://codereview.chromium.org/2832001/diff/4001/5002#newcode3873
src/runtime.cc:3873: // Check if this is an element.
Could we move this check earlier? We should only search for the property
as a named prop
LGTM!
http://codereview.chromium.org/2822003/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 4857
Author: a...@chromium.org
Date: Mon Jun 14 05:08:39 2010
Log: Remove direct reference from builtins code to global object. Load the
global object through the context instead.
Review URL: http://codereview.chromium.org/2822003
http://code.google.com/p/v8/source/detail?r=4857
Modifi
Reviewers: Mads Ager,
Description:
API: Added functions to retreive information on indexed properties managed
by
the embedding layer
BUG=737
TEST=test-api/PixelArrayInfo, test-api/ExternalArrayInfo
Please review this at http://codereview.chromium.org/2818003/show
SVN Base: http://v8.googlec
LGTM
http://codereview.chromium.org/2818003/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Fix build by fixing a typo in codegen-x64.cc.
tbr=whe...@chromium.org
Please review this at http://codereview.chromium.org/2824002/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/codegen-x64.cc
Index:
Revision: 4858
Author: a...@chromium.org
Date: Mon Jun 14 05:43:00 2010
Log: Fix build by fixing a typo in codegen-x64.cc.
tbr=whe...@chromium.org
Review URL: http://codereview.chromium.org/2824002
http://code.google.com/p/v8/source/detail?r=4858
Modified:
/branches/bleeding_edge/src/x64/codege
Reviewers: Erik Corry,
Description:
Another x64 build fix. Actually builds now.
KExponentBits -> kExponentBits.
tbr=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/2835001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M s
Revision: 4859
Author: a...@chromium.org
Date: Mon Jun 14 05:55:37 2010
Log: Another x64 build fix. Actually builds now.
KExponentBits -> kExponentBits.
tbr=erik.co...@gmail.com
Review URL: http://codereview.chromium.org/2835001
http://code.google.com/p/v8/source/detail?r=4859
Modified:
/bran
Revision: 4860
Author: sgje...@chromium.org
Date: Mon Jun 14 06:09:27 2010
Log: API: Added functions to retreive information on indexed properties
managed by the embedding layer
BUG=737
TEST=test-api/PixelArrayInfo, test-api/ExternalArrayInfo
Review URL: http://codereview.chromium.org/2818003
Updates:
Status: Fixed
Labels: -Type-Bug Type-FeatureRequest
Comment #1 on issue 737 by sgje...@chromium.org: Access to backing store of
the indexed properties managed by the embedding layer
http://code.google.com/p/v8/issues/detail?id=737
Added the following API methode to v8
Reviewers: Mads Ager,
Description:
Fix Mac build of r4860
Build error:
test/cctest/test-api.cc: In function 'void
ExternalArrayInfoTestHelper(v8::ExternalArrayType)':
test/cctest/test-api.cc:10069: warning: control may reach end of non-void
function 'int ExternalArrayElementSize(v8::ExternalArra
Revision: 4861
Author: sgje...@chromium.org
Date: Mon Jun 14 06:19:16 2010
Log: Fix Mac build of r4860
Build error:
test/cctest/test-api.cc: In function 'void
ExternalArrayInfoTestHelper(v8::ExternalArrayType)':
test/cctest/test-api.cc:10069: warning: control may reach end of non-void
functio
LGTM
http://codereview.chromium.org/2826002/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/2824002/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #1 on issue 619 by ri...@chromium.org: Object.defineProperty does
not behave correctly when trying to define properties on elements.
http://code.google.com/p/v8/issues/detail?id=619
This issue was closed by revision r4862.
--
v8-dev mailing list
v8-dev@
http://codereview.chromium.org/2832001/diff/4001/5002
File src/runtime.cc (right):
http://codereview.chromium.org/2832001/diff/4001/5002#newcode3873
src/runtime.cc:3873: // Check if this is an element.
On 2010/06/14 11:57:41, Mads Ager wrote:
Could we move this check earlier? We should only sea
Revision: 4862
Author: ri...@chromium.org
Date: Mon Jun 14 06:55:38 2010
Log: Add support for elements and array indices in Object.defineProperty
(fixes bug 619).
This also fixes a bug in GetOwnProperty in runtime.cc discovered by
the new test cases. That part of the code was not testable before
Reviewers: Erik Corry,
Description:
Add external references used for regexp execution to the serializer.
Please review this at http://codereview.chromium.org/2838001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/serialize.cc
M test/cctes
Reviewers: Vitaly, Dmitry Titov,
Message:
factory.cc will go away in a future CL; I've left it in for now to make
diffs
easier to read. This list touches a lot of files, but does so in a very
systematic way (usually Factory::foo => HEAP->foo or Factory::foo =>
HEAP->foo_handle).
http://code
lgtm
http://codereview.chromium.org/2838001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/2838001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
Thanks for fixing.
http://codereview.chromium.org/2835001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 4863
Author: a...@chromium.org
Date: Mon Jun 14 14:03:59 2010
Log: Add external references used for regexp execution to the serializer.
Review URL: http://codereview.chromium.org/2838001
http://code.google.com/p/v8/source/detail?r=4863
Modified:
/branches/bleeding_edge/src/serialize.c
http://codereview.chromium.org/2826001/diff/1/2
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/2826001/diff/1/2#newcode660
src/arm/assembler-arm.cc:660: // If the opcode is one with a
complementary version and the complementary
On 2010/06/14 07:56:47, Søren Gjesse wrote:
Reviewers: Vitaly, Dmitry Titov,
Message:
I wonder why assembler-arm's GrowBuffer doesn't worry about the spare buffer
like -x64 and -ia32do.
Description:
[Isolates] Remove statics from assembler-*.cc.
- Moved statics from CpuFeatures to Isolate.
- Moved a static buffer from the various Assembl
It might be helpful to look for static data by dumping symbol tables:
objdump --demangle -t obj/debug/ia32/assembler-ia32.o | grep
'\.bss\|\.data\|\.rodata'
ld .data .data
ld .bss .bss
ld .rodata .rodata
0ae8 l O .rodata
47 matches
Mail list logo
