LGTM
http://codereview.chromium.org/3041050/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM if you bring it back.
http://codereview.chromium.org/3027043/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Patch 5: Exposed the Executable memory usage through GetHeapStatistics API
and
changed Naming "RWX" -> "Executable"
On 2010/08/06 00:52:15, Valoo wrote:
Patch Set 4: capacity_rwx_ is now controlled through the
SetResuourceConstraints
API and defaults to the same value as Heap::MaxReserved() (
Patch Set 4: capacity_rwx_ is now controlled through the
SetResuourceConstraints
API and defaults to the same value as Heap::MaxReserved() (which essentially
disables the feature until the optimal value is determined)
Patch Set 3: fixes the bool -> Executability problem with patch 2
On 2010/08
Status: New
Owner:
New issue 813 by pi...@chromium.org: ASSERT on ARM in Debug:
CHECK(known_smi_map < (1u << count)) failed
http://code.google.com/p/v8/issues/detail?id=813
This happens in the embedded v8 inside of o3d on ARM.
Here's the log dump:
#
# Fatal error in v8/src/arm/virtual-
I think I've addressed Vitaly's comments, it is ready for another look.
1. The heap pointer is now sharing the field with scavenge callback pointer
in
meta map (since meta map always has it NULL). So there is no special meta
map
layout and no increase in map size. The special
has_heap_in_sc
Hi,
Need a little help to submit code for review, but I'm getting an error
on 'gcl upload mychange' Here the steps:
- gcl change mychange
- gcl upload mychange. Enterring my gmail credentials
...
urllib2.URLError:
Do I need to use diff server instead of codereview.chrominum.org ?
Thanks
Vlad
-
/noons/nouns/
http://codereview.chromium.org/3089005/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
http://codereview.chromium.org/3030048/diff/1/3
File src/spaces.cc (right):
http://codereview.chromium.org/3030048/diff/1/3#newcode299
src/spaces.cc:299: capacity_rwx_ = RoundUp(capacity, Page::kPageSize);
Will control through the API and expose through GetHeapStatistic
On 2010/08/05 21:04:23, zarko wrote:
http://codereview.chromium.org/3089005/diff/4001/5003
File src/isolate.h (right):
http://codereview.chromium.org/3089005/diff/4001/5003#newcode1028
src/isolate.h:1028: #define GET_ISOLATE(heap_pointer) ((Isolate*)( \
Would it be better to call this somethi
http://codereview.chromium.org/3089005/diff/4001/5003
File src/isolate.h (right):
http://codereview.chromium.org/3089005/diff/4001/5003#newcode1028
src/isolate.h:1028: #define GET_ISOLATE(heap_pointer) ((Isolate*)( \
Would it be better to call this something like HEAP_ISOLATE()?
http://coderev
Revision: 5191
Author: lukeza...@gmail.com
Date: Thu Aug 5 13:38:56 2010
Log: [Isolates] Avoid dereferencing Isolate::Current() to check oddball
identities.
- Added a kind field and accessors to JS Oddball objects.
- IsTrue/IsFalse/IsBoolean/IsTheHole/IsNull/IsUndefined now look like
[IsOdd
http://codereview.chromium.org/3031005/diff/52001/53001
File src/accessors.cc (right):
http://codereview.chromium.org/3031005/diff/52001/53001#newcode44
src/accessors.cc:44: if (obj == heap->null_value()) return NULL;
On 2010/08/02 12:49:47, Vitaly wrote:
Here and in lots of other places you're
Fixing the wrong indent -- sorry.
http://codereview.chromium.org/3056049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Object.seal(obj) and Object.freeze(obj) should return the input obj.
BUG=http://code.google.com/p/v8/issues/detail?id=809
TEST=Seal/freeze an object and check if Object.seal and Object.freeze
returns
the given object.
Please review this at http://codere
http://codereview.chromium.org/2883042/diff/1/5
File src/full-codegen.cc (right):
http://codereview.chromium.org/2883042/diff/1/5#newcode773
src/full-codegen.cc:773: CodeGenerator::RecordPositions(masm_,
fun->end_position() - 1);
Theoretically, you may consider creating a named constant for this
global.print throws an error in node.js and should be removed.
http://codereview.chromium.org/3046010/diff/6006/24003
File src/v8natives.js (right):
http://codereview.chromium.org/3046010/diff/6006/24003#newcode1115
src/v8natives.js:1115: global.print(argc_bound);
Looks like this line should be
I'm sorry for those long lines, I got used to check them on web page, but
the
limit was reset to 100 characters.
http://codereview.chromium.org/3029033/diff/8001/9003
File src/debug.cc (right):
http://codereview.chromium.org/3029033/diff/8001/9003#newcode1304
src/debug.cc:1304: // to function
Reviewers: Søren Gjesse,
Message:
tbr=sgje...@chromium.org
Description:
Fix failing tests and rollback two from Testing change for failing unit test
Committed: http://code.google.com/p/v8/source/detail?r=5153
Please review this at http://codereview.chromium.org/3052026/show
Affected files:
Mads,
I guess Soren may have returned from his vacation.
Do you think it's better to pass this CL to him?
p.s. Hi Soren! :)
Peter
http://codereview.chromium.org/3029033/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Message:
tbr=sgje...@chromium.org
Description:
Rollback one from Testing change for failing unit test
Please review this at http://codereview.chromium.org/2870083/show
Affected files:
M src/ia32/debug-ia32.cc
Index: src/ia32/debug-ia32.cc
diff --git a/src/ia32/debu
Reviewers: Søren Gjesse,
Message:
Hi Soren
This is a regular non-TBR change.
It's absolutely the same with unsuccessful
http://codereview.chromium.org/3029033 except for serialize.cc file.
There I added missing reference description and also an assert that should
help
not to make such mist
Reviewers: Søren Gjesse,
Message:
tbr=sgje...@chromium.org
Hi Soren
I'm sorry for so many TBR changes. Initially I committed the change that
failed
the tests.
Since I couldn't reproduce them locally I made couple of tentative changes
in
repository, hoping that it didn't bother anyone.
I f
Reviewers: Søren Gjesse,
Message:
tbr=sgje...@chromium.org
Description:
Testing change for failing unit test
Please review this at http://codereview.chromium.org/3031032/show
Affected files:
M src/debug.cc
M src/ia32/debug-ia32.cc
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug
Reviewers: Mads Ager,
Message:
Hi Mads
It's stack manipulations again. This time I think it should be more modest
change.
Peter
Description:
Fix 'step in' after live edit stack manipulation
Please review this at http://codereview.chromium.org/3029033/show
Affected files:
M src/arm/debug-ar
Does using -fno-tree-sink avoid the problem even without this patch?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41354
Den 5. aug. 2010 14.36 skrev :
> Revision: 5179
> Author: sgje...@chromium.org
> Date: Thu Aug 5 05:34:53 2010
> Log: Fix GCC 4.4.4 build
>
> Force a number functions to not inl
Revision: 5190
Author: ant...@chromium.org
Date: Thu Aug 5 11:35:53 2010
Log: Backport http://code.google.com/p/v8/source/detail?r=5181 to 2.2.
tbr=vego...@chromium.org
Review URL: http://codereview.chromium.org/3089008
http://code.google.com/p/v8/source/detail?r=5190
Modified:
/branches/2.2/
Reviewers: Vyacheslav Egorov,
Message:
Slava,
TBRed to you.
I've bumped patch level from 9 to 11 as I forgot to do that for my previous
commit to 2.2 branch.
Description:
Backport http://code.google.com/p/v8/source/detail?r=5181 to 2.2.
tbr=vego...@chromium.org
Please review this at http://
Revision: 5189
Author: ant...@chromium.org
Date: Thu Aug 5 11:23:43 2010
Log: Backport http://code.google.com/p/v8/source/detail?r=5188 to 2.2.
Review URL: http://codereview.chromium.org/3034058
http://code.google.com/p/v8/source/detail?r=5189
Modified:
/branches/2.2/src/objects.cc
==
LGTM
http://codereview.chromium.org/3034058/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly,
Message:
May you have a look, Vitaly?
Description:
Backport http://code.google.com/p/v8/source/detail?r=5188 to 2.2.
Please review this at http://codereview.chromium.org/3034058/show
SVN Base: http://v8.googlecode.com/svn/branches/2.2/
Affected files:
M src/objects.c
Revision: 5188
Author: ant...@chromium.org
Date: Thu Aug 5 11:12:39 2010
Log: Check ASCIIness of lhs, not this.
In one pathalogical case it's possible to have
this->IsAsciiRepresentation() &&
!this->TryFlattenGetString()->IsAsciiRepresentation()---if cons string has
two byte
string which hol
It did exactly that when I ran gmail in debug build.
I was too lazy to add the test, but you've spotted that :) Let me
quickly play with it.
yours,
anton.
On Thu, Aug 5, 2010 at 8:31 PM, wrote:
> LGTM!
>
> Can we add a test for this? It should hit an assert in String::ToAsciiVector
> in
> the
LGTM
http://codereview.chromium.org/3030049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM!
Can we add a test for this? It should hit an assert in
String::ToAsciiVector in
the case you describe.
Thanks,
Vitaly
http://codereview.chromium.org/3036046/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, but...
I'd keep asserts reducing their scope.
http://codereview.chromium.org/3030049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly,
Message:
Vitaly,
may you have a look?
Description:
Check ASCIIness of lhs, not this.
In one pathalogical case it's possible to have
this->IsAsciiRepresentation() &&
!this->TryFlattenGetString()->IsAsciiRepresentation()---if cons string has
two
byte
string which holds on
Reviewers: Vyacheslav Egorov, Vitaly, antonm,
Description:
Reapplying r5174 (Avoid GC when compiling CallIC stubs).
I could not find a way to introduce simple yet useful assertions,
so I removed the assertions that broke tests.
The new patch just fixes the actual problem (GC triggered while raw
Revision: 5187
Author: sgje...@chromium.org
Date: Thu Aug 5 08:54:42 2010
Log: Tagging version 2.3.5.2
http://code.google.com/p/v8/source/detail?r=5187
Added:
/tags/2.3.5.2
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5186
Author: sgje...@chromium.org
Date: Thu Aug 5 08:54:25 2010
Log: Merge r5179 (Fix GCC 4.4.4 build) to trunk
Review URL: http://codereview.chromium.org/2856089
http://code.google.com/p/v8/source/detail?r=5186
Modified:
/trunk/src/globals.h
/trunk/src/heap.h
/trunk/src/version.cc
LGTM
http://codereview.chromium.org/2856089/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Description:
Merge r5179 (Fix GCC 4.4.4 build) to trunk
Please review this at http://codereview.chromium.org/2856089/show
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/globals.h
M src/heap.h
M src/version.cc
Index: src/glo
http://codereview.chromium.org/3030048/diff/1/3
File src/spaces.cc (right):
http://codereview.chromium.org/3030048/diff/1/3#newcode299
src/spaces.cc:299: capacity_rwx_ = RoundUp(capacity, Page::kPageSize);
capacity_rwx_ = capacity_ to indicate that for now they are the same.
Also I think this s
Revision: 5185
Author: vego...@chromium.org
Date: Thu Aug 5 08:01:05 2010
Log: Landing r5180 and r5178 from bleeding_edge to 2.2 branch.
Fix handling of DEBUG_BREAK_SLOT and JS_RETURN relocations across platforms:
- on ia32 add DEBUG_BREAK_SLOT to RelocInfo::kApplyMask
- on x64 remove JS_RETURN
Revision: 5184
Author: sgje...@chromium.org
Date: Thu Aug 5 07:58:51 2010
Log: Tagging version 2.3.5.1
http://code.google.com/p/v8/source/detail?r=5184
Added:
/tags/2.3.5.1
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5183
Author: sgje...@chromium.org
Date: Thu Aug 5 07:53:39 2010
Log: Merge r5182 (Revert support for ES5's propertyname production) to trunk
tbr=...@chromium.org
Review URL: http://codereview.chromium.org/3041050
http://code.google.com/p/v8/source/detail?r=5183
Modified:
/trunk/src/p
Reviewers: Lasse Reichstein,
Description:
Merge r5182 (Revert support for ES5's propertyname production) to trunk
tbr=...@chromium.org
Please review this at http://codereview.chromium.org/3041050/show
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/parser.cc
M
Revision: 5182
Author: sgje...@chromium.org
Date: Thu Aug 5 07:46:34 2010
Log: Revert r5165 (Added support for ES5's propertyname production)
This is to test in Chromium without this change.
tbr=...@chromium.org
Review URL: http://codereview.chromium.org/3027043
http://code.google.com/p/v8/sour
Reviewers: Lasse Reichstein,
Description:
Revert r5165 (Added support for ES5's propertyname production)
This is to test in Chromium without this change.
tbr=...@chromium.org
Please review this at http://codereview.chromium.org/3027043/show
SVN Base: http://v8.googlecode.com/svn/branches/blee
LGTM
http://codereview.chromium.org/3064041/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5181
Author: ant...@chromium.org
Date: Thu Aug 5 07:12:50 2010
Log: Add information about memory allocator's size and capacity and heap
snapshot into heap stats.
That might help us debug OOM crashes in V8.
Review URL: http://codereview.chromium.org/3046049
http://code.google.com/p/
Reviewers: Søren Gjesse,
Description:
Landing r5180 and r5178 from bleeding_edge.
Fix handling of DEBUG_BREAK_SLOT and JS_RETURN relocations across platforms:
- on ia32 add DEBUG_BREAK_SLOT to RelocInfo::kApplyMask
- on x64 remove JS_RETURN from RelocInfo::kApply mask
Please review this at htt
Revision: 5180
Author: vego...@chromium.org
Date: Thu Aug 5 06:38:27 2010
Log: Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64.
Improve tests for debug API to check behavior of JS_RETURN and
DEBUG_BREAK_SLOT relocations.
Review URL: http://codereview.chromium.org/3058049
http:
Comment #8 on issue 222 by michaelj...@gmail.com: Arguments object is
copied on each access using Function.arguments.
http://code.google.com/p/v8/issues/detail?id=222
So did the code below work because it makes a reference to arguments before
accessing the arguments property?
function a()
LGTM
http://codereview.chromium.org/3058049/diff/10001/11006
File test/cctest/test-debug.cc (right):
http://codereview.chromium.org/3058049/diff/10001/11006#newcode1301
test/cctest/test-debug.cc:1301: foo = CompileFunction(&env, "function
bar(){};function foo(){bar();}", "foo");
Long line.
htt
Thanks a lot for review, Slava, and for all suggestions.
http://codereview.chromium.org/3046049/diff/5/6003
File src/heap.cc (right):
http://codereview.chromium.org/3046049/diff/5/6003#newcode4135
src/heap.cc:4135: // so snapshot won't be precise.
On 2010/08/05 12:58:09, Vyacheslav Egorov wrote
Comment #7 on issue 222 by kmilli...@chromium.org: Arguments object is
copied on each access using Function.arguments.
http://code.google.com/p/v8/issues/detail?id=222
This issue is not fixed, and it is the same underlying issue as issue 701.
function f() { return f.arguments === f.arguments
LGTM
http://codereview.chromium.org/3058049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64.
Improve tests for debug API to check behavior of JS_RETURN and
DEBUG_BREAK_SLOT
relocations.
Please review this at http://codereview.chromium.org/3058049/show
Affected files:
M src/arm/as
Comment #6 on issue 222 by michaelj...@gmail.com: Arguments object is
copied on each access using Function.arguments.
http://code.google.com/p/v8/issues/detail?id=222
This issue appears to have been fixed for 3 months now. Issue 701, however,
which never should have been merged into this on
LGTM
http://codereview.chromium.org/3046049/diff/5/6003
File src/heap.cc (right):
http://codereview.chromium.org/3046049/diff/5/6003#newcode4135
src/heap.cc:4135: // so snapshot won't be precise.
Maybe something like this:
// Note: snapshot won't be precise because IsFreeListNode returns true
Reviewers: Søren Gjesse,
Description:
Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64.
Please review this at http://codereview.chromium.org/2884066/show
Affected files:
M src/ia32/assembler-ia32.cc
M src/x64/assembler-x64-inl.h
M src/x64/assembler-x64.cc
M test/cctest/tes
Updates:
Status: Fixed
Comment #3 on issue 809 by sgje...@chromium.org: Object.seal(obj) and
Object.freeze(obj) return undefined instead of obj
http://code.google.com/p/v8/issues/detail?id=809
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Comment #2 on issue 809 by burcujdogan: Object.seal(obj) and
Object.freeze(obj) return undefined instead of obj
http://code.google.com/p/v8/issues/detail?id=809
This should have fixed by r5176.
http://code.google.com/p/v8/source/detail?r=5176
--
v8-dev mailing list
v8-dev@googlegroups.com
Revision: 5179
Author: sgje...@chromium.org
Date: Thu Aug 5 05:34:53 2010
Log: Fix GCC 4.4.4 build
Force a number functions to not inline in order th work around a bug in GCC
4.4.4.
See http://codereview.chromium.org/3083016 for more info.
Review URL: http://codereview.chromium.org/3034056
h
On 2010/08/04 21:37:52, Evan Martin wrote:
Decided on the __attribute__((noinline)), see
http://codereview.chromium.org/3034056
Closing issue.
http://codereview.chromium.org/3083016/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
IA32: Avoid going into stubs or runtime code for bitops even if the
inputs are heap numbers or the result is a heap number (only with
SSE2). Make it possible for a deferred code object to work without
spilling all registers.
Please review this at http:/
I checked GCC manual for 3.x versions and can confirm that noinline is
mentioned
in docs starting from 3.1.
So I think we can use it.
LGTM.
http://codereview.chromium.org/3034056/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Message:
This has not been tested with GCC 3, so I am not sure the NO_INLINE macro
will
work there. Maybe do the same for GCC 3 as for MSVC?
Description:
Fix GCC 4.4.4 build
Force a number functions to not inline in order th work around a bug in GCC
4.4.4.
See
Revision: 5178
Author: vego...@chromium.org
Date: Thu Aug 5 04:39:01 2010
Log: Add RelocInfo::DEBUG_BREAK_SLOT to RelocInfo::kApplyMask on ia32/x64
to ensure that debug break slots get relocated correctly during compacting
GC.
Review URL: http://codereview.chromium.org/3058048
http://code.g
LGTM!
http://codereview.chromium.org/3058048/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Add RelocInfo::DEBUG_BREAK_SLOT to RelocInfo::kApplyMask on ia32/x64.
Add RelocInfo::DEBUG_BREAK_SLOT to RelocInfo::kApplyMask on ia32/x64 to
ensure
that debug break slots get relocated correctly during GC.
Please review this at http://codereview.chromiu
Revision: 5177
Author: vego...@chromium.org
Date: Thu Aug 5 04:19:43 2010
Log: Revert r5174.
Review URL: http://codereview.chromium.org/2868108
http://code.google.com/p/v8/source/detail?r=5177
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
/branches/bleeding_edge/src/heap-inl.h
/
LGTM with a rubberstamp.
http://codereview.chromium.org/2868108/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Revert r5174.
Please review this at http://codereview.chromium.org/2868108/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/stub-cache-arm.cc
M src/heap-inl.h
M src/heap.h
M src/heap.cc
On 2010/08/05 10:54:16, Søren Gjesse wrote:
LGTM
I will go ahead and commit ti.
Committed: http://code.google.com/p/v8/source/detail?r=5176, closing issue.
Thanks for the patch!
http://codereview.chromium.org/3056049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google
Revision: 5176
Author: sgje...@chromium.org
Date: Thu Aug 5 03:56:15 2010
Log: Object.seal(obj) and Object.freeze(obj) should return the input obj.
BUG=http://code.google.com/p/v8/issues/detail?id=809
TEST=Seal/freeze an object and check if Object.seal and Object.freeze
returns the given objec
LGTM
I will go ahead and commit ti.
http://codereview.chromium.org/3056049/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5175
Author: whe...@chromium.org
Date: Thu Aug 5 03:45:07 2010
Log: Modify polymorphic keyed load IC stub to load cached properties from
the property array of a fast-case JSObject.
Review URL: http://codereview.chromium.org/3053042
http://code.google.com/p/v8/source/detail?r=5175
Mo
http://codereview.chromium.org/3053042/diff/5001/6001
File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/3053042/diff/5001/6001#newcode1206
src/arm/ic-arm.cc:1206: __ cmp(r5, r6);
On 2010/08/05 10:32:05, Erik Corry wrote:
This could be a sub with SetCC.
Done.
http://codereview.ch
LGTM
http://codereview.chromium.org/3053042/diff/5001/6001
File src/arm/ic-arm.cc (right):
http://codereview.chromium.org/3053042/diff/5001/6001#newcode1206
src/arm/ic-arm.cc:1206: __ cmp(r5, r6);
This could be a sub with SetCC.
http://codereview.chromium.org/3053042/show
--
v8-dev mailing li
Reviewers: Vyacheslav Egorov,
Message:
Slava,
may you have a look?
Description:
Add information about memory allocator's size and capacity and heap snapshot
into heap stats.
That might help us debug OOM crashes in V8.
Please review this at http://codereview.chromium.org/3046049/show
Affected
Revision: 5174
Author: kaznach...@chromium.org
Date: Thu Aug 5 01:37:12 2010
Log: Avoid GC when compiling CallIC stubs.
In rare cases GC could be called from ComputeCallMiss function thus
breaking CallIC::LoadFunction.
Review URL: http://codereview.chromium.org/3047027
http://code.google.com/p/
http://codereview.chromium.org/3047027/diff/16001/17003
File src/heap.cc (right):
http://codereview.chromium.org/3047027/diff/16001/17003#newcode328
src/heap.cc:328: ASSERT(gc_allowed_);
On 2010/08/04 14:39:37, antonm wrote:
On 2010/08/04 14:29:20, Vladislav Kaznacheev wrote:
> Cannot see much
Agree. Done.
On 2010/08/04 14:45:37, Vitaly wrote:
LGTM
I think now all calls to UpdateCaches are protected by AssertNoGC, so
having
AssertNoGC is UpdateCaches is unnecessary. Since UpdateCaches gets the
lookup
object from the calling function it's the responsibility of the caller to
prote
Comment #5 on issue 222 by kmilli...@chromium.org: Arguments object is
copied on each access using Function.arguments.
http://code.google.com/p/v8/issues/detail?id=222
The second issue is
http://code.google.com/p/chromium/issues/detail?id=36328 but we should
probably file a separate V8 bu
Comment #4 on issue 222 by lasserei...@gmail.com: Arguments object is
copied on each access using Function.arguments.
http://code.google.com/p/v8/issues/detail?id=222
That is a separate concern.
This issue refers to the "arguments" property of function objects (where
there is no specificati
http://codereview.chromium.org/3056049/diff/1/3
File src/v8natives.js (right):
http://codereview.chromium.org/3056049/diff/1/3#newcode49
src/v8natives.js:49: function InstallFunctions(object, attributes,
functions) {
I think you accidentally formatted all the JavaScript in this file with
tabs in
88 matches
Mail list logo
