Revision: 5221
Author: l...@chromium.org
Date: Tue Aug 10 00:00:34 2010
Log: Tagging version 2.3.6
http://code.google.com/p/v8/source/detail?r=5221
Added:
/tags/2.3.6
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5222
Author: l...@chromium.org
Date: Tue Aug 10 00:04:06 2010
Log: Removing another bad tagging. Next time will be better.
http://code.google.com/p/v8/source/detail?r=5222
Deleted:
/tags/2.3.6
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5223
Author: l...@chromium.org
Date: Tue Aug 10 00:07:14 2010
Log: Tagging version 2.3.6
http://code.google.com/p/v8/source/detail?r=5223
Added:
/tags/2.3.6
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5224
Author: mikhail.naga...@gmail.com
Date: Tue Aug 10 00:30:14 2010
Log: Heap profiler: Add static assertions for heap snapshot entities' sizes.
Review URL: http://codereview.chromium.org/2808112
http://code.google.com/p/v8/source/detail?r=5224
Modified:
/branches/bleeding_edge/src/
Updates:
Status: Fixed
Comment #2 on issue 783 by mikhail.naganov: The new implementation of heap
profiler produces very large snapshots
http://code.google.com/p/v8/issues/detail?id=783
Fixed in http://code.google.com/p/v8/source/detail?r=5211
Heap snapshots are now smaller than heap
Revision: 5225
Author: mikhail.naga...@gmail.com
Date: Tue Aug 10 00:37:59 2010
Log: Fix lint issue.
http://code.google.com/p/v8/source/detail?r=5225
Modified:
/branches/bleeding_edge/src/profile-generator.cc
===
--- /branches/bleeding_edge/src/profile-genera
LGTM if it works.
http://codereview.chromium.org/3082012/diff/1/2
File src/messages.js (right):
http://codereview.chromium.org/3082012/diff/1/2#newcode712
src/messages.js:712: this.receiver.__lookupSetter__(ownName) ===
this.fun ||
Is __lookup[GS]etter__ safe to use, or can it be changed by the
LGTM
http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):
http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if
property exists and false
The result is true if either boolean ...
->
The result is eith
Reviewers: Søren Gjesse,
Description:
Fix CPU profiler crash in start / stop sequence when non-existent name is
passed
BUG=51594
TEST=test-cpu-profiler/CrashIfStoppingLastNonExistentProfile
Please review this at http://codereview.chromium.org/3108004/show
Affected files:
M src/cpu-profile
http://codereview.chromium.org/3030048/diff/46001/47006
File src/spaces.cc (right):
http://codereview.chromium.org/3030048/diff/46001/47006#newcode2620
src/spaces.cc:2620: page->SetIsPageExecutable(false);
Without patch from 810 this looks a bit dirty. Flags should not affect
chunk size.
I thin
Reviewers: Mads Ager,
Description:
Enable static assertions in release mode.
Please review this at http://codereview.chromium.org/3146004/show
Affected files:
M src/checks.h
Index: src/checks.h
diff --git a/src/checks.h b/src/checks.h
index
13374d86dda4994474598dec85a232b70fdb483d..5ea599
LGTM
http://codereview.chromium.org/3146004/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5226
Author: mikhail.naga...@gmail.com
Date: Tue Aug 10 02:22:49 2010
Log: Enable static assertions in release mode.
Review URL: http://codereview.chromium.org/3146004
http://code.google.com/p/v8/source/detail?r=5226
Modified:
/branches/bleeding_edge/src/checks.h
LGTM, thanks!
http://codereview.chromium.org/3010060/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3015066/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3015066/diff/1/2#newcode4267
src/arm/codegen-arm.cc:4267: //frame_->EmitPop(r0); // r0 contains
value
Commented code
http://codereview.chromium.org/3015066/show
--
v8-dev
Revision: 5227
Author: ant...@chromium.org
Date: Tue Aug 10 02:53:56 2010
Log: Add v8::Value::IsRegExp method.
Patch by Vlad Burlik.
Review URL: http://codereview.chromium.org/3064051
http://code.google.com/p/v8/source/detail?r=5227
Modified:
/branches/bleeding_edge/AUTHORS
/branches/bleeding
Thanks a lot for review, Mads.
Landing.
yours,
anton.
On Tue, Aug 10, 2010 at 10:45 AM, wrote:
> LGTM
>
> http://codereview.chromium.org/3064051/show
>
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
>
--
v8-dev mailing list
v8-dev@googlegroups.co
Thanks a lot for review, Mads. Submitting.
http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):
http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if
property exists and false
On 2010/08/10 08:47:49,
Thanks a lot for review, Mads. Submitting.
http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):
http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if
property exists and false
On 2010/08/10 08:47:49,
Revision: 5228
Author: ant...@chromium.org
Date: Tue Aug 10 03:05:18 2010
Log: First phase of migration to new indexed property query callbacks.
Eventually indexed property query callbacks will return attributes
(as an integer) or an empty handle if property is not intercepted.
To gradually migr
Comment #2 on issue 816 by ant...@chromium.org: Allow indexed property
queries return property attributes
http://code.google.com/p/v8/issues/detail?id=816
http://code.google.com/p/v8/source/detail?r=5228 is first part of solution.
After that is being pushed to v8's trunk, I'll submit another
Comment #5 on issue 180 by travispuk: toLocaleDateString and
toLocaleTimeString do not honor the current locale
http://code.google.com/p/v8/issues/detail?id=180
When is this issue likely to be resolved?
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5229
Author: sgje...@chromium.org
Date: Tue Aug 10 04:52:18 2010
Log: Remove a couple of spill scopes
Review URL: http://codereview.chromium.org/3015066
http://code.google.com/p/v8/source/detail?r=5229
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.cc
==
LGTM
http://codereview.chromium.org/3108004/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5230
Author: mikhail.naga...@gmail.com
Date: Tue Aug 10 05:06:42 2010
Log: Fix CPU profiler crash in start / stop sequence when non-existent name
is passed
BUG=51594
TEST=test-cpu-profiler/CrashIfStoppingLastNonExistentProfile
Review URL: http://codereview.chromium.org/3108004
http:
Reviewers: Mads Ager,
Description:
Fix fuzzer-found error where left and right were the same register in
bitops.
Please review this at http://codereview.chromium.org/3115004/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/codegen-ia32.cc
Reviewers: Søren Gjesse,
Description:
Removed support for object literal get/set with number/string property name.
It doesn't work correctly for array indices.
Please review this at http://codereview.chromium.org/3109002/show
Affected files:
M src/parser.cc
M src/runtime.cc
M test/mjsunit
Drive by comment.
http://codereview.chromium.org/3115004/diff/1/4
File test/mjsunit/regress/bitops-register-alias.js (right):
http://codereview.chromium.org/3115004/diff/1/4#newcode28
test/mjsunit/regress/bitops-register-alias.js:28: // Whenever we enter a
with-scope, we copy the context. This
http://codereview.chromium.org/3115004/diff/1/4
File test/mjsunit/regress/bitops-register-alias.js (right):
http://codereview.chromium.org/3115004/diff/1/4#newcode28
test/mjsunit/regress/bitops-register-alias.js:28: // Whenever we enter a
with-scope, we copy the context. This in itself is fine
O
LGTM when test comment has been fixed.
http://codereview.chromium.org/3115004/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, except for the part about using vi. ;)
http://codereview.chromium.org/3115004/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5231
Author: erik.co...@gmail.com
Date: Tue Aug 10 05:30:14 2010
Log: Fix fuzzer-found error where left and right were the same register in
bitops.
Review URL: http://codereview.chromium.org/3115004
http://code.google.com/p/v8/source/detail?r=5231
Added:
/branches/bleeding_edge/test
http://codereview.chromium.org/3015066/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3015066/diff/1/2#newcode4267
src/arm/codegen-arm.cc:4267: //frame_->EmitPop(r0); // r0 contains
value
On 2010/08/10 09:35:30, Erik Corry wrote:
Commented code
Done.
http://cod
LGTM
http://codereview.chromium.org/3109002/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/3109002/diff/1/2#newcode3590
src/parser.cc:3590: // TODO(lrn): Allow NUMBER and STRING as well (and
handle array indices).
TODO(issue number)
http://codereview.chromium.org/3109002/s
Status: Accepted
Owner: lasserei...@gmail.com
Labels: Type-Bug Priority-Medium
New issue 819 by lasserei...@gmail.com: Allow number and string literals as
property names of literal get/set properties.
http://code.google.com/p/v8/issues/detail?id=819
Detailed description of the issue.
--
v8-
Updates:
Status: Invalid
Labels: -Type-Bug Type-FeatureRequest
Comment #1 on issue 819 by lasserei...@gmail.com: Allow number and string
literals as property names of literal get/set properties.
http://code.google.com/p/v8/issues/detail?id=819
Once more, next time with descrip
http://codereview.chromium.org/3109002/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/3109002/diff/1/2#newcode3590
src/parser.cc:3590: // TODO(lrn): Allow NUMBER and STRING as well (and
handle array indices).
Done.
http://codereview.chromium.org/3109002/show
--
v8-dev mail
Status: Accepted
Owner: lasserei...@gmail.com
Labels: Type-FeatureRequest Priority-Medium ES5
New issue 820 by lasserei...@gmail.com: Allow number and string literals as
property names of literal get/set properties.
http://code.google.com/p/v8/issues/detail?id=820
ES5 requires the object lite
Revision: 5232
Author: l...@chromium.org
Date: Tue Aug 10 05:44:13 2010
Log: Removed support for object literal get/set with number/string property
name.
It doesn't work correctly for array indices.
Review URL: http://codereview.chromium.org/3109002
http://code.google.com/p/v8/source/detail?r=
Reviewers: Mads Ager, antonm,
Description:
Copy-on-write arrays.
Object model changes
New fixed_cow_array_map is used for the elements array of a JSObject
to mark it as COW. The JSObject's map and other fields are not
affected. The JSObject's map still ha
Comment #23 on issue 264 by brickysam26: Allow __noSuchMethod__
implementations
http://code.google.com/p/v8/issues/detail?id=264
I have written an implementation of Harmony Proxy for node.js
[http://github.com/brickysam26/node-proxy]. I would love to see it included
in V8, it would be fai
Reviewers: dimich, Vitaly,
Message:
Thanks
Luke
Description:
[Isolates] Use ::GetHeap() more often.
++ indicates v8 tests (higher is better, reference/runtime)
-- indicates closure tests (lower is better, usec)
This patch (ia32):
++Crypto: 1877.75
--closure-json-raw: 357.50
++EarleyB
Cool. Couple comments:
http://codereview.chromium.org/3139005/diff/1/2
File src/contexts.cc (right):
http://codereview.chromium.org/3139005/diff/1/2#newcode70
src/contexts.cc:70: Context* Context::global_context(Heap* heap) {
I wonder how much speedup this particular function brings. It seems t
Status: New
Owner:
New issue 821 by 1nv151b13.b0b: support for calling java functions through
Packages would be very awesome.
http://code.google.com/p/v8/issues/detail?id=821
Detailed description of the issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/grou
Comment #1 on issue 821 by 1nv151b13.b0b: support for calling java
functions through Packages would be very awesome.
http://code.google.com/p/v8/issues/detail?id=821
dang. acidentally pressed enter instead of tab...
in firefox and rhino, you have access to the java API through a global
obj
Comment #2 on issue 821 by 1nv151b13.b0b: support for calling java
functions through Packages would be very awesome.
http://code.google.com/p/v8/issues/detail?id=821
it allows you do easily do the things in the attached HTML file. (only
works in fire fox)
Attachments:
java.htm 2.
Status: New
Owner:
New issue 822 by dannycoates: Clusterizer::CalculateNetworkSize may fail
cast assertion
http://code.google.com/p/v8/issues/detail?id=822
According JSObject::elements(), array can be a fixed, pixel, or external
array, but is cast to FixedArray in Clusterizer::Calculat
Comment #27 on issue 164 by elliottc...@gmail.com: Wrong order in Object
properties interation
http://code.google.com/p/v8/issues/detail?id=164
I’m for leaving it as-is. This allows for massive optimizations around
`Array`s, and is nothing more than implementing the standard as-described.
48 matches
Mail list logo
