Comment #4 on issue 585 by tobias.kaes: v8::Array::Length unresolved
external symbol in r3658
http://code.google.com/p/v8/issues/detail?id=585
I remember (unsigned) long being 8 bytes on my 64 bit linux box by default,
maybe that's why they're chosing ints. Is that part of the boost header
LGTM, I'll commmit it.
http://codereview.chromium.org/3413015/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, I'll commmit it.
http://codereview.chromium.org/3413015/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5490
Author: l...@chromium.org
Date: Mon Sep 20 01:43:35 2010
Log: Remove unused variable from Scanner class.
BUG=None
TEST=compiles
Patch from Thiago Farina
Review URL: http://codereview.chromium.org/3413015
http://code.google.com/p/v8/source/detail?r=5490
Modified:
/branches/blee
Revision: 5491
Author: floitsc...@gmail.com
Date: Mon Sep 20 02:18:00 2010
Log: Added precision mode to fast-dtoa.
Review URL: http://codereview.chromium.org/204
http://code.google.com/p/v8/source/detail?r=5491
Added:
/branches/bleeding_edge/test/cctest/gay-precision.cc
/branches/bleeding_e
Revision: 5492
Author: mikhail.naga...@gmail.com
Date: Mon Sep 20 02:29:12 2010
Log: Show RegExp calls in the profile.
It turns out they were filtered out. But when I unfiltered them, I
discovered another issue: when DevTools run, regexp literals get
recompiled each time they called (looks like t
On 2010/09/20 06:34:19, Søren Gjesse wrote:
LGTM
Thanks!
Could there be times where the same function(source wise) being recompiled
should be different functions? e.g. after page reload?
Surely that's possible. But I think this is a lesser issue than reporting
the
same regexp multiple t
Reviewers: Søren Gjesse,
Description:
Merge r5492 into 2.3 branch. Fix for showing regexps in profiler.
Please review this at http://codereview.chromium.org/3431016/show
SVN Base: http://v8.googlecode.com/svn/branches/2.3/
Affected files:
M src/api.cc
M src/cpu-profiler-inl.h
M
Reviewers: floitschv8_gmail.com,
Message:
Add an unneeded initialization of a local to make the Mac compiler happy.
Description:
Fix Mac compilation error in revision 5491. Initialize a local variable.
Please review this at http://codereview.chromium.org/3402016/show
SVN Base: http://v8.googl
http://codereview.chromium.org/3435012/diff/1/5
File benchmarks/README.txt (right):
http://codereview.chromium.org/3435012/diff/1/5#newcode74
benchmarks/README.txt:74: benchmark to exercise the regexp engine on
different input strings.
On 2010/09/19 12:45:17, Kasper Lund wrote:
regexp => regula
Revision: 5493
Author: sandh...@chromium.org
Date: Mon Sep 20 03:36:21 2010
Log: Changed the RegExp benchmark to exercise the regexp engine on different
inputs by scrambling the input strings.
Review URL: http://codereview.chromium.org/3435012
http://code.google.com/p/v8/source/detail?r=5493
Modi
The definition of the static const int member is removed from the
implementation
file.
http://codereview.chromium.org/3293002/diff/108002/109004
File src/full-codegen.cc (right):
http://codereview.chromium.org/3293002/diff/108002/109004#newcode513
src/full-codegen.cc:513: FullCodeGenerator::I
Revision: 5494
Author: floitsc...@gmail.com
Date: Mon Sep 20 03:58:41 2010
Log: Fix build-breakage on Mac. Initial variable eventhough it is
initialized in all reachable branches.
Review URL: http://codereview.chromium.org/3471001
http://code.google.com/p/v8/source/detail?r=5494
Modified:
/br
LGTM
http://codereview.chromium.org/3431016/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5495
Author: mikhail.naga...@gmail.com
Date: Mon Sep 20 04:53:15 2010
Log: Merge r5492 into 2.3 branch. Fix for showing regexps in profiler.
Review URL: http://codereview.chromium.org/3431016
http://code.google.com/p/v8/source/detail?r=5495
Modified:
/branches/2.3/src/api.cc
/branche
LGTM
http://codereview.chromium.org/3327022/diff/3001/4004
File src/ia32/disasm-ia32.cc (right):
http://codereview.chromium.org/3327022/diff/3001/4004#newcode1163
src/ia32/disasm-ia32.cc:1163: int8_t imm8 =
*reinterpret_cast(data + 1);
Why not just:
int imm8 = data[1];
?
http://codereview.chro
Comment #5 on issue 585 by hapalibashi: v8::Array::Length unresolved
external symbol in r3658
http://code.google.com/p/v8/issues/detail?id=585
The way its written, it doesn't look like it needs to distinguish between
Windows/Linux compilers (and supposedly is C99).
I suppose V8 may do it
Reviewers: Søren Gjesse,
Description:
Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug.
Test was failing is due to a fact that MSVC in debug mode uses
separate instances for identical string literals.
tbr=sgje...@chromium.org
Please review this at http://codereview.chromium.org
Revision: 5496
Author: mikhail.naga...@gmail.com
Date: Mon Sep 20 05:25:45 2010
Log: Fix ProfileNodeFindOrAddChildForSameFunction test on Win32 debug.
Test was failing is due to a fact that MSVC in debug mode uses
separate instances for identical string literals.
tbr=sgje...@chromium.org
Review
LGTM.
http://codereview.chromium.org/3471001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3381013/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5497
Author: vita...@chromium.org
Date: Mon Sep 20 06:50:27 2010
Log: Generate inline code for contextual loads.
Contextual load requires only a map check followed by a cell hole
check so we can generate pretty compact code for that. The fact that
we have inlined code is marked by mov e
On 2010/09/20 06:50:08, Søren Gjesse wrote:
LGTM
Thanks!
http://codereview.chromium.org/3402014/diff/1/5
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/3402014/diff/1/5#newcode9431
src/ia32/codegen-ia32.cc:9431: masm()->mov(result.reg(),
Factory::null_value());
How
http://codereview.chromium.org/3449004/diff/1/2
File src/ast.h (right):
http://codereview.chromium.org/3449004/diff/1/2#newcode181
src/ast.h:181: // Evaluated for its value (and side effects). Result on
stack.
On 2010/09/15 09:04:08, Kevin Millikin wrote:
The distinction between Stack/Accumula
New version uploaded. Changes from last time:
* The enums in ast.h are gone since they are no longer used.
* Move(reg, reg) introduced in ia32 and x64
* Virtual methods from some contexts moved to arch independent code.
* Ported to ARM and x64.
* Handling of && and || now uses virtual dispatch i
Reviewers: Mads Ager, Michail Naganov,
Description:
Use //@ sourceURL when formatting stack trace
BUG=672
Please review this at http://codereview.chromium.org/3444011/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/messages.js
M test/mjsun
On 2010/09/20 15:35:57, Yury Semikhatsky wrote:
LGTM
http://codereview.chromium.org/3444011/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5498
Author: yu...@chromium.org
Date: Mon Sep 20 08:55:28 2010
Log: Use //@ sourceURL when formatting stack trace
BUG=672
Review URL: http://codereview.chromium.org/3444011
http://code.google.com/p/v8/source/detail?r=5498
Modified:
/branches/bleeding_edge/src/messages.js
/branches/bl
Updates:
Status: Fixed
Comment #8 on issue 672 by yu...@chromium.org: Let the eval //@sourceURL
trick work for stack traces.
http://code.google.com/p/v8/issues/detail?id=672
Committed revision 5498.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I don't see it working for the following change:
function foo() {
function a() {
b();
}
function b() {
c();
}
function c() {
console.trace(); console.log(new Error().stack); as
}
a();
}
window.eval("(" + foo.toString() + ")(); //@ sourceUR
s/following change/following case/
http://codereview.chromium.org/3444011/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: New
Owner:
New issue 868 by dannycoates: Flush on Log::WriteToFile
http://code.google.com/p/v8/issues/detail?id=868
It would be nice if Log::WriteToFile would fflush after fwrite.
Reason:
Triggering a heap snapshot with
ResumeProfilerEx(PROFILER_MODULE_HEAP_SNAPSHOT) doesn't alwa
Updates:
Owner: mikhail.naganov
Comment #1 on issue 868 by mikhail.naganov: Flush on Log::WriteToFile
http://code.google.com/p/v8/issues/detail?id=868
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #1 on issue 859 by dannycoates: Cleanup: remove log compression and
memory buffer logging. It is no more used in Chrome.
http://code.google.com/p/v8/issues/detail?id=859
What does Chrome use instead of memory buffer?
I ask because I was thinking about using v8 with "--logfile=*" and
I have solved the problem with GC hitting while the inobject slack tracking
is
in progress.
Comments addressed.
Still need to add a test for multiple contexts.
http://codereview.chromium.org/3329019/diff/1/2
File src/arm/builtins-arm.cc (right):
http://codereview.chromium.org/3329019/diff/1
Status: New
Owner:
Labels: Type-Bug Priority-Medium
New issue 869 by asarg...@chromium.org: "With" and scope
http://code.google.com/p/v8/issues/detail?id=869
This bug appeared in the Chromium bug tracker but seems to be a V8 issue.
Original report here:
http://code.google.com/p/chromium/is
Status: New
Owner:
New issue 870 by oliverhunt: JSON.parse accepts incorrect strings
http://code.google.com/p/v8/issues/detail?id=870
JSON.parse allows unescaped newlines in string literals. eg.
JSON.parse('"\n"')
Is accepted as a valid, but is not.
--
v8-dev mailing list
v8-dev@googlegr
Updates:
Status: Duplicate
Labels: -Type-Bug -Priority-Medium
Mergedinto: 686
Comment #1 on issue 869 by vego...@chromium.org: "With" and scope
http://code.google.com/p/v8/issues/detail?id=869
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@google
Comment #8 on issue 686 by vego...@chromium.org: "With" and function scope
http://code.google.com/p/v8/issues/detail?id=686
Issue 869 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #9 on issue 672 by davi.fol: Let the eval //@sourceURL trick work
for stack traces.
http://code.google.com/p/v8/issues/detail?id=672
I'm stoked- how can / can I get a chrome build with this feature? Current
beta? Sorry, not familiar with your release cycle :)
--
v8-dev mailing lis
Updates:
Status: PendingFurtherInfo
Owner: LasseReichsteinHolstNielsen
Comment #1 on issue 870 by lasserei...@gmail.com: JSON.parse accepts
incorrect strings
http://code.google.com/p/v8/issues/detail?id=870
Which version of V8 are you using?
I cannot reproduce the error, and g
Comment #2 on issue 859 by mikhail.naganov: Cleanup: remove log compression
and memory buffer logging. It is no more used in Chrome.
http://code.google.com/p/v8/issues/detail?id=859
For CPU and heap profiles there is now a new API
in 'include/v8-profiler.h'. Do you need them or something el
Reviewers: William Hesse,
Message:
Please have another look.
http://codereview.chromium.org/204/diff/19001/14002
File src/fast-dtoa.cc (right):
http://codereview.chromium.org/204/diff/19001/14002#newcode78
src/fast-dtoa.cc:78: // ]w_low; w_low[ (often written as "(w_low;
w_low)")
On 20
http://codereview.chromium.org/204/diff/52001/56001
File src/fast-dtoa.cc (right):
http://codereview.chromium.org/204/diff/52001/56001#newcode518
src/fast-dtoa.cc:518: uint64_t unit = 1;
On 2010/09/20 06:58:16, William Hesse wrote:
Could this be called precision, or precision_unit, so i
Reviewers: William Hesse,
Message:
These are the remaining dtoa-changes I had on my hard-drive.
Description:
Add bignum fall-back when the fast dtoa doesn't succeed. This removes Gay's
dtoa
for the double->string direction. We still need it for the string->double
direction.
Please review thi
Yes that looks wrong!
17. sep. 2010 16.03 skrev BorisB :
> Hi
>
> The following code fragment in platform-linux.cc looks suspicious to
> me:
>
> uint64_t OS::CpuFeaturesImpliedByPlatform() {
> #if (defined(__VFP_FP__) && !defined(__SOFTFP__))
> // Here gcc is telling us that we are on an ARM and
Comment #12 on issue 672 by maste...@chromium.org: Let the eval
//@sourceURL trick work for stack traces.
http://code.google.com/p/v8/issues/detail?id=672
Hi davi.fol,
Please have a look here for more info on the release cycle:
http://www.chromium.org/getting-involved/dev-channel
--
v8-d
47 matches
Mail list logo
