Comment #100 on issue 164 by spamfry: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
@mendesjuan: You say "future proof your code, don't rely on non-standard
behavior." Are you saying that we should rely on "standard behavior"? If
so, do you m
FYI, the changes for SConstruct is now removed because we're no longer
doing a
conditional flag to set DEBUG_THREAD_NAME.
http://codereview.chromium.org/6070009/diff/33001/SConstruct
File SConstruct (right):
http://codereview.chromium.org/6070009/diff/33001/SConstruct#newcode129
SConstruct:12
Comment #99 on issue 164 by Be.DaveStein: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
@timdown This post is cute:
http://stackoverflow.com/questions/280713/elements-order-for-in-loop-in-javascript
They quote John Resig saying Chrome will fix
Comment #98 on issue 164 by timdown: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
"Can I ask how many different websites have you developed at all?"
I have no idea. I've been a professional web developer for 13 years, so
it's certainly in thr
Comment #97 on issue 164 by mendesjuan: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
Let me chime in also since everybody's throwing their two cents in the fire.
I wish Chrome would keep the order of iteration for properties as they were
adde
Comment #96 on issue 164 by Be.DaveStein: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
atcrabtree, I do like that solution better than underscores. It's
relatively simple, but any solution to this improvement/bug does require
extra logic and
Comment #95 on issue 164 by atcrabtree: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
I'd just like to add for all the frustration of current developers that a
great deal of this annoyance can be overcome by simply accepting reality. I
agree
Comment #94 on issue 164 by indrek.a...@sportlyzer.com: Wrong order in
Object properties interation
http://code.google.com/p/v8/issues/detail?id=164
Opening another bug will be of no help, there were 2 or 3 bugs open at some
time, all others were closed and marked as duplicate of this, and
Updates:
Owner: kmilli...@chromium.org
Cc: -kmilli...@chromium.org
Labels: -Priority-Medium Priority-High
Comment #1 on issue 1014 by a...@chromium.org: CHECK(fixed_size +
height_in_bytes == input_frame_size) failing intermittently
http://code.google.com/p/v8/issues/det
Comment #93 on issue 164 by Be.DaveStein: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
Indrek, this is CCing to a bunch of chrmoium dev's but none have answered.
They may not even be reading this because it was closed Nov 2008. I don't
know
Comment #92 on issue 164 by indrek.a...@sportlyzer.com: Wrong order in
Object properties interation
http://code.google.com/p/v8/issues/detail?id=164
"I've never seen it, except in examples posted in comments on this issue."
That has got to be one of the most common excuses in history.
I've
Revision: 6139
Author: vego...@chromium.org
Date: Mon Jan 3 11:16:29 2011
Log: Move first_artificial_register_ initialization to the right place.
Review URL: http://codereview.chromium.org/6009010
http://code.google.com/p/v8/source/detail?r=6139
Modified:
/branches/bleeding_edge/src/lithium-al
LGTM
http://codereview.chromium.org/6009010/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly,
Description:
Move first_artificial_register_ initialization to the right place.
Please review this at http://codereview.chromium.org/6009010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/lithium-allocator.cc
Index: src/lithium-allo
Comment #91 on issue 164 by jon.ronnenberg: Wrong order in Object
properties interation
http://code.google.com/p/v8/issues/detail?id=164
@timdown
I remember creating a self service page for a phone company a year ago that
relies on the object iteration order. Back then it worked in all brow
Comment #90 on issue 164 by Be.DaveStein: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
Tim, I think the major thing regarding that qustion is none of us really
know or can know. I doubt there's a data source of x websites using objects
in su
Revision: 6138
Author: vego...@chromium.org
Date: Mon Jan 3 09:02:15 2011
Log: Remember required register kind when creating artificial virtual
register.
Review URL: http://codereview.chromium.org/6065010
http://code.google.com/p/v8/source/detail?r=6138
Modified:
/branches/bleeding_edge/src
Updates:
Status: Fixed
Comment #7 on issue 1004 by kmilli...@chromium.org: Failing debug mode
test: mozilla/ecma_2/Statements/dowhile-003
http://code.google.com/p/v8/issues/detail?id=1004
This should be fixed on bleeding_edge by SVN revision 6137. I was unable
to reliably reproduce
Revision: 6137
Author: kmilli...@chromium.org
Date: Mon Jan 3 08:57:46 2011
Log: Fix a bug in deoptimization environments.
The function HEnvironment::SetExpressionStackAt did not update the
environment's history. This function is used to patch the bailout
environment for count operations and gl
LGTM.
http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (left):
http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc#oldcode1431
src/x64/stub-cache-x64.cc:1431:
I actually prefer the whitespace here, between declarations an
Reviewers: Lasse Reichstein,
Message:
Functions have just been cut and pasted into other locations in the same
file.
Description:
Reorder the functions in stub-cache-x64.cc, so they are in the same order
as in
stub-cache-ia32.cc.
Please review this at http://codereview.chromium.org/608500
LGTM. Small comments below.
http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h
File src/lithium-allocator.h (right):
http://codereview.chromium.org/6065010/diff/1/src/lithium-allocator.h#newcode758
src/lithium-allocator.h:758: class FlexibleBitVector BASE_EMBEDDED {
Maybe Gr
Comment #89 on issue 164 by timdown: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
On a similar theme, how many sites do actually rely on the enumeration
order of object properties? I've never seen it, except in examples posted
in comments on
LGTM
http://codereview.chromium.org/5992011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Message:
I couldn't find a simple way to trigger this in a test.
Description:
Fix a bug in deoptimization environments.
The function HEnvironment::SetExpressionStackAt did not update the
environment's history. This function is used to patch the bailout
environment
Reviewers: Kevin Millikin,
Description:
Remember required register kind when creating artificial virtual register.
Please review this at http://codereview.chromium.org/6065010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/data-flow.h
M src/lithium-al
Comment #88 on issue 164 by Be.DaveStein: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
I think the people that comment on a thread like this, are part of a much
smaller community than we realize. Most JS programmers barely know what
ECMA is,
Reviewers: lrn,
Message:
Only changes besides moving functions around in ic-x64.cc is replacement of
kTestEaxByte with Assembler::kTestEaxByte, and dropping of unused
declarations
of functions CallIC_Miss, etc, from runtime.
Description:
Cleanup of x64 code. Rearrange functions in ic-x64.cc
Revision: 6136
Author: whe...@chromium.org
Date: Mon Jan 3 06:59:12 2011
Log: Remove RecordWriteStub from X64 and ARM platforms.
Review URL: http://codereview.chromium.org/5986014
http://code.google.com/p/v8/source/detail?r=6136
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/bran
Reviewers: Erik Corry,
Description:
Reduce Page::kMaxHeapObjectSize.
Having 1mb objects in normal paged space does not make much sense.
This also reduces size of OldSpaceFreeList::free_ array.
Please review this at http://codereview.chromium.org/5987011/
SVN Base: https://v8.googlecode.com/sv
Redirecting CL to Erik.
http://codereview.chromium.org/5965011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2010/12/17 10:28:38, Søren Gjesse wrote:
LGTM
http://codereview.chromium.org/5781010/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/5781010/diff/1/src/arm/code-stubs-arm.cc#newcode1243
src/arm/code-stubs-arm.cc:1243:
Wouldn't it b
Updates:
Owner: kmilli...@chromium.org
Comment #6 on issue 1004 by ri...@chromium.org: Failing debug mode test:
mozilla/ecma_2/Statements/dowhile-003
http://code.google.com/p/v8/issues/detail?id=1004
This is a problem with the deoptimization environment at
pre/post-increment/decreme
Updates:
Cc: kmilli...@chromium.org
Comment #5 on issue 1004 by ri...@chromium.org: Failing debug mode test:
mozilla/ecma_2/Statements/dowhile-003
http://code.google.com/p/v8/issues/detail?id=1004
Issue 1011 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.
Updates:
Status: Duplicate
Mergedinto: 1004
Comment #1 on issue 1011 by ri...@chromium.org: [experimental/gc]
mjsunit/tools/tickprocessor.js became flaky after r6116
http://code.google.com/p/v8/issues/detail?id=1011
(No comment was entered for this change.)
--
v8-dev mailing
LGTM
http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc#newcode6817
src/x64/codegen-x64.cc:6817: __ RecordWriteHelper(tmp1.reg(),
index2.reg(), object.reg());
Swap tmp1 an
I've implemented the change in the generator used to create unicode.cc, and
committed a new version in revision 6133 (Changelist:
http://codereview.chromium.org/5993006/).
I'll close this issue.
http://codereview.chromium.org/6077006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.
Revision: 6135
Author: sgje...@chromium.org
Date: Mon Jan 3 03:39:22 2011
Log: Use the macro assembler Set instead of explicit xor for clearing
registers.
Review URL: http://codereview.chromium.org/6015011
http://code.google.com/p/v8/source/detail?r=6135
Modified:
/branches/bleeding_edge/src
Reviewers: Lasse Reichstein,
Description:
Remove RecordWriteStub from X64 and ARM platforms.
Please review this at http://codereview.chromium.org/5986014/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/code-stubs-arm.h
M src/arm/code-stubs-
LGTM
http://codereview.chromium.org/6015011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
Use the macro assembler Set instead of explicit xor for clearing registers.
Please review this at http://codereview.chromium.org/6015011/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/builtins-ia32.cc
Revision: 6134
Author: sandh...@chromium.org
Date: Mon Jan 3 02:51:34 2011
Log: Simplify ScanJsonString.
Review URL: http://codereview.chromium.org/6009009
http://code.google.com/p/v8/source/detail?r=6134
Modified:
/branches/bleeding_edge/src/scanner.cc
===
LGTM
http://codereview.chromium.org/6009009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6133
Author: l...@chromium.org
Date: Mon Jan 3 02:28:39 2011
Log: Changed uncast -1 in unsigned context to use constant kSentinel.
Review URL: http://codereview.chromium.org/5993006
http://code.google.com/p/v8/source/detail?r=6133
Modified:
/branches/bleeding_edge/src/unicode.cc
===
Done.
http://codereview.chromium.org/5993006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6132
Author: fschnei...@chromium.org
Date: Mon Jan 3 02:19:43 2011
Log: Tagging version 3.0.5
http://code.google.com/p/v8/source/detail?r=6132
Added:
/tags/3.0.5
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
Simplify ScanJsonString.
Please review this at http://codereview.chromium.org/6009009/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/scanner.cc
Index: src/scanner.cc
===
Revision: 6130
Author: a...@chromium.org
Date: Mon Jan 3 02:17:08 2011
Log: Add more documentation to Context::New in the API header file.
Review URL: http://codereview.chromium.org/6043005
http://code.google.com/p/v8/source/detail?r=6130
Modified:
/branches/bleeding_edge/include/v8.h
===
Please regenerate with the extra newline. Then it LGTM.
http://codereview.chromium.org/5993006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Message:
Generated using generator, but does the same as
http://codereview.chromium.org/6077006/
Description:
Changed uncast -1 in unsigned context to use constant kSentinel.
Please review this at http://codereview.chromium.org/5993006/
Affected files:
M src/unicode.cc
Revision: 6129
Author: fschnei...@chromium.org
Date: Mon Jan 3 02:02:17 2011
Log: Prepare push to trunk. Now working on 3.0.6.
Review URL: http://codereview.chromium.org/6005011
http://code.google.com/p/v8/source/detail?r=6129
Modified:
/branches/bleeding_edge/ChangeLog
/branches/bleeding_edg
LGTM
http://codereview.chromium.org/6005011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Prepare push to trunk. Now working on 3.0.6.
Please review this at http://codereview.chromium.org/6005011/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: ChangeLog
Updates:
Status: Accepted
Owner: LasseReichsteinHolstNielsen
Labels: Type-Bug ES5
Comment #1 on issue 1015 by lasserei...@gmail.com: Object literals
incorrectly invoke inherited setters for initialization
http://code.google.com/p/v8/issues/detail?id=1015
We have the sa
Quite easy.
I'll do it right away.
http://codereview.chromium.org/6077006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6043005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM with comments addressed.
http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc
File src/liveedit.cc (right):
http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode309
src/liveedit.cc:309: TokensCompareInput(Handle s1, int offset1,
int len1,
Only 2 char indent
Reviewers: Søren Gjesse,
Description:
Add more documentation to Context::New in the API header file.
Please review this at http://codereview.chromium.org/6043005/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M include/v8.h
Index: include/v8.h
LGTM
Committed: http://code.google.com/p/v8/source/detail?r=6128
http://codereview.chromium.org/6037015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6128
Author: sgje...@chromium.org
Date: Mon Jan 3 01:32:42 2011
Log: Changed #define symbols in test to OBJECT_PRINT from PRINT_OBJECT
because this is actually what is being used.
Patch by Mark Lam from Hewlett-Packard Development Company, LP
Review URL: http://codereview.chromium.org
http://codereview.chromium.org/5980006/diff/10002/src/d8.js
File src/d8.js (right):
http://codereview.chromium.org/5980006/diff/10002/src/d8.js#newcode302
src/d8.js:302: cmd_line = 'break'; // If not in debugger mode, break
with a frame request.
Long line. Some more below.
http://codereview.chr
Updates:
Owner: ri...@chromium.org
Comment #4 on issue 1004 by ri...@chromium.org: Failing debug mode test:
mozilla/ecma_2/Statements/dowhile-003
http://code.google.com/p/v8/issues/detail?id=1004
I am stealing this since I can now reproduce this on the buildbot.
--
v8-dev mailing lis
Thanks for the patch. This file is auto generated. Lasse, would it be easy
to
modify the generator instead?
http://codereview.chromium.org/6077006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Ah, another change has been uploaded. Thanks!
On Mon, Jan 3, 2011 at 8:49 AM, Mads Sig Ager wrote:
> Can't find this issue in the code review tool. Could you upload again?
>
> Thanks, -- Mads
>
> On Wed, Dec 22, 2010 at 6:44 PM, wrote:
>> Reviewers: Mads Ager,
>>
>> Message:
>> Adding object
Revision: 6127
Author: a...@chromium.org
Date: Mon Jan 3 00:13:37 2011
Log: Landing for Martin Maly.
Fix Xcode project.
http://code.google.com/p/v8/source/detail?r=6127
Modified:
/branches/bleeding_edge/tools/v8.xcodeproj/project.pbxproj
===
--- /branches/b
LGTM, thanks.
http://codereview.chromium.org/5976007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
66 matches
Mail list logo
