[v8-dev] Re: Issue 235 in v8: Support the Javascript E4X extension

Comment #60 on issue 235 by downchuck: Support the Javascript E4X extension http://code.google.com/p/v8/issues/detail?id=235 In case it was missed, E4X is well represented: http://en.wikipedia.org/wiki/E4X Boris recently pointed out a reasonable use case: http://lists.w3.org/Archives/Public/pub

[v8-dev] Re: Issue 1029 in v8: please merge pach to support Cygwin

Comment #1 on issue 1029 by helpmepro1: please merge pach to support Cygwin http://code.google.com/p/v8/issues/detail?id=1029 I could not apply the patch by my self. So you may ignore this. However I have a build problem at the moment... tried to build nodejs 0.3.3 on cygwin -- v8-dev mailing

[v8-dev] Issue 1029 in v8: please merge pach to support Cygwin

Status: New Owner: New issue 1029 by helpmepro1: please merge pach to support Cygwin http://code.google.com/p/v8/issues/detail?id=1029 https://github.com/ry/node/wiki/Building-node.js-on-Cygwin-(Windows) -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: On getting started with the code-base.

Hi Sanjoy, Here are some ideas: - If you have access to x64 FreeBSD machine you might try to help us with: http://code.google.com/p/v8/issues/detail?id=966. I suspect that something is wrong with ABI but we do not have FreeBSD machine to try it out. - You might try to help improve GDB JIT integr

[v8-dev] Re: Issue 951 in v8: V8 crash on XP/MinGW

Updates: Status: Fixed Comment #3 on issue 951 by vego...@chromium.org: V8 crash on XP/MinGW http://code.google.com/p/v8/issues/detail?id=951 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 966 in v8: v8 Build error in FreeBSD 8.1

Updates: Labels: HelpWanted Comment #7 on issue 966 by vego...@chromium.org: v8 Build error in FreeBSD 8.1 http://code.google.com/p/v8/issues/detail?id=966 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Implementing a few more missing stubs on ARM:... (issue6124005)

Reviewers: Mads Ager, Description: Implementing a few more missing stubs on ARM: * LCodeGen::EmitClassOfTest * LCodeGen::DoClassOfTestAndBranch * LCodeGen::DoMathFloor * LCodeGen::DoMathSqrt BUG=none TEST=none Please review this at http://codereview.chromium.org/6124005/ SVN Base: http://

[v8-dev] Re: ARM: Fix comparison of NaN values.... (issue6142004)

Thanks for the review. The patch should be uploaded soon. Alexandre http://codereview.chromium.org/6142004/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6142004/diff/1/src/arm/assembler-arm.cc#newcode2338 src/arm/assembler-arm.cc:2338: vo

[v8-dev] Re: ARM: Fix comparison of NaN values.... (issue6142004)

http://codereview.chromium.org/6142004/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] On getting started with the code-base.

Hi! I'm attempting to begin hacking on V8, and I was wondering if I could get some suggestions on a bite-sized project that I can start working on to familiarize myself with the code-base. I'm reasonably proficient in C++ and have worked with a JIT compiler before. -- Regards, Sanjoy Das http

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #106 on issue 164 by indrek.a...@sportlyzer.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 Hmm, would it be possible to check data type upon insertion? As I understand, fast and slow system works internally in parallel (thus getting

[v8-dev] Re: SSE2 truncating double-to-i. (issue6049008)

All issues addressed. Loading the constant did turn out to be a bit faster than building it manually. Please take the final look. Thanks! -- Vitaly http://codereview.chromium.org/6049008/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 981 in v8: Primordial privilege escalation from bad this-coercion

Comment #8 on issue 981 by lasserei...@gmail.com: Primordial privilege escalation from bad this-coercion http://code.google.com/p/v8/issues/detail?id=981 This will be changed as part of implementing strict mode. At that point, we will also need a way to call strict functions without convert

Re: [v8-dev] Re: Basic GDB JIT Interface integration. (issue5965011)

Cool. I'll try it out. Danno On Wed, Jan 5, 2011 at 10:00 AM, wrote: > LGTM > > > http://codereview.chromium.org/5965011/diff/12016/SConstruct > File SConstruct (right): > > http://codereview.chromium.org/5965011/diff/12016/SConstruct#newcode882 > SConstruct:882: Abort("GDBJIT interface is suppo

[v8-dev] Re: Make better use of the %_FastAsciiArrayJoin function. (issue6100005)

LGTM. http://codereview.chromium.org/615/diff/2001/src/array.js File src/array.js (right): http://codereview.chromium.org/615/diff/2001/src/array.js#newcode148 src/array.js:148: if (!IS_UNDEFINED(e) || (i in array)) { If all actually used convert functions convert undefined to the empty

[v8-dev] Make better use of the %_FastAsciiArrayJoin function. (issue6100005)

Reviewers: Lasse Reichstein, Description: Make better use of the %_FastAsciiArrayJoin function. Please review this at http://codereview.chromium.org/615/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/array.js Index: src/array.js ==

[v8-dev] Re: ARM: Fix lithium codegeneration of TypeofIs... (issue6113003)

LGTM. http://codereview.chromium.org/6113003/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r6231 committed - ARM: Fix lithium codegeneration of TypeofIs...

Revision: 6231 Author: sgje...@chromium.org Date: Fri Jan 7 06:27:32 2011 Log: ARM: Fix lithium codegeneration of TypeofIs The previous implementation was incomplete and wrong. tbr=karlkl...@chromium.org Review URL: http://codereview.chromium.org/6113003 http://code.google.com/p/v8/source/detai

[v8-dev] ARM: Fix lithium codegeneration of TypeofIs... (issue6113003)

Reviewers: Karl Klose, Description: ARM: Fix lithium codegeneration of TypeofIs The previous implementation was incomplete and wrong. tbr=karlkl...@chromium.org Please review this at http://codereview.chromium.org/6113003/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affect

[v8-dev] Re: Issue 1028 in v8: [ECMA compliance] RangeError in Array ctor.

Comment #1 on issue 1028 by jedrzej@nokia.com: [ECMA compliance] RangeError in Array ctor. http://code.google.com/p/v8/issues/detail?id=1028 Additional informations: system: Debian testing platform: 32 bit v8 version: Isolates branch from 13 12 2010 v8 version: Trunk r6190 (in d8 instead

[v8-dev] [v8] r6230 committed - Separate markbits from heap object map words into bitmaps....

Revision: 6230 Author: vego...@chromium.org Date: Fri Jan 7 06:11:14 2011 Log: Separate markbits from heap object map words into bitmaps. This change considerably degrades marking (50% slowdown) and sweeping (25% slowdown) but this is intended. We are going to reduce overheads in the CLs tha

[v8-dev] Issue 1028 in v8: [ECMA compliance] RangeError in Array ctor.

Status: New Owner: New issue 1028 by jedrzej@nokia.com: [ECMA compliance] RangeError in Array ctor. http://code.google.com/p/v8/issues/detail?id=1028 According to ECMA standard Array constructor should accept all uint32 values (15.4.2.2 ECMA 262 5th edition) but V8 doesn't. Examp

[v8-dev] [v8] r6229 committed - Disable flaky test on x64 when running with --crankshaft....

Revision: 6229 Author: ri...@chromium.org Date: Fri Jan 7 05:53:20 2011 Log: Disable flaky test on x64 when running with --crankshaft. mjsunit/compiler/simple-osr is flaky. Disabling for now until we get osr in place on the x64 port. Bug 1026 created to track this: http://code.google.com/p/v8/

[v8-dev] [v8] r6228 committed - Speed up a regression test regress-3249650.js so it does not timeout....

Revision: 6228 Author: whe...@chromium.org Date: Fri Jan 7 05:52:36 2011 Log: Speed up a regression test regress-3249650.js so it does not timeout. Review URL: http://codereview.chromium.org/6175001 http://code.google.com/p/v8/source/detail?r=6228 Modified: /branches/bleeding_edge/test/mjsunit/

[v8-dev] Re: Disable flaky test on x64 when running with --crankshaft.... (issue6176001)

LGTM. http://codereview.chromium.org/6176001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r6227 committed - ARM: Implement lithium codegen for DoTypeof, DoTypeofIs and DoSmiUntag...

Revision: 6227 Author: sgje...@chromium.org Date: Fri Jan 7 05:44:05 2011 Log: ARM: Implement lithium codegen for DoTypeof, DoTypeofIs and DoSmiUntag Review URL: http://codereview.chromium.org/6174001 http://code.google.com/p/v8/source/detail?r=6227 Modified: /branches/bleeding_edge/src/arm/lit

[v8-dev] [v8] r6226 committed - Aviod double checking IS_STRING when joining arrays....

Revision: 6226 Author: sandh...@chromium.org Date: Fri Jan 7 05:21:34 2011 Log: Aviod double checking IS_STRING when joining arrays. Review URL: http://codereview.chromium.org/5977013 http://code.google.com/p/v8/source/detail?r=6226 Modified: /branches/bleeding_edge/src/array.js /branches/blee

[v8-dev] Crankshaft: Move LParallelMove to lithium.h, add LGap to lithium-x64.h. (issue6132002)

Reviewers: fschneider, Message: Entirely cut-and-paste change. Description: Crankshaft: Move LParallelMove to lithium.h, add LGap to lithium-x64.h. Please review this at http://codereview.chromium.org/6132002/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M

[v8-dev] Re: Aviod double checking IS_STRING when joining arrays. (issue5977013)

http://codereview.chromium.org/5977013/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/5977013/diff/1/src/array.js#newcode70 src/array.js:70: // Optimized for sparse arrays if separator is ''. On 2011/01/07 13:13:43, Lasse Reichstein wrote: Make a comment saying th

[v8-dev] Re: Aviod double checking IS_STRING when joining arrays. (issue5977013)

LGTM http://codereview.chromium.org/5977013/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/5977013/diff/1/src/array.js#newcode70 src/array.js:70: // Optimized for sparse arrays if separator is ''. Make a comment saying that convert is only called on non-strings.

[v8-dev] Aviod double checking IS_STRING when joining arrays. (issue5977013)

Reviewers: Lasse Reichstein, Description: Aviod double checking IS_STRING when joining arrays. Please review this at http://codereview.chromium.org/5977013/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/array.js M src/v8natives.js Index: src

[v8-dev] Re: Speed up a regression test regress-3249650.js so it does not timeout. (issue6175001)

LGTM http://codereview.chromium.org/6175001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Issue 1027 in v8: http/tests/security/xss-DENIED-defineProperty.html started failing in revision 6220

Status: Accepted Owner: ri...@chromium.org Labels: Type-Bug Priority-Medium New issue 1027 by ri...@chromium.org: http/tests/security/xss-DENIED-defineProperty.html started failing in revision 6220 http://code.google.com/p/v8/issues/detail?id=1027 http/tests/security/xss-DENIED-defineProper

[v8-dev] [v8] r6225 committed - Change interpretation of malformed \c? escapes in RegExp to match JSC....

Revision: 6225 Author: l...@chromium.org Date: Fri Jan 7 04:35:42 2011 Log: Change interpretation of malformed \c? escapes in RegExp to match JSC. Review URL: http://codereview.chromium.org/6171001 http://code.google.com/p/v8/source/detail?r=6225 Modified: /branches/bleeding_edge/src/parser.cc

[v8-dev] [v8] r6224 committed - ARM: Support DoCallGlobal in lithium code generator....

Revision: 6224 Author: karlkl...@chromium.org Date: Fri Jan 7 04:34:39 2011 Log: ARM: Support DoCallGlobal in lithium code generator. BUG= TEST= Review URL: http://codereview.chromium.org/6094011 http://code.google.com/p/v8/source/detail?r=6224 Modified: /branches/bleeding_edge/src/arm/lithiu

[v8-dev] [v8] r6223 committed - Edited wiki page DebuggerProtocol through web user interface.

Revision: 6223 Author: sgje...@chromium.org Date: Fri Jan 7 04:34:38 2011 Log: Edited wiki page DebuggerProtocol through web user interface. http://code.google.com/p/v8/source/detail?r=6223 Modified: /wiki/DebuggerProtocol.wiki === --- /wiki/DebuggerProtocol

[v8-dev] Disable flaky test on x64 when running with --crankshaft.... (issue6176001)

Reviewers: William Hesse, Description: Disable flaky test on x64 when running with --crankshaft. mjsunit/compiler/simple-osr is flaky. Disabling for now until we get osr in place on the x64 port. Bug 1026 created to track this: http://code.google.com/p/v8/issues/detail?id=1026 Please review

[v8-dev] Re: Change interpretation of malformed \c? escapes in RegExp to match JSC. (issue6171001)

http://codereview.chromium.org/6171001/diff/2001/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6171001/diff/2001/src/parser.cc#newcode4037 src/parser.cc:4037: } On 2011/01/07 10:38:16, Erik Corry wrote: I think it's more readable with an else and a single break. Don

[v8-dev] Issue 1026 in v8: DISABLED TEST: compiler/simple-osr on x64 with --crankshaft

Status: Accepted Owner: ri...@chromium.org Labels: Type-Bug Priority-Medium HW-x64 New issue 1026 by ri...@chromium.org: DISABLED TEST: compiler/simple-osr on x64 with --crankshaft http://code.google.com/p/v8/issues/detail?id=1026 compiler/simple-osr is flaky when running in 64 bit mode with

[v8-dev] Re: Issue 1018 in v8: Fatal error in ARM crankshaft: Invalid gap size.

Comment #6 on issue 1018 by a...@chromium.org: Fatal error in ARM crankshaft: Invalid gap size. http://code.google.com/p/v8/issues/detail?id=1018 I think that is it. I put in tracing of emitting constant pool, parallel move and the place where the offset is too big: BeginDoParallelMove Em

[v8-dev] Speed up a regression test regress-3249650.js so it does not timeout. (issue6175001)

Reviewers: Søren Gjesse, Message: This test now takes 10 seconds on x64 with the slowest settings, <30 seconds on the slowest arm simulator settings. It hits all the optimizations and deoptimizations needed on ia32 and arm, for testing. Description: Speed up a regression test regress-3249650

[v8-dev] Re: Issue 1018 in v8: Fatal error in ARM crankshaft: Invalid gap size.

Comment #5 on issue 1018 by a...@chromium.org: Fatal error in ARM crankshaft: Invalid gap size. http://code.google.com/p/v8/issues/detail?id=1018 Thinking out loud: could this be caused by emitting a constant pool while generating the code for a gap? -- v8-dev mailing list v8-dev@googlegr

[v8-dev] Re: Separate markbits from heap object map words into bitmaps. (issue6088012)

LGTM http://codereview.chromium.org/6088012/diff/3001/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6088012/diff/3001/src/heap.cc#newcode218 src/heap.cc:218: int Heap::GcSafeSizeOfOldObject(HeapObject* object) { Shouldn't we just get rid of this alltogether? http://coder

[v8-dev] Re: First cut at bug 992 (issue6035014)

Landed in revision 6220 http://code.google.com/p/v8/source/detail?r=6220 On 2011/01/07 11:06:49, Rico wrote: Hi Peter, I will land this for you with the nit (since you do not have commit rights). Lets put the additional tests in another patch and get this in now. Thanks a lot for the effo

[v8-dev] Re: Added a few new debugger tests. (issue6035016)

LGTM Committed: http://code.google.com/p/v8/source/detail?r=6222 Regarding the gc and setflags requests you could just add sanity checks that the requests are recognized and return a response with the expected properties. http://codereview.chromium.org/6035016/ -- v8-dev mailing list v8-dev

[v8-dev] [v8] r6222 committed - Added a few new debugger tests....

Revision: 6222 Author: sgje...@chromium.org Date: Fri Jan 7 03:59:41 2011 Log: Added a few new debugger tests. Patch by Mark Lam from Hewlett-Packard Development Company, LP Review URL: http://codereview.chromium.org/6035016 http://code.google.com/p/v8/source/detail?r=6222 Added: /branches/b

[v8-dev] [v8] r6221 committed - Create platform-independent lithium files, move LGapResolver and LGapN...

Revision: 6221 Author: whe...@chromium.org Date: Fri Jan 7 03:49:22 2011 Log: Create platform-independent lithium files, move LGapResolver and LGapNode there Review URL: http://codereview.chromium.org/6121001 http://code.google.com/p/v8/source/detail?r=6221 Added: /branches/bleeding_edge/src

[v8-dev] Re: ARM: Implement lithium codegen for DoTypeof, DoTypeofIs and DoSmiUntag (issue6174001)

LGTM. http://codereview.chromium.org/6174001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r6220 committed - Landing for Peter Hallam...

Revision: 6220 Author: ri...@chromium.org Date: Fri Jan 7 03:49:09 2011 Log: Landing for Peter Hallam First cut at bug 992 Fixes JS portion of DefineOwnProperty when there is an existing property and the new descriptor is generic. Makes code follow spec steps more closely. Fixes typo for chec

[v8-dev] Re: ARM: Fix comparison of NaN values.... (issue6142004)

Drive by comment. http://codereview.chromium.org/6142004/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6142004/diff/1/src/arm/lithium-codegen-arm.cc#newcode1082 src/arm/lithium-codegen-arm.cc:1082: // Clear the Invalid cumulati

[v8-dev] Re: ARM: Fix comparison of NaN values.... (issue6142004)

Have you gone through the other uses of vcmp in the current system to verify that the existing code does not break because of this change? If you have, this looks good to me. I'll land once you have looked through the existing uses. Thanks for the patch! http://codereview.chromium.org/614200

[v8-dev] ARM: Implement lithium codegen for DoTypeof, DoTypeofIs and DoSmiUntag (issue6174001)

Reviewers: Karl Klose, Description: ARM: Implement lithium codegen for DoTypeof, DoTypeofIs and DoSmiUntag Please review this at http://codereview.chromium.org/6174001/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/lithium-arm.cc M src/arm

Re: [v8-dev] Re: Issue 1023 in v8: NaN is interpreted as true in conditionals on ARM with crankshaft

http://codereview.chromium.org/6142004/ Patch uploaded. On Thu, Jan 6, 2011 at 10:42 AM, wrote: > > Comment #3 on issue 1023 by alexandre.rames: NaN is interpreted as true in > conditionals on ARM with crankshaft > > http://code.google.com/p/v8/issues/de

[v8-dev] ARM: Fix comparison of NaN values.... (issue6142004)

Reviewers: Mads Ager, Description: ARM: Fix comparison of NaN values. Enables the cumulative exception flag when comparing values, and uses it to detect NaN results. BUG=1023 TEST=none Please review this at http://codereview.chromium.org/6142004/ SVN Base: http://v8.googlecode.com/svn/branche

[v8-dev] Re: First cut at bug 992 (issue6035014)

Hi Peter, I will land this for you with the nit (since you do not have commit rights). Lets put the additional tests in another patch and get this in now. Thanks a lot for the effort. Cheers, Rico On 2011/01/07 09:47:30, Rico wrote: LGTM I had not considered the possibility of being able to

[v8-dev] [v8] r6219 committed - Fix win64 build (int conversion)...

Revision: 6219 Author: ri...@chromium.org Date: Fri Jan 7 02:51:44 2011 Log: Fix win64 build (int conversion) Review URL: http://codereview.chromium.org/6083014 http://code.google.com/p/v8/source/detail?r=6219 Modified: /branches/bleeding_edge/src/runtime.cc =

[v8-dev] Re: Issue 1025 in v8: Performance regression on Crankshaft x86

Updates: Status: Fixed Comment #2 on issue 1025 by fschnei...@chromium.org: Performance regression on Crankshaft x86 http://code.google.com/p/v8/issues/detail?id=1025 Should be fixed in r6217. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r6218 committed - Fix GC issue in instanceof stub...

Revision: 6218 Author: sgje...@chromium.org Date: Fri Jan 7 02:37:26 2011 Log: Fix GC issue in instanceof stub The the call of the builtin in InstanceofStub was not correctly protected with an internal frame leading to the return address being handled as a pointer during GC. Marked the Ins

[v8-dev] Re: Change interpretation of malformed \c? escapes in RegExp to match JSC. (issue6171001)

LGTM Florian should be careful when pushing to Chromium. http://codereview.chromium.org/6171001/diff/2001/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6171001/diff/2001/src/parser.cc#newcode4037 src/parser.cc:4037: } I think it's more readable with an else and a sin

[v8-dev] Re: Crankshaft: Create platform-independent lithium files, move LGapResolver and LGapNode there. (issue6121001)

LGTM. http://codereview.chromium.org/6121001/diff/27001/src/lithium.h File src/lithium.h (right): http://codereview.chromium.org/6121001/diff/27001/src/lithium.h#newcode31 src/lithium.h:31: //#include "hydrogen.h" Remove the commented out code in the #includes. http://codereview.chromium.org/6

[v8-dev] [v8] r6217 committed - Revert r6194: Clean up code for type feedback a bit....

Revision: 6217 Author: fschnei...@chromium.org Date: Fri Jan 7 02:36:27 2011 Log: Revert r6194: Clean up code for type feedback a bit. This causes a big performance regression. I'll investigate. Review URL: http://codereview.chromium.org/6172001 http://code.google.com/p/v8/source/detail?r=6217

[v8-dev] Re: Revert r6194: Clean up code for type feedback a bit.... (issue6172001)

LGTM. http://codereview.chromium.org/6172001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Revert r6194: Clean up code for type feedback a bit.... (issue6172001)

Reviewers: William Hesse, Description: Revert r6194: Clean up code for type feedback a bit. This causes a big performance regression. I'll investigate. Please review this at http://codereview.chromium.org/6172001/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files:

[v8-dev] Change interpretation of malformed \c? escapes in RegExp to match JSC. (issue6171001)

Reviewers: Erik Corry, Description: Change interpretation of malformed \c? escapes in RegExp to match JSC. Please review this at http://codereview.chromium.org/6171001/ Affected files: M src/parser.h M src/parser.cc M test/cctest/test-regexp.cc M test/mjsunit/regexp.js M test/mjsunit/

[v8-dev] Re: Fix GC issue in instanceof stub... (issue6097010)

LGTM, thanks! http://codereview.chromium.org/6097010/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Fix win64 build (int conversion) (issue6083014)

LGTM http://codereview.chromium.org/6083014/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r6216 committed - Move IsArgumentsMarker from class MaybeObject to Object....

Revision: 6216 Author: kmilli...@chromium.org Date: Fri Jan 7 02:06:28 2011 Log: Move IsArgumentsMarker from class MaybeObject to Object. Since we never need to ask it of a MaybeObject, put it with the other oddball testers in class Object for consistency. Review URL: http://codereview.chromium

[v8-dev] Re: Issue 1025 in v8: Performance regression on Crankshaft x86

Updates: Status: Accepted Owner: fschnei...@chromium.org Comment #1 on issue 1025 by ri...@chromium.org: Performance regression on Crankshaft x86 http://code.google.com/p/v8/issues/detail?id=1025 You are right, this was introduced in revision 6194 Thanks for reporting this.

[v8-dev] Fix win64 build (int conversion) (issue6083014)

Reviewers: Søren Gjesse, Description: Fix win64 build (int conversion) Please review this at http://codereview.chromium.org/6083014/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/runtime.cc Index: src/runtime.cc =

[v8-dev] Re: Move IsArgumentsMarker from class MaybeObject to Object. (issue6138004)

LGTM. http://codereview.chromium.org/6138004/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Issue 1025 in v8: Performance regression on Crankshaft x86

Status: New Owner: New issue 1025 by m.h.kjaer: Performance regression on Crankshaft x86 http://code.google.com/p/v8/issues/detail?id=1025 My tests of v8's performance suffered badly when I updated yesterday. My v8Benchmark scores dropped from a 6900 point average to a 5900 average. My

[v8-dev] [v8] r6215 committed - X64 Crankshaft: Implement some methods in LInstruction, update mjsunit...

Revision: 6215 Author: whe...@chromium.org Date: Fri Jan 7 01:47:16 2011 Log: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test expectations. Review URL: http://codereview.chromium.org/6118002 http://code.google.com/p/v8/source/detail?r=6215 Modified: /branches/blee

[v8-dev] Re: First cut at bug 992 (issue6035014)

LGTM I had not considered the possibility of being able to change writable to false even with configurable set to false. I saw the discussion on es-discuss and that is a somehow valid point (although it intuitively does not make a lot of sense). But we should of course follow the spec here.

[v8-dev] Re: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test e... (issue6118002)

http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h File src/x64/lithium-x64.h (right): http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h#newcode33 src/x64/lithium-x64.h:33: #include "lithium.h" On 2011/01/07 09:36:07, Rico wrote: Do we need this include? Thi

[v8-dev] Re: Crankshaft: Create platform-independent lithium files, move LGapResolver and LGapNode there. (issue6121001)

http://codereview.chromium.org/6121001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test e... (issue6118002)

LGTM http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h File src/x64/lithium-x64.h (right): http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h#newcode33 src/x64/lithium-x64.h:33: #include "lithium.h" Do we need this include? http://codereview.chromium.org/6118

[v8-dev] Fix GC issue in instanceof stub... (issue6097010)

Reviewers: Mads Ager, Description: Fix GC issue in instanceof stub The the call of the builtin in InstanceofStub was not correctly protected with an internal frame leading to the return address being handled as a pointer during GC. Marked the Instanceof stub as allowing stub calls (the Recor

[v8-dev] Re: ARM: Support DoCallGlobal in lithium code generator. (issue6094011)

LGTM http://codereview.chromium.org/6094011/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] ARM: Support DoCallGlobal in lithium code generator. (issue6094011)

Reviewers: sgjesse, Description: ARM: Support DoCallGlobal in lithium code generator. BUG= TEST= Please review this at http://codereview.chromium.org/6094011/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/lithium-codegen-arm.cc Index: src/arm/li