Updates:
Status: WorkingAsIntended
Labels: DeliberateSpecViolation
Comment #2 on issue 1127 by a...@chromium.org: "do{;}while(false)false"
parses, in violation of specified grammar
http://code.google.com/p/v8/issues/detail?id=1127
(No comment was entered for this change.)
--
LGTM!
http://codereview.chromium.org/6463001/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6463001/diff/1/src/runtime.cc#newcode7394
src/runtime.cc:7394: Handle::cast(holder)->set(index, *value);
Do you know that this one cannot fail? Code that is a handle no
Updates:
Status: Invalid
Owner: k...@chromium.org
Comment #6 on issue 1101 by k...@chromium.org: NaN is converted to
0xfff8 (-NaN)
http://code.google.com/p/v8/issues/detail?id=1101
Per https://bugs.webkit.org/show_bug.cgi?id=53598 , after discussion on the
public
Updates:
Cc: jia...@chromium.org
Comment #5 on issue 1101 by k...@chromium.org: NaN is converted to
0xfff8 (-NaN)
http://code.google.com/p/v8/issues/detail?id=1101
Issue chromium:71979 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
Comment #1 on issue 971 by simon.steele: unable to build mksnapshot with
werror on msvcrt shared
http://code.google.com/p/v8/issues/detail?id=971
For what it's worth, same issue on VS2008:
cl /Foobj\release\mksnapshot.obj /c src\mksnapshot.cc /nologo /W3 /WX
/wd4351 /wd4355 /wd4800 /O2 /MD
Thanks.
On Tue, Feb 8, 2011 at 8:40 PM, wrote:
> LGTM
>
>
> http://codereview.chromium.org/6458001/
>
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #1 on issue 1127 by erig...@google.com: "do{;}while(false)false"
parses, in violation of specified grammar
http://code.google.com/p/v8/issues/detail?id=1127
Recorded as a spec bug at https://bugs.ecmascript.org/show_bug.cgi?id=8
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Status: New
Owner:
New issue 1127 by erig...@google.com: "do{;}while(false)false" parses, in
violation of specified grammar
http://code.google.com/p/v8/issues/detail?id=1127
As raised by David Fugate at
https://mail.mozilla.org/pipermail/es-discuss/2011-February/012751.html
and documen
Reviewers: Mads Ager,
Message:
Mads,
may you have a look?
Description:
Use GC-safe version when setting elements.
BUG=1125
TEST=test/mjsunit/regress/regress-1125.js
Please review this at http://codereview.chromium.org/6463001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
A
Revision: 6692
Author: ant...@chromium.org
Date: Tue Feb 8 12:13:08 2011
Log: Do sanity check of exception state when returning from native to JS.
If --debug-code is on, check that returned value and
Top::has_pending_exception
agree on exception state.
Review URL: http://codereview.chromium.
Updates:
Status: Fixed
Comment #3 on issue 1121 by ant...@chromium.org: getOwnPropertyNames can
trigger "CHECK(object->IsJSObject()) failed"
http://code.google.com/p/v8/issues/detail?id=1121
http://code.google.com/p/v8/source/detail?r=6691 should fix
--
v8-dev mailing list
v8-dev@goo
Revision: 6691
Author: ant...@chromium.org
Date: Tue Feb 8 11:56:44 2011
Log: Check if Array.prototype.__proto__ has been reset to null.
BUG=v8:1121
TEST=test/mjsunit/regress/regress-1121.js
Review URL: http://codereview.chromium.org/6454004
http://code.google.com/p/v8/source/detail?r=6691
Add
Revision: 6689
Author: ant...@chromium.org
Date: Tue Feb 8 11:42:14 2011
Log: Propagate exceptions thrown when setting elements.
Plus use more robust path when formatting messages---work
directly with fixed arrays.
BUG=v8:1107
TEST=test/mjsunit/getter-in-prototype.js,test/mjsunit/regress/regres
Revision: 6690
Author: a...@chromium.org
Date: Tue Feb 8 11:42:24 2011
Log: Port fix for duplicate AST ID for deoptimization to ARM and x64.
Review URL: http://codereview.chromium.org/6458001
http://code.google.com/p/v8/source/detail?r=6690
Modified:
/branches/bleeding_edge/src/arm/full-codege
LGTM
http://codereview.chromium.org/6458001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: antonm, Kevin Millikin,
Description:
Port fix for duplicate AST ID for deoptimization to ARM and x64.
Please review this at http://codereview.chromium.org/6458001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
M src/
Submitting
http://codereview.chromium.org/6451004/diff/6002/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/6451004/diff/6002/src/objects.cc#newcode1728
src/objects.cc:1728: return Heap::the_hole_value();
On 2011/02/08 18:59:11, Mads Ager wrote:
Can we do an output p
Revision: 6688
Author: ant...@chromium.org
Date: Tue Feb 8 11:19:42 2011
Log: We cannot assert that v8 is running in fatal error callback.
BUG=v8:
Review URL: http://codereview.chromium.org/6450005
http://code.google.com/p/v8/source/detail?r=6688
Modified:
/branches/bleeding_edge/src/api.
Søren, I am submitting it right now. I'll add a test later if we'll
find out how to do that.
yours,
anton.
On Tue, Feb 8, 2011 at 7:49 PM, Anton Muhin wrote:
> I've got it, but test dies with SIGABORT (that's what our handler
> does). And I cannot add it easily into test-api as I would need to
Revision: 6687
Author: ant...@chromium.org
Date: Tue Feb 8 11:04:17 2011
Log: 1) Return failure if any of property sets failed;
2) We cannot assert the declared property will go to the extension in the
presence of callbacks and interceptors.
BUG=1119
TEST=test/mjsunit/regress/regress-1119.js
LGTM when this comment is addressed.
http://codereview.chromium.org/6451004/diff/6002/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/6451004/diff/6002/src/objects.cc#newcode1728
src/objects.cc:1728: return Heap::the_hole_value();
Can we do an output parameter called
Revision: 6686
Author: a...@chromium.org
Date: Tue Feb 8 10:46:13 2011
Log: Fix wrong assumption in parser that parsing a function literal cannot
throw an exception.
Review URL: http://codereview.chromium.org/6453009
http://code.google.com/p/v8/source/detail?r=6686
Added:
/branches/bleeding
Reviewers: antonm,
Description:
Fix wrong assumption in parser that parsing a function literal cannot throw
an
exception.
Please review this at http://codereview.chromium.org/6453009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/parser.cc
A test/m
LGTM, thanks!
http://codereview.chromium.org/6454011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6453009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Message:
Mads,
may you have a look?
I've added three bailout checks, but managed to test only the last one. I
can
hit the path of first check, but cannot make it fail. And I cannot hit the
path
of the second check. In any event, those bailouts shouldn't hurt (me
t
Revision: 6685
Author: a...@chromium.org
Date: Tue Feb 8 10:09:19 2011
Log: ARM: Fix condition usage in DeoptimizeIf().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6447003
http://code.google.com/p/v8/source/detail?r=6685
Modified:
/branches/bleeding_edge/src/arm/lithium-code
LGTM!
http://codereview.chromium.org/6447003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6684
Author: vego...@chromium.org
Date: Tue Feb 8 09:25:40 2011
Log: Check for overflow when bumping new space's top in inlined allocation.
BUG=v8:1109
TEST=test/mjsunit/regress/regress-1109.js
Review URL: http://codereview.chromium.org/6453005
http://code.google.com/p/v8/source/detai
Reviewers: Mads Ager,
Message:
ARM platform is OK, function calls are OK, ArgumentsAdapter is OK.
Description:
Fix a bug that occurs when functions are defined with more than 16,382
parameters.
Please review this at http://codereview.chromium.org/6447007/
SVN Base: http://v8.googlecode.com/svn
Test please?
http://codereview.chromium.org/6447007/diff/8/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
http://codereview.chromium.org/6447007/diff/8/src/x64/full-codegen-x64.cc#newcode302
src/x64/full-codegen-x64.cc:302: if (is_uint16(arguments_bytes)) {
You could make
Hi Danny,
I found your effort on integrating profiling into Node Inspector (the
v8-profiler package) -- looks great! Does it mean that in-memory
logging that V8 has is no more needed for you? We would like to
continue the cleanup (issue 859
http://code.google.com/p/v8/issues/detail?id=859).
--
v
Good catch! Thanks!
--
Vyacheslav Egorov
On Tue, Feb 8, 2011 at 5:53 PM, wrote:
> drive by comments
>
>
> http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
>
> http://codereview.chromium.org/6453005/diff/1/src/arm/macro-
I've got it, but test dies with SIGABORT (that's what our handler
does). And I cannot add it easily into test-api as I would need to
override the default callback. Any other ideas how I can tell our
test runner that it's fine to die with OOM?
And thanks a lot for review.
yours,
anton.
On Tue,
drive by comments
http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc#newcode1154
src/arm/macro-assembler-arm.cc:1154: b(cs, gc_required);
You need
Should there be a test?
http://codereview.chromium.org/6450005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6450005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, Søren Gjesse,
Message:
Guys,
may you have a look?
Description:
We cannot assert that v8 is running in fatal error callback.
BUG=v8:
Please review this at http://codereview.chromium.org/6450005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Revision: 6683
Author: a...@chromium.org
Date: Tue Feb 8 08:31:58 2011
Log: Fix issues with using defineProperty on the global proxy object.
Review URL: http://codereview.chromium.org/6452004
http://code.google.com/p/v8/source/detail?r=6683
Added:
/branches/bleeding_edge/test/mjsunit/regress/r
http://codereview.chromium.org/6452004/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/6452004/diff/1/test/cctest/test-api.cc#newcode12563
test/cctest/test-api.cc:12563: "{ configurable: true,
defineProperty: true, value: 3 });"
On 2011/02/
LGTM
http://codereview.chromium.org/6454004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Looks good to me.
http://codereview.chromium.org/6450004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6453005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/6452007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Rico,
Message:
Rico,
may you have a look?
Description:
Check if Array.prototype.__proto__ has been reset to null.
BUG=v8:1121
TEST=test/mjsunit/regress/regress-1121.js
Please review this at http://codereview.chromium.org/6454004/
SVN Base: https://v8.googlecode.com/svn/branches/bl
Revision: 6682
Author: kmilli...@chromium.org
Date: Tue Feb 8 07:51:49 2011
Log: Prepare for bailout with the proper state at labeled block entries.
The state here should be NO_REGISTERS. It was spuriously changed to from
NO_REGISTERS to TOS_REG when TOS_EAX was renamed to TOS_REG.
BUG=v8:1113
+fschneider
http://codereview.chromium.org/6452007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Prepare for bailout with the proper state at labeled block entries.
The state here should be NO_REGISTERS. It was spuriously changed to from
NO_REGISTERS to TOS_REG when TOS_EAX was renamed to TOS_REG.
BUG=v8:1113
Please review this at http://codereview.chro
Reviewers: Mads Ager,
Description:
Check for overflow when bumping new space's top in inlined allocation.
BUG=v8:1109
TEST=test/mjsunit/regress/regress-1109.js
Please review this at http://codereview.chromium.org/6453005/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affecte
Reviewers: Mads Ager, Lasse Reichstein,
Message:
Lasse and Mads,
another tiny review.
If you're fine with it, I'll bring to other ports.
Description:
Do sanity check of exception state when returning from native to JS.
If --debug-code is on, check that returned value and
Top::has_pending_ex
Revision: 6681
Author: ri...@chromium.org
Date: Tue Feb 8 06:37:50 2011
Log: x64: Add MulI and DivI to lithium instructions.
Review URL: http://codereview.chromium.org/6448001
http://code.google.com/p/v8/source/detail?r=6681
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-1117.js
Thanks a lot for comments.
http://codereview.chromium.org/6451004/diff/1/src/messages.cc
File src/messages.cc (right):
http://codereview.chromium.org/6451004/diff/1/src/messages.cc#newcode78
src/messages.cc:78: Factory::NewJSArrayWithElements(arguments_elements);
On 2011/02/08 14:17:56, Lasse R
Updates:
Status: Fixed
Comment #1 on issue 1120 by ri...@chromium.org: Object.isExtensible called
on the global object when this has been frozen returns true
http://code.google.com/p/v8/issues/detail?id=1120
Fixed in revision 6677
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
LGTM
http://codereview.chromium.org/6452004/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/6452004/diff/1/test/cctest/test-api.cc#newcode12563
test/cctest/test-api.cc:12563: "{ configurable: true,
defineProperty: true, value: 3 });"
a des
Reviewers: Vitaly,
Description:
[Isolates] Increase the isolate thread's stack size for tests.
Please review this at http://codereview.chromium.org/6452006/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/isolates
Affected files:
M samples/shell.cc
Index: samples/shell.cc
dif
LGTM.
http://codereview.chromium.org/6448001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6451004/diff/1/src/messages.cc
File src/messages.cc (right):
http://codereview.chromium.org/6451004/diff/1/src/messages.cc#newcode78
src/messages.cc:78: Factory::NewJSArrayWithElements(arguments_elements);
Is this fixing anything, or is it just a rewrite?
ht
Forgotten: changes to messages.cc are not mandatory, but I think it's
a minor improvement over previous version.
yours,
anton.
On Tue, Feb 8, 2011 at 5:05 PM, wrote:
> Reviewers: Mads Ager, Lasse Reichstein,
>
> Message:
> Lasse and Mads,
>
> may you have a look?
>
> And I'll send enough path w
Reviewers: Mads Ager, Lasse Reichstein,
Message:
Lasse and Mads,
may you have a look?
And I'll send enough path which adds checks in CEntry stub what return
value and
Top::pending_exception are consistent on coming back to JS code.
Description:
Propagate exceptions thrown when setting eleme
Revision: 6680
Author: l...@chromium.org
Date: Tue Feb 8 06:04:27 2011
Log: Correct propagation of exceptions from setters.
BUG=v8:1105
TEST=test/mjsunit/regress/regress-1105.js
Review URL: http://codereview.chromium.org/6451003
http://code.google.com/p/v8/source/detail?r=6680
Added:
/branche
Revision: 6679
Author: kmilli...@chromium.org
Date: Tue Feb 8 06:00:22 2011
Log: Fix a possible duplicate AST ID for deoptimization.
For redeclarations of variables that alias the parameters in functions
using arguments, we need to avoid re-visiting the shared variable
rewrite.
BUG=v8:1104
Rev
Reviewers: Rico,
Description:
Fix issues with using defineProperty on the global proxy object.
Please review this at http://codereview.chromium.org/6452004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
M test/cctest/test-api.cc
A test/mj
http://codereview.chromium.org/6451003/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6451003/diff/1/src/runtime.cc#newcode1093
src/runtime.cc:1093: if (result.is_null()) return Failure::Exception();
And yet, if we had done it here, we would have caught this mu
LGTM
http://codereview.chromium.org/6451003/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6451003/diff/1/src/runtime.cc#newcode1093
src/runtime.cc:1093: if (result.is_null()) return Failure::Exception();
I know we do not typically do it, so feel free to ignor
Revision: 6678
Author: whe...@chromium.org
Date: Tue Feb 8 05:28:09 2011
Log: Bailout from crankshaft if a global property is found in the prototype
chain of the global object, not on the global object itself.
Review URL: http://codereview.chromium.org/6449002
http://code.google.com/p/v8/sourc
Reviewers: Mads Ager, antonm,
Description:
Correct propagation of exceptions from setters.
BUG=v8:1105
TEST=test/mjsunit/regress/regress-1105.js
Please review this at http://codereview.chromium.org/6451003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32
Affected fi
Updates:
Owner: ant...@chromium.org
Comment #2 on issue 1121 by ri...@chromium.org: getOwnPropertyNames can
trigger "CHECK(object->IsJSObject()) failed"
http://code.google.com/p/v8/issues/detail?id=1121
signing this over to anton
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
LGTM.
http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode955
src/ia32/lithium-codegen-ia32.cc:955: __ Set(temp, Immediate(lower));
Hav
Updates:
Owner: ri...@chromium.org
Comment #1 on issue 1121 by ri...@chromium.org: getOwnPropertyNames can
trigger "CHECK(object->IsJSObject()) failed"
http://code.google.com/p/v8/issues/detail?id=1121
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegrou
Revision: 6677
Author: ri...@chromium.org
Date: Tue Feb 8 05:09:07 2011
Log: Make sure that we do not call is_extensible on the global proxy.
When calling Object.isExtensible we did not do a check for the global
js proxy. This caused the check on the extensible bit on the map to
return true, eve
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
src/runtime.cc:881: static MaybeObject*
Runtime_PreventExtensions(Arguments args) {
On 2011/02/08 13:04:22, Mads Ager wrote:
Do you n
Status: New
Owner:
New issue 1121 by jandemo...@gmail.com: getOwnPropertyNames can
trigger "CHECK(object->IsJSObject()) failed"
http://code.google.com/p/v8/issues/detail?id=1121
This snippet:
--
Array.prototype.__proto__ = null;
Object.getOwnPropertyNames([]);
--
Asserts (d8 debug build
And LGTM with that fixed.
On 2011/02/08 13:04:22, Mads Ager wrote:
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
src/runtime.cc:881: static MaybeObject*
Runtime_PreventExtensi
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881
src/runtime.cc:881: static MaybeObject*
Runtime_PreventExtensions(Arguments args) {
Do you need it here too?
http://codereview.chromi
Revision: 6676
Author: vego...@chromium.org
Date: Tue Feb 8 05:01:34 2011
Log: Speedup decodeURI/decodeURIComponent by switching from charAt(i) to
charCodeAt(i) in Decode.
Original patch by Alexander Karpinsky.
Review URL: http://codereview.chromium.org/6440001
http://code.google.com/p/v8/so
Reviewers: Mads Ager,
Description:
Make sure that we do not call is_extensible on the global proxy.
When calling Object.isExtensible we did not do a check for the global
js proxy. This caused the check on the extensible bit on the map to
return true, even when the bit was set to false on the glo
Status: Accepted
Owner: ri...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1120 by ri...@chromium.org: Object.isExtensible called on the
global object when this has been frozen returns true
http://code.google.com/p/v8/issues/detail?id=1120
We currently don't do a IsJSGlobalProxy ch
LGTM.
http://codereview.chromium.org/6449002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
Use TEST=v8:1104 in description to link the the V8 bug.
http://codereview.chromium.org/6453004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6675
Author: ri...@chromium.org
Date: Tue Feb 8 04:41:16 2011
Log: Make sure that we never call prevent extension on the global proxy,
but instead call this on the global object.
BUG: 1103
Review URL: http://codereview.chromium.org/6454001
http://code.google.com/p/v8/source/detail?r=6
Reviewers: Søren Gjesse,
Description:
Fix a possible duplicate AST ID for deoptimization.
For redeclarations of variables that alias the parameters in functions
using arguments, we need to avoid re-visiting the shared variable
rewrite.
BUG=1104
Please review this at http://codereview.chromium.
http://codereview.chromium.org/6454001/diff/2001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/6454001/diff/2001/src/objects.cc#newcode2784
src/objects.cc:2784: if (proto->IsNull()) return proto;
On 2011/02/08 12:25:35, Mads Ager wrote:
I don't think you should retu
LGTM
http://codereview.chromium.org/6454001/diff/2001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/6454001/diff/2001/src/objects.cc#newcode2784
src/objects.cc:2784: if (proto->IsNull()) return proto;
I don't think you should return the null prototype here? Shouldn'
Reviewers: fschneider,
Description:
Bailout from crankshaft if a global property is found in the prototype
chain of
the global object, not on the global object itself.
Please review this at http://codereview.chromium.org/6449002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Reviewers: Mads Ager,
Description:
Make sure that we never call prevent extension on the global proxy,
but instead call this on the global object.
BUG: 1103
Please review this at http://codereview.chromium.org/6454001/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected f
Reviewers: Mads Ager,
Description:
ARM: Fix condition usage in DeoptimizeIf().
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/6447003/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/lithium-codegen-arm.cc
Index: src/ar
Revision: 6674
Author: l...@chromium.org
Date: Tue Feb 8 03:38:15 2011
Log: Fix bug in JSON.parse for objects containing "__proto__" as key.
It added the __proto__ key as a normal key, which made it visible
in enumeration, while reading still hit the hard-coded accessor.
Review URL: http://code
LGTM
http://codereview.chromium.org/6451002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Fix bug in JSON.parse for objects containing "__proto__" as key.
It added the __proto__ key as a normal key, which made it visible
in enumeration, while reading still hit the hard-coded accessor.
Please review this at http://codereview.chromium.org/6451002/
S
Reviewers: William Hesse,
Description:
Change the code for materializing double constants on ia32.
Instead of using the stack, use a temporary integer register
and avoid memory access.
Please review this at http://codereview.chromium.org/6452002/
SVN Base: http://v8.googlecode.com/svn/branche
Revision: 6673
Author: whe...@chromium.org
Date: Tue Feb 8 03:26:42 2011
Log: X64 Crankshaft: Implement DoCodeStub on X64 platform.
Review URL: http://codereview.chromium.org/6451001
http://code.google.com/p/v8/source/detail?r=6673
Modified:
/branches/bleeding_edge/src/x64/lithium-codegen-x64.c
LGTM
http://codereview.chromium.org/6451001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Please take another look, added a regression test for the constant 0 right
operand with negative left value.
http://codereview.chromium.org/6448001/diff/4002/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/6448001/diff/4002/src/x64/lith
As discussed, the extra parameter to LCodeGen::CallCode and
LCodeGen::CallRuntime is transitional. Eventually it will be eliminated.
I'm aware that the Hydrogen call instructions are a mess. I'll be able to
clean them up, but first we need to remove the bogus uses of the arguments
at the call in
Revision: 6672
Author: fschnei...@chromium.org
Date: Tue Feb 8 02:45:21 2011
Log: Refactor lithium instructions for constants.
1. Remove unnecessary superlcass LConstant.
2. Use hydrogen accessor instead of duplicating the value.
Review URL: http://codereview.chromium.org/6410120
http://code.go
Reviewers: fschneider,
Description:
Allow esi to be an allocatable register on IA32.
Make esi available to the register allocator rather than dedicating it
permanently to the context.
The context is still passed in register esi to JavaScript and to the runtime
as part of the calling convention.
LGTM.
http://codereview.chromium.org/6410120/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (left):
http://codereview.chromium.org/6410120/diff/1/src/x64/lithium-x64.h#oldcode43
src/x64/lithium-x64.h:43: // Type hierarchy:
Yay!
http://codereview.chromium.org/6410120/
--
v8-dev mailin
Status: Accepted
Owner: ri...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1117 by ri...@chromium.org: When crankshaft is enabled we might
do wrong integer multiplication when the left operand is constant 0
http://code.google.com/p/v8/issues/detail?id=1117
This will reproduce the p
redirecting to Kevin.
http://codereview.chromium.org/6410120/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: Accepted
Owner: whe...@chromium.org
Labels: Type-Bug Priority-Medium HW-x64
New issue 1116 by whe...@chromium.org: Add StringCharAt stub to x64
http://code.google.com/p/v8/issues/detail?id=1116
Crankshaft expects a StringCharAt stub, and tries to use it. Add it to x64.
The StringCharAt
1 - 100 of 109 matches
Mail list logo
