LGTM
http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc#newcode3376
src/arm/full-codegen-arm.cc:3376: // (but "delete this" is).
Remove the parenthesis?
bu
Reviewers: Mads Ager,
Description:
ARM: Add support for just one string argument in the string add stub
Having a string add stub which can handle a string in just one of the
arguments
is essencial for the type recording binary operation stub when expecting
strings. Otherwise string added with
LGTM
http://codereview.chromium.org/6552001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
OK, LGTM
http://codereview.chromium.org/6551006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6877
Author: kmilli...@chromium.org
Date: Mon Feb 21 22:41:32 2011
Log: Fix presubmit failure.
TBR=a...@chromium.org
Review URL: http://codereview.chromium.org/6552001
http://code.google.com/p/v8/source/detail?r=6877
Modified:
/branches/bleeding_edge/src/hydrogen.cc
Reviewers: Mads Ager,
Description:
Fix presubmit failure.
TBR=a...@chromium.org
Please review this at http://codereview.chromium.org/6552001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src
Great! It's anecdotal but, parseInt(x, 10), parseInt(x) and Number(x) are by
far the most common forms I've seen in the wild.
On Tue, Feb 22, 2011 at 5:25 PM, Anders Sandholm wrote:
> Yes, I have a CL for parseInt. Just checking that there are no regressions.
> Will look into Number today CET.
>
Yes, I have a CL for parseInt. Just checking that there are no regressions.
Will look into Number today CET.
-Anders
On Tue, Feb 22, 2011 at 04:36, Ojan Vafai wrote:
> Is it not possible to apply similar optimizations for parseInt(..., 10)? I
> don't think the conversion methods below are commo
Revision: 6876
Author: kmilli...@chromium.org
Date: Mon Feb 21 22:25:01 2011
Log: Shorten live ranges for arguments to runtime calls.
Before, the live ranges of the arguments extended to the call itself, and
they were pushed immediately before the call. Now, they are spilled eagerly
as soon as t
On Mon, Feb 21, 2011 at 6:02 PM, wrote:
> http://codereview.chromium.org/6526047/diff/1/src/lithium.h#newcode540
> src/lithium.h:540: return op == NULL || op->IsConstantOperand() ||
> op->IsArgument();
> Just wondering: Was this already a problem before to have LArgument
> operands in the enumera
Is it not possible to apply similar optimizations for parseInt(..., 10)? I
don't think the conversion methods below are common knowledge and parseInt
is usually given the radix (e.g. Google's JS style guide requires it). If it
just optimized parseInt(x) and parseInt(x, 10), I think that would cover
3rd time's the charm ... hopefully. =)
http://codereview.chromium.org/6541044/diff/4003/src/heap.h
File src/heap.h (right):
http://codereview.chromium.org/6541044/diff/4003/src/heap.h#newcode2161
src/heap.h:2161: class PathTracer: public ObjectVisitor {
On 2011/02/21 18:08:28, Mikhail Naganov (
Revision: 6875
Author: mm...@chromium.org
Date: Mon Feb 21 17:10:28 2011
Log: Fix Xcode project.
TBR= a...@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6551006
http://code.google.com/p/v8/source/detail?r=6875
Modified:
/branches/bleeding_edge/tools/v8.xcodeproj/project.p
Reviewers: Mads Ager,
Message:
I need to increase priority on looking into the gyp thing... :(
Thanks!
Martin
Description:
Fix Xcode project.
TBR= a...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/6551006/
SVN Base: https://v8.googlecode.com/svn/branches/blee
Done. Thanks!
http://codereview.chromium.org/6523052/diff/7018/src/ic.cc
File src/ic.cc (right):
http://codereview.chromium.org/6523052/diff/7018/src/ic.cc#newcode441
src/ic.cc:441: JSFunction* function = JSFunction::cast(*callee);
On 2011/02/21 07:45:11, Mads Ager wrote:
Let's keep it all in
Revision: 6874
Author: mm...@chromium.org
Date: Mon Feb 21 16:39:21 2011
Log: CallIC and KeyedCallIC not wrapping this for strict mode functions.
Fix CallIC and KeyedCallIC to correctly use Handle.
Review URL: http://codereview.chromium.org/6523052
http://code.google.com/p/v8/source/detail?r=6874
Status: New
Owner:
New issue 1185 by holisme: (new Date()).getTimezoneOffset() returns 0 here
http://code.google.com/p/v8/issues/detail?id=1185
OS: linux debian/sid
Affected versions : 2.5.9.15, 3.0.12.22
scons options : library=shared soname=on snapshot=on shlibtype=hidden
os=linux arch=
Comment #3 on issue 1178 by erig...@google.com: new Function('var break =
1;'); crashes under debugger
http://code.google.com/p/v8/issues/detail?id=1178
See attachment.
Bizarrely, when I try it again in the d8 v2.3.9 shell, it is now working
for me too. I have no idea what changed since th
Reviewers: Mads Ager,
Message:
Mads,
another exception handling related review for you.
Description:
Properly reset external catcher if exception couldn't be externally caught.
We can wrongly assume that exception which is not intended to be caught
by external try/catch should be caught if thi
Reviewers: Mads Ager,
Message:
Fix for bug 1176. An invalid assumption in the assert.
http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc#newcode8238
src/ia32/codege
Revision: 6873
Author: ant...@chromium.org
Date: Mon Feb 21 10:28:20 2011
Log: Minor refactoring: unify lazy function compilation for in loop and no
in loop variants.
Review URL: http://codereview.chromium.org/6542017
http://code.google.com/p/v8/source/detail?r=6873
Modified:
/branches/bleed
Thanks a lot for review and suggestions, guys. Submitting
http://codereview.chromium.org/6542017/diff/1/src/handles.cc
File src/handles.cc (right):
http://codereview.chromium.org/6542017/diff/1/src/handles.cc#newcode859
src/handles.cc:859: return CompileLazyFunction(function, flag, false /*
in
Looks almost good, some more comments.
http://codereview.chromium.org/6541044/diff/4003/src/heap.h
File src/heap.h (right):
http://codereview.chromium.org/6541044/diff/4003/src/heap.h#newcode2161
src/heap.h:2161: class PathTracer: public ObjectVisitor {
nit: space needed after PathTracer
http:
I've addressed all your comments except for the one in heap.cc about using 2
constructors. Can you please provide some clarification on that (see my
response to the comment)? Thanks.
BTW, the unsigned int counter changes came from another CL when I svn up on
bleeding edge. They're not part of
Almost LGTM, let's do last round and I'll land it
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc#newcode1534
src/arm/simulator-arm.cc:1534: typedef v8::Handle
(*
Revision: 6872
Author: mikhail.naga...@gmail.com
Date: Mon Feb 21 09:17:26 2011
Log: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing
file.
Patch by Mark Lam from Hewlett-Packard Development Company, LP
Review URL: http://codereview.chromium.org/6543039
http://code.google.
I see a wrong change in platform-freebsd, but it's trivial to fix.
LGTM, I will land a corrected change.
http://codereview.chromium.org/6543039/diff/1010/src/platform-freebsd.cc
File src/platform-freebsd.cc (right):
http://codereview.chromium.org/6543039/diff/1010/src/platform-freebsd.cc#newco
LGTM.
http://codereview.chromium.org/6526047/diff/1/src/lithium.h
File src/lithium.h (right):
http://codereview.chromium.org/6526047/diff/1/src/lithium.h#newcode540
src/lithium.h:540: return op == NULL || op->IsConstantOperand() ||
op->IsArgument();
Just wondering: Was this already a problem be
Revision: 6871
Author: kmilli...@chromium.org
Date: Mon Feb 21 08:49:39 2011
Log: Change the baseline compiler to match the Hydrogen graph builder.
The Hydrogen graph translation does not build a branch for unary negation in
an effect context, so the baseline compiler should not do so either.
Re
LGTM.
http://codereview.chromium.org/6546050/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I adapted the changes to the other backends. Seems to work correctly,
although
we currently don't see much of a performance improvement.
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.or
Reviewers: William Hesse,
Description:
Change the baseline compiler to match the Hydrogen graph builder.
The Hydrogen graph translation does not build a branch for unary negation in
an effect context, so the baseline compiler should not do so either.
Please review this at http://codereview.chro
Reviewers: Erik Corry,
Description:
Basic implementation of incremental marking.
Based on classic tri-color abstraction (white --- not seen, grey --- seen
and in
the marking stack, black --- seen and scanned) with a write barrier that
transfers black objects to grey when we assign to white ob
Revision: 6870
Author: vego...@chromium.org
Date: Mon Feb 21 08:11:46 2011
Log: Heap::gc_count_, last_gc_count, and kGCsBetweenCleanup should be
unsigned
in order to not be vulnerable to overflow issues.
Patch by Mark Lam of Hewlett-Packard Development Company, LP
Review URL: http://coderevie
Revision: 6869
Author: a...@chromium.org
Date: Mon Feb 21 07:59:23 2011
Log: Implement pixel array elements access in the presence of an
interceptor that does not handle the elements load.
Review URL: http://codereview.chromium.org/6551001
http://code.google.com/p/v8/source/detail?r=6869
Modifie
LGTM
http://codereview.chromium.org/6551001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: Accepted
Owner: sgje...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1183 by sgje...@chromium.org: Exception "Object 44 has no
method 'round'" on http://dropzap.appspot.com
http://code.google.com/p/v8/issues/detail?id=1183
Navigate to http://dropzap.appspot.com in Chrome an
Context of this change: subgraphs are not buying us anything and they
complicate the implementation. I'm in the process of getting rid of them
completely.
On Mon, Feb 21, 2011 at 4:41 PM, wrote:
> Reviewers: Mads Ager,
>
>
> http://codereview.chromium.org/6541060/diff/4/src/hydrogen.cc
> File s
Reviewers: danno,
Description:
Implement pixel array elements access in the presence of an
interceptor that does not handle the elements load.
Please review this at http://codereview.chromium.org/6551001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ob
Reviewers: Mads Ager,
http://codereview.chromium.org/6541060/diff/4/src/hydrogen.cc
File src/hydrogen.cc (left):
http://codereview.chromium.org/6541060/diff/4/src/hydrogen.cc#oldcode529
src/hydrogen.cc:529: const ZoneList* infos =
break_continue_info();
Before, we kept this zone-allocated list
LGTM with the comment addressed.
http://codereview.chromium.org/5966001/diff/1/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/5966001/diff/1/src/heap.cc#newcode3763
src/heap.cc:3763: static unsigned int last_gc_count = gc_count_;
There is a bug here: last_gc_count will be
On 2011/02/21 10:37:56, Mikhail Naganov (Chromium) wrote:
http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc#newcode330
src/platform-linux.cc:330: FILE* file = fopen(name, "
Hmm, what does should_have_prototype mean here? Does it mean that the
function
should not initially have a prototype? Maybe the assert is wrong here and we
should allow setting the prototype (and getting it once set)?
http://codereview.chromium.org/6548008/
--
v8-dev mailing list
v8-dev@google
LGTM
http://codereview.chromium.org/6548008/diff/6/src/accessors.cc
File src/accessors.cc (right):
http://codereview.chromium.org/6548008/diff/6/src/accessors.cc#newcode470
src/accessors.cc:470: if (!function->should_have_prototype()) return
Heap::undefined_value();
Does the return value here h
Reviewers: Mads Ager,
Description:
Fix second half of issue 1151, the first change (r6765) only fixed
FunctionGetPrototype, not FunctionSetPrototype.
Please review this at http://codereview.chromium.org/6548008/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
Revision: 6868
Author: vego...@chromium.org
Date: Mon Feb 21 05:55:34 2011
Log: Fix bug in Heap::RecordWrites.
Review URL: http://codereview.chromium.org/6548007
http://code.google.com/p/v8/source/detail?r=6868
Modified:
/branches/experimental/gc/src/heap-inl.h
LGTM!
http://codereview.chromium.org/6548007/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
http://codereview.chromium.org/6548007/diff/1/src/heap-inl.h#newcode287
src/heap-inl.h:287: StoreBuffer::Mark(address + start + i*kPointerSize);
Spaces around '*'.
http://codereview.chromium.org/654
Reviewers: Mads Ager,
Description:
Fix bug in Heap::RecordWrites.
Please review this at http://codereview.chromium.org/6548007/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M src/heap-inl.h
Index: src/heap-inl.h
diff --git a/src/heap-inl.h b/src/heap-inl
Please have a look again. This version still only works for ARM EABI, but it
will fail with UNIMPLEMENTED instead of producing wrong results.
http://codereview.chromium.org/6532020/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/6532020/diff/1/s
Revision: 6867
Author: fschnei...@chromium.org
Date: Mon Feb 21 05:27:36 2011
Log: Fix broken build by removing more const qualifiers.
Review URL: http://codereview.chromium.org/6532085
http://code.google.com/p/v8/source/detail?r=6867
Modified:
/branches/bleeding_edge/src/hydrogen-instructions
LGTM, however I am wondering if it wouldn't be better to collect what we
need
instead of the deltas where we generate to little?
AddToMinRelocSizeForDeoptimization
min_reloc_size_for_deoptimization_
The call AddToMinRelocSizeForDeoptimization at all places where deopt will
have
to writ
LGTM.
http://codereview.chromium.org/6532085/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Kevin Millikin,
Description:
Fix broken build by removing more const qualifiers.
Please review this at http://codereview.chromium.org/6532085/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/hydrogen-instructions.h
M src/hydrogen-in
Yes I'm parsing values that are probably numbers, but could be other
things like strings. I had guessed that V8 might have been failing to
optimize if the radix was supplied. I'd suspect with parseInt people
would very often supply the radix as a constant, so perhaps this could
be included in the f
LGTM.
http://codereview.chromium.org/6548006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6488028/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse, Kevin Millikin,
Description:
Add more generic version of reloc info padding to ensure enough space for
reloc
patching during deoptimization (fixes issue 1174).
The old version only added extra space when we did indirect calls, but
the problem remains the same with nor
Revision: 6866
Author: fschnei...@chromium.org
Date: Mon Feb 21 04:05:17 2011
Log: Remove const qualifier in a few places in the hydrogen IR files.
This is a preparation step for a larger refactoring of the
hydrogen instructions.
Review URL: http://codereview.chromium.org/6542042
http://code.goo
Revision: 6865
Author: a...@chromium.org
Date: Mon Feb 21 03:58:19 2011
Log: Remove passing tests from ARM test expectations. Yay!
TBR=karlkl...@chromium.org
Review URL: http://codereview.chromium.org/6548006
http://code.google.com/p/v8/source/detail?r=6865
Modified:
/branches/bleeding_edge/te
Reviewers: Karl Klose,
Description:
Remove passing tests from ARM test expectations. Yay!
TBR=karlkl...@chromium.org
Please review this at http://codereview.chromium.org/6548006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/cctest.status
Ind
Revision: 6864
Author: a...@chromium.org
Date: Mon Feb 21 03:55:45 2011
Log: Remove passing tests from expectations. Yay!
Review URL: http://codereview.chromium.org/6488028
http://code.google.com/p/v8/source/detail?r=6864
Modified:
/branches/bleeding_edge/test/cctest/cctest.status
TBR
http://codereview.chromium.org/6488028/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Remove passing tests from expectations. Yay!
Please review this at http://codereview.chromium.org/6488028/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/cctest.status
Index: test/cctest/cctest.status
diff
LGTM.
http://codereview.chromium.org/6542042/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6863
Author: whe...@chromium.org
Date: Mon Feb 21 03:32:28 2011
Log: X64 Crankshaft: Add ModI and ModT to x64 optimizing compiler.
Review URL: http://codereview.chromium.org/6548005
http://code.google.com/p/v8/source/detail?r=6863
Modified:
/branches/bleeding_edge/src/x64/lithium-codeg
Reviewers: Kevin Millikin,
Message:
Sorry, it's a pretty boring cl - but easy to review.
Description:
Remove const qualifier in a few places in the hydrogen IR files.
This is a preparation step for a larger refactoring of the
hydrogen instructions.
Please review this at http://codereview.chro
Revision: 6862
Author: a...@chromium.org
Date: Mon Feb 21 03:29:45 2011
Log: Unifying the handling of storing and loading from safepoint stack
slots across architectures.
Review URL: http://codereview.chromium.org/6541051
http://code.google.com/p/v8/source/detail?r=6862
Modified:
/branches/blee
Status: New
Owner:
New issue 1181 by alexandr...@gmail.com: Bug in OSR on ARM
http://code.google.com/p/v8/issues/detail?id=1181
It looks like there is a bug in OSR on ARM. Sorry I haven't had time yet to
look into details too much.
Raytrace sometimes fails when OSR is on. (Tested on a T
LGTM
http://codereview.chromium.org/6548005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 6861
Author: vita...@chromium.org
Date: Mon Feb 21 03:27:25 2011
Log: [Isolates] Get the current heap from page header instead of Map field.
Review URL: http://codereview.chromium.org/6469079
http://code.google.com/p/v8/source/detail?r=6861
Modified:
/branches/experimental/isolates/in
LGTM
http://codereview.chromium.org/6469079/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
[Isolates] Get the current heap from page header instead of Map field.
Please review this at http://codereview.chromium.org/6469079/
Affected files:
M include/v8.h
M src/heap.cc
M src/objects-inl.h
M src/objects.h
M src/serialize.cc
Index: include/
LGTM, nice cleanup!
http://codereview.chromium.org/6541051/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Unifying the handling of storing and loading from safepoint stack
slots across architectures.
Please review this at http://codereview.chromium.org/6541051/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/code-stub
http://codereview.chromium.org/6541044/diff/1003/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/6541044/diff/1003/src/heap.cc#newcode5187
src/heap.cc:5187: if (search_for_any_global_) {
Using two version of the constructor instead of run-time assert will
look more clear.
h
Reviewers: Rico,
Description:
X64 Crankshaft: Add ModI and ModT to x64 optimizing compiler.
Please review this at http://codereview.chromium.org/6548005/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/lithium-codegen-x64.cc
M src/x64/lithiu
http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc#newcode330
src/platform-linux.cc:330: FILE* file = fopen(name, "a+");
I don't think "a+" is the right flag. If you plan to r
Revision: 6860
Author: karlkl...@chromium.org
Date: Mon Feb 21 02:30:25 2011
Log: ARM: Implement DoMathRound in the lithium code generator.
Review URL: http://codereview.chromium.org/6519051
http://code.google.com/p/v8/source/detail?r=6860
Modified:
/branches/bleeding_edge/src/arm/lithium-arm.c
Thanks Anton, Serya for your comments. Please review the latest patch.
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/simulator-arm.cc#newcode1534
src/arm/simulator-arm.cc:1534:
Math.floor should work fine - in general you can make use of the implicit
conversions of Javascript operations: Two additional options that may be
even faster come to my mind: bitwise-or and unary plus. Bitwise-or converts
its input to integer-32, unary plus converts to a number. Depending on what
Updates:
Status: PendingFurtherInfo
Comment #2 on issue 1178 by sgje...@chromium.org: new Function('var break =
1;'); crashes under debugger
http://code.google.com/p/v8/issues/detail?id=1178
I have not been able to reproduce this neither in Chrome 11 nor in the D8
shell. If I open t
LGTM
http://codereview.chromium.org/6519051/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
ARM: Implement DoMathRound in the lithium code generator.
Please review this at http://codereview.chromium.org/6519051/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-arm.cc
M src/arm/lithium-codegen-ar
Updates:
Status: Invalid
Comment #2 on issue 1179 by whe...@chromium.org: use multiprocessor
effectively, make parallel computing to serial
http://code.google.com/p/v8/issues/detail?id=1179
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http:
We have an optimization of parseInt that hits if people attempt to use
parseInt instead of Math.floor. That optimization only hits currently if you
do not pass in an explicit radix. Is your code using parseInt on numbers? If
so, please use Math.floor instead. :-)
Cheers,-- Mads
On Mon, Feb 21
Comment #1 on issue 1179 by whe...@chromium.org: use multiprocessor
effectively, make parallel computing to serial
http://code.google.com/p/v8/issues/detail?id=1179
Making multiple cores work effectively together is a fundamental problem of
computer science, and is not very easy. You need
Updates:
Status: Fixed
Comment #1 on issue 1047 by fschnei...@chromium.org: Port template lithium
instructions to ARM
http://code.google.com/p/v8/issues/detail?id=1047
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
Comment #5 on issue 1155 by holisme: ARM segfaults with (Math.pow(2,32) -
1)*1 the second time
http://code.google.com/p/v8/issues/detail?id=1155
i more or less expected some backport to the 3.0 branch...
i tried with gdb but stack is corrupted, so it's hard to find where it
crashes.
Any cl
Updates:
Status: WorkingAsIntended
Comment #4 on issue 1155 by a...@chromium.org: ARM segfaults with
(Math.pow(2,32) - 1)*1 the second time
http://code.google.com/p/v8/issues/detail?id=1155
Thanks, closing.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group
89 matches
Mail list logo