And I'll just land it for you to speed up the fix.
http://codereview.chromium.org/6771015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM (and sorry, that was my last-minute-change).
http://codereview.chromium.org/6771015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Fix conditional on sse2 support in CompileMathFloor
We should test that there is NO sse2 support and return undefined in
that case.
Please review this at http://codereview.chromium.org/6759021/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
LGTM
http://codereview.chromium.org/6777005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Rico,
Description:
Do not try to execute empty programs.
After failing to read a non-existing file, the shell tried to execute the
resulting empty program, which resulted in a null pointer dereference. This
patch avoids execution of empty programs.
Please review this at http://coder
Reviewers: Mads Ager,
Description:
Cleanup usage of HEAP and FACTORY in the cache stub compiler.
Please review this at http://codereview.chromium.org/6770011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/stub-cache-arm.cc
M src/ia32/stub-cache-i
Revision: 7419
Author: mm...@chromium.org
Date: Tue Mar 29 21:36:41 2011
Log: Fix xcode build warning in shell.cc
(out of order initialization).
BUG=
TEST=
Review URL: http://codereview.chromium.org/6772021
http://code.google.com/p/v8/source/detail?r=7419
Modified:
/branches/bleedin
LGTM
http://codereview.chromium.org/6772021/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly Repeshko, Dmitry Titov,
Message:
When building v8 shell with -Wall compiler reports:
In constructor ‘SourceGroup::IsolateThread::IsolateThread(SourceGroup*)’:
‘SourceGroup::IsolateThread::group_’ will be initialized after
base ‘v8::internal::Thread’ when initialized here
Chang
Comment #1 on issue 1290 by ero...@chromium.org: Date.toLocaleString()
returns invalid characters
http://code.google.com/p/v8/issues/detail?id=1290
Also see comment #10 on http://crbug.com/77610:
ACK, you get the effect when you convert UTF-8 to UTF-16 when the input
is in
fact windows-12
The basic support of the Assembler, Simulator, and Disassembler for the MIPS
port was recently updated, see
http://code.google.com/p/v8/source/detail?r=7388.
Regards,
Søren
On Tue, Mar 29, 2011 at 19:09, Alexandre Rames wrote:
> Hello Rémi,
>
> I originally started the MIPS port of v8 while work
Status: New
Owner:
CC: kasperl%chromium@gtempaccount.com
Labels: Type-Bug Priority-Medium
New issue 1290 by ero...@chromium.org: Date.toLocaleString() returns
invalid characters
http://code.google.com/p/v8/issues/detail?id=1290
The timezone portion of date strings is not showing up c
LGTM! Thanks Slava!
http://codereview.chromium.org/6731054/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Assigned
Owner: vego...@chromium.org
Comment #3 on issue 1270 by vego...@chromium.org: Failure on ARM hardware
after isolates landed
http://code.google.com/p/v8/issues/detail?id=1270
As Soren and Karl discovered this was caused by an evaluation order
depende
Reviewers: Mads Ager,
Description:
Fix a number of GC-unsafe evaluation order dependent places.
Also change places which are triggering false positive alert in our static
analysis tool.
Please review this at http://codereview.chromium.org/6731054/
SVN Base: http://v8.googlecode.com/svn/branch
Reviewers: Lasse Reichstein,
Message:
Build fails for me on Mac OS without internal:: qualification in
preparser-api.cc
Description:
Fixing build on Mac
BUG=
TEST=
Please review this at http://codereview.chromium.org/6771015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Af
Revision: 7418
Author: mm...@chromium.org
Date: Tue Mar 29 10:54:44 2011
Log: Fix gyp files for d8 console. Include build/gyp in .gitignore.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6765006
http://code.google.com/p/v8/source/detail?r=7418
Modified:
/branches/bleeding_ed
Hello Rémi,
I originally started the MIPS port of v8 while working for Sigma Design, so
I thought I would give you a few pointers.
I think the easiest way to start a port would be to go through the initial
commits for other architectures - MIPS especially.
I would say that the two main first step
On 29 March 2011 07:40, wrote:
> On 2011/03/29 06:18:55, Mads Ager wrote:
>>
>> On 2011/03/28 20:54:04, ry wrote:
>> > Can this be merged into the 3.1 branch?
>
>> Patch landed. Will merge to 3.1 branch.
>
> The 3.1 branch does not have isolates so it is not a clean merge. I can't
> test
> this,
Reviewers: William Hesse, lrn,
Message:
The previous fix ( http://codereview.chromium.org/6771007 ) didn't solved
this
bug (1286) completely. I fixed the CodeGenerator::EmitNamedStore() function
in
the same way.
Description:
Fix another x64 compilation error due to some dead code.
BUG=v8
Hello,
as part of my job, I began to port v8 to the sh4 architecture and so I
have two questions:
* I read the documentation but wasn't able to find any template of
target specific functions/files to implement (like a list of required
functions and class).
* Is their some non-mandatory parts (e
Reviewers: ,
Message:
I get the following build error since the preparser got into
SConscript/SConstruct (http://codereview.chromium.org/6772002):
g++ -o obj/release/preparser-api.o -c -Wall -Werror -W -Wno-unused-parameter
-Wnon-virtual-dtor -pedantic -m32 -O3 -fomit-frame-pointer -fdata-sectio
Revision: 7417
Author: fschnei...@chromium.org
Date: Tue Mar 29 08:19:42 2011
Log: Use a fixed input register where we require a byte register.
Currently we can't specify a set of registers as a register constraint.
This change forces a fixed register (eax) in places that need
a byte r
LGTM
http://codereview.chromium.org/6708109/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6708109/diff/3001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
http://codereview.chromium.org/6708109/diff/3001/src/x64/lithium-x64.cc#newcode1878
src/x64/lithium-x64.cc:1878: case kExternalPixelArray:
On 2011/03/29 14:25:34, danno wrote:
Doesn't pi
here you go...
http://codereview.chromium.org/6708109/diff/3001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
http://codereview.chromium.org/6708109/diff/3001/src/ia32/lithium-ia32.cc#newcode1922
src/ia32/lithium-ia32.cc:1922: val = UseFixed(instr->value(), eax);
Good catch. T
LGTM.
http://codereview.chromium.org/6771008/diff/1/src/type-info.cc
File src/type-info.cc (right):
http://codereview.chromium.org/6771008/diff/1/src/type-info.cc#newcode379
src/type-info.cc:379:
maybe AssertNoAllocation from here.
http://codereview.chromium.org/6771008/
--
v8-dev mailing lis
Revision: 7416
Author: a...@chromium.org
Date: Tue Mar 29 07:00:41 2011
Log: Remove redundant usages of some macros and functions in debug.cc
Cleanup of HEAP and FACTORY macros and use isolate_ member of classes where
it is possible.
Cleanup of debugger(), debug() and global_handles
LGTM, I will fix this comment and land.
http://codereview.chromium.org/6708108/diff/1/src/debug.cc
File src/debug.cc (right):
http://codereview.chromium.org/6708108/diff/1/src/debug.cc#newcode1038
src/debug.cc:1038: Factory* factory = Isolate::Current()->factory();
Use isolate_ here as well.
h
Reviewers: danno,
Description:
Use a fixed input register where we require a byte register.
Currently we can't specify a set of registers as a register constraint.
This change forces a fixed register (eax) in places that need
a byte register.
BUG=77752
Please review this at http://codereview.c
Comment #3 on issue 1277 by evadef...@gmail.com: Build failure on Win7/x64
with VS2010
http://code.google.com/p/v8/issues/detail?id=1277
Oh, right---thanks, and sorry for the noise. I'll check bleeding_edge next
time before creating an issue...
--
v8-dev mailing list
v8-dev@googlegroups.c
Revision: 7415
Author: a...@chromium.org
Date: Tue Mar 29 06:41:06 2011
Log: Cleanup of HEAP and LOGGER macro usage in cpu-profiler.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6708101
http://code.google.com/p/v8/source/detail?r=7415
Modified:
/branches/bleeding
LGTM
http://codereview.chromium.org/6708101/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc#newcode163
src/preparser-api.cc:163: : JavaScriptScanner(&scanner_constants_),
scanner_constants_() { }
Yeah, it's a bit iffy.
LGTM.
On Tue, Mar 29, 2011 at 3:11 PM, wrote:
> Reviewers: Kasper Lund,
>
> Description:
> Decrease number of runs in mjsunit/compiler/pic.js (Test still gets
> optimized,
> even without --stress-opt)
>
> Please review this at http://codereview.chromium.org/6731049/
>
> SVN Base: http://v8.googl
Revision: 7414
Author: ri...@chromium.org
Date: Tue Mar 29 06:20:05 2011
Log: Decrease number of runs in mjsunit/compiler/pic.js (Test still
gets optimized, even without --stress-opt)
Review URL: http://codereview.chromium.org/6731049
http://code.google.com/p/v8/source/detail?r=7414
TBR: kasperl
http://codereview.chromium.org/6731049/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Kasper Lund,
Description:
Decrease number of runs in mjsunit/compiler/pic.js (Test still gets
optimized,
even without --stress-opt)
Please review this at http://codereview.chromium.org/6731049/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M
Revision: 7413
Author: l...@chromium.org
Date: Tue Mar 29 06:06:48 2011
Log: Make the preparser standalone library and process build in debug
mode.
It should now be possible to build the preparser using 'scons preparser' in
both release and debug modes.
Remove v8.h include from s
Revision: 7412
Author: mikhail.naga...@gmail.com
Date: Tue Mar 29 05:52:07 2011
Log: Remove snapshots-related code that is implemented in DevTools
heap profiler.
Diffs and retaining paths are implemented on JS side. There is no need
to maintain native implementation.
R=vita...@chro
LGTM! (I hope nobody was using the API.)
http://codereview.chromium.org/6770009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ,
Description:
Remove redundant usages of some macros and functions in debug.cc
Cleanup of HEAP and FACTORY macros and use isolate_ member of classes where
it
is possible.
Cleanup of debugger(), debug() and global_handles() functions.
Pass the isolate pointer to the HandleScope con
Reviewers: Vitaly Repeshko,
Description:
Remove snapshots-related code that is implemented in DevTools heap profiler.
Diffs and retaining paths are implemented on JS side. There is no need
to maintain native implementation.
R=vita...@chromium.org
BUG=none
TEST=none
Please review this at http:
LGTM
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc#newcode163
src/preparser-api.cc:163: : JavaScriptScanner(&scanner_constants_),
scanner_constants_() { }
This passes a poi
Reviewers: fschneider,
Description:
Reduce handle usage in type-info.cc PopulateMap.
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/6771008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/type-info.h
M src/type-info.cc
Ind
Reviewers: Vitaly Repeshko,
Description:
Make the preparser standalone library and process build in debug mode.
It should now be possible to build the preparser using 'scons preparser' in
both
release and debug modes.
Remove v8.h include from scanner-base.h and other files.
Remove NativeAlloc
LGTM
http://codereview.chromium.org/6718041/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6539006/diff/2001/SConstruct
File SConstruct (right):
http://codereview.chromium.org/6539006/diff/2001/SConstruct#newcode696
SConstruct:696: version = subprocess.Popen([env['CC'], '-dumpversion'],
should not we just rely on env['CCVERSION'] instead of guessing it
m
Comment #1 on issue 1289 by skyli...@chromium.org: Overwriting toString
member of objects can lead to NULL pointers when object is used as argument
to a method
http://code.google.com/p/v8/issues/detail?id=1289
@anton: I'd like to see if I can fix this, but I'll need some help to
familiari
Status: Accepted
Owner: skyli...@chromium.org
CC: ant...@google.com
Labels: Type-Bug Priority-Medium
New issue 1289 by skyli...@chromium.org: Overwriting toString member of
objects can lead to NULL pointers when object is used as argument to a
method
http://code.google.com/p/v8/issues/detail
Revision: 7411
Author: fschnei...@chromium.org
Date: Tue Mar 29 04:03:16 2011
Log: Tagging version 3.2.5.1
http://code.google.com/p/v8/source/detail?r=7411
Added:
/tags/3.2.5.1
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7410
Author: fschnei...@chromium.org
Date: Tue Mar 29 04:00:56 2011
Log: Merge r7408 from bleeding edge.
BUG=77654
Review URL: http://codereview.chromium.org/6708103
http://code.google.com/p/v8/source/detail?r=7410
Modified:
/trunk/src/ia32/lithium-ia32.cc
/trunk/src/versi
Comment #3 on issue 1285 by edy.b...@gmail.com: Compilation failure on
OpenSuSE 11.3
http://code.google.com/p/v8/issues/detail?id=1285
I've found out that it does not matter if it's a shared or static library,
and that the flag "-fno-strict-aliasing" can fix the problem (actually, the
oth
Revision: 7409
Author: kmilli...@chromium.org
Date: Tue Mar 29 03:57:43 2011
Log: [Arguments] Support setting properties on dictionary arguments.
Support setting properties that are not aliased by the parameters and that
are in a dictionary backing store. This required teaching the fu
LGTM
http://codereview.chromium.org/6708103/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Merge r7408 from bleeding edge.
BUG=77654
Please review this at http://codereview.chromium.org/6708103/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/ia32/lithium-ia32.cc
M src/version.cc
Index: src/ia32/lithium-ia32.cc
==
Updates:
Status: Fixed
Comment #6 on issue 1286 by whe...@chromium.org: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
Fixed in revision r7407.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/g
Revision: 7408
Author: fschnei...@chromium.org
Date: Tue Mar 29 03:51:35 2011
Log: Fix null-pointer dereference in the compiler when running without
sse3 support.
BUG=77654
Review URL: http://codereview.chromium.org/6731046
http://code.google.com/p/v8/source/detail?r=7408
Modified:
LGTM
http://codereview.chromium.org/6773005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7407
Author: whe...@chromium.org
Date: Tue Mar 29 03:48:28 2011
Log: Fix x64 compilation error due to some dead code, by deleting the
dead code.
BUG=1286
TEST=compile V8 with gcc-4.4.x.
Review URL: http://codereview.chromium.org/6771007
http://code.google.com/p/v8/source/
LGTM
http://codereview.chromium.org/6731046/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Fix null-pointer dereference in the compiler when running without sse3
support.
BUG=77654
Please review this at http://codereview.chromium.org/6731046/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/lithium
Reviewers: Mads Ager,
Description:
[Arguments] Support setting properties on dictionary arguments.
Support setting properties that are not aliased by the parameters and that
are in a dictionary backing store. This required teaching the function
ShouldConvertToFastElements about non-strict argum
LGTM
http://codereview.chromium.org/6771007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6771007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Message:
A tiny review for you.
Description:
Fix x64 compilation error due to some dead code, by deleting the dead code.
BUG=1286
TEST=compile V8 with gcc-4.4.x.
Please review this at http://codereview.chromium.org/6771007/
SVN Base: https://v8.googlecode.com/sv
Updates:
Owner: whe...@chromium.org
Labels: Type-Bug HW-x64 Priority-High
Comment #5 on issue 1286 by whe...@chromium.org: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
The failing code is dead code. r12 is n
Updates:
Status: Duplicate
Mergedinto: 1286
Comment #2 on issue 1288 by a...@chromium.org: V8 x64 compilation error
http://code.google.com/p/v8/issues/detail?id=1288
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com
Comment #4 on issue 1286 by a...@chromium.org: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
Issue 1288 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #2 on issue 1285 by edy.b...@gmail.com: Compilation failure on
OpenSuSE 11.3
http://code.google.com/p/v8/issues/detail?id=1285
Also, just updated to OpenSuSE 11.4 and I'm having the same problem.
Worth mentioning is that sample=shell won't automagically use the built
version of v8.
Comment #1 on issue 1288 by cey...@gmail.com: V8 x64 compilation error
http://code.google.com/p/v8/issues/detail?id=1288
this report is duplicated:
https://code.google.com/p/v8/issues/detail?id=1286
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7406
Author: erik.co...@gmail.com
Date: Tue Mar 29 02:35:57 2011
Log: Change the incremental marking speed-up-to-make-progress
heuristic so
that the speed is not reset on a scavenge. Also tune the constants and
add some explanation. Increase max heap size on IA32.
Review
Status: New
Owner:
New issue 1288 by angelo.d...@gmail.com: V8 x64 compilation error
http://code.google.com/p/v8/issues/detail?id=1288
While compiling V8 (with arch=x64) I got this compilation error.
g++ -o obj/release/x64/codegen-x64.o -c -fPIC -Wall -Werror -W
-Wno-unused-parameter -W
LGTM
http://codereview.chromium.org/6773004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7405
Author: kmilli...@chromium.org
Date: Tue Mar 29 02:32:29 2011
Log: [Arguments] Clean up some tests to reflect changing expectations.
R=a...@chromium.org
Review URL: http://codereview.chromium.org/6770003
http://code.google.com/p/v8/source/detail?r=7405
Added:
/branche
Reviewers: Vyacheslav Egorov,
Description:
Change the incremental marking speed-up-to-make-progress heuristic so
that the speed is not reset on a scavenge. Also tune the constants and
add some explanation. Increase max heap size on IA32.
Please review this at http://codereview.chromium.org/677
Revision: 7404
Author: l...@chromium.org
Date: Tue Mar 29 02:21:25 2011
Log: Introduce scons target to build preparser libraray and
proof-of-concept command line process.
The target doesn't compile yet, due to v8 dependencies introduced by
isolates.
Review URL: http://codereview
Updates:
Status: Fixed
Comment #1 on issue 1287 by mikhail@gmail.com: "tick" records contain
an extra field (unneeded comma)
http://code.google.com/p/v8/issues/detail?id=1287
Fixed in http://code.google.com/p/v8/source/detail?r=7403
--
v8-dev mailing list
v8-dev@googlegroups.com
Revision: 7403
Author: mikhail.naga...@gmail.com
Date: Tue Mar 29 02:18:08 2011
Log: Remove an extra comma from "tick" log records.
This fixes VM state fetching from "tick" log records.
TBR=vita...@chromium.org
BUG=1287
TEST=none
Review URL: http://codereview.chromium.org/6718041
htt
Reviewers: ,
Description:
Cleanup of HEAP and LOGGER macro usage in cpu-profiler.cc.
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/6708101/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/cpu-profiler.cc
Index: src/cpu-profi
Comment #3 on issue 1286 by cey...@gmail.com: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
It is a compiler warning. If you remove the -Werror directive everything
will compile correctly. Also it is a warning due the optim
Status: Accepted
Owner: mikhail@gmail.com
Labels: Type-Bug Priority-Medium
New issue 1287 by mikhail@gmail.com: "tick" records contain an extra
field (unneeded comma)
http://code.google.com/p/v8/issues/detail?id=1287
E.g. in this record:
tick,0x934ff28e,0xbfffe99c,,0,0x934ff1ed,0,0x4
LGTM
http://codereview.chromium.org/6772002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6770003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Introduce scons target to build preparser libraray and proof-of-concept
command
line process.
The target doesn't compile yet, due to v8 dependencies introduced by
isolates.
Please review this at http://codereview.chromium.org/6772002/
SVN Base: http
Comment #2 on issue 1286 by pva...@inf.u-szeged.hu: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
The problem is same with the -fno-strict-aliasing flag.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.c
regress/regress-900066.js is a rename of bugs/bug-900066.js.
On Tue, Mar 29, 2011 at 10:51 AM, wrote:
> Reviewers: Mads Ager,
>
> Description:
> [Arguments] Clean up some tests to reflect changing expectations.
>
> R=a...@chromium.org
>
>
> Please review this at http://codereview.chromium.org/67
Reviewers: Mads Ager,
Description:
[Arguments] Clean up some tests to reflect changing expectations.
R=a...@chromium.org
Please review this at http://codereview.chromium.org/6770003/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/arguments
Affected files:
M test/mjsunit/debu
Comment #1 on issue 1286 by erik.co...@gmail.com: V8 compile fails with
arch=x64 on 64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
This may be a strict aliasing bug.
What happens when you add -fnostrict-aliasing to the flags?
--
v8-dev mailing list
v8-dev@go
LGTM
http://codereview.chromium.org/6765006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #1 on issue 1280 by a...@chromium.org: thread_local is a c++0x
keyword
http://code.google.com/p/v8/issues/detail?id=1280
Renamed. Thanks.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7402
Author: a...@chromium.org
Date: Tue Mar 29 01:04:26 2011
Log: Rename local variable in api.cc to avoid using C++0x keyword
thread_local.
Also, the name thread_local did not make much sense.
R=karlkl...@chromium.org
BUG=1280
Review URL: http://codereview.chromium.org
LGTM
http://codereview.chromium.org/6771003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: New
Owner:
New issue 1286 by pva...@inf.u-szeged.hu: V8 compile fails with arch=x64 on
64bit platform with gcc-4.5.2
http://code.google.com/p/v8/issues/detail?id=1286
When I try to compile V8 with "scons arch=x64" I get the following error:
g++ -o obj/release/x64/codegen-x64.o -c
Reviewers: Karl Klose,
Description:
Rename local variable in api.cc to avoid using C++0x keyword thread_local.
Also, the name thread_local did not make much sense.
R=karlkl...@chromium.org
BUG=1280
Please review this at http://codereview.chromium.org/6771003/
SVN Base: https://v8.googlecode.
Revision: 7401
Author: kmilli...@chromium.org
Date: Tue Mar 29 00:56:46 2011
Log: [Arguments] Support stores to fast-mode non-strict arguments
elements.
Support stores to the elements that are not aliased by the parameters, if
the backing store is a fast one. This required teaching
http://codereview.chromium.org/6739004/diff/1/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/6739004/diff/1/src/objects.cc#newcode3076
src/objects.cc:3076: ASSERT(HasDictionaryElements());
On 2011/03/29 07:40:17, Mads Ager wrote:
On 2011/03/28 15:48:01, Kevin Milliki
Revision: 7400
Author: l...@chromium.org
Date: Tue Mar 29 00:53:33 2011
Log: Fix reference to masm_ after delete in RegExpMacroAssemblerX64.
BUG=77633
Review URL: http://codereview.chromium.org/6771002
http://code.google.com/p/v8/source/detail?r=7400
Modified:
/branches/bleeding_edg
LGTM
http://codereview.chromium.org/6771002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7399
Author: sgje...@chromium.org
Date: Tue Mar 29 00:43:27 2011
Log: ARM: Check for minus zero when converting binary operation result
to smi
The result of an Int32 binary operation will be converted to a smi if it
fits. However a minus zero check was missing.
BUG=v8:
1 - 100 of 106 matches
Mail list logo
