LGTM, consider adding a regression test for this
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc#newcode3400
src/heap.cc:3400: maybe_elem =
Fits on one line
http://codereview.chromium.org/749701
Added reviewers.
http://codereview.chromium.org/7516001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #5 on issue 1541 by ri...@chromium.org: 3.4.10 build fails on OSX
http://code.google.com/p/v8/issues/detail?id=1541
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Labels: ES5
Comment #14 on issue 1547 by ri...@chromium.org: Wrong global in
cross-frame this-coercion
http://code.google.com/p/v8/issues/detail?id=1547
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8
Reviewers: danno, fschneider,
Description:
Use type info for the ToBoolean translation in crankshaft.
To do this, the Branch instruction needs to carry around a temporary
register,
but only when the crankshafted code will make a map access. When the
crankshafted code sees an object of a type
Reviewers: Kasper Lund, fschneider,
Description:
tighten invariants of HValue::InferRange
* src/hydrogen-instructions.cc (HValue::InferRange): Only mark values
with int32 representation as never being -0. Always return a non-NULL
value; callers should check for representation().IsNone() if
Feedback addressed, please take another quick look, since there were a few
minor
additional tweaks to get rid of all the problems.
I'll see if there is an easy way to add a regression test in a separate CL.
http://codereview.chromium.org/7497010/diff/2001/src/heap.cc
File src/heap.cc (right):
LGTM
http://codereview.chromium.org/7497010/diff/5001/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/7497010/diff/5001/src/runtime.cc#newcode223
src/runtime.cc:223: case JSObject::EXTERNAL_PIXEL_ELEMENTS:
default: last?
http://codereview.chromium.org/7497010/
--
v8
Updates:
Status: Accepted
Comment #1 on issue 1572 by fschnei...@chromium.org: timeout in
regress-crbug-84186
http://code.google.com/p/v8/issues/detail?id=1572
Yes, this is indeed a problem. I can also reproduce it. It only occurs when
running without snapshots.
--
v8-dev mailing
Reviewers: Rico, antonm,
Message:
PTAL.
It's probably best to start with objects.h for the definition of
SlicedString
and go from there.
I haven't implemented generated code for creating substrings yet. Slices can
only be created in the runtime system for now. I just adapted a lot of other
t
Reviewers: Vitaly Repeshko, Sven,
Message:
This is an attempt to fix the safepoint problem with the ToBoolean stub. It
would be nice to have a regression test, but I fear, it may not easy to
create
one.
Description:
Record safepoint at calls ToBooleanStub.
This fixes the issues when GC happe
Updates:
Status: Assigned
Owner: whe...@chromium.org
Comment #2 on issue 1572 by fschnei...@chromium.org: timeout in
regress-crbug-84186
http://code.google.com/p/v8/issues/detail?id=1572
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
+VItalyr who did a lot of string work.
First round of comments.
http://codereview.chromium.org/7477045/diff/1/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/7477045/diff/1/src/heap.cc#newcode2687
src/heap.cc:2687: WriteBarrierMode mode =
sliced_string->GetWriteBarrierMode
Made a few changes according to Anton's suggestions.
http://codereview.chromium.org/7477045/diff/6002/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/7477045/diff/6002/src/heap.cc#newcode2691
src/heap.cc:2691: sliced_string->set_parent(cons->first());
There is no second par
Redirecting because of vacation. Bill, can you have a look?
Is any of this actually ARM specific? It doesn't look that way. If it is
not,
please port to the other architectures as well.
http://codereview.chromium.org/7489045/diff/1/src/arm/constants-arm.h
File src/arm/constants-arm.h (right)
Almost looks good. Two questions. Don't we need CallRuntimeSaveDoubles in
the
stub itself? Is there are a deep reason why ARM is taking the argument in a
register and other platforms on the stack?
-- Vitaly
http://codereview.chromium.org/7465066/
--
v8-dev mailing list
v8-dev@googlegroups.co
Reviewers: fschneider,
Description:
Ensure that a string is flattened when entering JsonParser::ParseJson.
Fixes
issue v8:1572.
BUG=v8:1572
TEST=mjsunit/regress/regress-crbug-l84186.js
Please review this at http://codereview.chromium.org/7480044/
SVN Base: https://v8.googlecode.com/svn/b
http://codereview.chromium.org/7477045/diff/6002/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/7477045/diff/6002/src/arm/code-stubs-arm.cc#newcode4804
src/arm/code-stubs-arm.cc:4804: __ tst(result_,
Operand(kStringRepresentationMask));
Do we hav
About ARM version: I don't know the reason for the different calling
convention. Historic relict?
Den 27. jul. 2011 15.09 skrev :
> Almost looks good. Two questions. Don't we need CallRuntimeSaveDoubles in
> the
> stub itself? Is there are a deep reason why ARM is taking the argument in a
> regis
LGTM.
http://codereview.chromium.org/7480044/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
New approach. As discussed we just don't invoke a stub that does patching.
http://codereview.chromium.org/7465066/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 8746
Author: whe...@chromium.org
Date: Wed Jul 27 07:34:59 2011
Log: Ensure that a string is flattened when entering
JsonParser::ParseJson. Fixes issue v8:1572.
BUG=v8:1572
TEST=mjsunit/regress/regress-crbug-l84186.js
Review URL: http://codereview.chromium.org/7480044
ht
LGTM with a tiny stylistic change
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h
File src/code-stubs.h (right):
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h#newcode938
src/code-stubs.h:938: static Types all_types() { return
Types(kAllTypes); }
Removing kA
LGTM
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h
File src/code-stubs.h (right):
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h#newcode924
src/code-stubs.h:924: bool IsEmpty() const { return set_.IsEmpty(); }
Maybe add IsAll()?
http://codereview.chromium
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h
File src/code-stubs.h (right):
http://codereview.chromium.org/7465066/diff/5002/src/code-stubs.h#newcode924
src/code-stubs.h:924: bool IsEmpty() const { return set_.IsEmpty(); }
On 2011/07/27 14:49:38, Vitaly Repeshko wrote:
Mayb
Updates:
Status: Fixed
Comment #3 on issue 1572 by whe...@chromium.org: timeout in
regress-crbug-84186
http://code.google.com/p/v8/issues/detail?id=1572
Json.parse was not always flattening a cons string before parsing it,
leading to O(n^2) behavior. Fixed in change r8746
--
v8-d
Revision: 8747
Author: fschnei...@chromium.org
Date: Wed Jul 27 07:56:36 2011
Log: Record safepoint at calls ToBooleanStub.
This fixes the issues when GC happens when invoking
ToBooleanStub.
Review URL: http://codereview.chromium.org/7465066
http://code.google.com/p/v8/source/detail?r=
Revision: 8748
Author: da...@chromium.org
Date: Wed Jul 27 08:08:50 2011
Log: Fix FixedDoubleArray crashes in chromebot
R=ri...@chromium.org
BUG=non
TEST=running urls from reliability bots
Review URL: http://codereview.chromium.org/7497010
http://code.google.com/p/v8/source/detail?r=8
LGTM
http://codereview.chromium.org/7477047/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
There's an issue with string externalization. We can't rely on parent
staying a
sequential string. It may be externalized and change its encoding. This
makes
slices similar to conses, we have to check the parent's type separately.
I don't think we want to prohibit externalization of parents.
Revision: 8749
Author: da...@chromium.org
Date: Wed Jul 27 08:29:02 2011
Log: Re-activate unboxed double arrays by default.
R=svenpa...@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7477047
http://code.google.com/p/v8/source/detail?r=8749
Modified:
/bran
Reviewers: Sven,
Description:
Re-activate unboxed double arrays by default.
R=svenpa...@chromium.org
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/7477047/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
In
http://codereview.chromium.org/7385006/diff/7003/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/7385006/diff/7003/src/objects.cc#newcode11772
src/objects.cc:11772: MaybeObject* maybe_hash = key->GetIdentityHash();
On 2011/07/26 22:30:23, Michael Starzinger wrote:
On
Reviewers: fschneider, Kevin Millikin,
Description:
use a worklist in HGraph::InsertRepresentationChanges
* src/hydrogen.cc (HGraph::InsertRepresentationChanges): Use a worklist
instead of a change flag, as suggested in a comment.
BUG=
TEST=test suite passes
Please review this at http://cod
www.moonstartravels.com
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
The last set of patches is bigger than expected because of changing the base
class. Also the testcase is more comprehensive. But it should be much
cleaner
now. Sorry for the review-overhead, I am still trying to get to know the
codebase. :)
http://codereview.chromium.org/7385006/diff/7003/src
Status: New
Owner:
New issue 1573 by bradley@gmail.com: There should be a
Debug::DisableAgent to match Debug::EnableAgent
http://code.google.com/p/v8/issues/detail?id=1573
We have a long lived Node process that sometimes we want to enable a
debugger on but want to disable it after
Status: New
Owner:
New issue 1574 by bradley@gmail.com: Debugger should have a way to mark
scripts as non-public
http://code.google.com/p/v8/issues/detail?id=1574
Working with v8 we preload some bootstraps and would like a way to prevent
some scripts from being accessed through the
Reviewers: danno,
Description:
Prepare push to trunk. Now working on 3.5.2.
Please review this at http://codereview.chromium.org/7522015/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: ChangeLog
=
http://codereview.chromium.org/7477045/diff/6002/src/objects.h
File src/objects.h (right):
http://codereview.chromium.org/7477045/diff/6002/src/objects.h#newcode524
src/objects.h:524: SLICED_SYMBOL_TYPE = kTwoByteStringTag | kSymbolTag |
kSlicedStringTag,
On 2011/07/27 14:04:49, antonm wrote:
D
40 matches
Mail list logo
