[v8-dev] Issue 1707 in v8: NewGC: test-heap/GrowAndShrinkNewSpace times out

2011-09-21 Thread codesite-noreply
Status: Accepted Owner: mstarzin...@chromium.org Labels: Type-Bug Priority-Medium newgc New issue 1707 by erik.corry: NewGC: test-heap/GrowAndShrinkNewSpace times out http://code.google.com/p/v8/issues/detail?id=1707 Disabled in test/cctest/cctest.status -- v8-dev mailing list

[v8-dev] Re: Issue 1703 in v8: Update String.split implementation to conform to ES5 standard

2011-09-21 Thread codesite-noreply
Updates: Status: WorkingAsIntended Comment #1 on issue 1703 by yang...@chromium.org: Update String.split implementation to conform to ES5 standard http://code.google.com/p/v8/issues/detail?id=1703 The tests in http://stevenlevithan.com/demo/split.cfm work perfectly fine in Chrome.

[v8-dev] Disable some tests while we hunt for the reasons behind them. (issue 7978022)

2011-09-21 Thread erik . corry
Reviewers: danno, Description: Disable some tests while we hunt for the reasons behind them. Please review this at http://codereview.chromium.org/7978022/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/spaces.cc M test/cctest/cctest.status M

[v8-dev] [v8] r9350 committed - Disable some tests while we hunt for the reasons behind them....

2011-09-21 Thread codesite-noreply
Revision: 9350 Author: erik.co...@gmail.com Date: Wed Sep 21 00:25:33 2011 Log: Disable some tests while we hunt for the reasons behind them. Review URL: http://codereview.chromium.org/7978022 http://code.google.com/p/v8/source/detail?r=9350 Modified:

[v8-dev] Re: Disable some tests while we hunt for the reasons behind them. (issue 7978022)

2011-09-21 Thread danno
lgtm http://codereview.chromium.org/7978022/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1672 in v8: NewGC: Page live bytes are off for some tests

2011-09-21 Thread codesite-noreply
Comment #4 on issue 1672 by erik.corry: NewGC: Page live bytes are off for some tests http://code.google.com/p/v8/issues/detail?id=1672 The assert was disabled in r9350. Search for TODO(1672) in spaces.cc to see where it should go. -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 1701 in v8: NewGC: array-join is flaky

2011-09-21 Thread codesite-noreply
Comment #1 on issue 1701 by erik.corry: NewGC: array-join is flaky http://code.google.com/p/v8/issues/detail?id=1701 The test has been temporarily disabled in test/cctest/cctest.status -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1705 in v8: Debugger protocol: excessively large backtrace response

2011-09-21 Thread codesite-noreply
Comment #1 on issue 1705 by yang...@chromium.org: Debugger protocol: excessively large backtrace response http://code.google.com/p/v8/issues/detail?id=1705 There is currently no way to limit the response size. But then this begs the question how a large response should be handled. A JSON

[v8-dev] Fixed alignment problem when generating code for builtins. (issue 7978023)

2011-09-21 Thread svenpanne
Reviewers: danno, Description: Fixed alignment problem when generating code for builtins. This is not perfect, but it should fix the problem at hand. We should really clean up the memory handling responsibilities for the (macro)assemblers. Please review this at

[v8-dev] Re: Issue 1707 in v8: NewGC: test-heap/GrowAndShrinkNewSpace times out

2011-09-21 Thread codesite-noreply
Updates: Labels: -Priority-Medium Priority-Critical Comment #1 on issue 1707 by da...@chromium.org: NewGC: test-heap/GrowAndShrinkNewSpace times out http://code.google.com/p/v8/issues/detail?id=1707 (No comment was entered for this change.) -- v8-dev mailing list

[v8-dev] Re: Issue 761 in v8: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions

2011-09-21 Thread codesite-noreply
Comment #19 on issue 761 by shrivast...@gmail.com: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions http://code.google.com/p/v8/issues/detail?id=761 Problem is even if we send data in exact javascript string format converting all non BMP characters to

[v8-dev] Re: Fixed alignment problem when generating code for builtins. (issue 7978023)

2011-09-21 Thread danno
lgtm http://codereview.chromium.org/7978023/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1706 in v8: v8 crashes on ARM cpus that do not allow unaligned accesses (

2011-09-21 Thread codesite-noreply
Updates: Status: Accepted Owner: svenpa...@chromium.org Comment #4 on issue 1706 by svenpa...@chromium.org: v8 crashes on ARM cpus that do not allow unaligned accesses ( http://code.google.com/p/v8/issues/detail?id=1706 (No comment was entered for this change.) -- v8-dev

[v8-dev] Issue 1708 in v8: MarkWordToObjectStarts encountered consecutive one-bits.

2011-09-21 Thread codesite-noreply
Status: Accepted Owner: mstarzin...@chromium.org Labels: Type-Bug Priority-Critical NewGC New issue 1708 by mstarzin...@chromium.org: MarkWordToObjectStarts encountered consecutive one-bits. http://code.google.com/p/v8/issues/detail?id=1708 Several sites (e.g. http://24ur.com/) trigger an

[v8-dev] Re: Issue 1291 in v8: V8 does not compile with GCC 4.6 (various compiler warnings)

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #17 on issue 1291 by svenpa...@chromium.org: V8 does not compile with GCC 4.6 (various compiler warnings) http://code.google.com/p/v8/issues/detail?id=1291 The current v8 compiles with GCCs up to 4.6.1. Using the GCC from HEAD (upcoming 4.7.0) almost

[v8-dev] [v8] r9351 committed - Fixed alignment problem when generating code for builtins....

2011-09-21 Thread codesite-noreply
Revision: 9351 Author: svenpa...@chromium.org Date: Wed Sep 21 00:59:28 2011 Log: Fixed alignment problem when generating code for builtins. This is not perfect, but it should fix the problem at hand. We should really clean up the memory handling responsibilities for the

[v8-dev] Re: Issue 1706 in v8: v8 crashes on ARM cpus that do not allow unaligned accesses (

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #5 on issue 1706 by svenpa...@chromium.org: v8 crashes on ARM cpus that do not allow unaligned accesses ( http://code.google.com/p/v8/issues/detail?id=1706 Hopefully fixed in r9351, but we currently don't have a good way to test this. If the problem

[v8-dev] Re: Issue 1708 in v8: MarkWordToObjectStarts encountered consecutive one-bits.

2011-09-21 Thread codesite-noreply
Comment #1 on issue 1708 by svenpa...@chromium.org: MarkWordToObjectStarts encountered consecutive one-bits. http://code.google.com/p/v8/issues/detail?id=1708 Just another data point: A different assertion in the same method can be triggered very reliably by visiting

[v8-dev] Re: Issue 761 in v8: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions

2011-09-21 Thread codesite-noreply
Comment #20 on issue 761 by l...@chromium.org: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions http://code.google.com/p/v8/issues/detail?id=761 I've been reading up on websockets, and splitting into surrogate pairs before sending it from the server is

[v8-dev] Issue 1709 in v8: Crash in mjsunit/array-constructor

2011-09-21 Thread codesite-noreply
Status: Accepted Owner: CC: fschnei...@chromium.org, vego...@chromium.org, erik.corry Labels: Type-Bug Priority-Medium New issue 1709 by fschnei...@chromium.org: Crash in mjsunit/array-constructor http://code.google.com/p/v8/issues/detail?id=1709 It seems flaky. Here is the failure

[v8-dev] Merge r9337 to the 3.5 branch. (issue 7981021)

2011-09-21 Thread fschneider
Reviewers: Kevin Millikin, Description: Merge r9337 to the 3.5 branch. Fix a bug with uninitialized const variables in the optimizing compiler. BUG=96989 Original code review: http://codereview.chromium.org/7974009/ Please review this at http://codereview.chromium.org/7981021/ SVN Base:

[v8-dev] Re: Merge r9337 to the 3.5 branch. (issue 7981021)

2011-09-21 Thread kmillikin
lgtm http://codereview.chromium.org/7981021/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 839 in v8: Implementation of the arguments object does not follow the spec

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #7 on issue 839 by kmilli...@chromium.org: Implementation of the arguments object does not follow the spec http://code.google.com/p/v8/issues/detail?id=839 Yes, this is fixed. We expect V8 to be fully ES5 spec compliant with respect to the arguments

[v8-dev] Merge r9337 to the 3.4 branch. (issue 7983030)

2011-09-21 Thread fschneider
Reviewers: Kevin Millikin, Description: Merge r9337 to the 3.4 branch. Fix a bug with uninitialized const variables in the optimizing compiler. BUG=96989 Original code review: http://codereview.chromium.org/7974009/ Please review this at http://codereview.chromium.org/7983030/ SVN Base:

[v8-dev] [v8] r9352 committed - Merge r9337 to the 3.5 branch....

2011-09-21 Thread codesite-noreply
Revision: 9352 Author: fschnei...@chromium.org Date: Wed Sep 21 01:38:23 2011 Log: Merge r9337 to the 3.5 branch. Fix a bug with uninitialized const variables in the optimizing compiler. BUG=96989 Original code review: http://codereview.chromium.org/7974009/ Review URL:

[v8-dev] Re: Merge r9337 to the 3.4 branch. (issue 7983030)

2011-09-21 Thread kmillikin
lgtm http://codereview.chromium.org/7983030/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] API: Added Debug::DisableAgent to match existing Debug::EnableAgent (issue 7978025)

2011-09-21 Thread yangguo
Reviewers: Sven, Message: I came across this issue when looking through some debugger related stuff. This one is really easy. Test cases already exist. Description: API: Added Debug::DisableAgent to match existing Debug::EnableAgent BUG=v8:1573 TEST=cctest test-debug/TestDebuggerAgent

[v8-dev] Re: Issue 1669 in v8: LowMemoryNotify isn't as effective as it should be.

2011-09-21 Thread codesite-noreply
Updates: Status: Assigned Owner: u...@chromium.org Comment #5 on issue 1669 by da...@chromium.org: LowMemoryNotify isn't as effective as it should be. http://code.google.com/p/v8/issues/detail?id=1669 (No comment was entered for this change.) -- v8-dev mailing list

[v8-dev] Re: Issue 1458 in v8: NewGC: Do meaningful work on idle notifications.

2011-09-21 Thread codesite-noreply
Updates: Owner: u...@chromium.org Comment #4 on issue 1458 by da...@chromium.org: NewGC: Do meaningful work on idle notifications. http://code.google.com/p/v8/issues/detail?id=1458 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [v8] r9353 committed - Tagging version 3.5.10.11

2011-09-21 Thread codesite-noreply
Revision: 9353 Author: fschnei...@chromium.org Date: Wed Sep 21 01:46:18 2011 Log: Tagging version 3.5.10.11 http://code.google.com/p/v8/source/detail?r=9353 Added: /tags/3.5.10.11 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r9354 committed - Merge r9337 to the 3.4 branch....

2011-09-21 Thread codesite-noreply
Revision: 9354 Author: fschnei...@chromium.org Date: Wed Sep 21 01:47:07 2011 Log: Merge r9337 to the 3.4 branch. Fix a bug with uninitialized const variables in the optimizing compiler. BUG=96989 Original code review: http://codereview.chromium.org/7974009/ Review URL:

[v8-dev] [v8] r9355 committed - Tagging version 3.4.14.23

2011-09-21 Thread codesite-noreply
Revision: 9355 Author: fschnei...@chromium.org Date: Wed Sep 21 01:49:19 2011 Log: Tagging version 3.4.14.23 http://code.google.com/p/v8/source/detail?r=9355 Added: /tags/3.4.14.23 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix pre-parsing function declarations. (issue 7983006)

2011-09-21 Thread keuchel
Reviewers: Lasse Reichstein, Message: PTAL. Description: Fix pre-parsing function declarations. The preparser has been out of sync with the parser. As a reminder, we have the following grammer for harmony mode Block :: { SourceElement* } SourceElement :: Statement

[v8-dev] [v8] r9356 committed - Reapply Clean up Context::Lookup and its uses....

2011-09-21 Thread codesite-noreply
Revision: 9356 Author: kmilli...@chromium.org Date: Wed Sep 21 01:51:44 2011 Log: Reapply Clean up Context::Lookup and its uses. The threading test failures seem to be due to a GC-unsafe place, that mixed handles and raw pointers, in the runtime code for context lookup.

[v8-dev] [v8] r9357 committed - Fix build....

2011-09-21 Thread codesite-noreply
Revision: 9357 Author: kmilli...@chromium.org Date: Wed Sep 21 02:04:44 2011 Log: Fix build. Last minute cleanup lost a '*'. TBR=ri...@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7977020 http://code.google.com/p/v8/source/detail?r=9357 Modified:

[v8-dev] Re: Issue 1709 in v8: NewGC: Crash in mjsunit/array-constructor

2011-09-21 Thread codesite-noreply
Updates: Summary: NewGC: Crash in mjsunit/array-constructor Labels: NewGC Comment #1 on issue 1709 by vego...@chromium.org: NewGC: Crash in mjsunit/array-constructor http://code.google.com/p/v8/issues/detail?id=1709 This was fixed in r9345. -- v8-dev mailing list

[v8-dev] Fwd: [chromium-dev] PSA: Request to show your username in bug comments

2011-09-21 Thread Kevin Millikin
Just a reminder: the Chromium 'policy' is that committers are encouraged to turn off address hiding in Google Code's profile settings. -- Forwarded message -- From: Mark Larson (Google) m...@chromium.org Date: Fri, Jun 3, 2011 at 6:14 AM Subject: [chromium-dev] PSA: Request to

[v8-dev] Fix GC hazard. (issue 7977021)

2011-09-21 Thread rossberg
Reviewers: Jakob, Description: Fix GC hazard. R=jkumme...@chromium.org BUG=v8:1698 TEST= Please review this at http://codereview.chromium.org/7977021/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/objects.cc M test/mjsunit/mjsunit.status Index:

[v8-dev] Re: Fix GC hazard. (issue 7977021)

2011-09-21 Thread jkummerow
LGTM http://codereview.chromium.org/7977021/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r9358 committed - Fix GC hazard....

2011-09-21 Thread codesite-noreply
Revision: 9358 Author: rossb...@chromium.org Date: Wed Sep 21 02:58:40 2011 Log: Fix GC hazard. R=jkumme...@chromium.org BUG=v8:1698 TEST= Review URL: http://codereview.chromium.org/7977021 http://code.google.com/p/v8/source/detail?r=9358 Modified:

[v8-dev] Issue 1710 in v8: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Status: New Owner: New issue 1710 by wi...@igalia.com: stepping- / debugging-related crashes in the test suite http://code.google.com/p/v8/issues/detail?id=1710 In bleeding_edge, I'm getting some crashes in the test suite: === release debug-step-stub-callfunction === Path:

[v8-dev] Re: Issue 1710 in v8: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Comment #1 on issue 1710 by wi...@igalia.com: stepping- / debugging-related crashes in the test suite http://code.google.com/p/v8/issues/detail?id=1710 A backtrace for the stepin-builtin: Starting program: /home/wingo/src/v8/d8 --stress-opt --always-opt --expose-debug-as debug

[v8-dev] Issue 1711 in v8: String.prototype.split should execute spec-defined steps in order

2011-09-21 Thread codesite-noreply
Status: New Owner: New issue 1711 by bever...@google.com: String.prototype.split should execute spec-defined steps in order http://code.google.com/p/v8/issues/detail?id=1711 Given the following code: 'hello'.split({ toString: function() { alert('foo'); return 'e'; }}, 0);

[v8-dev] Re: Fix pre-parsing function declarations. (issue 7983006)

2011-09-21 Thread lrn
LGTM http://codereview.chromium.org/7983006/diff/1/src/preparser.cc File src/preparser.cc (right): http://codereview.chromium.org/7983006/diff/1/src/preparser.cc#newcode396 src/preparser.cc:396: return ParseStatement(CHECK_OK); CHECK_OK - ok We won't be checking the result after the return

[v8-dev] Re: Make heap iterable in PrepareForBreakPoints. (issue 7977004)

2011-09-21 Thread vegorov
Please review Erik. http://codereview.chromium.org/7977004/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1710 in v8: NewGC: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Updates: Summary: NewGC: stepping- / debugging-related crashes in the test suite Status: Assigned Owner: vego...@chromium.org Labels: Type-Bug Priority-Critical NewGC Comment #2 on issue 1710 by vego...@chromium.org: NewGC: stepping- / debugging-related crashes

[v8-dev] Re: Issue 1703 in v8: Update String.split implementation to conform to ES5 standard

2011-09-21 Thread codesite-noreply
Comment #2 on issue 1703 by bever...@google.com: Update String.split implementation to conform to ES5 standard http://code.google.com/p/v8/issues/detail?id=1703 See http://code.google.com/p/v8/issues/detail?id=1711 for more information; sorry, I missed this one. -- v8-dev mailing list

[v8-dev] Re: Make heap iterable in PrepareForBreakPoints. (issue 7977004)

2011-09-21 Thread ricow
LGTM http://codereview.chromium.org/7977004/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1710 in v8: NewGC: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Comment #3 on issue 1710 by wi...@igalia.com: NewGC: stepping- / debugging-related crashes in the test suite http://code.google.com/p/v8/issues/detail?id=1710 No prob, I'm just back from vacation and wanted to get in on the NewGC fun :) I'll try again when that patch lands. -- v8-dev

[v8-dev] Re: SemiSpace::AssertValidRange should use NewSpacePage::FromLimit for start. (issue 7979019)

2011-09-21 Thread lrn
LGTM http://codereview.chromium.org/7979019/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix d8 GYP build on 3.4 branch (issue 7978026)

2011-09-21 Thread sgjesse
Reviewers: Jakob, Description: Fix d8 GYP build on 3.4 branch R=jkumme...@chromium.org Please review this at http://codereview.chromium.org/7978026/ SVN Base: http://v8.googlecode.com/svn/branches/3.4/ Affected files: M src/d8.gyp M src/version.cc Index: src/d8.gyp

[v8-dev] Re: Fix d8 GYP build on 3.4 branch (issue 7978026)

2011-09-21 Thread kasperl
LGTM. http://codereview.chromium.org/7978026/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Fix d8 GYP build on 3.4 branch (issue 7978026)

2011-09-21 Thread jkummerow
LGTM as well. http://codereview.chromium.org/7978026/diff/1/src/d8.gyp File src/d8.gyp (right): http://codereview.chromium.org/7978026/diff/1/src/d8.gyp#newcode1 src/d8.gyp:1: # Copyright 2010 the V8 project authors. All rights reserved. nit: 2011 (if you care, I don't)

[v8-dev] [v8] r9359 committed - Fix d8 GYP build on 3.4 branch...

2011-09-21 Thread codesite-noreply
Revision: 9359 Author: sgje...@chromium.org Date: Wed Sep 21 04:15:49 2011 Log: Fix d8 GYP build on 3.4 branch R=jkumme...@chromium.org Review URL: http://codereview.chromium.org/7978026 http://code.google.com/p/v8/source/detail?r=9359 Modified: /branches/3.4/src/d8.gyp

[v8-dev] Re: Fix d8 GYP build on 3.4 branch (issue 7978026)

2011-09-21 Thread sgjesse
http://codereview.chromium.org/7978026/diff/1/src/d8.gyp File src/d8.gyp (right): http://codereview.chromium.org/7978026/diff/1/src/d8.gyp#newcode1 src/d8.gyp:1: # Copyright 2010 the V8 project authors. All rights reserved. On 2011/09/21 11:14:54, Jakob wrote: nit: 2011 (if you care, I don't)

[v8-dev] [v8] r9360 committed - Make heap iterable in PrepareForBreakPoints....

2011-09-21 Thread codesite-noreply
Revision: 9360 Author: vego...@chromium.org Date: Wed Sep 21 04:20:05 2011 Log: Make heap iterable in PrepareForBreakPoints. When aborting incremental marking with compaction discard all slots collected on evacuation candidates. R=ri...@chromium.org BUG=v8:1700

[v8-dev] Re: API: Added Debug::DisableAgent to match existing Debug::EnableAgent (issue 7978025)

2011-09-21 Thread svenpanne
lgtm http://codereview.chromium.org/7978025/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1709 in v8: NewGC: Crash in mjsunit/array-constructor

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #2 on issue 1709 by vego...@chromium.org: NewGC: Crash in mjsunit/array-constructor http://code.google.com/p/v8/issues/detail?id=1709 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 1710 in v8: NewGC: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #4 on issue 1710 by vego...@chromium.org: NewGC: stepping- / debugging-related crashes in the test suite http://code.google.com/p/v8/issues/detail?id=1710 I've landed the CL. Does it still crash for you? -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [v8] r9361 committed - API: Added Debug::DisableAgent to match existing Debug::EnableAgent...

2011-09-21 Thread codesite-noreply
Revision: 9361 Author: yang...@chromium.org Date: Wed Sep 21 04:34:05 2011 Log: API: Added Debug::DisableAgent to match existing Debug::EnableAgent BUG=v8:1573 TEST=cctest test-debug/TestDebuggerAgent Review URL: http://codereview.chromium.org/7978025

[v8-dev] Re: Issue 1573 in v8: There should be a Debug::DisableAgent to match Debug::EnableAgent

2011-09-21 Thread codesite-noreply
Comment #4 on issue 1573 by yang...@chromium.org: There should be a Debug::DisableAgent to match Debug::EnableAgent http://code.google.com/p/v8/issues/detail?id=1573 Done in r9361. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 1573 in v8: There should be a Debug::DisableAgent to match Debug::EnableAgent

2011-09-21 Thread codesite-noreply
Updates: Status: Fixed Comment #5 on issue 1573 by yang...@chromium.org: There should be a Debug::DisableAgent to match Debug::EnableAgent http://code.google.com/p/v8/issues/detail?id=1573 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Issue 1712 in v8: Assert in test mozilla/js1_5/Regress/regress-360969-05

2011-09-21 Thread codesite-noreply
Status: Accepted Owner: vego...@chromium.org CC: fschnei...@chromium.org Labels: Type-Bug Priority-Medium New issue 1712 by fschnei...@chromium.org: Assert in test mozilla/js1_5/Regress/regress-360969-05 http://code.google.com/p/v8/issues/detail?id=1712 === debug mozilla regress-360969-05

[v8-dev] [v8] r9362 committed - SemiSpace::AssertValidRange should use NewSpacePage::FromLimit for sta...

2011-09-21 Thread codesite-noreply
Revision: 9362 Author: vego...@chromium.org Date: Wed Sep 21 04:42:48 2011 Log: SemiSpace::AssertValidRange should use NewSpacePage::FromLimit for start. Otherwise we get the wrong page when start == limit. R=l...@chromium.org Review URL: http://codereview.chromium.org/7979019

[v8-dev] Re: Issue 761 in v8: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions

2011-09-21 Thread codesite-noreply
Comment #21 on issue 761 by shrivast...@gmail.com: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions http://code.google.com/p/v8/issues/detail?id=761 That is what our default implementation everything is sent utf8 encoded from native server over

[v8-dev] Issue 1713 in v8: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together.

2011-09-21 Thread codesite-noreply
Status: Accepted Owner: vego...@chromium.org Labels: Type-Bug Priority-High New issue 1713 by erik.corry: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together. http://code.google.com/p/v8/issues/detail?id=1713 When we lazily deopt, we overwrite the code

[v8-dev] Re: Fix pre-parsing function declarations. (issue 7983006)

2011-09-21 Thread keuchel
http://codereview.chromium.org/7983006/diff/1/src/preparser.cc File src/preparser.cc (right): http://codereview.chromium.org/7983006/diff/1/src/preparser.cc#newcode394 src/preparser.cc:394: (!strict_mode() || !expr.AsIdentifier().IsFutureReserved())) { While we are already here. This check is

[v8-dev] Re: Issue 1713 in v8: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together.

2011-09-21 Thread codesite-noreply
Updates: Cc: mstarzin...@chromium.org Comment #1 on issue 1713 by da...@chromium.org: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together. http://code.google.com/p/v8/issues/detail?id=1713 (No comment was entered for this change.) -- v8-dev

[v8-dev] [v8] r9363 committed - Fix pre-parsing function declarations....

2011-09-21 Thread codesite-noreply
Revision: 9363 Author: keuc...@chromium.org Date: Wed Sep 21 05:27:07 2011 Log: Fix pre-parsing function declarations. The preparser has been out of sync with the parser. As a reminder, we have the following grammer for harmony mode Block :: { SourceElement* } SourceElement

[v8-dev] [v8] r9364 committed - Fix and test use of property descriptor objects....

2011-09-21 Thread codesite-noreply
Revision: 9364 Author: rossb...@chromium.org Date: Wed Sep 21 05:45:51 2011 Log: Fix and test use of property descriptor objects. R=kmilli...@chromium.org BUG=v8:1543 TEST= Review URL: http://codereview.chromium.org/7828080 http://code.google.com/p/v8/source/detail?r=9364 Modified:

[v8-dev] Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread sgjesse
Reviewers: Yang, Description: Turn on d8 interactive debugging before running files passed on the command line If the file test.js contains: function f() { debugger; } f() Then running $ d8 --debugger test.js will now hit the breakpoint in f which it would not before.

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread yangguo
LGTM except for the shared library build. http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261 src/d8.cc:1261: if (i::FLAG_debugger options.last_run) { This breaks the shared library build. Putting

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread kasperl
Nit: http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257 src/d8.cc:1257: // Keep using the same context in the interactive shell Terminate comment with . http://codereview.chromium.org/7981023/ --

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread kasperl
http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261 src/d8.cc:1261: if (i::FLAG_debugger options.last_run) { options.last_run will be true here, right? http://codereview.chromium.org/7981023/ --

[v8-dev] [v8] r9365 committed - Landing for mi...@chromium.org: Add an optional source length field to...

2011-09-21 Thread codesite-noreply
Revision: 9365 Author: fschnei...@chromium.org Date: Wed Sep 21 06:28:09 2011 Log: Landing for mi...@chromium.org: Add an optional source length field to the Extension constructor. Original code review: http://codereview.chromium.org/7889046/ Review URL:

[v8-dev] Re: Add an optional source length field to the Extension constructor. (issue 7889046)

2011-09-21 Thread Florian Schneider
Landed in r9365. Den 21. sep. 2011 07.38 skrev Florian Schneider fschnei...@chromium.org: Sure, I'll land it. Den 20. sep. 2011 19.19 skrev mi...@chromium.org: On 2011/09/20 10:40:56, fschneider wrote: LGTM. Thanks, Florian. Will you please submit? (I'm also pressing the commit button

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread sgjesse
http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257 src/d8.cc:1257: // Keep using the same context in the interactive shell On 2011/09/21 13:14:49, Kasper Lund wrote: Terminate comment with .

[v8-dev] [v8] r9366 committed - Turn on d8 interactive debugging before running files passed on the co...

2011-09-21 Thread codesite-noreply
Revision: 9366 Author: sgje...@chromium.org Date: Wed Sep 21 06:42:25 2011 Log: Turn on d8 interactive debugging before running files passed on the command line If the file test.js contains: function f() { debugger; } f() Then running $ d8 --debugger test.js will now hit

[v8-dev] Re: Issue 1713 in v8: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together.

2011-09-21 Thread codesite-noreply
Comment #2 on issue 1713 by mstarzin...@chromium.org: NewGC: http://www.maisfutebol.iol.pt/ Lazy deopt and compaction do not play well together. http://code.google.com/p/v8/issues/detail?id=1713 Just because I got it in GDB by accident while trying to trigger other crashes, here is a

[v8-dev] Turn on d8 interactive debugging before running files passed on the command line (issue 7977022)

2011-09-21 Thread sgjesse
Reviewers: Yang, Description: Turn on d8 interactive debugging before running files passed on the command line Merge of r9366 from bleeding edge. R=yang...@chromium.org Please review this at http://codereview.chromium.org/7977022/ SVN Base: http://v8.googlecode.com/svn/branches/3.4/

[v8-dev] Turn on d8 interactive debugging before running files passed on the command line (issue 7982027)

2011-09-21 Thread sgjesse
Reviewers: Yang, Description: Turn on d8 interactive debugging before running files passed on the command line Merge of r9366 from bleeding edge. R=yang...@chromium.org Please review this at http://codereview.chromium.org/7982027/ SVN Base: http://v8.googlecode.com/svn/branches/3.5/

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7977022)

2011-09-21 Thread yangguo
On 2011/09/21 14:02:19, Søren Gjesse wrote: LGTM. http://codereview.chromium.org/7977022/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7982027)

2011-09-21 Thread yangguo
On 2011/09/21 14:02:29, Søren Gjesse wrote: LGTM. http://codereview.chromium.org/7982027/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r9367 committed - Turn on d8 interactive debugging before running files passed on the co...

2011-09-21 Thread codesite-noreply
Revision: 9367 Author: sgje...@chromium.org Date: Wed Sep 21 07:08:56 2011 Log: Turn on d8 interactive debugging before running files passed on the command line Merge of r9366 from bleeding edge. R=yang...@chromium.org Review URL: http://codereview.chromium.org/7982027

[v8-dev] Re: Fix broken Windows build. (issue 7983033)

2011-09-21 Thread vegorov
LGTM http://codereview.chromium.org/7983033/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7983033/diff/1/test/cctest/test-api.cc#newcode4319 test/cctest/test-api.cc:4319: v8::RegisterExtension(new Extension(extension_name.start(), This test

[v8-dev] [v8] r9368 committed - Turn on d8 interactive debugging before running files passed on the co...

2011-09-21 Thread codesite-noreply
Revision: 9368 Author: sgje...@chromium.org Date: Wed Sep 21 07:11:49 2011 Log: Turn on d8 interactive debugging before running files passed on the command line Merge of r9366 from bleeding edge. R=yang...@chromium.org Review URL: http://codereview.chromium.org/7977022

[v8-dev] Re: Basic support for tracking smi-only arrays on ia32. (issue 7901016)

2011-09-21 Thread danno
I addressed all the feedback, and made sure that x64 and arm also build and run with --smi-only-arrays off. Please review again. http://codereview.chromium.org/7901016/diff/4001/src/bootstrapper.cc File src/bootstrapper.cc (right):

[v8-dev] [v8] r9369 committed - Fix broken Windows build....

2011-09-21 Thread codesite-noreply
Revision: 9369 Author: fschnei...@chromium.org Date: Wed Sep 21 07:42:50 2011 Log: Fix broken Windows build. Review URL: http://codereview.chromium.org/7983033 http://code.google.com/p/v8/source/detail?r=9369 Modified: /branches/bleeding_edge/test/cctest/test-api.cc

[v8-dev] Re: Basic support for tracking smi-only arrays on ia32. (issue 7901016)

2011-09-21 Thread yangguo
I already had a look at the platform-specific code when porting. http://codereview.chromium.org/7901016/diff/28079/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/7901016/diff/28079/src/ia32/full-codegen-ia32.cc#newcode1490

[v8-dev] [v8] r9370 committed - Reorganize object type enum, such that proxies are no longer in the mi...

2011-09-21 Thread codesite-noreply
Revision: 9370 Author: rossb...@chromium.org Date: Wed Sep 21 07:46:54 2011 Log: Reorganize object type enum, such that proxies are no longer in the middle of the range of proper JS objects. Unfortunately, callable types no longer form a range now. However, there are only two

[v8-dev] Issue 1714 in v8: Early ReferenceErrors on assignments to non-reference LHSs

2011-09-21 Thread codesite-noreply
Status: New Owner: keuc...@chromium.org Labels: Type-Bug Priority-Low ES5 New issue 1714 by keuc...@chromium.org: Early ReferenceErrors on assignments to non-reference LHSs http://code.google.com/p/v8/issues/detail?id=1714 ES5 clause 16 states the following An implementation must treat any

[v8-dev] Re: Issue 1705 in v8: Debugger protocol: excessively large backtrace response

2011-09-21 Thread codesite-noreply
Comment #2 on issue 1705 by sc...@skysheet.com: Debugger protocol: excessively large backtrace response http://code.google.com/p/v8/issues/detail?id=1705 The debugger agent already has mechanisms by which it reduces response size, such as omitting refs for nested object properties. Perhaps

[v8-dev] Re: Basic support for tracking smi-only arrays on ia32. (issue 7901016)

2011-09-21 Thread jkummerow
LGTM. http://codereview.chromium.org/7901016/diff/28079/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): http://codereview.chromium.org/7901016/diff/28079/test/cctest/test-heap.cc#newcode676 test/cctest/test-heap.cc:676: CHECK(array-HasFastElements() ||

[v8-dev] Re: Add an optional source length field to the Extension constructor. (issue 7889046)

2011-09-21 Thread Florian Schneider
Had to change test-api.cc to make it compile on Win32 platform: http://codereview.chromium.org/7983033/ Den 21. sep. 2011 15.32 skrev Florian Schneider fschnei...@chromium.org: Landed in r9365. Den 21. sep. 2011 07.38 skrev Florian Schneider fschnei...@chromium.org: Sure, I'll land it.

[v8-dev] Re: Issue 1710 in v8: NewGC: stepping- / debugging-related crashes in the test suite

2011-09-21 Thread codesite-noreply
Comment #5 on issue 1710 by wi...@igalia.com: NewGC: stepping- / debugging-related crashes in the test suite http://code.google.com/p/v8/issues/detail?id=1710 It works now. Thanks! -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 761 in v8: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions

2011-09-21 Thread codesite-noreply
Comment #22 on issue 761 by js...@chromium.org: Incorrect UTF-8 encoding/decoding for non-BMP characters in String related functions http://code.google.com/p/v8/issues/detail?id=761 In 3), what rendering issue do you have? Your previous comment about rendering (comment #17) does not say

[v8-dev] Re: Fix pre-parsing function declarations. (issue 7983006)

2011-09-21 Thread lrn
http://codereview.chromium.org/7983006/diff/1/src/preparser.cc File src/preparser.cc (right): http://codereview.chromium.org/7983006/diff/1/src/preparser.cc#newcode394 src/preparser.cc:394: (!strict_mode() || !expr.AsIdentifier().IsFutureReserved())) { We should disallow FutureReserved in

[v8-dev] Notify collector about lazily deoptimized code objects. (issue 7983045)

2011-09-21 Thread vegorov
Reviewers: Erik Corry, Description: Notify collector about lazily deoptimized code objects. All slots that were recorded on these objects during incremental marking should be ignored as they are no longer valid. To filter such invalidated slots out during slots buffers iteration we set

[v8-dev] Re: Fix pre-parsing function declarations. (issue 7983006)

2011-09-21 Thread keuchel
http://codereview.chromium.org/7983006/diff/1/src/preparser.cc File src/preparser.cc (right): http://codereview.chromium.org/7983006/diff/1/src/preparser.cc#newcode394 src/preparser.cc:394: (!strict_mode() || !expr.AsIdentifier().IsFutureReserved())) { Actually we do follow ES5 already and for

[v8-dev] Attention, des nouvelles visites sur ton profil Badoo !

2011-09-21 Thread Badoo
Attention, des nouvelles visites sur ton profil Badoo ! 1 nouvelle personne a visité ton profil, parce qu'elle s'intéresse à toi. D'autres personnes sont aussi présentes: Al Wesam Découvre son profil et vois si vous avez des intérêts communs

  1   2   >