Reviewers: danno,
Message:
First version. Building with snapshot is currently broken.
This depends on the definition of "primitive" functions from
http://codereview.chromium.org/8677008/.
Danno: WDYT?
Kevin: FYI. Feel free to comment if you care.
Description:
New approach to Crankshaft decisio
actually sending the comment...
http://codereview.chromium.org/8701006/diff/1/src/v8natives.js
File src/v8natives.js (right):
http://codereview.chromium.org/8701006/diff/1/src/v8natives.js#newcode891
src/v8natives.js:891: throw
MakeTypeError("obj_ctor_property_non_object", ["getOwnPropertyNames
On 2011/11/25 15:34:40, Lasse Reichstein wrote:
PTAL
drive-by LGTM with comments. Did not make sure the corrections are
exhaustive
though.
http://codereview.chromium.org/8701006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: rossberg,
Message:
PTAL
Description:
Clean up JavaScript files to better follow coding standard.
Multiline conditionals must use braces.
Semicolons are not optional.
Please review this at http://codereview.chromium.org/8701006/
SVN Base: https://v8.googlecode.com/svn/branches/blee
Revision: 10072
Author: mstarzin...@chromium.org
Date: Fri Nov 25 06:41:38 2011
Log: Implement high promotion mode for new space.
This mode drastically decreases pause times by limiting maximum capacity
of the young generation when mutators generate many long-lived objects.
It shrinks
LGTM
http://codereview.chromium.org/8702006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10071
Author: yang...@chromium.org
Date: Fri Nov 25 06:26:54 2011
Log: Shorten FP register pops where possible.
Review URL: http://codereview.chromium.org/8699004
http://code.google.com/p/v8/source/detail?r=10071
Modified:
/branches/bleeding_edge/src/ia32/lithium-codegen-ia
LGTM.
http://codereview.chromium.org/8699004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Message:
PTAL. Local tests look good.
Description:
Shorten FP register pops where possible.
Please review this at http://codereview.chromium.org/8699004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-codegen-ia32.cc
M s
Landed.
http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#newcode4563
src/arm/code-stubs-arm.cc:4563: __ and_(r1, r0, Operand(kIsNotStringMask
| kStringRep
Revision: 10070
Author: yang...@chromium.org
Date: Fri Nov 25 06:04:47 2011
Log: Add external strings support to regexp in generated code.
TEST=test/mjsunit/string-external-cached.js
Review URL: http://codereview.chromium.org/8680010
http://code.google.com/p/v8/source/detail?r=10070
Revision: 10069
Author: yang...@chromium.org
Date: Fri Nov 25 05:38:43 2011
Log: Fixing build errors on arm.
Review URL: http://codereview.chromium.org/8698005
http://code.google.com/p/v8/source/detail?r=10069
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
=
LGTM.
http://codereview.chromium.org/8698005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Message:
PTAL.
Description:
Fixing build errors on arm.
Please review this at http://codereview.chromium.org/8698005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/code-stubs-arm.cc
Index: src/arm/code-stubs-arm.cc
diff --git a/
Reviewers: Erik Corry,
Message:
PTAL.
Description:
Implement high promotion mode for new space.
This mode drastically decreases pause times by limiting maximum capacity
of the young generation when mutators generate many long-lived objects.
It shrinks new space back to the initial capacity and
Revision: 10068
Author: mstarzin...@chromium.org
Date: Fri Nov 25 05:21:56 2011
Log: Fix assertion broken by recent revision.
R=yang...@chromium.org
TEST=mjsunit/keyed-call-ic
Review URL: http://codereview.chromium.org/8688008
http://code.google.com/p/v8/source/detail?r=10068
Modifie
Revision: 10067
Author: yang...@chromium.org
Date: Fri Nov 25 05:15:31 2011
Log: Implement Math.tan in generated code.
Review URL: http://codereview.chromium.org/874
http://code.google.com/p/v8/source/detail?r=10067
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/br
Thanks Lasse. Ulan and I just found out by looking at GCC-compiled code of
tan(). There are a few other places where "ffree(); fincstp()" could be
replaced. Will be addressed in another CL though.
Yang
On Fri, Nov 25, 2011 at 2:11 PM, wrote:
> LGTM if Lasse's comment is addressed.
>
>
> http://
LGTM if Lasse's comment is addressed.
http://codereview.chromium.org/874/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/874/diff/1/src/arm/full-codegen-arm.cc#newcode3142
src/arm/full-codegen-arm.cc:3142: context()->Plug(r0);
LGTM
http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/8680010/diff/3001/src/arm/code-stubs-arm.cc#newcode4563
src/arm/code-stubs-arm.cc:4563: __ and_(r1, r0, Operand(kIsNotStringMask
| kStringRepres
drive-by comment.
http://codereview.chromium.org/874/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
http://codereview.chromium.org/874/diff/1/src/x64/code-stubs-x64.cc#newcode1781
src/x64/code-stubs-x64.cc:1781: __ fincstp();
If you just want to drop the top el
On 2011/11/24 17:21:24, Michael Starzinger wrote:
PTAL.
drive-by LGTM.
http://codereview.chromium.org/8688008/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Message:
This takes advantage of FPTAN on intel architectures. Please take a look.
Description:
Implement Math.tan in generated code.
Please review this at http://codereview.chromium.org/874/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
Hello,
Concerning your comment:
"What we really should do is to recognize that the result is always
used as an integer, avoiding deopts when the modulus is non-zero or
some kind of overflow happens [...]"
I have a patch doing this optimization in hydrogen when the result is
used in bitwise operat
Revision: 10066
Author: l...@chromium.org
Date: Fri Nov 25 01:36:31 2011
Log: Don't preparse large files to find boundaries of lazy functions.
Instead use the preparser inline to parse only the lazy function
bodies.
This is still disabled for small files.
More measurements are needed
Still LGTM
http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-api.cc#newcode13430
test/cctest/test-api.cc:13430: }
Can we test that the heap is now much smaller?
http
Uploaded a new patch set that renames "heavy" to "non_primitive" and adds
comments.
I tried moving the counters to IsInlineable (see
http://codereview.chromium.org/871/) but don't really like it because
there
is no good place to call ComputeAstNodeCountAndInlineableFlags() from. This
funct
27 matches
Mail list logo
