LGTM.
Don't bother removing PartialPreParse now. It should go away eventually, but
there is no rush.
http://codereview.chromium.org/8725001/diff/2001/src/ast.h
File src/ast.h (right):
http://codereview.chromium.org/8725001/diff/2001/src/ast.h#newcode1179
src/ast.h:1179: friend class Rewriter;
I
Revision: 10080
Author: keuc...@chromium.org
Date: Tue Nov 29 00:43:14 2011
Log: Reapply "Fix the ScopeIterator reimplementation".
This reapplies a fixed version of r10076 that also works on arm. Patch set
one is r10076 reapplied and patch set 2 contains the new fix.
Review URL: ht
http://codereview.chromium.org/8725001/diff/2001/src/ast.h
File src/ast.h (right):
http://codereview.chromium.org/8725001/diff/2001/src/ast.h#newcode1179
src/ast.h:1179: friend class Rewriter;
Done. Also unfriended Scope :P
On 2011/11/29 08:07:27, Lasse Reichstein wrote:
Is it really necessary
Revision: 10081
Author: mstarzin...@chromium.org
Date: Tue Nov 29 00:48:51 2011
Log: Fix assertion while marking Harmony weak maps.
R=erik.co...@gmail.com
BUG=v8:1845
TEST=mjsunit/harmony/proxies-example-membrane
Review URL: http://codereview.chromium.org/8715004
http://code.google.co
Nice find!
http://codereview.chromium.org/8698022/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Owner: fschnei...@chromium.org
Comment #1 on issue 1846 by kmilli...@chromium.org: CHECK failure in
v8/src/x64/deoptimizer-x64.cc, line 83 on techcrunch.com
http://code.google.com/p/v8/issues/detail?id=1846
Thanks for the report. We'll take a look.
--
v8-dev mailing list
v8
LGTM
http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h
File src/conversions-inl.h (right):
http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h#newcode107
src/conversions-inl.h:107: EndMark end,
Indentation.
http://codereview.chromium.org/8680013/diff/400
Comment #4 on issue 1845 by mstarzin...@chromium.org: Crash in
proxies-example-membrane.js
http://code.google.com/p/v8/issues/detail?id=1845
Fixed the assertion in r10081. The original crash (which is unrelated to
the assertion) however is still present, issue remains open.
--
v8-dev mail
لديك 1 رسالة جديدة...
هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على
الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 1 رسالة جديدة من 1 جهة إتصال ،
إتبع هذا الرابط:
http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4ed4ad60
Revision: 10082
Author: vego...@chromium.org
Date: Tue Nov 29 02:02:38 2011
Log: When scavenging update source slot before migrating object it
points to.
Source slot might belong to a dead old object and we might allocate a new
object over it when evacuating a new space object thi
http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h
File src/conversions-inl.h (right):
http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h#newcode107
src/conversions-inl.h:107: EndMark end,
On 2011/11/29 09:34:56, Erik Corry wrote:
Indentation.
Thanks.
Updates:
Status: Fixed
Comment #3 on issue 1826 by keuc...@chromium.org: Combination of return and
with statements breaks debugger scope enumeration
http://code.google.com/p/v8/issues/detail?id=1826
Fix landed in r10080.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.go
Revision: 10084
Author: erik.co...@gmail.com
Date: Tue Nov 29 03:56:14 2011
Log: Only sweep one page eagerly unless we are running out of space.
Limit the number of pages that are compacted in a given GC.
Review URL: http://codereview.chromium.org/8692002
http://code.google.com/p/v8/sou
Updates:
Status: Fixed
Comment #2 on issue 1824 by keuc...@chromium.org:
CHECK(ParserApi::Parse(&info)) failed when breaking at top level code in
DevTools
http://code.google.com/p/v8/issues/detail?id=1824
Fix landed in r10080.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Revision: 10085
Author: da...@chromium.org
Date: Tue Nov 29 04:09:06 2011
Log: Port array literal changes on ARM.
Includes general array boilerplate copier and re-introduction FAST_ELEMENT
optimizations in full-codegen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org
Reviewers: Michael Starzinger,
Description:
Fix windows build.
Please review this at http://codereview.chromium.org/8725029/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/mark-compact.cc
Index: src/mark-compact.cc
=
LGTM.
http://codereview.chromium.org/8725029/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10086
Author: erik.co...@gmail.com
Date: Tue Nov 29 04:17:59 2011
Log: Fix windows build.
Review URL: http://codereview.chromium.org/8725029
http://code.google.com/p/v8/source/detail?r=10086
Modified:
/branches/bleeding_edge/src/mark-compact.cc
=
Reviewers: Vyacheslav Egorov,
Description:
Fix bug when generating padding to ensure space for lazy deoptimization.
BUG=v8:1846
Please review this at http://codereview.chromium.org/8725030/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/lithium-
lgtm
http://codereview.chromium.org/8725030/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10087
Author: fschnei...@chromium.org
Date: Tue Nov 29 04:39:28 2011
Log: Fix bug when generating padding to ensure space for lazy
deoptimization.
BUG=v8:1846
Review URL: http://codereview.chromium.org/8725030
http://code.google.com/p/v8/source/detail?r=10087
Modified:
/
Updates:
Status: Assigned
Comment #2 on issue 1846 by fschnei...@chromium.org: CHECK failure in
v8/src/x64/deoptimizer-x64.cc, line 83 on techcrunch.com
http://code.google.com/p/v8/issues/detail?id=1846
I have a fix on the way.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gr
Updates:
Status: Fixed
Comment #3 on issue 1846 by fschnei...@chromium.org: CHECK failure in
v8/src/x64/deoptimizer-x64.cc, line 83 on techcrunch.com
http://code.google.com/p/v8/issues/detail?id=1846
The problem is a wrong calculation of the padding size for lazy
deoptimization.
I
Updates:
Status: Fixed
Comment #3 on issue 1789 by fschnei...@chromium.org: jslint segfaults on
ia32 after r9758
http://code.google.com/p/v8/issues/detail?id=1789
The first attempt did not solve the problem. I committed a new fix for this
bug in r10006.
--
v8-dev mailing list
v8-d
Thank you for the comments! I uploaded a new patch set.
http://codereview.chromium.org/8677008/diff/4001/src/ast.h
File src/ast.h (right):
http://codereview.chromium.org/8677008/diff/4001/src/ast.h#newcode694
src/ast.h:694: WithStatement(Isolate* isolate, Expression* expression,
Statement* stat
Reviewers: Erik Corry,
Description:
Prepare push to trunk. Now working on version 3.7.12.
R=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/8725032/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
In
LGTM
http://codereview.chromium.org/8725032/diff/1/ChangeLog
File ChangeLog (right):
http://codereview.chromium.org/8725032/diff/1/ChangeLog#newcode3
ChangeLog:3: Fix bug when generating padding to ensure space for lazy
deoptimization.
Fix -> Fixed and below Implement->Implemented
http://coder
Added new patch set. Landed.
http://codereview.chromium.org/8725032/diff/1/ChangeLog
File ChangeLog (right):
http://codereview.chromium.org/8725032/diff/1/ChangeLog#newcode3
ChangeLog:3: Fix bug when generating padding to ensure space for lazy
deoptimization.
On 2011/11/29 14:15:22, Erik Corry
Revision: 10088
Author: mstarzin...@chromium.org
Date: Tue Nov 29 06:21:47 2011
Log: Prepare push to trunk. Now working on version 3.7.12.
R=erik.co...@gmail.com
Review URL: http://codereview.chromium.org/8725032
http://code.google.com/p/v8/source/detail?r=10088
Modified:
/branches
Revision: 10090
Author: mstarzin...@chromium.org
Date: Tue Nov 29 06:30:18 2011
Log: Tagging version 3.7.11
http://code.google.com/p/v8/source/detail?r=10090
Added:
/tags/3.7.11
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Description:
Elide write barrier.
Please review this at http://codereview.chromium.org/8659039/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/objects.cc
Index: src/objects.cc
==
LGTM
http://codereview.chromium.org/8659039/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Yang,
Description:
Fix handling of recompiling code for optimized and inlined functions
The debugger preparation did not take optimized functions - including
inlined function into account. This caused the full-code used for
deoptimization to be the "lazy compile" builtin which did not
Comment #2 on issue 1771 by enef...@gmail.com: Generalize the approach of
ExternalStringResource to any kind of Object
http://code.google.com/p/v8/issues/detail?id=1771
Greetings!
The last time I wrote the generalized ExternalResource concept
was only an idea. Now there is an implementation
لديك 1 رسالة جديدة...
هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على
الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 1 رسالة جديدة من 1 جهة إتصال ،
إتبع هذا الرابط:
http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4ed52dd4
Reviewers: Steven,
Message:
The patch unbreaks compilation of src/full-codegen.cc with GCC 4.7. The
build
fails due to -Werror=narrowing stating:
Error: narrowing conversion of »id« from »int« to »unsigned int« inside { }
is
ill-formed in C++11
The solution is to change "int" to "unsigned"
لديك 1 رسالة جديدة...
هوية المرسل و المحتوى سوف يظهر لك فقط. يمكنك حذفه في أي وقت. يمكنك الرد على
الفور ، بإستخدام منبر Badoo للدردشة. لإظهار 1 رسالة جديدة من 1 جهة إتصال ،
إتبع هذا الرابط:
http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=19&pref_lang=11&m=44&mid=4ed5a9cb
Comment #3 on issue 1724 by yex...@gmail.com: Windows 2000 supprt
http://code.google.com/p/v8/issues/detail?id=1724
Hi,
It seems patch will break MinGW build. Can you please add condition macros
to fix it? Thank you.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
38 matches
Mail list logo
