Revision: 10334
Author: vego...@chromium.org
Date: Wed Jan 4 23:53:28 2012
Log: Ensure that store buffer filtering hash sets are cleared after
StoreBuffer::Filter.
R=erik.co...@gmail.com
Review URL: http://codereview.chromium.org/8964025
http://code.google.com/p/v8/source/detail?r
Hi Erik, Can you back port this to 3.6?
feel free to use my attempt if it is correct -
https://gist.github.com/d5fcb57e00e1a32475b4
http://codereview.chromium.org/9086006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM! Great that you managed to find this one!
http://codereview.chromium.org/8964025/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM with comments.
Dynamic decision of the default elements kind is nifty, I like it :-)
Now that it's January, please change the year to 2012 in all files in this
CL.
http://codereview.chromium.org/9050001/diff/6002/src/bootstrapper.cc
File src/bootstrapper.cc (right):
http://codereview.
Reviewers: Erik Corry,
Description:
Ensure that store buffer filtering hash sets are cleared after
StoreBuffer::Filter.
R=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/8964025/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/
Reviewers: Erik Corry,
Description:
Alter the second hash used in StoreBuffer::Compact.
hash2 >> (kHashMapLengthLog2 * 2) was always zero because hash2 was masked
with
(kHashMapLength - 1).
R=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/9085021/
SVN Base: http
Revision: 10333
Author: vego...@chromium.org
Date: Wed Jan 4 11:59:01 2012
Log: When shrinking semispace don't relink pages if semispace is not
committed
R=mstarzin...@chromium.org
Review URL: http://codereview.chromium.org/9086005
http://code.google.com/p/v8/source/detail?r=10333
Comment #7 on issue 1877 by k...@chromium.org: NULL ptr in v8::Value::IsInt32
http://code.google.com/p/v8/issues/detail?id=1877
Thanks for the quick fix. I've commented on the patch.
I think this is because the constructor uses the set() method to copy the
elements.
Actually, I think the pr
Revision: 10332
Author: da...@chromium.org
Date: Wed Jan 4 09:29:01 2012
Log: Rollback 10331: Make sure transitioned arrays efficiently call
builtin Array functions
Due to perf regressions
TBR=fschnei...@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8
Revision: 10331
Author: da...@chromium.org
Date: Wed Jan 4 09:16:04 2012
Log: Make sure transitioned arrays efficiently call builtin Array
functions
Loosen the requirement for Map equivalency on several map checks, including
checks up the prototype chain, that are not sensitive t
Comment #7 on issue 1869 by msporle...@gmail.com: more netbsd support
including gyp
http://code.google.com/p/v8/issues/detail?id=1869
The last change I needed was:
build/common.gypi
264'cflags': [ '-I/usr/pkg/include -Wno-strict-aliasing' ],
298 'cflags': [ '-I/usr/p
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352
src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes,
On 2012/01/04 14:30:57, Vyacheslav Egorov wro
Reviewers: Michael Starzinger,
Message:
A small code review.
Description:
Avoid recording unnecessary deoptimization environments in a couple of
places.
This reduces the number of uses and potentially shortens live ranges.
Please review this at http://codereview.chromium.org/8983018/
SVN B
Revision: 10330
Author: erik.co...@gmail.com
Date: Wed Jan 4 07:12:15 2012
Log: Randomize the seed used for string hashing. This helps guard
against
CPU-eating DOS attacks against node.js servers. Based on code from
Bert Belder. This version only solves the issue for those that c
http://codereview.chromium.org/9086005/diff/1/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/9086005/diff/1/src/spaces.cc#newcode1272
src/spaces.cc:1272: if (!is_committed()) {
On 2012/01/04 14:38:28, Michael Starzinger wrote:
Can we invert the condition and place the
Revision: 10329
Author: kmilli...@chromium.org
Date: Wed Jan 4 06:45:29 2012
Log: Fix a few preprocessor macros that could capture an 'else'.
Namely they are SLOW_ASSERT, RETURN_IF_SCHEDULED_EXCEPTION, and
RETURN_IF_EMTPY_HANDLE_VALUE.
R=svenpa...@chromium.org
BUG=
TEST=
Review URL:
LGTM (with a nit).
http://codereview.chromium.org/9086005/diff/1/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/9086005/diff/1/src/spaces.cc#newcode1272
src/spaces.cc:1272: if (!is_committed()) {
Can we invert the condition and place the block below inside the if
state
المزيد من الأشخاص يريدون الإلتقاء بك على Badoo!
الآن لديك 3 أشخاص يريدون أن يلتقوا بك. إذهب إلى Badoo و إختار من منهم تريد أن
تلتقي أيضاً!
http://eu1.badoo.com/access.phtml?UID=261054792&secret=gKHxdj3QC0&g=20&m=43&mid=4f046398000b004625e9dd60
شكراً لك ،
فريق Badoo
بعد الكتابة :
lgtm
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352
src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes,
Maybe it should be noted that data in
lgtm
http://codereview.chromium.org/8983016/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Description:
Randomize the seed used for string hashing. This helps guard against
CPU-eating DOS attacks against node.js servers. Based on code from
Bert Belder. This version only solves the issue for those that compile
V8 themselves or those that do not use snaps
Thanks for the comments. Please take another quick look.
http://codereview.chromium.org/8983016/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Description:
When shrinking semispace don't relink pages if semispace is not committed
R=mstarzin...@chromium.org
Please review this at http://codereview.chromium.org/9086005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M sr
LGTM with nits
http://codereview.chromium.org/8983016/diff/1/src/isolate.h
File src/isolate.h (right):
http://codereview.chromium.org/8983016/diff/1/src/isolate.h#newcode111
src/isolate.h:111: if (isolate->has_scheduled_exception()) { \
We should probably always use parentheses around a
Thanks. I have some suggestions.
http://codereview.chromium.org/9008012/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/9008012/diff/1/src/api.cc#newcode2837
src/api.cc:2837: i::Handle result =
i::Object::GetPrototype(self);
i::Handle result(self->GetPrototype());
ht
Reviewers: Sven,
Description:
Fix a few preprocessor macros that could capture an 'else'.
Namely they are SLOW_ASSERT, RETURN_IF_SCHEDULED_EXCEPTION, and
RETURN_IF_EMTPY_HANDLE_VALUE.
R=svenpa...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/8983016/
SVN Base:
lgtm
http://codereview.chromium.org/9015020/diff/14002/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/9015020/diff/14002/src/arm/macro-assembler-arm.cc#newcode2004
src/arm/macro-assembler-arm.cc:2004: Map* transitioned_fast_element_m
Updates:
Status: Fixed
Comment #1 on issue 1883 by vego...@chromium.org: Call::ComputeTarget
should skip transitions when looking for a CONSTANT_FUNCTION
http://code.google.com/p/v8/issues/detail?id=1883
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegr
Comment #6 on issue 1877 by u...@chromium.org: NULL ptr in
v8::Value::IsInt32
http://code.google.com/p/v8/issues/detail?id=1877
Thank you for investigating this, Ken.
I uploaded a fix to WebKit (https://bugs.webkit.org/show_bug.cgi?id=75532).
I'm really unclear why V8Float64Array::setCallba
Updates:
Status: Fixed
Comment #1 on issue 1878 by da...@chromium.org: InternalArray has Array map
http://code.google.com/p/v8/issues/detail?id=1878
Fixed in r10308
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #1 on issue 1849 by da...@chromium.org: Preallocated Array
incorrectly transitions to fast-double-elements backing store
http://code.google.com/p/v8/issues/detail?id=1849
Fixed in r10311
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Feedback addressed, please take another look.
http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc#newcode1
src/hydrogen-instructions.cc:1: // Copyri
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #6 on issue 1869 by yang...@chromium.org: more netbsd support
including gyp
http://code.google.com/p/v8/issues/detail?id=1869
I updated the changes here: http://codereview.chromium.org/9071004/
Please reconfirm tha
http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js#newcode286
test/mjsunit/harmony/collections.js:286: assertThrows(function () {
fun
Revision: 10328
Author: yang...@chromium.org
Date: Wed Jan 4 01:58:21 2012
Log: Fix windows build.
Review URL: http://codereview.chromium.org/8983014
http://code.google.com/p/v8/source/detail?r=10328
Modified:
/branches/bleeding_edge/test/cctest/test-api.cc
On 2012/01/03 19:37:47, Nebojša Ćirić wrote:
On 2011/12/22 18:07:54, Nebojša Ćirić wrote:
Ping
LGTM.
http://codereview.chromium.org/9016034/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/8983014/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10327
Author: da...@chromium.org
Date: Wed Jan 4 01:40:47 2012
Log: MIPS: Undo allocation of half-formed array during elements
transition
Port r10320 (bb429e82)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9082001
Patch from Gergely Kis .
http://code.google.com
On 2012/01/04 09:39:54, Yang wrote:
PTAL. snprintf doesnt exist on windows.
Please take another look.
http://codereview.chromium.org/8983014/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 10326
Author: da...@chromium.org
Date: Wed Jan 4 01:39:35 2012
Log: MIPS: Add InternalArrayCodeGeneric
Port r10308 (4e74cc88)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9078002
Patch from Gergely Kis .
http://code.google.com/p/v8/source/detail?r=10326
Modified:
lgtm
http://codereview.chromium.org/9080001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/9078002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/9082001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Message:
PTAL. snprintf doesnt exist on windows.
Description:
Fix windows build.
Please review this at http://codereview.chromium.org/8983014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
Index: test/cctest/test
Revision: 10325
Author: da...@chromium.org
Date: Wed Jan 4 01:38:08 2012
Log: MIPS: Ensure that InternalArrays remain InternalArrays regardless
of how they are constructed.
Port r10306 (9141da8e)
BUG=
TEST=
Review URL: http://codereview.chromium.org/9080001
Patch from Gergely Kis
Most plaform-specific feedback applies to the other platforms as well.
http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc#newcode1
src/hydrogen-ins
Revision: 10324
Author: da...@chromium.org
Date: Wed Jan 4 00:51:35 2012
Log: Create experimental branch for Chromium WPO testing
http://code.google.com/p/v8/source/detail?r=10324
Added:
/branches/experimental/wpotest
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.goo
Revision: 10323
Author: yang...@chromium.org
Date: Wed Jan 4 00:48:35 2012
Log: Implement callback when script finishes running in V8 API.
TEST=test-api/LeaveScriptCallback
Review URL: http://codereview.chromium.org/8937003
http://code.google.com/p/v8/source/detail?r=10323
Modified:
LGTM
http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py
File tools/grokdump.py (right):
http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py#newcode957
tools/grokdump.py:957: def FindMap(self, tagged_address):
One trick that might help to guess whether smth is map or not
LGTM with tiny nits
http://codereview.chromium.org/8937003/diff/19001/include/v8.h
File include/v8.h (right):
http://codereview.chromium.org/8937003/diff/19001/include/v8.h#newcode3054
include/v8.h:3054: * This function removes callback which was installed
by
Just: Removes callback that was ins
Changed/fixed comments.
http://codereview.chromium.org/8937003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
51 matches
Mail list logo
