[v8-dev] Re: Issue 1858 in v8: Iteration over frozen object is slow

Updates: Status: Accepted Owner: ad...@chromium.org Cc: verwa...@chromium.org Comment #13 on issue 1858 by verwa...@chromium.org: Iteration over frozen object is slow http://code.google.com/p/v8/issues/detail?id=1858 What's mentioned in #9 isn't exactly true. Fast prop

[v8-dev] Re: Make Object.freeze fast (issue 14888005)

First round of comments. I especially like the CopyReplaceDescriptors changes. Some (simple) tests I can think of: - Objects in fast mode should stay in fast mode if they don't have normalized properties. - Freezing of objects does the right thing (maybe already tested?) - Two fast objects w

[v8-dev] Re: Issue 2688 in v8: How to compile on Windows 8 (WinRT) and Windows8 Phone

Updates: Status: Invalid Comment #1 on issue 2688 by yang...@chromium.org: How to compile on Windows 8 (WinRT) and Windows8 Phone http://code.google.com/p/v8/issues/detail?id=2688 WinRT doesnt allow executing JIT code by third party apps, so V8 cannot be ported. -- You received th

[v8-dev] Re: Issue 2675 in v8: Object.setPrototypeOf

Comment #3 on issue 2675 by andrea.g...@gmail.com: Object.setPrototypeOf http://code.google.com/p/v8/issues/detail?id=2675 now in ES6 specification: http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts#current_working_draft Object.setPrototypeOf() exactly spec'd the way I've patc

[v8-dev] Re: Implement Array.observe and emit splice change records for ArrayPush (issue 14978007)

https://codereview.chromium.org/14978007/diff/3001/src/array.js File src/array.js (right): https://codereview.chromium.org/14978007/diff/3001/src/array.js#newcode432 src/array.js:432: On 2013/05/16 00:45:30, adamk wrote: Nit: no need for this blank line Done. https://codereview.chromium.org/

[v8-dev] Make Object.freeze fast (issue 14888005)

Reviewers: Toon Verwaest, Message: No tests yet: I'd be interested in thoughts on what tests I should be adding (and how to craft those tests so they retain their value, i.e., they properly force objects into various modes). Description: Make Object.freeze fast This patch both speeds up the

[v8-dev] Re: Implement Array.observe and emit splice change records for ArrayPush (issue 14978007)

https://codereview.chromium.org/14978007/diff/3001/src/array.js File src/array.js (right): https://codereview.chromium.org/14978007/diff/3001/src/array.js#newcode432 src/array.js:432: Nit: no need for this blank line https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js File

[v8-dev] Implement Array.observe and emit splice change records for ArrayPush (issue 14978007)

Reviewers: adamk, Description: Implement Array.observe and emit splice change records for ArrayPush Please review this at https://codereview.chromium.org/14978007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/array.js M src/bootstrapper.cc M src/c

[v8-dev] [v8] r14699 committed - MIPS: Fix debug mode test failures....

Revision: 14699 Author: pal...@homejinni.com Date: Wed May 15 15:45:46 2013 Log: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Review URL: https

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 15179005)

Committed manually as r14699 (presubmit successful). https://codereview.chromium.org/15179005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fr

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 15179005)

lgtm https://codereview.chromium.org/15179005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] [v8] r14698 committed - Re-land Notifier.prototype.performChange + tests...

Revision: 14698 Author: ad...@chromium.org Date: Wed May 15 15:09:40 2013 Log: Re-land Notifier.prototype.performChange + tests Fixes the debug check failure on sorting an object with an array __proto__. Original Issue: https://codereview.chromium.org/14779011/ TBR=ad...@chromium.org

[v8-dev] Re: Re-land Notifier.prototype.performChange + tests (issue 14977015)

Committed patchset #1 manually as r14698 (presubmit successful). https://codereview.chromium.org/14977015/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Re-land Notifier.prototype.performChange + tests (issue 14977015)

lgtm, landing TBR rossberg (one line fix) https://codereview.chromium.org/14977015/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] MIPS: Fix debug mode test failures. (issue 15179005)

Reviewers: Paul Lind, Toon Verwaest, danno, kisg, kilvadyb, Description: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Please review this at https://code

[v8-dev] Re-land Notifier.prototype.performChange + tests (issue 14977015)

Reviewers: adamk, rossberg, Description: Re-land Notifier.prototype.performChange + tests Fixes the debug check failure on sorting an object with an array __proto__. Original Issue: https://codereview.chromium.org/14779011/ R=adamk,rossberg BUG= Please review this at https://codereview.chromi

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 14948010)

https://codereview.chromium.org/14948010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] MIPS: Fix debug mode test failures. (issue 14948010)

Reviewers: Paul Lind, vervox96, Description: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Please review this at https://codereview.chromium.org/14948010

[v8-dev] MIPS: Fix debug mode test failures. (issue 14948010)

Reviewers: Paul Lind, vervox96, Description: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Please review this at https://codereview.chromium.org/14948010

[v8-dev] MIPS: Fix debug mode test failures. (issue 14948010)

Reviewers: Paul Lind, vervox96, Description: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Please review this at https://codereview.chromium.org/14948010

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 14948010)

https://codereview.chromium.org/14948010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 14948010)

https://codereview.chromium.org/14948010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: MIPS: Fix debug mode test failures. (issue 14948010)

https://codereview.chromium.org/14948010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] MIPS: Fix debug mode test failures. (issue 14948010)

Reviewers: Paul Lind, vervox96, Description: MIPS: Fix debug mode test failures. This commit fixes a couple of debug mode test failures, which were introduced by commit 14600. TEST=mjsunit/mirror-number,mjsunit/mirror-object BUG= Please review this at https://codereview.chromium.org/14948010

Re: [v8-dev] Re: Preserve optimized code map during GCs weakly. (issue 14794007)

Woohoo :-) On May 15, 2013 9:09 AM, wrote: > > Committed patchset #4 manually as r14695 (presubmit successful). > > > https://codereview.chromium.org/14794007/ > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > ---You received this message because

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

Hmm, I wonder why the bots only noticed on your change... On Wed, May 15, 2013 at 12:44 PM, Rafael Weinstein wrote: > Note the following does not hit the assert. > > var arr = new Array; > arr.push('1', '2'); > Object.observe(arr, function() {}); > arr.sort(); > > > On Wed, May 15, 2013 at 12:43

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

Note the following does not hit the assert. var arr = new Array; arr.push('1', '2'); Object.observe(arr, function() {}); arr.sort(); On Wed, May 15, 2013 at 12:43 PM, Rafael Weinstein wrote: > So, this assert is unrelated to this patch. I can repro the assert > without my patch applied with: >

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

So, this assert is unrelated to this patch. I can repro the assert without my patch applied with: function Arrayish() {} Arrayish.prototype = { __proto__: Array.prototype }; var arr = new Arrayish; arr.push('1', '2'); Object.observe(arr, function() {}); arr.sort(); On Wed, May 15, 2013 at 12:07 P

[v8-dev] Re: Remove one more unneccessary conversion to double. (issue 15204002)

lgtm https://codereview.chromium.org/15204002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Issue 2688 in v8: How to compile on Windows 8 (WinRT) and Windows8 Phone

Status: New Owner: New issue 2688 by amerkol...@gmail.com: How to compile on Windows 8 (WinRT) and Windows8 Phone http://code.google.com/p/v8/issues/detail?id=2688 Any detail on how to compile for those platforms? -- You received this message because this project is configured to send

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

On Wed, May 15, 2013 at 10:28 AM, Rafael Weinstein wrote: > I think Arv's comments make sense, but I'd prefer to discuss a bit, > and not hold up this patch. > > Adam, can you please go ahead and land and I'll sort out the arg > validation detail with Arv and follow up in a later patch? Landed, b

[v8-dev] Remove one more unneccessary conversion to double. (issue 15204002)

Reviewers: rossberg, Message: PTAL Description: Remove one more unneccessary conversion to double. R=rossb...@chromium.org Please review this at https://codereview.chromium.org/15204002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/runtime.cc Index

[v8-dev] [v8] r14697 committed - Revert "Implement Object.getNotifier(obj).performChange()" (r14696)...

Revision: 14697 Author: ad...@chromium.org Date: Wed May 15 11:47:48 2013 Log: Revert "Implement Object.getNotifier(obj).performChange()" (r14696) Reverts r14696 because it caused debug assertion failures when running test/mjsunit/harmony/object-observe.js TBR=rossberg Review URL:

[v8-dev] Re: Revert "Implement Object.getNotifier(obj).performChange()" (r14696) (issue 15203002)

Committed patchset #1 manually as r14697 (presubmit successful). https://codereview.chromium.org/15203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Revert "Implement Object.getNotifier(obj).performChange()" (r14696) (issue 15203002)

Reviewers: rossberg, Description: Revert "Implement Object.getNotifier(obj).performChange()" (r14696) Reverts r14696 because it caused debug assertion failures when running test/mjsunit/harmony/object-observe.js TBR=rossberg Please review this at https://codereview.chromium.org/15203002/ SVN

[v8-dev] [v8] r14696 committed - Implement Object.getNotifier(obj).performChange()...

Revision: 14696 Author: ad...@chromium.org Date: Wed May 15 10:44:45 2013 Log: Implement Object.getNotifier(obj).performChange() R=rossberg,adamk,arv BUG= Review URL: https://codereview.chromium.org/14779011 Patch from Rafael Weinstein . http://code.google.com/p/v8/source/detail?r=146

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

I think Arv's comments make sense, but I'd prefer to discuss a bit, and not hold up this patch. Adam, can you please go ahead and land and I'll sort out the arg validation detail with Arv and follow up in a later patch? On Wed, May 15, 2013 at 9:39 AM, Adam Klein wrote: > I can land for rafaelw

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

I can land for rafaelw too, once he's dealt with arv's comments. On Wed, May 15, 2013 at 9:00 AM, Andreas Rossberg wrote: > OK, I'll hold off with landing til tomorrow, in case you still want to > address Arv's comment. I'd be fine with it. > > On 15 May 2013 15:52, wrote: >> I see that we are

[v8-dev] [v8] r14695 committed - Preserve optimized code map during GCs weakly....

Revision: 14695 Author: mstarzin...@chromium.org Date: Wed May 15 09:09:25 2013 Log: Preserve optimized code map during GCs weakly. This change preserves the contents of optimized code maps during GCs but treats the references in this cache weakly. It uses infrastructure from code flus

[v8-dev] Re: Preserve optimized code map during GCs weakly. (issue 14794007)

Committed patchset #4 manually as r14695 (presubmit successful). https://codereview.chromium.org/14794007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

OK, I'll hold off with landing til tomorrow, in case you still want to address Arv's comment. I'd be fine with it. On 15 May 2013 15:52, wrote: > I see that we are using for-in loops. I just wanted to ask if the order of > these > loops matter? Remember that we iterate over index-like property n

[v8-dev] [v8] r14694 committed - Revert "GeneratorFunction() makes generator instances"...

Revision: 14694 Author: wi...@igalia.com Date: Wed May 15 08:57:58 2013 Log: Revert "GeneratorFunction() makes generator instances" This reverts r14684 because of blink LayoutTest failures in inspector/debugger/debugger-pause-in-internal.html. R=mstarzin...@chromium.org BUG= Review U

[v8-dev] Re: Revert "GeneratorFunction() makes generator instances" (issue 14619040)

Committed patchset #1 manually as r14694 (presubmit successful). https://codereview.chromium.org/14619040/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Revert "GeneratorFunction() makes generator instances" (issue 14619040)

LGTM (rubber-stamped). https://codereview.chromium.org/14619040/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] Revert "GeneratorFunction() makes generator instances" (issue 14619040)

Reviewers: Michael Starzinger, Message: This CL reverts a previous commit due to test failures. I had uploaded another reversion CL (https://codereview.chromium.org/14773041/), but uploading the base files failed. Re-uploading made a new issue. Sorry for any confusion. Description: Rever

[v8-dev] [v8] r14693 committed - Preallocate transitioned maps for TypedArrays....

Revision: 14693 Author: dslo...@chromium.org Date: Wed May 15 08:23:53 2013 Log: Preallocate transitioned maps for TypedArrays. R=hpa...@chromium.org Review URL: https://codereview.chromium.org/15172003 http://code.google.com/p/v8/source/detail?r=14693 Modified: /branches/bleeding_e

[v8-dev] Re: Preallocate transitioned maps for TypedArrays. (issue 15172003)

Committed patchset #1 manually as r14693 (presubmit successful). https://codereview.chromium.org/15172003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r14692 committed - With flag optimize-constructed-arrays on, ARM and MIPS suffered a perf...

Revision: 14692 Author: mvstan...@chromium.org Date: Wed May 15 08:17:01 2013 Log: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade due to incorrect code in GenerateRecordCallTarget(). The CL also enables flag optimize-constructed-arrays. BUG= R

[v8-dev] Re: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (issue 14772043)

Committed patchset #2 manually as r14692 (presubmit successful). https://codereview.chromium.org/14772043/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Preserve optimized code map during GCs weakly. (issue 14794007)

Addressed comments. Will land after some more benchmarking. https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1072 src/mark-compact.cc:1072: Code* code = Code::

[v8-dev] Re: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (issue 14772043)

LGTM with a nit. Nice catch. https://codereview.chromium.org/14772043/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/14772043/diff/1/test/mjsunit/allocation-site-info.js#newcode31 test/mjsunit/allocation-site-info.j

[v8-dev] [v8] r14691 committed - Add a HBreak instruction for debugging...

Revision: 14691 Author: ol...@chromium.org Date: Wed May 15 07:24:47 2013 Log: Add a HBreak instruction for debugging BUG= R=jkumme...@chromium.org Review URL: https://codereview.chromium.org/14997008 http://code.google.com/p/v8/source/detail?r=14691 Modified: /branches/bleeding_edg

[v8-dev] Re: Add a HBreak instruction for debugging (issue 14997008)

Reviewers: Jakob, Message: Committed patchset #2 manually as r14691 (presubmit successful). Description: Add a HBreak instruction for debugging BUG= R=jkumme...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14691 Please review this at https://codereview.chromium.org/149

[v8-dev] With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (issue 14772043)

Reviewers: Michael Starzinger, Message: Hi Michael, here is the CL we discussed, thanks! --Michael Description: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade due to incorrect code in GenerateRecordCallTarget(). The CL also enables flag optimize-constr

[v8-dev] Re: Preallocate transitioned maps for TypedArrays. (issue 15172003)

LGTM! one nit from my side. https://codereview.chromium.org/15172003/diff/2001/src/heap.h File src/heap.h (right): https://codereview.chromium.org/15172003/diff/2001/src/heap.h#newcode141 src/heap.h:141: EmptyExternalPixelArray) \ Can we move empty_external_pixel_array after emp

[v8-dev] [v8] r14690 committed - Shift additional_index by element_shift_size, not shift_size....

Revision: 14690 Author: verwa...@chromium.org Date: Wed May 15 07:04:44 2013 Log: Shift additional_index by element_shift_size, not shift_size. R=jkumme...@chromium.org Review URL: https://chromiumcodereview.appspot.com/14629021 http://code.google.com/p/v8/source/detail?r=14690 Modif

[v8-dev] Re: Shift additional_index by element_shift_size, not shift_size. (issue 14629021)

Committed patchset #1 manually as r14690 (presubmit successful). https://chromiumcodereview.appspot.com/14629021/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r14689 committed - Slight improvement of object printer for maps....

Revision: 14689 Author: mstarzin...@chromium.org Date: Wed May 15 07:03:42 2013 Log: Slight improvement of object printer for maps. R=u...@chromium.org Review URL: https://codereview.chromium.org/14969030 http://code.google.com/p/v8/source/detail?r=14689 Modified: /branches/bleeding

[v8-dev] Re: Slight improvement of object printer for maps. (issue 14969030)

Committed patchset #1 manually as r14689 (presubmit successful). https://codereview.chromium.org/14969030/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Slight improvement of object printer for maps. (issue 14969030)

lgtm https://codereview.chromium.org/14969030/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Slight improvement of object printer from maps. (issue 14969030)

Reviewers: ulan, Description: Slight improvement of object printer from maps. R=u...@chromium.org Please review this at https://codereview.chromium.org/14969030/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/objects-printer.cc Index: src/objects-prin

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

I see that we are using for-in loops. I just wanted to ask if the order of these loops matter? Remember that we iterate over index-like property names first. Does that screw up the expected order? https://codereview.chromium.org/14779011/diff/25001/src/object-observe.js File src/object-observe

[v8-dev] Re: new style of property/function callbacks (issue 12494012)

LGTM again, if a short overview comment is added what the new machinery in arguments.{h,cc} is actually doing and why it is needed. I really hope a lot of this stuff will die after a transitional phase, currently it is quite intimidating... https://codereview.chromium.org/12494012/ -- -- v8-d

[v8-dev] Re: v8: fix dragonflybsd build (issue 11421013)

On 2013/05/15 12:55:46, Jakob wrote: [...] Moving some of these lists to global variables would be very nice too, but a little messy in practice due to subtle differences (sometimes we test for "Linux or *BSD or Mac", sometimes for "Linux or *BSD", sometimes what we really mean is "do we comp

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

lgtm if there are no regressions on the big three benchmarks https://codereview.chromium.org/14284010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] [v8] r14688 committed - Tagging version 3.17.6.14

Revision: 14688 Author: jkumme...@chromium.org Date: Wed May 15 06:26:27 2013 Log: Tagging version 3.17.6.14 http://code.google.com/p/v8/source/detail?r=14688 Added: /tags/3.17.6.14 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You recei

[v8-dev] [v8] r14687 committed - Merged r14638 into 3.17 branch....

Revision: 14687 Author: jkumme...@chromium.org Date: Wed May 15 06:26:10 2013 Log: Merged r14638 into 3.17 branch. Fix missing hole check for loads from Smi arrays when all uses are changes BUG=chromium:233737 R=da...@chromium.org Review URL: https://codereview.chromium.org/14698021

[v8-dev] Re: Merged r14638 into 3.17 branch. (issue 14698021)

Committed patchset #1 manually as r14687 (presubmit successful). https://codereview.chromium.org/14698021/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Merged r14638 into 3.17 branch. (issue 14698021)

lgtm https://codereview.chromium.org/14698021/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] [v8] r14686 committed - Tagging version 3.18.5.5

Revision: 14686 Author: jkumme...@chromium.org Date: Wed May 15 06:23:41 2013 Log: Tagging version 3.18.5.5 http://code.google.com/p/v8/source/detail?r=14686 Added: /tags/3.18.5.5 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You receive

[v8-dev] [v8] r14685 committed - Merged r14638 into 3.18 branch....

Revision: 14685 Author: jkumme...@chromium.org Date: Wed May 15 06:23:24 2013 Log: Merged r14638 into 3.18 branch. Fix missing hole check for loads from Smi arrays when all uses are changes BUG=chromium:233737 R=da...@chromium.org Review URL: https://codereview.chromium.org/15199004

[v8-dev] Merged r14638 into 3.17 branch. (issue 14698021)

Reviewers: danno, Description: Merged r14638 into 3.17 branch. Fix missing hole check for loads from Smi arrays when all uses are changes BUG=chromium:233737 R=da...@chromium.org Please review this at https://codereview.chromium.org/14698021/ SVN Base: https://v8.googlecode.com/svn/branches/3

[v8-dev] Re: Merged r14638 into 3.18 branch. (issue 15199004)

Committed patchset #1 manually as r14685 (presubmit successful). https://codereview.chromium.org/15199004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Issue 2680 in v8: (function* () { }).constructor() - crash

Updates: Status: Fixed Comment #2 on issue 2680 by wi...@igalia.com: (function* () { }).constructor() - crash http://code.google.com/p/v8/issues/detail?id=2680 Fixed in r14684. -- You received this message because this project is configured to send all issue notifications to this a

[v8-dev] Re: Merged r14638 into 3.18 branch. (issue 15199004)

lgtm https://codereview.chromium.org/15199004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Merged r14638 into 3.18 branch. (issue 15199004)

https://codereview.chromium.org/15199004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] [v8] r14684 committed - GeneratorFunction() makes generator instances...

Revision: 14684 Author: wi...@igalia.com Date: Wed May 15 06:22:05 2013 Log: GeneratorFunction() makes generator instances The current specification has GeneratorFunction() be like Function(), except that it makes generator instances. This commit implements that behavior. It also fil

[v8-dev] Merged r14638 into 3.18 branch. (issue 15199004)

Reviewers: danno, Description: Merged r14638 into 3.18 branch. Fix missing hole check for loads from Smi arrays when all uses are changes BUG=chromium:233737 R=da...@chromium.org Please review this at https://codereview.chromium.org/15199004/ SVN Base: https://v8.googlecode.com/svn/branches/3

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

On 2013/05/15 09:15:30, danno wrote: https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/14284010/diff/56001/src/hydrogen-instructions.h#newcode5267 src/hydrogen-instructions.h:5267: unsigne

[v8-dev] [v8] r14683 committed - Fix build failure on Linux since r14681....

Revision: 14683 Author: mstarzin...@chromium.org Date: Wed May 15 06:14:24 2013 Log: Fix build failure on Linux since r14681. R=da...@chromium.org, svenpa...@chromium.org Review URL: https://codereview.chromium.org/14969025 http://code.google.com/p/v8/source/detail?r=14683 Modified:

[v8-dev] Re: Fix build failure on Linux since r14681. (issue 14969025)

Committed patchset #1 manually as r14683 (presubmit successful). https://codereview.chromium.org/14969025/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Fix build failure on Linux since r14681. (issue 14969025)

lgtm https://codereview.chromium.org/14969025/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Fix build failure on Linux since r14681. (issue 14969025)

lgtm https://codereview.chromium.org/14969025/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Preserve optimized code map during GCs weakly. (issue 14794007)

LGTM! just a few nits... https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/14794007/diff/10001/src/mark-compact.cc#newcode1072 src/mark-compact.cc:1072: Code* code = Code::cast(code_map->get(i + 1)); Can we

[v8-dev] Re: Remove use_system_v8 logic from the mailine gyp file. (issue 14872005)

Sorry, sat on this for way too long, and now the patch doesn't apply any more, so I've re-created, re-uploaded and committed it at https://codereview.chromium.org/15001031/. Thanks for the contribution, I do indeed like the simplification! https://codereview.chromium.org/14872005/ -- -- v8-de

[v8-dev] Fix build failure on Linux since r14681. (issue 14969025)

Reviewers: danno, Description: Fix build failure on Linux since r14681. R=da...@chromium.org Please review this at https://codereview.chromium.org/14969025/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M test/cctest/test-conversions.cc Index: test/cctest/

[v8-dev] [v8] r14682 committed - Remove use_system_v8 logic from the mainline gyp file...

Revision: 14682 Author: jkumme...@chromium.org Date: Wed May 15 06:09:57 2013 Log: Remove use_system_v8 logic from the mainline gyp file Re-upload of https://codereview.chromium.org/14872005/ BUG=chromium:226860 R=u...@chromium.org Review URL: https://codereview.chromium.org/15001031

[v8-dev] Re: Remove use_system_v8 logic from the mainline gyp file (issue 15001031)

Reviewers: Michael Starzinger, ulan, Message: Committed patchset #1 manually as r14682 (presubmit successful). Description: Remove use_system_v8 logic from the mainline gyp file Re-upload of https://codereview.chromium.org/14872005/ BUG=chromium:226860 R=u...@chromium.org Committed: http://co

[v8-dev] Remove use_system_v8 logic from the mainline gyp file (issue 15001031)

LGTM (rubber-stamp) https://codereview.chromium.org/15001031/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Abcd for performance check. (issue 14046017)

LGTM with a few more nits. Let's discuss the higher-level situation on Friday. https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/14046017/diff/23001/src/hydrogen-instructions.cc#newcode120

[v8-dev] Re: v8: fix dragonflybsd build (issue 11421013)

What I don't like about this patch in its current form is the inconsistency it introduces to the various OS-based conditions in the .gyp files. We should settle for either of: (1) OS=="a" or OS=="b" or... (2) OS!="win" (3) OS in "a b ...".split() (4) OS in ["a", "b", ...] and then use that consi

[v8-dev] Re: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (issue 14284010)

On Wed, May 15, 2013 at 11:15 AM, wrote: > > https://codereview.chromium.**org/14284010/diff/56001/src/** > hydrogen-instructions.h > File src/hydrogen-instructions.h (right): > > https://codereview.chromium.**org/14

[v8-dev] Re: v8: fix dragonflybsd build (issue 11421013)

Removed Michael, added Jakob, just for fun. :-) https://codereview.chromium.org/11421013/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from th

[v8-dev] Re: v8: fix dragonflybsd build (issue 11421013)

On 2013/01/22 02:51:35, evilsjg wrote: http://www.thesjg.com/dragonfly/v8df.patch Here's the patch I have used to build v8 locally, with libexecinfo from pkgsrc wip and with the unmasked sem_timedwait() I'm just going through my list of old CLs and hit this one: If I understand this cor

[v8-dev] [v8] r14681 committed - Provide BitField64 utility class....

Revision: 14681 Author: mstarzin...@chromium.org Date: Wed May 15 05:29:13 2013 Log: Provide BitField64 utility class. R=svenpa...@chromium.org TEST=cctest/test-conversions/BitField64 Review URL: https://codereview.chromium.org/14643004 http://code.google.com/p/v8/source/detail?r=1468

[v8-dev] Re: Provide BitField64 utility class. (issue 14643004)

Committed patchset #1 manually as r14681 (presubmit successful). https://codereview.chromium.org/14643004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

Thanks. =-) On Wed, May 15, 2013 at 5:27 AM, wrote: > LGTM. Will land once I'm back on VPN. > > https://codereview.chromium.org/14779011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Go

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

LGTM. Will land once I'm back on VPN. https://codereview.chromium.org/14779011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group a

[v8-dev] Re: Implement Object.getNotifier(obj).performChange() (issue 14779011)

PTAL. On Tue, May 14, 2013 at 11:20 AM, wrote: > > https://codereview.chromium.org/14779011/diff/18001/test/mjsunit/harmony/object-observe.js > File test/mjsunit/harmony/object-observe.js (right): > > https://codereview.chromium.org/14779011/diff/18001/test/mjsunit/harmony/object-observe.js#newc

[v8-dev] Re: new style of property/function callbacks (issue 12494012)

Just for the record: There seem to be some Windows problems, after these are fixed, this CL can be landed. https://codereview.chromium.org/12494012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed t

  1   2   >