Revision: 15139
Author: yu...@chromium.org
Date: Thu Jun 13 23:12:22 2013
Log: Edited wiki page Contributing through web user interface.
http://code.google.com/p/v8/source/detail?r=15139
Modified:
/wiki/Contributing.wiki
===
--- /wiki/Contributing.
Revision: 15138
Author: svenpa...@chromium.org
Date: Thu Jun 13 23:06:00 2013
Log: Reduce the amount of full code generated to fill out array
literals.
This is achieved by tuning the calling convention of StoreArrayLiteralStub:
* The map of the array literal can be loaded in the s
Committed patchset #2 manually as r15138 (presubmit successful).
https://codereview.chromium.org/16950004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Comments addressed, landing...
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc#newcode6105
src/hydrogen.cc:6105: new(zone()) HConstant(expr->literal_index(),
Representation::Smi(;
O
lgtm
https://chromiumcodereview.appspot.com/16994002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Committed patchset #1 manually as r15136 (presubmit successful).
https://codereview.chromium.org/16996004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15137
Author: jkumme...@chromium.org
Date: Thu Jun 13 14:27:46 2013
Log: Tagging version 3.19.15.1
http://code.google.com/p/v8/source/detail?r=15137
Added:
/tags/3.19.15.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You recei
LGTM
https://codereview.chromium.org/16996004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
This is a somewhat speculative revert to fix
#
# Fatal error in ../../v8/src/hydrogen-instructions.h, line 1310
# CHECK(value->IsInstruction()) failed
#
as seen on
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/38343/steps/content_browsertests/logs
Reviewers: Hannes Payer,
Description:
Rollback of r15097, r15087 in trunk branch.
MIPS: Allow the deoptimizer translation to track de-materialized objects.
Allow the deoptimizer translation to track de-materialized objects.
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.c
Reviewers: Jakob,
Message:
New version of https://codereview.chromium.org/14796012/. PTAL.
Description:
Try convert polymorphic stores into a single monomorphic store.
Please review this at https://chromiumcodereview.appspot.com/16975006/
SVN Base: https://v8.googlecode.com/svn/branches/bleedi
Reviewers: danno, dcarney, Sven Panne,
Message:
Committed patchset #1 manually as r15135 (presubmit successful).
Description:
Notify CPU profiler when calling native getters
This change modifies code produced by
BaseLoadStubCompiler::GenerateLoadCallback
so that instead of calling AccessorGet
Committed manually as r15134 (presubmit successful).
https://codereview.chromium.org/16983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Revision: 15133
Author: pal...@homejinni.com
Date: Thu Jun 13 11:48:19 2013
Log: MIPS: Implement IC support for Constant Function transitions.
Port r15124 (6b02a945)
BUG=
Review URL: https://codereview.chromium.org/16984002
http://code.google.com/p/v8/source/detail?r=15133
Modified:
Revision: 15134
Author: pal...@homejinni.com
Date: Thu Jun 13 11:49:09 2013
Log: MIPS: Only extend storage if FIELD
Port r15125 (0c202ff0)
BUG=
Review URL: https://codereview.chromium.org/16983002
http://code.google.com/p/v8/source/detail?r=15134
Modified:
/branches/bleeding_edge/s
Committed manually as r15133 (presubmit successful).
https://codereview.chromium.org/16984002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Reviewers: Paul Lind, danno, Toon Verwaest, kisg, kilvadyb,
Description:
MIPS: Only extend storage if FIELD
Port r15125 (0c202ff0)
BUG=
Please review this at https://codereview.chromium.org/16983002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips
lgtm
https://codereview.chromium.org/16983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/16983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/16984002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/16984002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Paul Lind, danno, Toon Verwaest, kisg, kilvadyb,
Description:
MIPS: Implement IC support for Constant Function transitions.
Port r15124 (6b02a945)
BUG=
Please review this at https://codereview.chromium.org/16984002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
A
Comment #3 on issue 1855 by teleclim...@gmail.com: Debug mode only listen
in loopback address(127.0.0.1) which cause I cannot did remote debug
http://code.google.com/p/v8/issues/detail?id=1855
I am wondering why this is marked as "works as intended"? Is there a reason
why a script running i
Reviewers: mvstanton,
Message:
PTAL
Description:
Observe smi as input for HCompareIDAndBranch
Please review this at https://chromiumcodereview.appspot.com/16994002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff
Revision: 15132
Author: verwa...@chromium.org
Date: Thu Jun 13 11:09:33 2013
Log: Reduce usage of AssumeRepresentation
BUG=
R=mstarzin...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16871011
http://code.google.com/p/v8/source/detail?r=15132
Modified:
/branches/bl
Committed patchset #1 manually as r15132 (presubmit successful).
https://chromiumcodereview.appspot.com/16871011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
LGTM.
https://codereview.chromium.org/16871011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Reduce usage of AssumeRepresentation
BUG=
Please review this at https://chromiumcodereview.appspot.com/16871011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.h
M src/hydrogen.cc
I
Revision: 15131
Author: pal...@homejinni.com
Date: Thu Jun 13 10:47:28 2013
Log: MIPS: Delegating yield does not re-box result objects.
Port r15113 (9d28761)
Delegating yield (yield*) should just pass on the iterator results it
receives instead of re-boxing them.
TEST=mjsunit/harmony
Committed as r15131.
https://codereview.chromium.org/16855009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
I cannot upload a new patchset to this issue (I don't own this issue), but I
will fix the nit, when I land this CL.
https://codereview.chromium.org/16855009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are sub
Revision: 15130
Author: verwa...@chromium.org
Date: Thu Jun 13 10:38:10 2013
Log: Remove manual representation annotations for constants.
R=mstarzin...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16818016
http://code.google.com/p/v8/source/detail?r=15130
Modified:
Committed patchset #2 manually as r15130 (presubmit successful).
https://chromiumcodereview.appspot.com/16818016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Addressed comments.
https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc#newcode1415
src/hydrogen.cc:1415:
Handle(isolate()->heap()->empty_fixed_array()));
On 2013/06/13 17:33:56, Michael St
LGTM with nits.
https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16818016/diff/1/src/hydrogen.cc#newcode1415
src/hydrogen.cc:1415:
Handle(isolate()->heap()->empty_fixed_array()));
I know this is not you change, but can
LGTM, but please fix the nit.
https://codereview.chromium.org/16855009/diff/1/src/mips/full-codegen-mips.cc
File src/mips/full-codegen-mips.cc (right):
https://codereview.chromium.org/16855009/diff/1/src/mips/full-codegen-mips.cc#newcode2124
src/mips/full-codegen-mips.cc:2124: CallIC(value_ic);
Reviewers: Yang,
Message:
Please take a look.
Description:
Make MathFloorOfDiv optimization trigger more often
BUG=v8:2205
Please review this at https://codereview.chromium.org/16973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-arm.h
Revision: 15129
Author: hpa...@chromium.org
Date: Thu Jun 13 10:03:57 2013
Log: Allow allocations in spaces with constant allocation size use the
smallest possible size-class.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/16957003
http://code.google.com/p
Committed patchset #3 manually as r15129 (presubmit successful).
https://codereview.chromium.org/16957003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc#newcode2236
src/spaces.cc:2236: ASSERT(size_in_bytes <= *node_size);
On 2013/06/13 13:00:13, Michael Starzinger wrote:
Can we add this as
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Remove manual representation annotations for constants.
Please review this at https://chromiumcodereview.appspot.com/16818016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/code-stubs-hydrogen.c
Reviewers: danno, wingo, Paul Lind, palfia, kisg,
Description:
MIPS: Delegating yield does not re-box result objects.
Port r15113 (9d28761)
Delegating yield (yield*) should just pass on the iterator results it
receives instead of re-boxing them.
TEST=mjsunit/harmony/generators-iteration
BUG=
Committed as r15128.
https://codereview.chromium.org/16923008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 15128
Author: pal...@homejinni.com
Date: Thu Jun 13 09:50:22 2013
Log: MIPS: Use keyed-call inline caches in delegating yield.
Port r15111 (7de1a19)
Original commit message:
Since we can't assume anything about the shape of the iterator in a
yield* (delegating yield), use an
Revision: 15127
Author: pal...@homejinni.com
Date: Thu Jun 13 09:44:54 2013
Log: MIPS: Increase sanity of integer division handling.
Port r15057 (c82c777)
Original commit message:
- In the INT32 BinaryOpStub, fix type feedback collection for DIV,
bringing it in line with other platfor
Committed as r15127.
https://codereview.chromium.org/16857004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: Michael Starzinger,
Message:
PTAL
mstarzinger@: please review
hpayer@: FYI (comments welcome, of course!)
Description:
Do not use weak handles for ArrayBuffers.
Instead of allocating weak handles to free ArrayBuffer backing store,
dispose of
memory while walking the weak list of A
Revision: 15126
Author: verwa...@chromium.org
Date: Thu Jun 13 09:36:15 2013
Log: Refactor turning polymorphic loads into monomorphic loads
- remove special code for polymorphic loading of array length
- use it in VisitCountOperation
BUG=
R=hpa...@chromium.org
Review URL: https://chro
Committed patchset #5 manually as r15126 (presubmit successful).
https://chromiumcodereview.appspot.com/16948005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
LGTM
https://codereview.chromium.org/16948005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Addressed comments
https://codereview.chromium.org/16948005/diff/6001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16948005/diff/6001/src/hydrogen.cc#newcode6319
src/hydrogen.cc:6319: HInstruction*
HOptimizedGraphBuilder::LoadPolymorphicAsMonomorphic(
On 2013/06
lgtm
https://codereview.chromium.org/16923008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM.
https://codereview.chromium.org/16857004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 15125
Author: verwa...@chromium.org
Date: Thu Jun 13 09:21:32 2013
Log: Only extend storage if FIELD
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16818014
http://code.google.com/p/v8/source/detail?r=15125
Modified:
/branches/bleeding_edge/src
Committed patchset #1 manually as r15125 (presubmit successful).
https://chromiumcodereview.appspot.com/16818014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://chromiumcodereview.appspot.com/16818014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Message:
PTAL
Description:
Only extend storage if FIELD
Please review this at https://chromiumcodereview.appspot.com/16818014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/stub-cache-arm.cc
M src/ia32/stub-cache-ia32.cc
M src
Status: New
Owner:
New issue 2730 by ultimate...@gmail.com: The default setting of
type_info_threshold is too low
http://code.google.com/p/v8/issues/detail?id=2730
It seems that the default value of type_info_threshold is now outdated to
give the best performance on large applications
Reviewers: Michael Starzinger,
Message:
PTAL
https://chromiumcodereview.appspot.com/16955008/diff/2001/test/mjsunit/regress/regress-crbug-217858.js
File test/mjsunit/regress/regress-crbug-217858.js (left):
https://chromiumcodereview.appspot.com/16955008/diff/2001/test/mjsunit/regress/regress-c
Reviewers: danno, wingo, Paul Lind, palfia, kisg,
Description:
MIPS: Use keyed-call inline caches in delegating yield.
Port r15111 (7de1a19)
Original commit message:
Since we can't assume anything about the shape of the iterator in a
yield* (delegating yield), use an IC to do the next() and thr
some comments
https://codereview.chromium.org/16578008/diff/11001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/16578008/diff/11001/src/api.cc#newcode5150
src/api.cc:5150: bool v8::V8::SetFunctionEntryHook(FunctionEntryHook
entry_hook) {
API calls should take an Isolate pa
looking good, first round of comments
https://codereview.chromium.org/16948005/diff/6001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16948005/diff/6001/src/hydrogen.cc#newcode6319
src/hydrogen.cc:6319: HInstruction*
HOptimizedGraphBuilder::LoadPolymorphicAsMono
https://codereview.chromium.org/16855008/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/16855008/diff/1/src/arm/code-stubs-arm.cc#oldcode4696
src/arm/code-stubs-arm.cc:4696: __ cmp(r3,
Operand(terminal_kind_sentinel));
How about you turn t
Committed patchset #1 manually as r15124 (presubmit successful).
https://chromiumcodereview.appspot.com/16826016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 15124
Author: verwa...@chromium.org
Date: Thu Jun 13 08:01:25 2013
Log: Implement IC support for Constant Function transitions.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16826016
http://code.google.com/p/v8/source/detail?r=15124
Modified:
Committed patchset #3 manually as r15123 (presubmit successful).
https://codereview.chromium.org/16663009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15123
Author: mstarzin...@chromium.org
Date: Thu Jun 13 08:00:30 2013
Log: Deprecate several unchecked accessors.
R=hpa...@google.com
BUG=v8:1490
Review URL: https://codereview.chromium.org/16663009
http://code.google.com/p/v8/source/detail?r=15123
Modified:
/branches/blee
lgtm
https://chromiumcodereview.appspot.com/16826016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r15122 (presubmit successful).
https://chromiumcodereview.appspot.com/16957005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 15122
Author: verwa...@chromium.org
Date: Thu Jun 13 07:58:41 2013
Log: Temporarily patch HCompareIDAndBranch to accept Smi.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16957005
http://code.google.com/p/v8/source/detail?r=15122
Modified:
/br
Reviewers: danno, Jakob, Paul Lind, palfia, kisg,
Description:
MIPS: Increase sanity of integer division handling.
Port r15057 (c82c777)
Original commit message:
- In the INT32 BinaryOpStub, fix type feedback collection for DIV,
bringing it in line with other platforms.
- In Lithium codegen, em
Revision: 15121
Author: da...@chromium.org
Date: Thu Jun 13 07:40:50 2013
Log: Tagging version 3.19.15
http://code.google.com/p/v8/source/detail?r=15121
Added:
/tags/3.19.15
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Revision: 15119
Author: da...@chromium.org
Date: Thu Jun 13 07:38:36 2013
Log: Prepare push to trunk. Now working on version 3.19.16.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/16924007
http://code.google.com/p/v8/source/detail?r=15119
Modified:
/branches/
Committed patchset #1 manually as r15119 (presubmit successful).
https://codereview.chromium.org/16924007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/16924007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
Prepare push to trunk. Now working on version 3.19.16.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/16924007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
Ind
Revision: 15118
Author: mvstan...@chromium.org
Date: Thu Jun 13 07:29:01 2013
Log: HCheckFunction is needed to protect new array constructors in
crankshafted code.
BUG=
R=da...@chromium.org
Review URL: https://codereview.chromium.org/16944006
http://code.google.com/p/v8/source/detail?
Committed patchset #1 manually as r15118 (presubmit successful).
https://codereview.chromium.org/16944006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/16944006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/16957004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16957004/diff/1/src/hydrogen.cc#newcode9458
src/hydrogen.cc:9458: ASSERT(right_type->Is(Type::None()));
This might no longer be true in the future. I think the condition
Addressed comments.
https://codereview.chromium.org/16957005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: danno,
Message:
Hi Danno, here is the CL we discussed,
--Michael
Description:
HCheckFunction is needed to protect new array constructors in
crankshafted code.
BUG=
Please review this at https://codereview.chromium.org/16944006/
SVN Base: https://v8.googlecode.com/svn/branches/bleed
Reviewers: Jakob,
Message:
PTAL.
No crankshaft support yet, so it will still go generic. But at least
decisive
generic rather than having no feedback.
Description:
Implement IC support for Constant Function transitions.
Please review this at https://chromiumcodereview.appspot.com/16826016/
Committed patchset #1 manually as r15117 (presubmit successful).
https://codereview.chromium.org/16838013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: dcarney, Sven Panne,
Description:
Revert "Notify CPU profiler when calling native getters"
This reverts commit f323d984a73bab345c4eab5c1907552ccfa7ccaa.
Broke compilation on the bots with an error that doesn't occur locally:
CXX(target)
/mnt/data/b/build/slave/v8-linux-debug/build
Addressed comments. Will land once tree is open again.
https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc#newcode1505
src/mark-compact.cc:1505: code);
On 2013/06/13 13:09
LGTM with comments.
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/16950004/diff/1/src/hydrogen.cc#newcode6105
src/hydrogen.cc:6105: new(zone()) HConstant(expr->literal_index(),
Representation::Smi(;
I would just
Yeah, the spec requires next to be a method on the prototype so we need
private
state.
Andreas, I'm in favor to exposing private names to embedders if we cannot
get
TC39 to support them.
Is it OK to trigger this based on --harmony_iteration? Is it OK that this
needs
--harmony_symbol to al
Committed patchset #18 manually as r15116 (presubmit successful).
https://codereview.chromium.org/16286016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM with a comment.
https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc#newcode9924
src/hydrogen.cc:9924: if (left_rep.IsInteger32()) left_rep =
Representation::Smi();
I thin
Comment #37 on issue 90 by math...@qiwi.be: V8 doesn't stable sort
http://code.google.com/p/v8/issues/detail?id=90
I’ve re-opened the (old) sorting algorithms discussion on the es-discuss
mailing list. Please discuss this issue there instead of in this thread.
Thanks!
https://mail.mozilla.
LGTM! one nit
https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/16663009/diff/2001/src/mark-compact.cc#newcode1505
src/mark-compact.cc:1505: code);
that fits in one line
https://codereview.chromium.org/16663
LGTM with one suggestion.
https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc#newcode2236
src/spaces.cc:2236: ASSERT(size_in_bytes <= *node_size);
Can we add this assert to every case, I th
Reviewers: Michael Starzinger, danno,
Description:
Allow allocations in spaces with constant allocation size use the
smallest possible size-class.
BUG=
Please review this at https://codereview.chromium.org/16957003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Updates:
Status: Fixed
Comment #1 on issue 2724 by mstarzin...@chromium.org: cctest
Regression144230 fails with --stress-compaction
http://code.google.com/p/v8/issues/detail?id=2724
Fixed in r15115.
--
You received this message because this project is configured to send all
issue n
Committed patchset #1 manually as r15115 (presubmit successful).
https://codereview.chromium.org/16858010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15115
Author: mstarzin...@chromium.org
Date: Thu Jun 13 05:49:38 2013
Log: Disable compaction stress for test-heap/Regression144230.
R=yang...@chromium.org
BUG=v8:2724
TEST=cctest/test-heap/Regression144230
Review URL: https://codereview.chromium.org/16858010
http://code.goo
On 2013/06/13 12:39:33, Michael Starzinger wrote:
Disabling compaction for this test-case, because trying to fix it would
just
be
brain-dead.
LGTM.
https://codereview.chromium.org/16858010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rec
Reviewers: Michael Starzinger,
Message:
The auto-increment optimization we talked about offline is still missing, I
will
add this later in this CL or a separate one.
Description:
Reduce the amount of full code generated to fill out array literals.
This is achieved by tuning the calling conve
Comment #36 on issue 90 by math...@qiwi.be: V8 doesn't stable sort
http://code.google.com/p/v8/issues/detail?id=90
Instead of adding additional "me too" comments, I suspect it's more
useful for
someone to write (or find) a comprehensive test of sort stability (for
various
array sizes) and ru
1 - 100 of 167 matches
Mail list logo
