Status: New
Owner:
New issue 2759 by weiliang...@gmail.com: Performance regression of
StringReplace function
http://code.google.com/p/v8/issues/detail?id=2759
Test case:
function test () {
var string = "scDfce";
string = string.replace(/\r\n/g,"\n");
return string;
}
var sta
Reviewers: Michael Starzinger,
Message:
ptal
Description:
Make MachO gdbjit support compile again
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/18621002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/gdb-jit.cc
In
ptal
https://codereview.chromium.org/18621002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Cc: bmeu...@chromium.org
Comment #1 on issue 2759 by yang...@chromium.org: Performance regression of
StringReplace function
http://code.google.com/p/v8/issues/detail?id=2759
(No comment was entered for this change.)
--
You received this message because this project is config
This seems a bit arbitrary to me. I'm handing off to yang to take a closer
look.
https://codereview.chromium.org/18068007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-
Updates:
Status: Assigned
Owner: bmeu...@chromium.org
Cc: -bmeu...@chromium.org yang...@chromium.org
Comment #2 on issue 2759 by yang...@chromium.org: Performance regression of
StringReplace function
http://code.google.com/p/v8/issues/detail?id=2759
Thanks for reportin
LGTM.
https://codereview.chromium.org/18621002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
I've fixed the style issues that you pointed out. Some of them come from
copy-pasting code from other part of the V8 source. If I missed or
misunderstood
something feel free to notice me, I will fix it ASAP.
https://codereview.chromium.org/1833/
--
--
v8-dev mailing list
v8-dev@googlegr
On 2013/07/03 07:40:22, danno wrote:
This seems a bit arbitrary to me. I'm handing off to yang to take a closer
look.
This does not seem like a correct fix.
This test is supposed to check whether V8 aborts execution orderly with an
out
of memory exception due to the cons string content bein
Revision: 15460
Author: da...@chromium.org
Date: Wed Jul 3 01:29:46 2013
Log: Make MachO gdbjit support compile again
R=mstarzin...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18621002
http://code.google.com/p/v8/source/detail?r=15460
Modified:
/branches/bleedin
lgtm
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Generally, looks like the right direction as long as you do indeed execute
your
long-term plan. I'll defer to Jakob for the specifics of the build changes,
but
the rest LGTM.
https://codereview.chromium.org/18487004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/
Issue 2744: Meta-Bug: TSAN finds many data races in V8
http://code.google.com/p/v8/issues/detail?id=2744
This issue is now blocking issue chromium:189177.
See http://code.google.com/p/chromium/issues/detail?id=189177
--
You received this message because you are listed in the owner
or CC fields o
Issue 2744: Meta-Bug: TSAN finds many data races in V8
http://code.google.com/p/v8/issues/detail?id=2744
This issue is no longer blocking issue chromium:189177.
See http://code.google.com/p/chromium/issues/detail?id=189177
--
You received this message because you are listed in the owner
or CC fie
lgtm
https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h#newcode119
src/profile-generator.h:119: Logger::LogEventsAndTags tag() const {
return tag_; }
revert?
htt
Reviewers: loislo, Jakob, alph,
Description:
Do not store fp and sp values in TickSample
Their values are not used neither by the tick processor nor by CpuProfiler
so it
is just a waste of space.
TickSample used to be a transport for grabbed register values to
TickSample::Trace, now they are
https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h#newcode119
src/profile-generator.h:119: Logger::LogEventsAndTags tag() const {
return tag_; }
On 2013/07/03 08:50:
Comment #6 on issue 2340 by yang...@chromium.org: Force format stack traces
for Errors that survived major GC
http://code.google.com/p/v8/issues/detail?id=2340
Revisiting this, I found that it's hard to impossible to completely avoid
side effects, especially with upcoming Proxies etc.
Wha
lgtm
https://codereview.chromium.org/18620002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Comment #7 on issue 2340 by yang...@chromium.org: Force format stack traces
for Errors that survived major GC
http://code.google.com/p/v8/issues/detail?id=2340
We already have a weak referencing list on error objects that we need to
format in order to release objects. We are just not taking
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 2756 by yang...@chromium.org: d8.js missing else
http://code.google.com/p/v8/issues/detail?id=2756
upcoming fix :)
https://codereview.chromium.org/18572009
--
You received this message because this project
Reviewers: mvstanton,
Description:
Fix small mistake in d8.js.
R=mvstan...@chromium.org
BUG=v8:2756
Please review this at https://codereview.chromium.org/18572009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/d8.js
Index: src/d8.js
diff --git a/src/
Hi Hannes, the perf bug is addressed (see type-info.cc), and the platform
ports
are done. thanks!
--Michael
https://codereview.chromium.org/15094018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribe
I guess next step should be disabling the extension in the WebKit code (our
Blink part) and enabling v8 implementation (this CL) for Chrome.
LGTM
https://codereview.chromium.org/18487004/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/18487004/diff/1/src/api.cc#newco
Reviewers: ulan,
Description:
Don't return frame by reference in ProcessTopOptimizedFrame.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/18592006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mark-compact.cc
Index: src/ma
LGTM, thank you!
https://codereview.chromium.org/18592006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
Revision: 15461
Author: mstarzin...@chromium.org
Date: Wed Jul 3 02:47:22 2013
Log: Don't return frame by reference in ProcessTopOptimizedFrame.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/18592006
http://code.google.com/p/v8/source/detail?r=15461
Modified:
/bra
Committed patchset #1 manually as r15461 (presubmit successful).
https://codereview.chromium.org/18592006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #1 manually as r15462 (presubmit successful).
https://codereview.chromium.org/17599007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15462
Author: yang...@chromium.org
Date: Wed Jul 3 03:10:27 2013
Log: Log deopts with --log-timer-events.
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/17599007
http://code.google.com/p/v8/source/detail?r=15462
Modified:
/branches/bleeding_edge
Reviewers: loislo, Jakob, Yang,
Description:
Remove #include "cpu-profiler-inl.h" from v8.h
This significantly reduces amount of files to be recompiled after changes in
cpu-profiler.h and its dependencies.
BUG=None
Please review this at https://codereview.chromium.org/18522004/
SVN Base: http
Reviewers: Yang, danno,
Description:
Reintroduce runtime zone to Isolate.
In case tcmalloc is not being used, the malloc()/free() overhead
can be significant for several runtime functions like StringReplace.
Therefore we reintroduce the runtime_zone into Isolate and reenable
the segment caching
lgtm
https://codereview.chromium.org/18572009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r15463 (presubmit successful).
https://codereview.chromium.org/18572009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Updates:
Status: Fixed
Comment #2 on issue 2756 by yang...@chromium.org: d8.js missing else
http://code.google.com/p/v8/issues/detail?id=2756
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to th
Revision: 15463
Author: yang...@chromium.org
Date: Wed Jul 3 03:38:20 2013
Log: Fix small mistake in d8.js.
R=mvstan...@chromium.org
BUG=v8:2756
Review URL: https://codereview.chromium.org/18572009
http://code.google.com/p/v8/source/detail?r=15463
Modified:
/branches/bleeding_edge/
Reviewers: Jakob,
Description:
Enable GDBJIT interface for standalone by default.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/18638002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile
M build/standalone.gypi
In
LGTM with one comment.
https://codereview.chromium.org/18496002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/18496002/diff/1/src/hydrogen.h#newcode1423
src/hydrogen.h:1423: class HOsrBuilder {
Since the implementation has been factored out into a separate f
Status: New
Owner:
New issue 2760 by fen.x...@gmail.com: The problem with windows-1251 codepage
http://code.google.com/p/v8/issues/detail?id=2760
When creating a new String with Cyrillic characters in the encoding
windows-1251, all Cyrillic characters are replaced with question marks:
v
lgtm
https://codereview.chromium.org/18522004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Comment #1 on issue 2760 by fen.x...@gmail.com: The problem with
windows-1251 codepage
http://code.google.com/p/v8/issues/detail?id=2760
When the run command read("file") in shell.cc, with file in windows-1251
encoding problem is present.
--
You received this message because this project
Hi Yang,
Thanks for the review and have a try to modify the old space size. I did not
change anything. Here is the crash trace in my machine:
#
# Fatal error in ../src/contexts.h, line 236
# CHECK(context->IsContext()) failed
#
C stack trace ===
1: V8_Fatal
2
LGTM. I left a comment about the future direction of GDBJIT but I am fine
with
landing this temporary fix.
As for having test coverage for GDBJIT, I couldn't agree more. I actually
aim to
enable it (i.e. compilation, not the runtime flag) by default. We should be
able
to enable it for stand
Build system changes LGTM. I've verified that by default it builds fine even
when ICU is not checked out into third_party/icu.
I'll land.
https://codereview.chromium.org/18487004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this mess
Committed patchset #1 manually as r15464 (presubmit successful).
https://codereview.chromium.org/18487004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Oops, overlooked Cira's comment. Sorry. Please fix in a follow-up CL.
https://codereview.chromium.org/18487004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/18638002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/18635003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2013/07/03 11:36:38, danno wrote:
lgtm
lgtm
https://codereview.chromium.org/18635003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Revision: 15465
Author: bmeu...@chromium.org
Date: Wed Jul 3 04:40:30 2013
Log: Reintroduce runtime zone to Isolate.
In case tcmalloc is not being used, the malloc()/free() overhead
can be significant for several runtime functions like StringReplace.
Therefore we reintroduce the runti
Committed patchset #1 manually as r15465 (presubmit successful).
https://codereview.chromium.org/18635003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profiler.cc#newcode1198
test/cctest/test-cpu-profiler.cc:1198:
nit: if Rietveld isn't
Updates:
Status: Fixed
Comment #3 on issue 2759 by bmeu...@chromium.org: Performance regression of
StringReplace function
http://code.google.com/p/v8/issues/detail?id=2759
Fixed with r15465.
--
You received this message because this project is configured to send all
issue notificat
Thanks for the review.
I have a comment on the Logger::IssueCodeMovedEvent, it might not work for
the
current gdbjit implementation. If I understand the codes correctly, the code
removal event is issued when new codes take its place, instead of being
marked
as garbage at the current positio
Updates:
Status: WorkingAsIntended
Comment #2 on issue 2760 by yang...@chromium.org: The problem with
windows-1251 codepage
http://code.google.com/p/v8/issues/detail?id=2760
This piece of code seems to work just fine:
v8::Local string = v8::String::New("Hello! Привет!");
v8::Stri
It compiles, but does not work. Please see
https://codereview.chromium.org/13083002/ for more information.
In the future, we should make lldb work for V8 jit on Mac as gdb remains
6.3.50
on Mac but gdbjit requires 7.0. When I have free time, I will have a try :)
https://codereview.chromium.or
lgtm
https://codereview.chromium.org/18363007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno,
Description:
Fix GDBJIT for Linux after r15460.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/18363007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/gdb-jit.cc
Index: src/gdb-jit.cc
diff --git a/src/gdb
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 2757 by yang...@chromium.org: stack trace generation
can be corrupted by harmony proxies
http://code.google.com/p/v8/issues/detail?id=2757
I guess this is unfortunate, but does not actually ruin the stac
Yes, I agree. Switching GDBJIT over to the existing JitCodeEvent mechanism
might
require slight adaptations of the GDBJIT interface implementation. But I
think
it's worth it in the long run because then only one hooking mechanism needs
to
be maintained.
https://codereview.chromium.org/13880
Revision: 15466
Author: mstarzin...@chromium.org
Date: Wed Jul 3 04:57:38 2013
Log: Fix GDBJIT for Linux after r15460.
R=da...@chromium.org
Review URL: https://codereview.chromium.org/18363007
http://code.google.com/p/v8/source/detail?r=15466
Modified:
/branches/bleeding_edge/src/g
Committed patchset #1 manually as r15466 (presubmit successful).
https://codereview.chromium.org/18363007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Yes, I agree. Thanks for taking care of it :)
https://codereview.chromium.org/13880031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
Committed patchset #1 manually as r15467 (presubmit successful).
https://codereview.chromium.org/18638002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15467
Author: mstarzin...@chromium.org
Date: Wed Jul 3 05:00:40 2013
Log: Enable GDBJIT interface for standalone by default.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/18638002
http://code.google.com/p/v8/source/detail?r=15467
Modified:
/branches
Reviewers: Jakob, Yang, loislo,
Description:
Fix test-cpu-profiler/FunctionCallSample flakiness under GC stress testing
The test flakes on "V8 GC Stress" bots and the sample looks like this:
[Top down]:
90 0 (root) [-1] #0 1
1 1(program) [-1] #0 2
8989(garbage col
lgtm
https://codereview.chromium.org/18068012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
Fix typo in api.cc
BUG=v8:2745
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/18471005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/sr
Reviewers: Jakob,
Description:
Sort the i18n extension sources correctly.
It's important that e.g. the header comes first, and the footer last
BUG=v8:2745
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/18187005/
SVN Base: https://v8.googlecode.com/svn/branches/
Reviewers: Jakob,
Description:
Mark i18n functions as native and set proper names
BUG=v8:2745
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/18075004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/extensions/i18n/break-i
Reviewers: Jakob,
Description:
Change mjsunit tests to work with and without the i18n extension
BUG=v8:2745
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/18187006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/
Reviewers: Michael Starzinger,
Description:
Fix compilation on x64 after r15466
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/18643002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/gdb-jit.cc
Index: src/gdb-jit.cc
https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profiler.cc#newcode1198
test/cctest/test-cpu-profiler.cc:1198:
On 2013/07/03 11:41:50, Jakob
Committed patchset #5 manually as r15468 (presubmit successful).
https://codereview.chromium.org/18269003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15468
Author: yu...@chromium.org
Date: Wed Jul 3 07:04:37 2013
Log: Correctly report stack trace when current function is
FunctionApply builtin
When pc is inside FunctionApply builtin function the top frame may be either
2) Internal stack frame created by FunctionApply it
lgtm
https://codereview.chromium.org/18620002/diff/2001/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/18620002/diff/2001/src/frames.cc#newcode220
src/frames.cc:220: StackFrameIteratorBase(isolate, false),
nit: while you're here, please move the ':' onto this line a
Reviewers: rossberg,
Description:
Type::GetName(...) for inspecting Types in the debugger
BUG=
Please review this at https://codereview.chromium.org/18587007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/types.h
M src/types.cc
--
--
v8-dev mailing
LGTM. Thanks.
https://codereview.chromium.org/18643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/18620002/diff/2001/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/18620002/diff/2001/src/frames.cc#newcode220
src/frames.cc:220: StackFrameIteratorBase(isolate, false),
On 2013/07/03 14:12:31, Jakob wrote:
nit: while you're here, please
Can you please commit
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev
Committed patchset #1 manually as r15469 (presubmit successful).
https://codereview.chromium.org/18643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15469
Author: mstarzin...@chromium.org
Date: Wed Jul 3 07:21:21 2013
Log: Fix compilation on x64 after r15466
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/18643002
Patch from Jochen Eisinger .
http://code.google.com/p/v8/source/detail?r=15469
Mod
lgtm
https://codereview.chromium.org/18068012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob, loislo,
Description:
Relax test expectations for test-cpu-profiler/FunctionApplySample
The profile may look a bit different on the bots (see below). We expected
this
only under GC stress testing, the change makes regular expectations the
same.
[Top down]:
68 0 (
Committed patchset #1 manually as r15470 (presubmit successful).
https://codereview.chromium.org/18331012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15470
Author: yu...@chromium.org
Date: Wed Jul 3 07:23:34 2013
Log: Relax test expectations for test-cpu-profiler/FunctionApplySample
The profile may look a bit different on the bots (see below). We expected
this only under GC stress testing, the change makes regular expec
lgtm
https://codereview.chromium.org/18471005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 15471
Author: yu...@chromium.org
Date: Wed Jul 3 07:26:38 2013
Log: Fix test-cpu-profiler/FunctionCallSample flakiness under GC
stress testing
The test flakes on "V8 GC Stress" bots and the sample looks like this:
[Top down]:
90 0 (root) [-1] #0 1
1 1
Committed patchset #1 manually as r15471 (presubmit successful).
https://codereview.chromium.org/18068012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/18187005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2013/07/03 11:01:03, loislo wrote:
lgtm
LGTM.
https://codereview.chromium.org/18522004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
lgtm
https://codereview.chromium.org/18075004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/18187006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/18331012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: machenbach,
Description:
Fix GDBJIT compilation on Mac after r15467.
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/18259007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/gdb-jit.cc
Index: src/gdb-jit.cc
d
Status: New
Owner:
New issue 2761 by earth...@google.com: AddressSanitizer reports
use-after-free in V8 tests on x64 Linux
http://code.google.com/p/v8/issues/detail?id=2761
To reproduce: build with ASan and run
tools/run-tests.py --no-presubmit --arch=x64 -m release
I see several very
Comment #1 on issue 2761 by earth...@google.com: AddressSanitizer reports
use-after-free in V8 tests on x64 Linux
http://code.google.com/p/v8/issues/detail?id=2761
r15466
--
You received this message because this project is configured to send all
issue notifications to this address.
You m
https://codereview.chromium.org/18587007/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/18587007/diff/1/src/types.cc#newcode501
src/types.cc:501: for (int i = 0; i < unioned->length(); ++i) {
Note that for a union, at most one part is not a constant or class.
Sinc
On 2013/07/03 11:12:47, haitao.feng wrote:
Hi Yang,
Thanks for the review and have a try to modify the old space size. I did
not
change anything. Here is the crash trace in my machine:
#
# Fatal error in ../src/contexts.h, line 236
# CHECK(context->IsContext()) failed
#
C stack tr
Committed patchset #1 manually as r15472 (presubmit successful).
https://codereview.chromium.org/18068007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
1 - 100 of 156 matches
Mail list logo
