Reviewers: Toon Verwaest,
Message:
Committed patchset #2 manually as r16017 (presubmit successful).
Description:
Disable test in object observe because of bug 2774.
BUG=
R=verwa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16017
Please review this at https://coderev
Revision: 16017
Author: hpa...@chromium.org
Date: Thu Aug 1 23:40:50 2013
Log: Disable test in object observe because of bug 2774.
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/21495004
http://code.google.com/p/v8/source/detail?r=16017
Modified:
/branches
Status: New
Owner:
New issue 2821 by tyosh...@chromium.org: [Feature Request] Expose JSON
parser API
http://code.google.com/p/v8/issues/detail?id=2821
For Chromium (to implement XMLHttpRequest responseType='json'), we'd like
to use JSON parser implementation of v8 directly from C++ cod
Reviewers: danno,
Message:
Addressed danno's comments on https://codereview.chromium.org/18014003/.
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h#newcode598
s
LGTM. I'll land this tomorrow when I am back in the office.
https://codereview.chromium.org/21079003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Committed patchset #1 manually as r16016 (presubmit successful).
https://codereview.chromium.org/21512002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16016
Author: joc...@chromium.org
Date: Thu Aug 1 12:43:06 2013
Log: Reenable tests that need to access the default timezone.
It's now available via builtins.
BUG=v8:2475
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/21512002
http://code.google.com
Committed patchset #1 manually as r16015 (presubmit successful).
https://codereview.chromium.org/21499003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16015
Author: joc...@chromium.org
Date: Thu Aug 1 12:25:27 2013
Log: Move helper methods from i18n extension into runtime.
BUG=v8:2475
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/21499003
http://code.google.com/p/v8/source/detail?r=16015
Deleted:
Revision: 16014
Author: joc...@chromium.org
Date: Thu Aug 1 12:21:16 2013
Log: Fix incorrect #ifdef statements for I18N support.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/21509002
http://code.google.com/p/v8/source/detail?r=16014
Modified:
/branches/bleed
Committed patchset #1 manually as r16014 (presubmit successful).
https://codereview.chromium.org/21509002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16013
Author: joc...@chromium.org
Date: Thu Aug 1 12:20:42 2013
Log: Remove test that v8Intl symbol exists, as we don't define it
anymore.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/21511002
http://code.google.com/p/v8/source/detail?r=16013
Del
Committed patchset #1 manually as r16013 (presubmit successful).
https://codereview.chromium.org/21511002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #1 manually as r16012 (presubmit successful).
https://codereview.chromium.org/20831003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16012
Author: joc...@chromium.org
Date: Thu Aug 1 12:20:01 2013
Log: Never define 'DEBUG' for non-v8 code
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/20831003
http://code.google.com/p/v8/source/detail?r=16012
Modified:
/branches/bleeding_edge/buil
Comment #3 on issue 2813 by bnjb...@gmail.com: Incorrect behavior on
box2d.js (regression)
http://code.google.com/p/v8/issues/detail?id=2813
Works for me on rev 16011.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may
Reviewers: Yury Semikhatsky, alph,
Message:
test will follow
Description:
Propagate bailout reason to cpu profile node.
BUG=
Please review this at https://codereview.chromium.org/21593002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8-profiler.
Reviewers: Michael Starzinger, danno,
Description:
Remove instructions and infrastructure related to IDEFs that is now obsolete
(and was never turned on). The new bounds check elimination phase doesn't
make
use of these features, as they were the first parts of the previous approach
which was
On 2013/08/01 17:19:32, Jakob wrote:
On 2013/08/01 17:14:25, Dirk Pranke wrote:
> lgtm also. Did this fix the problem?
The problem has been fixed by
https://chromiumcodereview.appspot.com/20607005.
I
still think we should land this patch too.
Ah. I feel better that it wasn't this change t
On 2013/08/01 17:14:25, Dirk Pranke wrote:
lgtm also. Did this fix the problem?
The problem has been fixed by
https://chromiumcodereview.appspot.com/20607005. I
still think we should land this patch too.
https://codereview.chromium.org/21495002/
--
--
v8-dev mailing list
v8-dev@googlegroup
Reviewers: danno,
Message:
PTAL.
This depends on https://chromiumcodereview.appspot.com/21065006/.
Description:
Implement de-deprecation in HCheckMaps.
Currently only direct map checks are supported. Otherwise only polymorphic
cases
with a generic fallback behave properly, regular polymorphi
lgtm also. Did this fix the problem?
https://codereview.chromium.org/21495002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (left):
https://codereview.chromium.org/21495002/diff/1/build/toolchain.gypi#oldcode67
build/toolchain.gypi:67: # This may be hard or impossible to debug.
This
https://codereview.chromium.org/21055011/diff/3001/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/21055011/diff/3001/src/hydrogen-escape-analysis.cc#newcode74
src/hydrogen-escape-analysis.cc:74: for (int i = 0; i <
graph()->blocks()-
Revision: 16011
Author: da...@chromium.org
Date: Thu Aug 1 10:00:39 2013
Log: Tagging version 3.20.12
http://code.google.com/p/v8/source/detail?r=16011
Added:
/tags/3.20.12
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Revision: 16009
Author: da...@chromium.org
Date: Thu Aug 1 09:57:58 2013
Log: Prepare push to trunk. Now working on version 3.20.13.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/21575003
http://code.google.com/p/v8/source/detail?r=16009
Modified:
/branches/
Committed patchset #1 manually as r16009 (presubmit successful).
https://codereview.chromium.org/21575003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Comment #5 on issue 2137 by mj1856: Timezone computations is wrong for Lord
Howe Island
http://code.google.com/p/v8/issues/detail?id=2137
If it is related to half-hour offsets, wouldn't other places be failing as
well? For example, India is UTC+5:30. There are many others with :30
offse
LGTM with nit.
https://codereview.chromium.org/21575003/diff/1/ChangeLog
File ChangeLog (right):
https://codereview.chromium.org/21575003/diff/1/ChangeLog#newcode7
ChangeLog:7: Fix a crash for large code objects on ARM (Chromium issue
2736)
nit: past tense. (Again below.)
https://codereview.ch
Reviewers: Jakob,
Description:
Prepare push to trunk. Now working on version 3.20.13.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/21575003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
Ind
Reviewers: Jakob,
Description:
Prepare push to trunk. Now working on version 3.20.13.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/21570003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
ChangeLog
src/version.cc
Index:
Reviewers: Michael Starzinger,
Description:
More cleanup regarding the maximum non-large object allocation size.
BUG=
Please review this at https://codereview.chromium.org/20867003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
M src/objects-
This seems to be heading in the right direction, but there is a lot more
work to
do... this is a first round of comments but there will be more to come as I
make
more progress on the review
https://codereview.chromium.org/21014003/diff/17001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-
Furthermore, with this patch the observed behavior is correct in every way.
It is once we implement the @@create hook the current behavior needs to be
refined to support subclassing.
I apologize for not including all of this information in the CL
description. A better description could have done a
This was agreed at the latest face to face meeting. Shipping the current
behavior, even under an experimental flag, is future hostile.
On Thu, Aug 1, 2013 at 12:17 PM, wrote:
> NOT lgtm. Why the change for an experimental feature that we don't make any
> promises about? This is needless code ch
First round of comments.
https://codereview.chromium.org/21079003/diff/2007/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/21079003/diff/2007/src/harmony-array.js#newcode48
src/harmony-array.js:48: var length = ToUint32(array.length);
The access to "arra
On 2013/07/31 17:12:58, Jakob wrote:
Drive-by LGTM with a comment.
https://codereview.chromium.org/21103011/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21103011/diff/1/src/hydrogen.cc#newcode3016
src/hydrogen.cc:3016: // TODO(titzer): this phase shou
NOT lgtm. Why the change for an experimental feature that we don't make any
promises about? This is needless code churn that I see no benefit from. I am
very tempted to roll this back... and in the future please don't don't make
changes to experimental features on purpose that change one incorrect
Committed patchset #1 manually as r16008.
https://codereview.chromium.org/21531003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16008
Author: jkumme...@chromium.org
Date: Thu Aug 1 09:12:31 2013
Log: Remove buggy ToNumber truncation
BUG=v8:2813
R=da...@chromium.org
Review URL: https://codereview.chromium.org/21531003
http://code.google.com/p/v8/source/detail?r=16008
Modified:
/branches/bleeding_ed
A test case would be nice :-), but otherwise lgtm
https://codereview.chromium.org/21531003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Reviewers: danno,
Message:
PTAL.
Description:
Remove buggy ToNumber truncation
BUG=v8:2813
Please review this at https://codereview.chromium.org/21531003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/
Updates:
Status: Accepted
Owner: mstarzin...@chromium.org
Cc: rossb...@chromium.org ioseb.dz...@gmail.com
Labels: -Type-Bug Type-FeatureRequest
Comment #2 on issue 2777 by mstarzin...@chromium.org: ES6: Implement
Array.prototype.findIndex
http://code.google.com/
I'll take a look at this one.
https://codereview.chromium.org/21079003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Updates:
Status: Accepted
Owner: mstarzin...@chromium.org
Cc: rossb...@chromium.org ioseb.dz...@gmail.com
Labels: -Type-Bug Type-FeatureRequest
Comment #2 on issue 2776 by mstarzin...@chromium.org: ES6: Implement
Array.prototype.find
http://code.google.com/p/v8/
Reviewers: Jakob,
Description:
Store transition on HStoreNamedField as HConstant.
This allows optimization passes that run in the parallel compiler thread
to use the map that a store transitions to for further analysis even
though the map handle cannot be dereferenced.
R=jkumme...@chromium.org
Adding Dmitry who was there at the F2F
https://codereview.chromium.org/21180008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
lgtm
https://codereview.chromium.org/21466003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Looking good already. I like this change. A few comments on the interface
though. Also, can we add a few one-liner comments to the public methods of
the
EternalHandle class explaining semantics?
https://codereview.chromium.org/21133006/diff/9001/src/global-handles.cc
File src/global-handles.c
Reviewers: Sven Panne,
Description:
IsNearDeath needs to include pending nodes
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/21466003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/global-handles.c
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc#newcode488
src/compiler.cc:488: info()->set_bailout_reason(kCodeGenerationFailed);
On 2013/08/01 12:02:13, Jakob wrote:
While you'r
Committed patchset #2 manually as r16007.
https://chromiumcodereview.appspot.com/20607005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Revision: 16007
Author: u...@chromium.org
Date: Thu Aug 1 05:55:19 2013
Log: Fix mozilla regress-398085-01 failure on windows.
Make sure that all stack pages are mapped before accessing them.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20607005
http:/
lgtm
https://chromiumcodereview.appspot.com/20607005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Message:
PTAL
Description:
Fix mozilla regress-398085-01 failure on windows.
Make sure that all stack pages are mapped before accessing them.
R=jkumme...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/20607005/
SVN Base: https://v8.googlecode.com/
As discussed offline with Michael: Wouldn't it be much easier and far more
readable with:
* Use 2 lists instead of a partitioned one. Iterators would make it easy
to
iterate over all nodes or only over one of the parts.
* Use a circular doubly linked list with the standard "looped" sent
LGTM (with a few comments). This is a maintenance nightmare.
https://codereview.chromium.org/21042004/diff/17001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/21042004/diff/17001/src/global-handles.cc#newcode61
src/global-handles.cc:61: LAST_STATE = N
On 2013/08/01 12:02:13, Jakob wrote:
DBC.
Could you explain briefly what the motivation for this change is?
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc#newcode488
src/c
lgtm
https://codereview.chromium.org/21534002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: ulan,
Description:
TSan: Move definition of AtomicOps_x86CPUFeatureStruct into v8::internal
namespace
This matches other atomicops_internals_* files.
Please review this at https://codereview.chromium.org/21534002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affec
DBC.
Could you explain briefly what the motivation for this change is?
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc#newcode488
src/compiler.cc:488: info()->set_bailout_reason(
LGTM with comment.
https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc#newcode814
src/ia32/lithium-ia32.cc:814: if (op == Token::MOD) return
MarkAsCall(DefineSame
LGTM, I'll land.
Next time, when you accidentally delete a local git branch, you can create
a new
one and use "git cl issue 21210002" to associate it with an existing code
review
issue. Or even easier: you'll probably want to do "git cl patch 21210002" on
that new branch instead, which autom
Why not move this logic into void Assembler::test(const Operand& op, const
Immediate& imm) in assembler-ia32.cc, similar to what the Register+Immediate
variant is already doing? That way all call sites would benefit without
having
to adapt every single one of them.
https://codereview.chromium.
I like this change. Lgtm with some nits.
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode4902
src/ia32/lithium-codegen-ia
LGTM. The bug number in the CL description seems to be off though.
https://codereview.chromium.org/21512002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Updates:
Summary: Local variables of non-topmost stack frames cannot be inspected
Status: Accepted
Comment #4 on issue 2820 by jkumme...@chromium.org: Local variables of
non-topmost stack frames cannot be inspected
http://code.google.com/p/v8/issues/detail?id=2820
OK, so the i
https://codereview.chromium.org/20843012/diff/6001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/objects.cc#newcode15968
src/objects.cc:15968: ASSERT(reason >= kLastErrorMessage);
<
https://codereview.chromium.org/20843012/diff/6001/src/objec
LGTM (with nits). I didn't actually review the implementation of the runtime
methods, but I assume it's a straight copy of the existing ones.
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/21499003/diff/1/src/runtime.c
https://codereview.chromium.org/21505002/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21505002/diff/3001/src/hydrogen.cc#newcode7731
src/hydrogen.cc:7731: HValue* context) {
On 2013/08/01 09:21:09, Sven Panne wrote:
Hmmm, having 8 arguments is not very
Reviewers: Yury Semikhatsky, alph,
Message:
the most part of the patch is a mechanical changes that were made by the
script.
use strict;
my %map;
my $filter =
'Bailout\("|Abort\("|set_bailout_reason\("|DisableOptimization\("|
\sCheck\([^"].+"|\sAssert\([^"].+"';
print $filter . "\n";
my
As discussed, I don't really see the point of this change.
https://codereview.chromium.org/21367002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscr
lgtm
https://codereview.chromium.org/21511002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/21509002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/20831003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/21495002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
mod does not rely on a fixed register anymore, the arguments are passed via
the
stack.
BUG=
Please review this at https://codereview.chromium.org/21495005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-ia3
Reviewers: Toon Verwaest,
Description:
Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi
Additionally refactor the X87Stack tracking
BUG=
Please review this at https://codereview.chromium.org/20781007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affecte
lgtm
https://codereview.chromium.org/21495004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Comment #14 on issue 2071 by u...@chromium.org: with statement is broken
since Chrome 19
http://code.google.com/p/v8/issues/detail?id=2071
@joeedh, is it possible to get a test that reproduces the problem?
--
You received this message because this project is configured to send all
issue no
Updates:
Blockedon: v8:2590
Comment #8 on issue 1497 by dslo...@chromium.org: Typed Array function
constructors should expose `call` and `apply` methods.
http://code.google.com/p/v8/issues/detail?id=1497
(No comment was entered for this change.)
--
You received this message because t
https://codereview.chromium.org/21340002/diff/14001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/21340002/diff/14001/src/runtime.cc#newcode8247
src/runtime.cc:8247: if (it.frame()->function()->code() ==
*optimized_code) {
Yep, this method is looking good to me now.
Issue 2590: Implement ES6 TypedArrays
http://code.google.com/p/v8/issues/detail?id=2590
This issue is now blocking issue v8:1497.
See http://code.google.com/p/v8/issues/detail?id=1497
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you star
Updates:
Owner: dslo...@chromium.org
Cc: da...@chromium.org
Comment #7 on issue 1497 by dslo...@chromium.org: Typed Array function
constructors should expose `call` and `apply` methods.
http://code.google.com/p/v8/issues/detail?id=1497
(No comment was entered for this change.)
On 2013/08/01 09:21:39, dcarney wrote:
lgtm
maybe the i18n runtime functions want their own file if they are behind a
compile flag?
Then I don't have all the nice macros (and the debugger support stuff is
also
behind a compile flag).
https://codereview.chromium.org/21499003/
--
--
v8-de
Comment #13 on issue 2071 by joe...@gmail.com: with statement is broken
since Chrome 19
http://code.google.com/p/v8/issues/detail?id=2071
I think this bug has reappeared, or at least I'm getting it; with
statements in nested functions are producing ReferenceError's. I'm using
version 28.
LGTM with nits.
https://codereview.chromium.org/21505002/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21505002/diff/3001/src/hydrogen.cc#newcode7635
src/hydrogen.cc:7635: HValue* right,
Nit: Fix indentation of arguments.
https://codereview.chromium.or
lgtm
maybe the i18n runtime functions want their own file if they are behind a
compile flag?
https://codereview.chromium.org/21499003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Revision: 16006
Author: dslo...@chromium.org
Date: Thu Aug 1 02:18:28 2013
Log: Calling Map etc without new should throw TypeError
Even though we do not yet allow Map, Set, WeakMap and WeakSet to be
subclassed we need to ensure that we do not allow them to be [[Call]]ed
to allow them
Committed patchset #1 manually as r16006 (presubmit successful).
https://codereview.chromium.org/2142/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Michael Starzinger,
Description:
Reenable tests that need to access the default timezone.
It's now available via builtins.
BUG=v8:2475
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/21512002/
SVN Base: https://v8.googlecode.com/svn/branches/bleedin
In related news, I want a pony^W^W compilation trybots
On Thu, Aug 1, 2013 at 11:04 AM, Dmitry Lomov wrote:
> I prefer to have a self-contained CL rather than a CL and a myriad of
> dependent CLs. I know that we were lax about this before, but I like to do
> the right thing (it is also pretty e
Reviewers: Jakob,
Description:
Remove test that v8Intl symbol exists, as we don't define it anymore.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/21511002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
D test/intl/general/v8
lgtm
https://codereview.chromium.org/21502002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: mvstanton,
Description:
Extend assembler and codegen with more fpu arithmetic
BUG=
Please review this at https://codereview.chromium.org/21509003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia3
https://codereview.chromium.org/21499003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Michael Starzinger,
Description:
Move helper methods from i18n extension into runtime.
BUG=v8:2475
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/21499003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/exten
Discussed offline, but putting this here for the record: the new behavior is
better because it is future-proof - the user cannot write code that will
break.
https://codereview.chromium.org/2142/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Reviewers: Jakob,
Description:
Fix incorrect #ifdef statements for I18N support.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/21509002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/api.cc
M src/icu_util.cc
Index:
Comment #3 on issue 2820 by ch...@allestelle.com: Content of variables not
used in closures cannot be inspected
http://code.google.com/p/v8/issues/detail?id=2820
The actual use case is:
function myFunction(param, cb){
cb(param^2+param/45); //Or whatever... something that produce an
exp
Reviewers: Jakob,
Description:
Never define 'DEBUG' for non-v8 code
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/20831003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M build/standalone.gypi
Index: build/standalone.gypi
1 - 100 of 156 matches
Mail list logo
