Comment #3 on issue 2842 by jokeyrh...@gmail.com: v8.log: ReferenceError:
arguments is not defined
http://code.google.com/p/v8/issues/detail?id=2842
This project wraps the tools provided with the V8 source code, making it
very easy to parse the profiler v8.log (and it works on my system, ya
PTAL.
https://codereview.chromium.org/23026005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Jakob,
Description:
Merged r16200 into trunk branch.
MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow
changing
hole to nan if all uses allow undefined as nan.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23026005/
SVN B
Revision: 16200
Author: pal...@homejinni.com
Date: Wed Aug 14 16:07:48 2013
Log: MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only
allow changing hole to nan if all uses allow undefined as nan.
Port r16183 (1858bc57)
BUG=
Review URL: https://codereview.chromium.org/23
Committed manually as r16200.
https://codereview.chromium.org/23130006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Thanks for the review, I've fixed the nits.
https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc#newcode2325
src/mips/lithium-codegen-mips.
Fixed nits.
https://codereview.chromium.org/23130006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
LGTM, with the nitty rename request.
https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc#newcode2325
src/mips/lithium-codegen-mips.cc:2325
Reviewers: machenbach, Jakob,
Message:
I agree. I am sorry for adding more exceptions.
Description:
Avoid -O3 in nacl as it does not play well with -W.
Also cleans up some uninitialized data I saw while investigating
the problem.
Please review this at https://codereview.chromium.org/23119004/
Reviewers: Paul Lind, kisg, kilvadyb, danno, Toon Verwaest,
Message:
PTAL.
Description:
MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow
changing
hole to nan if all uses allow undefined as nan.
Port r16183 (1858bc57)
BUG=
Please review this at https://codereview.chromi
Reviewers: abarth, rossberg,
Description:
Add access check for observed objects
This change is mostly straightforward: for 'normal' sorts of change records,
simply don't deliver a changeRecord to a given observer callback if an
access
the callback's Context is not allowed to [[Get]] changeRec
On 2013/08/14 19:39:31, dcarney wrote:
On 2013/08/13 23:11:12, arv wrote:
> Hi Dan,
>
> I'm not sure who is the best person to review FunctionTemplate changes.
If
there
> is someone else that is more suitable feel free to change the reviewers.
>
> Thanks
It seems somewhat unnatural to not ha
Reviewers: Yang,
Message:
Hi Yang
This should be the patch for a long annoying bug.
I definitely could use some help with assembler clean-up, because currently
it's
very sketchy.
Peter
Description:
Patch CEntry stub to swallow exception if liveedit/restart frame needs it.
BUG=2203
Please r
Updates:
Owner: pry...@chromium.org
Comment #1 on issue 2203 by peter.ry...@gmail.com: [LiveEdit] restart frame
doesn't work when VM is paused on throwing exception.
http://code.google.com/p/v8/issues/detail?id=2203
(No comment was entered for this change.)
--
You received this messa
On 2013/08/13 23:11:12, arv wrote:
Hi Dan,
I'm not sure who is the best person to review FunctionTemplate changes. If
there
is someone else that is more suitable feel free to change the reviewers.
Thanks
It seems somewhat unnatural to not have a prototype property, but, whatever
the
Updates:
Status: Accepted
Cc: da...@chromium.org dcar...@chromium.org verwa...@chromium.org
Labels: Type-FeatureRequest
Comment #6 on issue 1482 by a...@chromium.org: It is not possible to
configure properties with getters and setters with an ObjectTemplate
http://code.
Lgtm with a comment for future reference.
https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc#newcode2869
src/hydrogen-instructions.cc:2869: map->CanT
Reviewers: Toon Verwaest,
Description:
Make HConstant::InstanceOf less ambiguous.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/23203002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
M src/hydr
Revision: 16199
Author: da...@chromium.org
Date: Wed Aug 14 10:15:00 2013
Log: Tagging version 3.20.17
http://code.google.com/p/v8/source/detail?r=16199
Added:
/tags/3.20.17
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM.
https://codereview.chromium.org/22815005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Committed patchset #2 manually as r16197 (presubmit successful).
https://codereview.chromium.org/22870007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16197
Author: da...@chromium.org
Date: Wed Aug 14 10:10:14 2013
Log: Prepare push to trunk. Now working on version 3.21.0
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/22870007
http://code.google.com/p/v8/source/detail?r=16197
Modified:
/branches/
LGTM (rubber-stamped).
https://codereview.chromium.org/22870007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Reviewers: Michael Starzinger,
Description:
Prepare push to trunk. Now working on version 3.20.18.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/22870007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/v
Revision: 16196
Author: da...@chromium.org
Date: Wed Aug 14 10:03:19 2013
Log: Fix GC Mole warning
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/22815005
http://code.google.com/p/v8/source/detail?r=16196
Modified:
/branches/bleeding_edge/src/hydrogen-instruc
Committed patchset #1 manually as r16196.
https://codereview.chromium.org/22815005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Michael Starzinger,
Description:
Fix GC Mole warning
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/22815005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instr
Revision: 16195
Author: da...@chromium.org
Date: Wed Aug 14 10:00:16 2013
Log: Fix src/version.cc number to be consistent with next trunk push
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/2310
http://code.google.com/p/v8/source/detail?r=16195
Modified:
Committed patchset #1 manually as r16195.
https://codereview.chromium.org/2310/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Committed patchset #1 manually as r16194.
https://chromiumcodereview.appspot.com/23154004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Revision: 16194
Author: verwa...@chromium.org
Date: Wed Aug 14 09:58:14 2013
Log: Fix no-sse2 part 2.
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23154004
http://code.google.com/p/v8/source/detail?r=16194
Modified:
/branches/bleeding_edge/src/ia32/lithium
lgtm
https://chromiumcodereview.appspot.com/23154004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: danno,
Message:
PTAL
Description:
Fix no-sse2 part 2.
Please review this at https://chromiumcodereview.appspot.com/23154004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-codegen-ia32.cc
Index: src/ia32/lithium-codegen-ia32.cc
LGTM (rubber-stamped).
https://codereview.chromium.org/2310/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Reviewers: Michael Starzinger,
Description:
Fix src/version.cc number to be consistent with next trunk push
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/2310/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/version
Revision: 16193
Author: da...@chromium.org
Date: Wed Aug 14 09:13:58 2013
Log: Fix Crankshafted CompareNil of constant values
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/23198002
http://code.google.com/p/v8/source/detail?r=16193
Added:
/branches/bleeding_edg
Committed patchset #3 manually as r16193.
https://codereview.chromium.org/23198002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
patch set 2 LGTM too.
https://codereview.chromium.org/23198002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
https://codereview.chromium.org/23198002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Revision: 16192
Author: verwa...@chromium.org
Date: Wed Aug 14 08:50:23 2013
Log: Fix CmpHoleAndBranch on no-sse2
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22810005
http://code.google.com/p/v8/source/detail?r=16192
Modified:
/branches/bleeding_edge/src/
Committed patchset #2 manually as r16192.
https://chromiumcodereview.appspot.com/22810005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
lgtm
https://codereview.chromium.org/22810005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM with nit.
https://codereview.chromium.org/23198002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23198002/diff/1/src/hydrogen.cc#newcode1755
src/hydrogen.cc:1755: Object* constant_object =
*(constant_value->handle());
nit: let's just keep this handlif
Reviewers: Jakob,
Message:
PTAL
Description:
Fix Crankshafted CompareNil of constant values
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/23198002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.cc
A + test/m
lgtm with comments:
It fixes the issue. Even though, I am not happy that toolchain.gypi is full
of
exceptions...
@Jakob: Second pair of eyes?
https://codereview.chromium.org/23119004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received t
On Wed, Aug 14, 2013 at 11:13 AM, wrote:
> What I mean is that you can't break when you go past the length. You
> actually
> have to go to a slow path when you read past the length, that does the
> entire
> in-check; and loops until the index surpasses the preloaded length value.
> And
> that's i
What I mean is that you can't break when you go past the length. You
actually
have to go to a slow path when you read past the length, that does the
entire
in-check; and loops until the index surpasses the preloaded length value.
And
that's independent of whether the receiver is fast-packed
On 2013/08/14 14:48:55, Toon Verwaest wrote:
You can actually create, using Object.defineProperty, an array that
doesn't
have
foreign accessors as its length anymore.
No, Array instances have a non configurable length data property.
At that point values don't get deleted
anymore when you r
Reviewers: Jakob,
Message:
PTAL
Description:
Fix unreachable liveness of unreachable constant-folded branches
BUG=chromium:258519
Please review this at https://codereview.chromium.org/22876009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithiu
Reviewers: danno,
Message:
Committed patchset #1 manually as r16191.
Description:
Revert "Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv."
This reverts r16190.
TBR=da...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16191
Please review thi
Revision: 16191
Author: bmeu...@chromium.org
Date: Wed Aug 14 07:50:15 2013
Log: Revert "Drop broken and unnecessary RequiredInputRepresentation()
in HMathFloorOfDiv."
This reverts r16190.
TBR=da...@chromium.org
Review URL: https://codereview.chromium.org/23188003
http://code.goog
You can actually create, using Object.defineProperty, an array that doesn't
have
foreign accessors as its length anymore. At that point values don't get
deleted
anymore when you reduce the length. This means you can create a "packed
array"
which has elements beyond its length (which you can f
Committed patchset #1 manually as r16190.
https://codereview.chromium.org/23190002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
On 2013/08/14 07:48:47, Michael Starzinger wrote:
https://codereview.chromium.org/22545007/diff/20001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/22545007/diff/20001/src/array.js#newcode1263
src/array.js:1263: if (!isProxy && %HasFastPackedElements(array) || i in
a
Revision: 16190
Author: bmeu...@chromium.org
Date: Wed Aug 14 07:34:40 2013
Log: Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/23190002
http://code.google.com/p/v8/source/detail?r=1619
lgtm
https://codereview.chromium.org/23190002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Updates:
Status: Fixed
Comment #8 on issue 2740 by verwa...@chromium.org: r15156 slowed some array
code WAY down
http://code.google.com/p/v8/issues/detail?id=2740
I'm going to close this given that the indicated perf-problem has been
fixed.
--
You received this message because thi
Reviewers: titzer, danno,
Description:
Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv.
Please review this at https://codereview.chromium.org/23190002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Reviewers: danno,
Message:
PTAL
Description:
Fix CmpHoleAndBranch on no-sse2
Please review this at https://chromiumcodereview.appspot.com/22810005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-codegen-ia32.cc
Index: src/ia32/lithium-cod
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h
File src/allocation.h (right):
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h#newcode36
src/allocation.h:36: // Specify memory alignment for structs, classes,
etc.
On 2013/08/14 11:38:09, Benedikt Meurer w
Late DBC...
https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/Makefile
File tools/gcmole/Makefile (right):
https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/Makefile#newcode43
tools/gcmole/Makefile:43: rm -f libgcmole.so
Pro tip: Use $(RM). :-) Furthermore, clean sho
LGTM. I'll land this next week.
https://codereview.chromium.org/23176002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and sto
Revision: 16188
Author: joc...@chromium.org
Date: Wed Aug 14 05:53:01 2013
Log: updates
http://code.google.com/p/v8/source/detail?r=16188
Modified:
/branches/bleeding_edge/tools/gcmole/bootstrap.sh
===
--- /branches/bleeding_edge/tools/gcmole/boots
Revision: 16189
Author: joc...@chromium.org
Date: Wed Aug 14 05:53:09 2013
Log: updates
http://code.google.com/p/v8/source/detail?r=16189
Modified:
/branches/bleeding_edge/tools/gcmole/bootstrap.sh
===
--- /branches/bleeding_edge/tools/gcmole/boots
Revision: 16187
Author: joc...@chromium.org
Date: Wed Aug 14 05:52:51 2013
Log: Add a bootstrap script to make it easier to build gcmole
R=machenb...@chromium.org
http://code.google.com/p/v8/source/detail?r=16187
Added:
/branches/bleeding_edge/tools/gcmole/bootstrap.sh
Modified:
/br
LGTM with nit
https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/bootstrap.sh
File tools/gcmole/bootstrap.sh (right):
https://codereview.chromium.org/22893006/diff/5001/tools/gcmole/bootstrap.sh#newcode124
tools/gcmole/bootstrap.sh:124: echo
nit: trailing whitespace
https://codere
Revision: 16186
Author: jkumme...@chromium.org
Date: Wed Aug 14 05:40:44 2013
Log: Revert "Make GlobalHandle::NodeBlock deletable"
This reverts r16040 due to OOM crashes.
R=da...@chromium.org
Review URL: https://codereview.chromium.org/22970004
http://code.google.com/p/v8/source/deta
lgtm
https://codereview.chromium.org/22970004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r16186.
https://codereview.chromium.org/22970004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: danno,
Message:
PTAL.
Description:
Revert "Make GlobalHandle::NodeBlock deletable"
This reverts r16040 due to OOM crashes.
Please review this at https://codereview.chromium.org/22970004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/global-
Comment #2 on issue 2843 by ri...@chromium.org: Flaky error on the 3.20
branch
http://code.google.com/p/v8/issues/detail?id=2843
Actually attach the file
Attachments:
out.js 780 KB
--
You received this message because this project is configured to send all
issue notifications to
Updates:
Cc: a...@google.com kusterm...@google.com
Comment #1 on issue 2843 by ri...@chromium.org: Flaky error on the 3.20
branch
http://code.google.com/p/v8/issues/detail?id=2843
(No comment was entered for this change.)
--
You received this message because this project is configure
Status: Accepted
Owner:
CC: da...@chromium.org, mstarzin...@chromium.org
Labels: Type-Bug Priority-High
New issue 2843 by ri...@chromium.org: Flaky error on the 3.20 branch
http://code.google.com/p/v8/issues/detail?id=2843
I updated our d8 testing binary to the 3.20 branch and is seeing th
Updates:
Status: Verified
Comment #2 on issue 2827 by machenb...@chromium.org:
benchmarks/sunspider/3d-morph crashes under deopt stress
http://code.google.com/p/v8/issues/detail?id=2827
(No comment was entered for this change.)
--
You received this message because this project is con
Revision: 16185
Author: jkumme...@chromium.org
Date: Wed Aug 14 05:14:08 2013
Log: Fix Math.round/floor that had bogus Smi representation
BUG=chromium:272564
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/23022005
http://code.google.com/p/v8/source/detail?r=16185
Committed patchset #1 manually as r16185.
https://codereview.chromium.org/23022005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
lgtm
https://codereview.chromium.org/23022005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Fix Math.round/floor that had bogus Smi representation
BUG=chromium:272564
Please review this at https://codereview.chromium.org/23022005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-ins
https://codereview.chromium.org/22893006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: machenbach,
Description:
Add a bootstrap script to make it easier to build gcmole
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/22893006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/gcmole/Makefile
A t
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h
File src/allocation.h (right):
https://codereview.chromium.org/22849002/diff/32001/src/allocation.h#newcode36
src/allocation.h:36: // Specify memory alignment for structs, classes,
etc.
Please move the ALIGN_AT definition to gl
Reviewers: Sven Panne, Michael Starzinger, ulan,
Message:
PTAL
Description:
Replace OS::Ticks() with Stopwatch utility class.
OS::Ticks() was used to measure elapsed time in microseconds, which
is now properly encapsulated in the Stopwatch class. Stopwatch uses
a monotonic clock if available, f
Reviewers: Michael Starzinger,
Description:
Push SetAccessor to Template
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23182003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/api.cc
M src/apina
On 2013/08/13 11:49:02, Toon Verwaest wrote:
PTAL
lgtm.
https://chromiumcodereview.appspot.com/23047002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 16184
Author: verwa...@chromium.org
Date: Wed Aug 14 02:47:27 2013
Log: Load size in signed int before making negative.
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23074003
http://code.google.com/p/v8/source/detail?r=16184
Modified:
/branches/bl
Committed patchset #2 manually as r16184.
https://chromiumcodereview.appspot.com/23074003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
lgtm
https://chromiumcodereview.appspot.com/23074003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: danno,
Message:
PTAL
Description:
Load size in signed int before making negative.
Please review this at https://chromiumcodereview.appspot.com/23074003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/lithium-codegen-ia32.cc
M src/x64/l
Committed patchset #7 manually as r16183.
https://chromiumcodereview.appspot.com/22152003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Revision: 16183
Author: verwa...@chromium.org
Date: Wed Aug 14 01:54:27 2013
Log: Never hchange nan-hole to hole or hole to nan-hole.
Only allow changing hole to nan if all uses allow undefined as nan.
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22152003
ht
Reviewers: Jakob,
Description:
Fixed HMul::Canonicalize() to support SMI
Same idea for HDiv when the right oeprand is 1
BUG=
Please review this at https://codereview.chromium.org/23176002/
SVN Base: https://github.com/v8/v8.git@master
Affected files:
M src/hydrogen-instructions.cc
M src/
https://codereview.chromium.org/22545007/diff/20001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/22545007/diff/20001/src/array.js#newcode1263
src/array.js:1263: if (!isProxy && %HasFastPackedElements(array) || i in
array) {
On 2013/08/13 20:47:42, Toon Verwaest wrote:
92 matches
Mail list logo
