Thanks for review!
This is now ready to land. svenpanne, can you land it?
https://codereview.chromium.org/23707009/diff/1/test/cctest/test-declarative-accessors.cc
File test/cctest/test-declarative-accessors.cc (right):
Updates:
Status: Assigned
Owner: bmeu...@chromium.org
Labels: Type-FeatureRequest OS-All HW-All Priority-Low
Comment #1 on issue 1844 by bmeu...@chromium.org: Missing version macros
for preprocessor
http://code.google.com/p/v8/issues/detail?id=1844
(No comment was
Updates:
Status: Accepted
Owner: verwa...@chromium.org
Comment #2 on issue 2866 by verwa...@chromium.org: Possibly incorrect order
of evaluation with __defineGetter__
http://code.google.com/p/v8/issues/detail?id=2866
(No comment was entered for this change.)
--
You received
Updates:
Status: Duplicate
Mergedinto: 691
Comment #3 on issue 2866 by verwa...@chromium.org: Possibly incorrect order
of evaluation with __defineGetter__
http://code.google.com/p/v8/issues/detail?id=2866
(No comment was entered for this change.)
--
You received this message
Comment #8 on issue 691 by verwa...@chromium.org: Sequencing of getter side
effects wrong
http://code.google.com/p/v8/issues/detail?id=691
Issue 2866 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this
Reviewers: ,
Description:
Initial prototype of object layout generation.
R=
Please review this at https://codereview.chromium.org/23604020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile
M src/objects-debug.cc
A src/objects-gen.h
A
Reviewers: Sven Panne,
Description:
remove Isolate::Current from most files starting with 'a'
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23859002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/accessors.cc
M
Reviewers: Benedikt Meurer,
Message:
On 2013/08/30 07:31:32, Benedikt Meurer wrote:
Your patch broke the ARM tests, we had to revert. Please submit a new
patch
that
actually passes the test suite.
Sorry about that, we did not realize the bug had been fixed in the latest
bleeding edge.
https://codereview.chromium.org/23604020/diff/1/src/objects.layout
File src/objects.layout (right):
https://codereview.chromium.org/23604020/diff/1/src/objects.layout#newcode56
src/objects.layout:56: { name: value, comment: the boxed contents.
},
I guess a field without a type is just assumed
Reviewers: Sven Panne, Jakob,
Message:
PTAL
Description:
Move version macros to public V8 header.
Move the V8 version macros to the public v8.h file, so it can be used
by other projects for testing specific V8 versions at compile time.
Adjust tools to work on include/v8.h instead of
Hey Sven,
Please have a look.
CC'd Jakob for sanity checking of build system implications.
https://codereview.chromium.org/23723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Latest patch-set is busted. Can you upload it again?
https://codereview.chromium.org/23748003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
lgtm
https://codereview.chromium.org/23824002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2013/09/02 09:04:35, Michael Starzinger wrote:
Latest patch-set is busted. Can you upload it again?
Done.
https://codereview.chromium.org/23748003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Toon Verwaest,
Description:
Remove OptimizedCodeEntry *sigh*.
BUG=
Please review this at https://codereview.chromium.org/23584004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/factory.h
M src/factory.cc
M src/heap.h
LGTM. It's a pity that we have to keep the Isolate field in the AST visitor
because of the stack check. Otherwise this should really belong to the
subclasses... :-P
https://codereview.chromium.org/23859002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Committed patchset #1 manually as r16462 (presubmit successful).
https://codereview.chromium.org/23824002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16462
Author: dcar...@chromium.org
Date: Mon Sep 2 09:25:20 2013 UTC
Log: thread isolate in accessors.cc
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23824002
http://code.google.com/p/v8/source/detail?r=16462
Modified:
Committed patchset #1 manually as r16463 (presubmit successful).
https://codereview.chromium.org/23859002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16463
Author: dcar...@chromium.org
Date: Mon Sep 2 09:27:27 2013 UTC
Log: remove Isolate::Current from most files starting with 'a'
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23859002
http://code.google.com/p/v8/source/detail?r=16463
Committed patchset #8 manually as r16464 (presubmit successful).
https://codereview.chromium.org/22290005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16464
Author: ol...@chromium.org
Date: Mon Sep 2 09:30:54 2013 UTC
Log: Move ToI conversions to the MacroAssembler
+ Replace DeferredTaggedToINoSSE2 by DoubleToIStub and a fpu version.
+ Prevent truncating TaggedToI from bailing out.
BUG=
R=verwa...@chromium.org
Review
lgtm
https://codereview.chromium.org/23584004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Sven Panne,
Description:
thread isolate in PreallocatedStorageAllocationPolicy
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23479015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/allocation-inl.h
M
Committed patchset #1 manually as r16465 (presubmit successful).
https://codereview.chromium.org/23584004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: titzer,
Description:
Fix OSR to ignore phis without merge index in loop entry.
This fixes a corner case introduced by escape analysis where phis are
introduced in OSR loop entry blocks that don't have a merge index and
hence cannot contain OSR values.
R=tit...@chromium.org
LGTM. I'm not totally happy with our template magic for policies, but this
has
been there before. We'll clean this up later. :-D
https://codereview.chromium.org/23479015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Revision: 16465
Author: tit...@chromium.org
Date: Mon Sep 2 10:35:34 2013 UTC
Log: Remove OptimizedCodeEntry *sigh*.
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/23584004
http://code.google.com/p/v8/source/detail?r=16465
Modified:
Reviewers: Sven Panne,
Description:
Prepare push to trunk. Now working on version 3.21.9.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/23620015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
High-level comment:
I'm not convinced that we want this change. Given the rate at which the V8
API
changes, and the rate at which new branches are created and old branches
become
unsupported, I'm hesitant to create the appearance that supporting several
V8
versions in embedding code is
Committed patchset #1 manually as r16466 (presubmit successful).
https://codereview.chromium.org/23620015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16466
Author: jkumme...@chromium.org
Date: Mon Sep 2 11:01:06 2013 UTC
Log: Prepare push to trunk. Now working on version 3.21.9.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/23620015
http://code.google.com/p/v8/source/detail?r=16466
Modified:
lgtm
https://codereview.chromium.org/23620015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2013/09/02 11:00:47, Jakob wrote:
High-level comment:
I'm not convinced that we want this change. Given the rate at which the
V8 API
changes, and the rate at which new branches are created and old branches
become
unsupported, I'm hesitant to create the appearance that supporting
several
Updates:
Status: Invalid
Comment #2 on issue 1844 by bmeu...@chromium.org: Missing version macros
for preprocessor
http://code.google.com/p/v8/issues/detail?id=1844
Rejected, see Jakob's comment in https://codereview.chromium.org/23723003/.
--
You received this message because this
Reviewers: Sven Panne,
Description:
thread isolate for files starting with 'c' and 'd'
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23729006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/builtins.h
M
Committed patchset #2 manually as r16467 (presubmit successful).
https://codereview.chromium.org/23479015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16467
Author: dcar...@chromium.org
Date: Mon Sep 2 11:20:42 2013 UTC
Log: thread isolate in PreallocatedStorageAllocationPolicy
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23479015
http://code.google.com/p/v8/source/detail?r=16467
Modified:
Reviewers: titzer,
Description:
Introduce speculative concurrent on-stack replacement.
Currently disabled behind --speculative-osr.
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23710014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Revision: 16468
Author: dcar...@chromium.org
Date: Mon Sep 2 11:39:23 2013 UTC
Log: revert thread isolate in PreallocatedStorageAllocationPolicy
This reverts 16467 for breaking windows build
TBR=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23824005
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16468.
Description:
revert thread isolate in PreallocatedStorageAllocationPolicy
This reverts 16467 for breaking windows build
TBR=svenpa...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16468
Status: New
Owner:
CC: a...@google.com, verwa...@chromium.org, hpa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2867 by fschnei...@chromium.org: Infinite
optimization/deoptimization cycle from generic property store
http://code.google.com/p/v8/issues/detail?id=2867
The
LGTM.
https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc
File test/cctest/test-semaphore.cc (right):
https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc#newcode28
test/cctest/test-semaphore.cc:28: // Tests of the TokenLock class from
Reviewers: Jakob,
Message:
PTAL
Description:
Representation of interceptor / handler properties are tagged.
Otherwise store ICs will never be initialized, due to
lookup-CanHoldValue(value);
BUG=chromium:256330
Please review this at https://chromiumcodereview.appspot.com/23533012/
SVN Base:
Revision: 16470
Author: jkumme...@chromium.org
Date: Mon Sep 2 11:48:34 2013 UTC
Log: Tagging version 3.21.8
http://code.google.com/p/v8/source/detail?r=16470
Added:
/tags/3.21.8
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
LGTM.
Can we have a testcase (that asserts that a function doesn't deopt when
optimized code sees the same types that the IC did)?
https://chromiumcodereview.appspot.com/23533012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
As discussed offline, this patch doesn't change anything, as defined values
default to 1 anyway. It doesn't hurt to keep it in for now, but the next
cleanup
can take it out again.
https://codereview.chromium.org/23718004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc
File test/cctest/test-semaphore.cc (right):
https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc#newcode28
test/cctest/test-semaphore.cc:28: // Tests of the TokenLock class from
lock.h
Thanks! LGTM.
https://chromiumcodereview.appspot.com/23533012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Revision: 16471
Author: verwa...@chromium.org
Date: Mon Sep 2 12:16:02 2013 UTC
Log: Representation of interceptor / handler properties are tagged.
Otherwise store ICs will never be initialized, due to
lookup-CanHoldValue(value);
BUG=chromium:256330
R=jkumme...@chromium.org
Committed patchset #2 manually as r16471 (presubmit successful).
https://chromiumcodereview.appspot.com/23533012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #4 manually as r16472 (presubmit successful).
https://codereview.chromium.org/23264015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #8 manually as r16473 (presubmit successful).
https://codereview.chromium.org/23748003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Updates:
Status: Accepted
Owner: verwa...@chromium.org
Comment #1 on issue 2867 by verwa...@chromium.org: Infinite
optimization/deoptimization cycle from generic property store
http://code.google.com/p/v8/issues/detail?id=2867
(No comment was entered for this change.)
--
You
Revision: 16474
Author: bmeu...@chromium.org
Date: Mon Sep 2 12:36:08 2013 UTC
Log: Fix Mac llvm-gcc42 build after commit r16473.
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/23437020
http://code.google.com/p/v8/source/detail?r=16474
Modified:
Reviewers: machenbach,
Message:
Committed patchset #1 manually as r16474.
Description:
Fix Mac llvm-gcc42 build after commit r16473.
TBR=machenb...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16474
Please review this at https://codereview.chromium.org/23437020/
SVN
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc#newcode49
src/code-stubs.cc:49: miss_handler_(),
Is this change intentional? I can't easily see why it's
correct/needed...
Reviewers: Jakob,
Message:
PTAL
Description:
Allow uncacheable identifiers to go generic.
BUG=v8:2867
Please review this at https://chromiumcodereview.appspot.com/23453019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ic.cc
M src/objects-inl.h
M
Addressed offline comments.
https://codereview.chromium.org/23503025/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Updates:
Status: Fixed
Comment #2 on issue 2867 by verwa...@chromium.org: Infinite
optimization/deoptimization cycle from generic property store
http://code.google.com/p/v8/issues/detail?id=2867
Will be fixed by https://chromiumcodereview.appspot.com/23453019/
--
You received this
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/23729006/diff/1/src/code-stubs.cc#newcode49
src/code-stubs.cc:49: miss_handler_(),
On 2013/09/02 12:40:52, Sven Panne wrote:
Is this change intentional? I can't
Reviewers: Michael Starzinger,
Message:
As discussed. PTAL.
Description:
Bump MaxRegularSpaceAllocationSize to InitialSemiSpaceSize() * 4/5
to allow allocation of large packed arrays in paged spaces.
BUG=v8:2790
Please review this at https://codereview.chromium.org/23604023/
SVN Base:
If I understand correctly, this CL is functionally equivalent to:
#if V8_TARGET_ARCH_X64
static const int kInitialMaxFastElementArray = 98297;
#else
static const int kInitialMaxFastElementArray = 10;
#endif
Right?
While a computed value is arguably cleaner (and more robust towards
Reviewers: Jakob,
Description:
Enable escape analysis for Hydrogen.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/23629016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
Index:
lgtm
https://codereview.chromium.org/23629016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
Please take a thorough look. Do I win the CL of the month award?
Description:
Fix ChangeLog entry for 3.20.15
BUG=v8:2845
Please review this at https://codereview.chromium.org/23871002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
LGTM with comments.
https://codereview.chromium.org/23604023/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode195
src/heap.cc:195: ASSERT(MaxRegularSpaceAllocationSize() =
The initial_semispace_size might change at runtime, so this
Reviewers: Sven Panne,
Description:
remove Isolate::Current from most files starting with 'd' and 'e'
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23606012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M
https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips.cc#newcode1588
src/mips/macro-assembler-mips.cc:1588: not_in_int32_range);
Any particular
LGTM with comment.
https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h
File src/objects-inl.h (right):
https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h#newcode2652
src/objects-inl.h:2652: static bool IsIdentifier(UnicodeCache* cache,
Name*
LGTM :-)
https://codereview.chromium.org/23871002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Thanks for the review, landing.
https://codereview.chromium.org/23604023/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode195
src/heap.cc:195: ASSERT(MaxRegularSpaceAllocationSize() =
On 2013/09/02 13:12:43, Michael Starzinger
Committed patchset #2 manually as r16475 (presubmit successful).
https://codereview.chromium.org/23604023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16475
Author: jkumme...@chromium.org
Date: Mon Sep 2 13:36:49 2013 UTC
Log: Bump MaxRegularSpaceAllocationSize to InitialSemiSpaceSize() * 4/5
to allow allocation of large packed arrays in paged spaces.
BUG=v8:2790
R=mstarzin...@chromium.org
Review URL:
Committed patchset #1 manually as r16476 (presubmit successful).
https://codereview.chromium.org/23871002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16476
Author: jkumme...@chromium.org
Date: Mon Sep 2 13:42:20 2013 UTC
Log: Fix ChangeLog entry for 3.20.15
BUG=v8:2845
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/23871002
http://code.google.com/p/v8/source/detail?r=16476
Modified:
Updates:
Status: Fixed
Owner: jkumme...@chromium.org
Comment #1 on issue 2845 by jkumme...@chromium.org: ChangeLog entry missing
for v3.20.15
http://code.google.com/p/v8/issues/detail?id=2845
Fixed in r16476. No regression test, though.
--
You received this message because
LGTM with a nit.
https://codereview.chromium.org/23606012/diff/1/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/23606012/diff/1/src/execution.cc#newcode159
src/execution.cc:159: Isolate* isolate = Isolate::Current();
I think all callers have the Isolate
lgtm
https://codereview.chromium.org/23729006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Description:
Merged r16324 into 3.20 branch.
Lower kInitialMaxFastElementArray constant to 95K
BUG=v8:2790
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/23506017/
SVN Base: https://v8.googlecode.com/svn/branches/3.20
Affected
Reviewers: Michael Starzinger,
Message:
New ConditionVariable class, PTAL.
Description:
Import ConditionVariable class.
Condition variables are synchronization primitives that can be used
to block one or more threads while waiting for condition to become
true.
Right now we have only
LGTM.
https://codereview.chromium.org/23506017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 16477
Author: jkumme...@chromium.org
Date: Mon Sep 2 14:34:05 2013 UTC
Log: Merged r16324 into 3.20 branch.
Lower kInitialMaxFastElementArray constant to 95K
BUG=v8:2790
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23506017
Committed patchset #1 manually as r16477 (presubmit successful).
https://codereview.chromium.org/23506017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Starzinger,
Description:
Merged r16324 into 3.19 branch.
Lower kInitialMaxFastElementArray constant to 95K
BUG=v8:2790
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/23821003/
SVN Base: https://v8.googlecode.com/svn/branches/3.19
Affected
Revision: 16478
Author: jkumme...@chromium.org
Date: Mon Sep 2 14:34:28 2013 UTC
Log: Tagging version 3.20.17.5
http://code.google.com/p/v8/source/detail?r=16478
Added:
/tags/3.20.17.5
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
LGTM (rubber-stamped).
https://codereview.chromium.org/23821003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Revision: 16479
Author: jkumme...@chromium.org
Date: Mon Sep 2 14:36:37 2013 UTC
Log: Merged r16324 into 3.19 branch.
Lower kInitialMaxFastElementArray constant to 95K
BUG=v8:2790
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23821003
Committed patchset #1 manually as r16479 (presubmit successful).
https://codereview.chromium.org/23821003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16480
Author: jkumme...@chromium.org
Date: Mon Sep 2 14:36:59 2013 UTC
Log: Tagging version 3.19.18.22
http://code.google.com/p/v8/source/detail?r=16480
Added:
/tags/3.19.18.22
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h#newcode63
include/v8-profiler.h:63: HandleString GetBailoutReason() const;
Can we start returning const char* instead
Comment #7 on issue 2744 by mstarzin...@chromium.org: Meta-Bug: TSAN finds
many data races in V8
http://code.google.com/p/v8/issues/detail?id=2744
As far as I know we fixed three issues found through these warnings so far.
A huge bulk of the warnings (i.e. all in v8.cc, v8.h and
Reviewers: Jakob,
Description:
Move global V8::UseCrankshaft() into the Isolate.
R=jkumme...@chromium.org
BUG=v8:2744
Please review this at https://codereview.chromium.org/23441029/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/compiler.h
M
https://codereview.chromium.org/23606012/diff/1/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/23606012/diff/1/src/execution.cc#newcode159
src/execution.cc:159: Isolate* isolate = Isolate::Current();
On 2013/09/02 14:23:45, Sven Panne wrote:
I think all callers
Reviewers: Jakob,
Message:
PTAL
Description:
Add premonomorphic store ICs. This also fixes wrongly inlined accessors due
to
monomorphic store ICs with interceptors.
BUG=
Please review this at https://chromiumcodereview.appspot.com/23442016/
SVN Base:
Reviewers: Yury Semikhatsky,
Message:
comments addressed
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h#newcode63
include/v8-profiler.h:63: HandleString
Addressed comment
https://chromiumcodereview.appspot.com/23453019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/23817003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Revision: 16481
Author: verwa...@chromium.org
Date: Mon Sep 2 16:32:11 2013 UTC
Log: Allow uncacheable identifiers to go generic.
BUG=v8:2867
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23453019
http://code.google.com/p/v8/source/detail?r=16481
Reviewers: Yang,
Description:
Remove obsolete global V8::IsRunning() predicate.
R=yang...@chromium.org
BUG=v8:2744
Please review this at https://codereview.chromium.org/23597013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/bootstrapper.cc
M
1 - 100 of 124 matches
Mail list logo
