LGTM
https://codereview.chromium.org/24956002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Owner: verwa...@chromium.org
Comment #2 on issue 2904 by da...@chromium.org: Mix of integer and long
strings as property names severely degrades object iteration
http://code.google.com/p/v8/issues/detail?id=2904
(No comment was entered for this change.)
--
You received this
Reviewers: danno,
Message:
PTAL.
Description:
Tweak SmiSub for X64
Please review this at https://codereview.chromium.org/24965002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+53, -44 lines):
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.
Comment #8 on issue 2254 by victor.g...@gmail.com: Negated regexp character
class take unusually long to evaluate.
http://code.google.com/p/v8/issues/detail?id=2254
http://code.google.com/p/v8/issues/detail?id=2912
It is an actual problem. We have a server app that uses a lot of regexes.
We
Reviewers: kisg, palfia, kilvadyb, Jakob,
Message:
PTAL.
Description:
MIPS: Fix simulator divide for overflow case.
TEST=mjsunit/div-mul-minus-one.js
BUG=
Please review this at https://codereview.chromium.org/24956002/
SVN Base: git://github.com/v8/v8.git@gbl
Affected files (+7, -3 lines):
Reviewers: Michael Starzinger,
Description:
Function::Call API should allow v8::Value as a receiver
Since the primitive values can be a receiver of strict mode functions in
ECMA262 5.1th, v8::Function::Call should take v8::Value as a receiver
instead of v8::Object.
BUG=v8:2915
Please review th
Status: New
Owner:
New issue 2915 by yusukesu...@chromium.org: v8::Function::Call API should
allow v8::Value as a receiver
http://code.google.com/p/v8/issues/detail?id=2915
Since the primitive values can be a receiver of strict mode functions in
ECMA262 5.1th,
v8::Function::Call shoul
Comment #3 on issue 2910 by weiliang...@gmail.com: non-smi int32 constants
confuse representation inference
http://code.google.com/p/v8/issues/detail?id=2910
Yes, The type of non-smi int32 constants is a
union "{Signed32,Constant(0x3f11ce29)}"． It will fall into Number type no
matter what
Committed patchset #1 manually as r16971 (presubmit successful).
https://codereview.chromium.org/24857002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16971
Author: pal...@homejinni.com
Date: Thu Sep 26 22:18:02 2013 UTC
Log: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo,
step 2.
Port r16961 (ce471468)
Original commit message:
This step reorders the FunctionCallbackInfo fields.
BUG=
R=plin...@gmail.com
lgtm
https://codereview.chromium.org/24857002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Paul Lind, kilvadyb, kisg, danno, marja,
Message:
PTAL.
Description:
MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2.
Port r16961 (ce471468)
Original commit message:
This step reorders the FunctionCallbackInfo fields.
BUG=
Please review this at https://codere
Updates:
Cc: csh...@chromium.org vadi...@chromium.org
Comment #4 on issue 2885 by mar...@chromium.org: mksnapshot's output isn't
deterministic
http://code.google.com/p/v8/issues/detail?id=2885
Having a deterministic build opens significant testing improvement
opportunities; if the b
Updates:
Status: Accepted
Cc: da...@chromium.org
Comment #1 on issue 2904 by vego...@chromium.org: Mix of integer and long
strings as property names severely degrades object iteration
http://code.google.com/p/v8/issues/detail?id=2904
All the time is spent in building snapshots
LGTM, thanks!
https://codereview.chromium.org/24643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Updates:
Cc: rossb...@chromium.org
Comment #2 on issue 2910 by jkumme...@chromium.org: non-smi int32 constants
confuse representation inference
http://code.google.com/p/v8/issues/detail?id=2910
I think the bug is in Type::LubBitset(). In case HEAP_NUMBER_TYPE, we
should inspect the
I like this approach much more. Go ahead and do the platform ports.
https://codereview.chromium.org/23480031/diff/87001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23480031/diff/87001/src/objects.h#newcode5154
src/objects.h:5154: kPreAgedCodeAge = kQuinquagenarianC
Revision: 16970
Author: tit...@chromium.org
Date: Thu Sep 26 16:25:57 2013 UTC
Log: Implement local check elimination on basic blocks.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23866016
http://code.google.com/p/v8/source/detail?r=16970
Added:
/branc
Committed patchset #2 manually as r16970 (presubmit successful).
https://codereview.chromium.org/23866016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/26 09:09:55, Michael Starzinger wrote:
LGTM with comments.
https://codereview.chromium.org/23866016/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/23866016/diff/1/src/hydrogen-check-elimination.cc#newcode5
Committed patchset #2 manually as r16969 (presubmit successful).
https://codereview.chromium.org/24561002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16969
Author: mstarzin...@chromium.org
Date: Thu Sep 26 15:28:46 2013 UTC
Log: Fix replaying of HCapturedObject for nested objects.
R=tit...@chromium.org
TEST=mjsunit/compiler/property-refs,mjsunit/compiler/escape-analysis
Review URL: https://codereview.chromium.org/24561002
On 2013/09/26 15:16:04, Michael Starzinger wrote:
Added test case. PTAL.
LGTM
https://codereview.chromium.org/24561002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-de
Status: New
Owner:
New issue 2914 by emilecan...@gmail.com: Non-enumerable keys on Error object
http://code.google.com/p/v8/issues/detail?id=2914
Object.keys(new Error('test')) returns an empty array, which causes
problems when serializing a JSON object from an Error (it just returns an
Added test case. PTAL.
https://codereview.chromium.org/24561002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Reviewers: Jakob,
Description:
Finish control flow after throw if not inlined.
R=jkumme...@chromium.org
BUG=v8:2868
Please review this at https://codereview.chromium.org/24768002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+47, -0 lines):
M src/arm/lithiu
Revision: 16968
Author: hpa...@chromium.org
Date: Thu Sep 26 14:49:47 2013 UTC
Log: Fix Windows build of defaults.cc.
BUG=None
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/24762002
Patch from Ross McIlroy .
http://code.google.com/p/v8/source/detail?r=16968
Modif
Committed patchset #1 manually as r16968.
https://codereview.chromium.org/24762002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
LGTM
https://codereview.chromium.org/24762002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Hannes Payer,
Description:
Fix Windows build of defaults.cc.
BUG=None
Please review this at https://codereview.chromium.org/24762002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/defaults.cc
Index: src/defaults.cc
diff --gi
Status: New
Owner:
New issue 2913 by h0x91b: debuggersupport=off, broken again (error: no type
named 'Socket' in namespace 'v8::internal')
http://code.google.com/p/v8/issues/detail?id=2913
OS X 10.8.5
v8 (git checkout 3.22.2)
without flag debuggersupport=off everything is fine...
$ mak
Reviewers: danno,
Message:
Restart the 31-bit SMI work. Sorry for the delay.
This CL is inspired by the CountOperation implementation and danno's
comments
(https://chromiumcodereview.appspot.com/21014003/diff/45001/src/x64/macro-assembler-x64.cc#newcode2067
and
https://chromiumcodereview.apps
Revision: 16967
Author: jkumme...@chromium.org
Date: Thu Sep 26 14:02:23 2013 UTC
Log: Tagging version 3.20.17.13
http://code.google.com/p/v8/source/detail?r=16967
Added:
/tags/3.20.17.13
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 16966
Author: jkumme...@chromium.org
Date: Thu Sep 26 14:01:43 2013 UTC
Log: Tagging version 3.20.17.12
http://code.google.com/p/v8/source/detail?r=16966
Added:
/tags/3.20.17.12
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #2 manually as r16965 (presubmit successful).
https://codereview.chromium.org/24245005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16965
Author: dcar...@chromium.org
Date: Thu Sep 26 13:46:37 2013 UTC
Log: Add EscapableHandleScope to api to fix problems with
HandleScope::Close
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24245005
http://code.google.com/p/v8/source/detai
LGTM.
https://codereview.chromium.org/24245005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 16964
Author: hpa...@chromium.org
Date: Thu Sep 26 13:31:19 2013 UTC
Log: Add methods to enable configuration of ResourceConstraints based
on limits derived at runtime.
Adds ConfigureResourceConstraintsForCurrentPlatform and
SetDefaultResourceConstraintsForCurrentPlatfor
Committed patchset #6 manually as r16964 (presubmit successful).
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16963
Author: jkumme...@chromium.org
Date: Thu Sep 26 13:29:44 2013 UTC
Log: Merged r16393 into 3.20 branch.
And revert "Revert 3.20 branch to 3.20.17.7", bringing
the 3.20 branch back to the state of 3.20.17.11 (plus r16393).
R=hpa...@chromium.org
Review URL: https://coder
Committed patchset #1 manually as r16963 (presubmit successful).
https://codereview.chromium.org/24704005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/24704005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
https://codereview.chromium.org/22852024/diff/72001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/72001/src/heap.cc#newcode4982
src/heap.cc:4982: object_size);
On 2013/09/25 14:51:52, Yury Semikhatsky wrote:
style: wrong alignment
Done.
https://coderevie
Reviewers: Hannes Payer,
Message:
PTAL.
Description:
Merged r16393 into 3.20 branch.
And revert "Revert 3.20 branch to 3.20.17.7", bringing
the 3.20 branch back to the state of 3.20.17.11 (plus r16393).
Please review this at https://codereview.chromium.org/24704005/
SVN Base: https://v8.googl
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16962.
Description:
build fix for 16957 - broke shared builds
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16962
Please review this at https://codereview.chromium.org/245620
Revision: 16962
Author: dcar...@chromium.org
Date: Thu Sep 26 12:42:10 2013 UTC
Log: build fix for 16957 - broke shared builds
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24562009
http://code.google.com/p/v8/source/detail?r=16962
Modified:
/branches
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode2587
src/arm/lithium-codegen-arm.cc:2587: void
LCodeGen::DoStringCompareAndBranch(LStr
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h#newcode357
src/spaces-inl.h:357: if (profiler->is_tracking_allocations()) {
On 2013/09/26 11:53:07, loislo wrote:
profiler is
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h#newcode357
src/spaces-inl.h:357: if (profiler->is_tracking_allocations()) {
profiler is null here at test-spaces/NewSpace
http
On 2013/09/23 12:58:34, rmcilroy wrote:
I've redo this to use code stubs which track whether code has been
executed
zero, once or multiple times. I didn't bother with a counter on the Code
object
as this didn't seem necessary given the stubs track this implicitly.
PTAL, let me know what you
https://codereview.chromium.org/24245005/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode778
include/v8.h:778: // TODO(dcarney): deprecated - use
CloseableHandleScope::Close.
On 2013/09/26 09:48:11, Michael Starzinger wrote:
nit
LGTM if comments are addressed.
https://codereview.chromium.org/24550006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24550006/diff/1/src/api.cc#newcode700
src/api.cc:700: return reinterpret_cast(
nit: The reinterpret_cast here should be obsolete.
https://coderevi
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
On 2013/09/26 09:11:33, loislo wrote:
sgtm
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h#newcode310
src/spaces-inl.h:310: MaybeObject* PagedSpace::AllocateRaw(int
siz
As mentioned offline: With https://codereview.chromium.org/23533003/ applied
mjsunit/compiler/property-refs starts failing. This bug cannot be triggered
without the fixpoint CL because that is the only way to produce nested
graphs of
HCapturedObjects values. But I can write a dedicated test for
Committed patchset #7 manually as r16961 (presubmit successful).
https://codereview.chromium.org/23484037/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16961
Author: ma...@chromium.org
Date: Thu Sep 26 10:28:00 2013 UTC
Log: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2.
This step reorders the FunctionCallbackInfo fields.
BUG=
R=dcar...@chromium.org, mstarzin...@chromium.org
Review URL: https://codereview
Reviewers: Michael Starzinger,
Message:
ptal
note: this has to wait for chrome and blink patches to land
Description:
remove Local::New with no isolate parameter
R=mstarzin...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/24550006/
SVN Base: https://v8.google
Comment #2 on issue 2912 by victor.g...@gmail.com: Regex explodes (100% CPU
usage for 100 years)
http://code.google.com/p/v8/issues/detail?id=2912
Yes, but not exactly. An average infinite loop is easily debuggable but a
regex hangup is not.
Node.js goes dead, no I/O, no SIGUSR1 debugging.
Looks good. First round of comments.
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode2587
src/arm/lithium-codegen-arm.cc:2587: void
L
On 2013/09/25 11:13:31, Michael Starzinger wrote:
You got tests?
https://codereview.chromium.org/24561002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/24245005/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24245005/diff/1/include/v8.h#newcode778
include/v8.h:778: // TODO(dcarney): deprecated - use
CloseableHandleScope::Close.
nit: s/Closeable/Escapeable/
https://codereview.chrom
Revision: 16960
Author: hpa...@chromium.org
Date: Thu Sep 26 09:40:13 2013 UTC
Log: Add -optimize-for-size flag to optimize for memory size (will be
used by pre-aging CL), and remove the is_memory_constrained
ResourceConstraint.
BUG=292928
R=hpa...@chromium.org
Review URL: https:
Committed patchset #2 manually as r16960 (presubmit successful).
https://codereview.chromium.org/24018009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16959
Author: mstarzin...@chromium.org
Date: Thu Sep 26 09:37:25 2013 UTC
Log: Make Heap::AllocateRawFixedArray methods private.
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/24337005
http://code.google.com/p/v8/source/detail?r=16959
Modified:
/branches
Committed patchset #3 manually as r16959 (presubmit successful).
https://codereview.chromium.org/24337005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/24337005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Status: Duplicate
Mergedinto: 430
Comment #1 on issue 2912 by yang...@chromium.org: Regex explodes (100% CPU
usage for 100 years)
http://code.google.com/p/v8/issues/detail?id=2912
Writing efficient regexp is part of programming as well. In comparison,
writing a expo
Comment #12 on issue 430 by yang...@chromium.org: Regex hardlock
http://code.google.com/p/v8/issues/detail?id=430
Issue 2912 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your n
sgtm
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/22852024/diff/72001/src/spaces-inl.h#newcode310
src/spaces-inl.h:310: MaybeObject* PagedSpace::AllocateRaw(int
size_in_bytes,
I'd rewrite this the next way:
LGTM with comments.
https://codereview.chromium.org/23866016/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/23866016/diff/1/src/hydrogen-check-elimination.cc#newcode53
src/hydrogen-check-elimination.cc:53: HValue* object
TO GYPI
To whom it may concern
Have a good day!
We hereby sincerely invite you and your company representatives to visit
The 114th Canton Fair which will be held at Pazhou complex, Guangzhou
city from Otc.15th-19th,2013.Our booth no. is 5.2D45.
I'm Cindy Ho from the Foshan S
Revision: 16958
Author: dcar...@chromium.org
Date: Thu Sep 26 08:47:59 2013 UTC
Log: build fix for 16957
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24726002
http://code.google.com/p/v8/source/detail?r=16958
Modified:
/branches/bleeding_edge/test/cc
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16958.
Description:
build fix for 16957
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16958
Please review this at https://codereview.chromium.org/24726002/
SVN Base: https:/
Reviewers: titzer,
Description:
Disposing an OSR job should only restore the back edge state.
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/24725002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+24, -21 lines):
M src/comp
Committed patchset #2 manually as r16957 (presubmit successful).
https://codereview.chromium.org/24508006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16957
Author: dcar...@chromium.org
Date: Thu Sep 26 08:21:48 2013 UTC
Log: remove uses of static oddball accessors using GetCurrent in
advance of removal from api
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24508006
http://code.google.com/p
LGTM.
https://codereview.chromium.org/24508006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24508006/diff/1/src/api.cc#newcode1013
src/api.cc:1013: if (data.IsEmpty())
nit: Curly braces if it doesn't fit into one line.
https://codereview.chromium.org/24508006/diff
Reviewers: Michael Starzinger,
Message:
ptal
Description:
remove uses of static oddball accessors using GetCurrent in advance of
removal
from api
R=mstarzin...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/24508006/
SVN Base: https://v8.googlecode.com/svn/b
Revision: 16956
Author: dcar...@chromium.org
Date: Thu Sep 26 07:43:09 2013 UTC
Log: fix copy/paste error in r16955
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24721002
http://code.google.com/p/v8/source/detail?r=16956
Modified:
/branches/bleeding_e
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16956 (presubmit successful).
Description:
fix copy/paste error in r16955
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16956
Please review this at https://codereview.chromiu
Comment #1 on issue 2910 by weiliang...@gmail.com: non-smi int32 constants
confuse representation inference
http://code.google.com/p/v8/issues/detail?id=2910
It seems number literals binary operation(like BIT_OR here) computation in
parser misses some info. The BIT_OR return value should be
Revision: 16955
Author: dcar...@chromium.org
Date: Thu Sep 26 07:37:59 2013 UTC
Log: add isolate parameter to ThrowException
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24538002
http://code.google.com/p/v8/source/detail?r=16955
Modified:
/branches/ble
Committed patchset #2 manually as r16955 (presubmit successful).
https://codereview.chromium.org/24538002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16954
Author: machenb...@chromium.org
Date: Thu Sep 26 07:37:16 2013 UTC
Log: Tagging version 3.22.2
http://code.google.com/p/v8/source/detail?r=16954
Added:
/tags/3.22.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
ptal
https://chromiumcodereview.appspot.com/24245005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
Revision: 16952
Author: machenb...@chromium.org
Date: Thu Sep 26 07:35:34 2013 UTC
Log: Prepare push to trunk. Now working on version 3.22.3.
R=da...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24530008
http://code.google.com/p/v8/source/detail?r=16952
Modified:
/
Committed patchset #1 manually as r16952 (presubmit successful).
https://codereview.chromium.org/24530008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/24530008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
The only thing worth keeping in the changlog might have been: Revert
OS::TimeCurrentMillis on Windows introduced in r16413.
https://codereview.chromium.org/24530008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Reviewers: danno,
Description:
Prepare push to trunk. Now working on version 3.22.3.
R=da...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/24530008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1 lines):
M ChangeLog
M src/v
91 matches
Mail list logo
