Comment #10 on issue 2874 by bmeu...@chromium.org: Threading problems in
test-api
http://code.google.com/p/v8/issues/detail?id=2874
That would at least reduce the current crash rate.
--
You received this message because this project is configured to send all
issue notifications to this add
Revision: 16998
Author: haitao.f...@intel.com
Date: Sat Sep 28 00:48:08 2013 UTC
Log: Refactor register allocator a little bit
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/24438006
http://code.google.com/p/v8/source/detail?r=16998
Modified:
/branches/bleeding
Committed patchset #3 manually as r16998 (presubmit successful).
https://codereview.chromium.org/24438006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
I prefer 1). I will upload a separate CL on StackArgumentsAccessor for X64
for
the recent commits:
1) https://codereview.chromium.org/23903053
2) your part2 and part3
Could you and dcarney help me review it next week?
After that, danno could continue reviewing
https://codereview.chromium.or
Reviewers: Michael Starzinger,
Description:
Avoid allocations in Object.observe access check tests
R=mstarzin...@chromium.org
BUG=v8:2907
Please review this at https://codereview.chromium.org/24999007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -34 lin
Comment #1 on issue 2907 by ad...@chromium.org: Object.observe access
checks cause allocation while in DisallowHeapAllocation scope
http://code.google.com/p/v8/issues/detail?id=2907
This is a test-only failure, triggered by allocation in the tests' access
check callbacks. Will require some
Reviewers: ulan,
Message:
PTAL
Description:
Cleanup in IC patching.
BUG=
Please review this at https://chromiumcodereview.appspot.com/25001005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+31, -29 lines):
M src/ic.cc
M src/objects-inl.h
M src/objects.
Reviewers: ulan,
Message:
PTAL
Description:
Make strict_mode a flag on StoreIC.
BUG=
Please review this at https://chromiumcodereview.appspot.com/25090002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+141, -170 lines):
M src/ic.h
M src/ic.cc
--
--
v8-
Committed as r16997.
https://codereview.chromium.org/25050002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 16997
Author: plin...@gmail.com
Date: Fri Sep 27 16:16:40 2013 UTC
Log: MIPS: Improve integer multiplication.
Port r16576 (8ce78a4)
TEST=test/mjsunit/lithium/MulI.js
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/25050002
Patch from Balazs Kilvady .
h
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1456
src/mips/lithium-codegen-mips.cc:1456: // Correct the sign of the result
is
Revision: 16996
Author: mstarzin...@chromium.org
Date: Fri Sep 27 15:45:02 2013 UTC
Log: Tagging version 3.22.3.2
http://code.google.com/p/v8/source/detail?r=16996
Added:
/tags/3.22.3.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Reviewers: ulan,
Message:
PTAL
Description:
Allow code to be cached in shared maps.
Please review this at https://chromiumcodereview.appspot.com/25058004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -21 lines):
M src/objects.h
M src/objects.cc
Inde
Committed patchset #1 manually as r16995 (presubmit successful).
https://codereview.chromium.org/25076003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16995
Author: mstarzin...@chromium.org
Date: Fri Sep 27 15:44:41 2013 UTC
Log: Merged r16994 into trunk branch.
Try to make MSVC happy about EscapableHandleScope.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25076003
http://code.google.com/p/v8/sourc
lgtm
https://codereview.chromium.org/25076003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
Merged r16994 into trunk branch.
Try to make MSVC happy about EscapableHandleScope.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/25076003/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files (+8, -1 lines):
M include
Revision: 16994
Author: mstarzin...@chromium.org
Date: Fri Sep 27 15:32:26 2013 UTC
Log: Try to make MSVC happy about EscapableHandleScope.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25077002
http://code.google.com/p/v8/source/detail?r=16994
Modified:
/bran
Committed patchset #1 manually as r16994 (presubmit successful).
https://codereview.chromium.org/25077002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM, thanks!
https://codereview.chromium.org/25077002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Description:
Try to make MSVC happy about EscapableHandleScope.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/25077002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -0 lines):
M include/v8.h
Index: in
Reviewers: ulan,
Message:
PTAL
Description:
Reduce code duplication in IC updating.
BUG=
Please review this at https://chromiumcodereview.appspot.com/25033003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+74, -242 lines):
M src/ic.h
M src/ic.cc
M src/
LGTM, but please fix the nits.
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1456
src/mips/lithium-codegen-mips.cc:1456: // C
Reviewers: Benedikt Meurer, machenbach,
Description:
Fix threading problems in test-api when running on simulator
Sampler can retrieve current simulator for profiled isolate from its
ThreadLocalTop without calls to Isolate::FindPerThreadDataForThread which
sometimes leads to acquring same mutex
Reviewers: danno, Jakob, Paul Lind, palfia, kisg, Rodolph Perfetta,
Description:
MIPS: Improve integer multiplication.
Port r16576 (8ce78a4)
TEST=test/mjsunit/lithium/MulI.js
BUG=
Please review this at https://codereview.chromium.org/25050002/
SVN Base: https://github.com/v8/v8.git@gbl
Affec
Committed patchset #2 manually as r16993 (presubmit successful).
https://codereview.chromium.org/24596002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: ulan,
Message:
PTAL
Description:
Tag normal as handlers, and make code handler-specific.
BUG=
Please review this at https://chromiumcodereview.appspot.com/25049003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+61, -36 lines):
M src/builtins.h
https://codereview.chromium.org/24978006/diff/1/src/defaults.cc
File src/defaults.cc (right):
https://codereview.chromium.org/24978006/diff/1/src/defaults.cc#newcode50
src/defaults.cc:50: constraints->set_max_old_space_size(768 *
lump_of_memory);
Let's leave this at 700. There's no benefit to ha
Revision: 16992
Author: yang...@chromium.org
Date: Fri Sep 27 13:48:19 2013 UTC
Log: Finish control flow after throw if not inlined.
R=jkumme...@chromium.org
BUG=v8:2868
Review URL: https://codereview.chromium.org/24768002
http://code.google.com/p/v8/source/detail?r=16992
Modified:
Updates:
Status: Fixed
Comment #8 on issue 2868 by yang...@chromium.org: Performance regression
after bleeding edge revision 16406
http://code.google.com/p/v8/issues/detail?id=2868
(No comment was entered for this change.)
--
You received this message because this project is configur
Committed patchset #1 manually as r16992 (presubmit successful).
https://codereview.chromium.org/24768002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/24978006/diff/1/src/defaults.cc
File src/defaults.cc (right):
https://codereview.chromium.org/24978006/diff/1/src/defaults.cc#newcode46
src/defaults.cc:46: // be a multiple of Page::kPageSize.
You pump up the old space size for all platforms. This will change
perf
Committed patchset #1 manually as r16991 (presubmit successful).
https://codereview.chromium.org/24997003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16991
Author: yang...@chromium.org
Date: Fri Sep 27 13:45:17 2013 UTC
Log: Restrict recorded execution pauses to the required range.
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24997003
http://code.google.com/p/v8/source/detail?r=16991
Modified
On 2013/09/27 12:38:42, Michael Starzinger wrote:
The same applies to Object::CallAsFunction, I think we should fix it in
one CL
to preserve consistency.
Thanks for your review.
So I've added the Object::CallAsFunction changes to this CL.
https://chromiumcodereview.appspot.com/24920003/
--
Revision: 16990
Author: mvstan...@chromium.org
Date: Fri Sep 27 13:38:04 2013 UTC
Log: Refactoring such that loop builders only call into the
HOsrBuilder if
compiling for OSR.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/25039003
http://code.google.co
Committed patchset #2 manually as r16990 (presubmit successful).
https://codereview.chromium.org/25039003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
thanks very mich--
much.
https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc
File src/hydrogen-osr.cc (right):
https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc#newcode40
src/hydrogen-osr.cc:40: HBasicBlock* HOsrBuilder::BuildOsrLoopEntry(
On 2013/09/27 13:26:
Reviewers: Jakob, Hannes Payer,
Message:
As discussed with Jakob, this enables platforms with swap to be "one bucket
up"
in max heap sizes. It also introduces a 1-2GB bucket since previously the
step
between 512MB and 2GB sizes was quite large. PTAL.
Description:
Tweak default max heap si
LGTM with nits.
https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc
File src/hydrogen-osr.cc (right):
https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc#newcode40
src/hydrogen-osr.cc:40: HBasicBlock* HOsrBuilder::BuildOsrLoopEntry(
nit: Should fit into one line.
Patch set 3 LGTM.
https://codereview.chromium.org/24438006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
Reviewers: Michael Starzinger,
Message:
Hi Michael, PTAL, thx!
---Michael
Description:
Refactoring such that loop builders only call into the HOsrBuilder if
compiling for OSR.
BUG=
Please review this at https://codereview.chromium.org/25039003/
SVN Base: https://v8.googlecode.com/svn/branches
Reviewers: ulan,
Message:
PTAL
Description:
Tag handlers as HANDLER rather than STUB.
Please review this at https://chromiumcodereview.appspot.com/25044002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+27, -20 lines):
M src/arm/ic-arm.cc
M src/builtins.h
lgtm
https://codereview.chromium.org/24997003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Alright, so the end result should be that x64 uses StackArgumentAccessor.
haitao.feng: We can do any of these:
1) I land this as is, you rebase your CL (which starts using
StackArgumentAccessor) on top
2) I start using StackArgumentAccessor in this CL (merge parts of your CL
into
it)
3) You la
Hi All,
Could anyone point me out some resource about the deoptimization
algorithm v8 is using? what's the design thoughts of the Translation class
etc.
currently, I am porting v8 to a new processor, and trying to fix bugs
(still about 2000 failures ...) exposed by running v8 testsuite.
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc#newcode1214
src/arm/lithium-arm.cc:1214: : UseFixed(instr->context(), cp);
OK, let's leave UseFixed.
https:/
Revision: 16989
Author: mvstan...@chromium.org
Date: Fri Sep 27 12:43:37 2013 UTC
Log: Avoid using double temp register explicitly in lithium codegen
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/23531084
http://code.google.com/p/v8/source/detail?r=16989
M
Committed patchset #1 manually as r16989 (presubmit successful).
https://codereview.chromium.org/23531084/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Michael Starzinger,
Description:
remove Isolate::Current from ScriptData and Script
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/25037002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+50, -28 lines):
M in
The same applies to Object::CallAsFunction, I think we should fix it in one
CL
to preserve consistency.
https://codereview.chromium.org/24920003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc#newcode1214
src/arm/lithium-arm.cc:1214: : UseFixed(instr->context(), cp);
On 2013/09/27 12:08:00, ulan wrote
LGTM (if comments about StackArgumentsAccessor are addressed).
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Sorry, it is
https://github.com/fenghaitao/v8/commit/badbe6839183e943558ea93341b8bd9e27612749.
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Googl
Thanks danno for the explanation.
The x32 port of rebase with your "Refactor PropertyCallbackInfo &
FunctionCallbackInfo, part 2" is at
https://github.com/fenghaitao/v8/commit/ce471468e782c854e24186ec331bc8304373eee4.
Please ignore the x32 codes as they are generated from x64 by a script.
https:
LGTM.
https://codereview.chromium.org/24768002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
LGTM
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc#newcode1214
src/arm/lithium-arm.cc:1214: : UseFixed(instr->context(), cp);
I think we can use UseAny he
Does the link to perf results in the description include measurements for
patch
set #9 or for some earlier version where the tracking flag was checked
right in
the generated code?
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google
Reviewers: Yang,
Message:
Hi Yang, here is the visitor I was talking about.
Thanks,
--Michael
Description:
Use a walking visitor to traverse JSObject structure. The purpose is to
prepare
for more complex context-dependent walks of the structure, needed for
allocation
site and pretenuring wor
Please do use the StackArgumentsAccessor. It's not just a question of code
simplicity, the StackArgumentsAccessor is necessary to get parameter access
to
work without special casing for the x32 port of the x64 code.
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@go
Please do use the StackArgumentsAccessor. It's not just a question of code
simplicity, the StackArgumentsAccessor is necessary to get parameter access
to
work without special casing for the x32 port of the x64 code.
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@go
On 2013/09/27 11:28:53, haitao.feng wrote:
It will be great if you could use StackArgumentsAccessor for all the
argument
access from rsp or rbp for X64 in this CL. Please see
https://codereview.chromium.org/22267005/patch/24001/25010 for the
changes I
have done over the recent commit.
Or
Committed patchset #1 manually as r16988 (presubmit successful).
https://codereview.chromium.org/25002004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16988
Author: dcar...@chromium.org
Date: Fri Sep 27 11:32:13 2013 UTC
Log: make v8::Locker not use Isolate::GetCurrent()
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25002004
http://code.google.com/p/v8/source/detail?r=16988
Modified:
/branch
Committed patchset #1 manually as r16987 (presubmit successful).
https://codereview.chromium.org/24359003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16987
Author: joc...@chromium.org
Date: Fri Sep 27 11:31:06 2013 UTC
Log: Only zapped used handles if a handle scope fits entirely within
one handle block
This should avoid zapping the same unused handles over and over again
when using many small nested handle scopes.
BUG
It will be great if you could use StackArgumentsAccessor for all the
argument
access from rsp or rbp for X64 in this CL. Please see
https://codereview.chromium.org/22267005/patch/24001/25010 for the changes I
have done over the recent commit.
Or I could upload a patchset for the argument access
LGTM.
https://codereview.chromium.org/25002004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
LGTM.
https://codereview.chromium.org/24359003/diff/1/src/handles-inl.h
File src/handles-inl.h (right):
https://codereview.chromium.org/24359003/diff/1/src/handles-inl.h#newcode133
src/handles-inl.h:133: std::swap(current->next, prev_next);
nit: Two white-spaces after comma.
https://coderevie
Revision: 16986
Author: jkumme...@chromium.org
Date: Fri Sep 27 11:21:18 2013 UTC
Log: Tagging version 3.22.3.1
http://code.google.com/p/v8/source/detail?r=16986
Added:
/tags/3.22.3.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rec
Committed patchset #1 manually as r16985 (presubmit successful).
https://codereview.chromium.org/24996004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16985
Author: jkumme...@chromium.org
Date: Fri Sep 27 11:20:51 2013 UTC
Log: Merged r16977, r16979, r16983 into trunk branch.
Disable escape analysis for Canary stabilization.
Revert "Add methods to enable configuration of ResourceConstraints based on
limits derived at run
Reviewers: Michael Starzinger,
Message:
ptal
Description:
make v8::Locker not use Isolate::GetCurrent()
R=mstarzin...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/25002004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+25, -
On 2013/09/27 11:05:07, Jakob wrote:
lgtm
https://codereview.chromium.org/24996004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 16984
Author: hpa...@chromium.org
Date: Fri Sep 27 11:04:16 2013 UTC
Log: Disable gc stress mode for mjsunit timer test.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/24979002
http://code.google.com/p/v8/source/detail?r=16984
Modified:
/branch
Reviewers: machenbach,
Description:
Merged r16977, r16979, r16983 into trunk branch.
Disable escape analysis for Canary stabilization.
Revert "Add methods to enable configuration of ResourceConstraints based on
limits derived at runtime." and "Fix Windows build of defaults.cc."
Re-land "Add me
Committed patchset #1 manually as r16984 (presubmit successful).
https://codereview.chromium.org/24979002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Okay, it sounds good.
lgtm.
https://codereview.chromium.org/23531084/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
Revision: 16983
Author: hpa...@chromium.org
Date: Fri Sep 27 10:53:07 2013 UTC
Log: Re-land "Add methods to enable configuration of
ResourceConstraints based on limits derived at runtime."
Adds ConfigureResourceConstraintsForCurrentPlatform and
SetDefaultResourceConstraintsForCurr
Committed patchset #2 manually as r16983 (presubmit successful).
https://codereview.chromium.org/24989003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/24989003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 16982
Author: pal...@homejinni.com
Date: Fri Sep 27 10:42:51 2013 UTC
Log: MIPS: Fix simulator divide for overflow case.
TEST=mjsunit/div-mul-minus-one.js
BUG=
R=gerg...@homejinni.com
Review URL: https://codereview.chromium.org/24956002
Patch from Paul Lind .
http://code.go
Committed as r16982.
https://codereview.chromium.org/24956002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: Hannes Payer,
Description:
Inline some more compare operations.
BUG=
Please review this at https://codereview.chromium.org/25009003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -0 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --gi
LGTM
https://codereview.chromium.org/24996003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Hannes Payer,
Description:
Fix performance regression caused by accidental change in default max young
space size.
BUG=None
Please review this at https://codereview.chromium.org/24989003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
Revision: 16981
Author: mvstan...@chromium.org
Date: Fri Sep 27 09:51:08 2013 UTC
Log: Tagging version 3.20.17.14
http://code.google.com/p/v8/source/detail?r=16981
Added:
/tags/3.20.17.14
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 16980
Author: mvstan...@chromium.org
Date: Fri Sep 27 09:50:47 2013 UTC
Log: Merged r16355 into 3.20 branch.
Filler sizes have to be Smis, fix x64 breakage.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25011002
http://code.google.com/p/v8/source/deta
Committed patchset #1 manually as r16980 (presubmit successful).
https://codereview.chromium.org/25011002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16979
Author: machenb...@chromium.org
Date: Fri Sep 27 09:45:14 2013 UTC
Log: Revert "Add methods to enable configuration of
ResourceConstraints based on limits derived at runtime." and "Fix Windows
build of defaults.cc."
This reverts commit r16964 and r16968 due to perf
Committed patchset #2 manually as r16979 (presubmit successful).
https://codereview.chromium.org/24996003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Revert "Add methods to enable configuration of ResourceConstraints based on
limits derived at runtime." and "Fix Windows build of defaults.cc."
This reverts commit r16964 and r16968 due to performance regressions in
octane.
Please review t
mstarzinger, ptal.
Pitch for this one: "positive array indexes instead of negative array
indexes"!
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to th
Revision: 16978
Author: yang...@chromium.org
Date: Fri Sep 27 09:37:18 2013 UTC
Log: Disposing an OSR job should only restore the back edge state.
R=tit...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24725002
http://code.google.com/p/v8/source/detail?r=16978
Modifie
Committed patchset #2 manually as r16978 (presubmit successful).
https://codereview.chromium.org/24725002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/25011002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
Merged r16355 into 3.20 branch.
Filler sizes have to be Smis, fix x64 breakage.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/25011002/
SVN Base: https://v8.googlecode.com/svn/branches/3.20
Affected files (+23, -6 lines):
M sr
lgtm
https://codereview.chromium.org/24566004/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24566004/diff/1/include/v8.h#newcode4605
include/v8.h:4605: */
v8::CpuProfiler may be a better place for this method.
https://codereview.chromium.org/24566004/
--
--
lgtm
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: dcarney,
Message:
dcarney, ptal
Description:
Refactor PropertyCallbackInfo & FunctionCallbackInfo, part 3.
This CL starts using positive array indices instead of negative array
indices
for the PropertyCallbackInfo and FunctionCallbackInfo fields. Also, the
indices
match now, so
1 - 100 of 127 matches
Mail list logo
