On 2014/04/06 20:30:57, mathiasb wrote:
LGTM
https://codereview.chromium.org/227113005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
On 2014/04/07 06:36:16, Yang wrote:
On 2014/04/06 20:30:57, mathiasb wrote:
LGTM
test-mark-compact/BootUpMemoryUse fails on x64 bit. Could you bump up the
limits
there for 64-bit by 100k each?
https://codereview.chromium.org/227113005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2014/04/04 15:08:13, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/225683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
LGTM
https://codereview.chromium.org/225923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/226023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
https://codereview.chromium.org/226153002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/226153002/diff/1/src/heap.cc#newcode4650
src/heap.cc:4650: HandleJSArray Heap::AllocateJSArrayWithElements(
Since this is now handlified, it belongs to factory.cc
Revision: 20526
Author: ma...@chromium.org
Date: Mon Apr 7 07:40:18 2014 UTC
Log: compiler.cc: Remove a comment which is no longer true.
We don't do any automatic PreParsing in Compiler::Compile any more (it was
removed by r10066, 2 years ago).
R=mstarzin...@chromium.org
BUG=
Committed patchset #1 manually as r20526 (presubmit successful).
https://codereview.chromium.org/225993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: rossberg,
Message:
As discussed offline last week... PTAL
Description:
Use distinct maps for oddballs with special handling in the type system.
Please review this at https://codereview.chromium.org/227473002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Reviewers: Benedikt Meurer,
Description:
Yet another regression test for range analysis.
BUG=v8:3204
Please review this at https://codereview.chromium.org/224723016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+17, -0 lines):
M
LGTM
https://codereview.chromium.org/224723016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Please take another look.
After testing on a few popular websites, I did the following changes:
- instead of maintaining the dependent IC stubs in the dependent code
array, I
use the next_code_link field of a stub (which was unused before) to chain
the
stubs together in a linked list. The
On 2014/03/25 15:27:44, jarin wrote:
ping
https://codereview.chromium.org/208683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM.
https://codereview.chromium.org/208683006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/208683006/diff/1/src/hydrogen-instructions.h#newcode3381
src/hydrogen-instructions.h:3381: virtual bool IsDeletable() const
V8_FINAL
Committed patchset #1 manually as r20527 (presubmit successful).
https://codereview.chromium.org/226053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20527
Author: mvstan...@chromium.org
Date: Mon Apr 7 07:52:24 2014 UTC
Log: Fix for v8:3255 Grow KeyedStoreIC doesn't respect String value
wrappers
BUG=v8:3255
LOG=N
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/226053002
On Sat, Apr 5, 2014 at 12:16 AM, Peter Kasting pkast...@google.com wrote:
I'm trying to track down whether --no-js-randomness is used anymore.
[...] Does anyone still use this?
I've never heard of that flag, and I'm quite sure that from a V8 POV, it is
OK to remove it.
--
--
v8-dev mailing
Updates:
Status: Fixed
Comment #3 on issue 3255 by mvstan...@chromium.org: Grow KeyedStoreIC
doesn't respect String value wrappers
http://code.google.com/p/v8/issues/detail?id=3255
(No comment was entered for this change.)
--
You received this message because this project is
Revision: 20528
Author: svenpa...@chromium.org
Date: Mon Apr 7 08:04:25 2014 UTC
Log: Yet another regression test for range analysis.
BUG=v8:3204
LOG=y
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/224723016
http://code.google.com/p/v8/source/detail?r=20528
Committed patchset #1 manually as r20528 (presubmit successful).
https://codereview.chromium.org/224723016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Thanks.
https://codereview.chromium.org/208683006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/208683006/diff/1/src/hydrogen-instructions.h#newcode3381
src/hydrogen-instructions.h:3381: virtual bool IsDeletable() const
V8_FINAL
Committed patchset #3 manually as r20529 (presubmit successful).
https://codereview.chromium.org/208683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20529
Author: ja...@chromium.org
Date: Mon Apr 7 08:42:34 2014 UTC
Log: Dead code elimination of inlined arguments objects causes wrong
deopt info to be generated - instead of materializing the arguments, we
get 'undefined'.
Golem says the change is perf-neutral.
Reviewers: Yang,
Description:
Handlify six allocator functions from the Heap.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/227533002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+37, -115 lines):
M src/factory.h
M
https://codereview.chromium.org/227473002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/227473002/diff/1/src/heap.h#newcode187
src/heap.h:187: V(Map, oddball_map, OddballMap)
\
Can't we have distinct maps for the other oddballs as well and get
test-mark-compact/BootUpMemoryUse fails on x64 bit. Could you bump up the
limits
there for 64-bit by 100k each?
Done. PTAL
https://codereview.chromium.org/227113005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Comment #2 on issue 3259 by svenpa...@chromium.org: Floor of div on ARM
returns incorrect results.
http://code.google.com/p/v8/issues/detail?id=3259
OK, I can reproduce this, and it happens really only with the ARM backend.
Even tinier repro:
// Flags: --nouse_inlining
function div(a,
LGTM.
https://codereview.chromium.org/227533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r20530 (presubmit successful).
https://codereview.chromium.org/225683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20530
Author: ish...@chromium.org
Date: Mon Apr 7 09:20:44 2014 UTC
Log: ElementsAccessor::GetAccessorPair() handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/225683003
http://code.google.com/p/v8/source/detail?r=20530
Modified:
https://codereview.chromium.org/226153002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/226153002/diff/1/src/heap.cc#newcode4650
src/heap.cc:4650: HandleJSArray Heap::AllocateJSArrayWithElements(
On 2014/04/07 07:20:48, Yang wrote:
Since this is now handlified,
https://codereview.chromium.org/227473002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/227473002/diff/1/src/heap.h#newcode187
src/heap.h:187: V(Map, oddball_map, OddballMap)
\
On 2014/04/07 09:04:03, rossberg wrote:
Can't we have distinct maps
lgtm.
https://codereview.chromium.org/226153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/227473002/diff/20008/src/types.h
File src/types.h (right):
https://codereview.chromium.org/227473002/diff/20008/src/types.h#newcode155
src/types.h:155: V(NonNumber, kBoolean | kInternal | kName |
kNull | \
Nit: put kInternal last
https://codereview.chromium.org/227473002/diff/20008/src/types.h
File src/types.h (right):
https://codereview.chromium.org/227473002/diff/20008/src/types.h#newcode155
src/types.h:155: V(NonNumber, kBoolean | kInternal | kName |
kNull | \
On 2014/04/07 09:32:15, rossberg wrote:
Revision: 20531
Author: bmeu...@chromium.org
Date: Mon Apr 7 09:41:13 2014 UTC
Log: Use distinct maps for oddballs with special handling in the type
system.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/227473002
Committed patchset #5 manually as r20531 (presubmit successful).
https://codereview.chromium.org/227473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Igor Sheludko,
Description:
Return MaybeHandle from SetElement and DeleteElement.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/227573002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+303, -296 lines):
M
Reviewers: Michael Achenbach,
Description:
Version 3.25.28.6 (merged r20316, r20366, r20428, r20451)
Don't pass the hole to SetElement when creating Array.observe change records
Fix Type::Intersect to skip uninhabited bitsets
Make invalid LHSs that are calls late errors
Revision: 20532
Author: ish...@chromium.org
Date: Mon Apr 7 10:00:14 2014 UTC
Log: Callers of ElementsAccessor::Validate() handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/226153002
http://code.google.com/p/v8/source/detail?r=20532
Modified:
Committed patchset #2 manually as r20532 (presubmit successful).
https://codereview.chromium.org/226153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20533 (presubmit successful).
https://codereview.chromium.org/227533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20533
Author: mstarzin...@chromium.org
Date: Mon Apr 7 10:12:54 2014 UTC
Log: Handlify six allocator functions from the Heap.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/227533002
http://code.google.com/p/v8/source/detail?r=20533
Modified:
Committed patchset #2 manually as r20534 (presubmit successful).
https://codereview.chromium.org/227113005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20534
Author: yang...@chromium.org
Date: Mon Apr 7 10:24:01 2014 UTC
Log: Make `String.prototype.contains` throw when passing a regular
expression
Contributed by Mathias Bynens mathi...@opera.com.
TEST=mjsunit/harmony
BUG=v8:3261
LOG=Y
R=yang...@chromium.org,
Drive-by with a question.
https://codereview.chromium.org/225723004/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/225723004/diff/1/include/v8.h#oldcode5278
include/v8.h:5278: bool HasOutOfMemoryException() { return false; }
Why isn't this going through
After discussion with Michael, I moved the head of the dependent IC list
into
the dependent code array.
https://codereview.chromium.org/188783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
I guess you have a point there. Updated.
https://codereview.chromium.org/225723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
lgtm
https://codereview.chromium.org/227483006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm - CCing Ken from nacl team. Anybody interested in figuring out why
these
tests are now failing in V8?
https://codereview.chromium.org/227133006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Achenbach,
Message:
Committed patchset #1 manually as r20535 (presubmit successful).
Description:
Skip a bunch of new failing nacl tests
R=machenb...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20535
Please review this at
Revision: 20535
Author: dcar...@chromium.org
Date: Mon Apr 7 10:44:48 2014 UTC
Log: Skip a bunch of new failing nacl tests
R=machenb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/227133006
http://code.google.com/p/v8/source/detail?r=20535
Modified:
Committed patchset #1 manually as r20536.
https://codereview.chromium.org/227483006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 20536
Author: rossb...@chromium.org
Date: Mon Apr 7 10:47:54 2014 UTC
Log: Version 3.25.28.6 (merged r20316, r20366, r20428, r20451)
Don't pass the hole to SetElement when creating Array.observe change records
Fix Type::Intersect to skip uninhabited bitsets
Make invalid
Revision: 20537
Author: rossb...@chromium.org
Date: Mon Apr 7 10:48:28 2014 UTC
Log: Tagging version 3.25.28.6
http://code.google.com/p/v8/source/detail?r=20537
Added:
/tags/3.25.28.6
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
lgtm
https://codereview.chromium.org/225743004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20538
Author: rossb...@chromium.org
Date: Mon Apr 7 11:00:41 2014 UTC
Log: Refactoring to allow adding new structured types
Also, simplfy representation of zone types, using a simple struct.
R=bmeu...@chromium.org
BUG=
LOG=N
Review URL:
Committed patchset #1 manually as r20538 (presubmit successful).
https://codereview.chromium.org/225923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ulan,
Description:
Handlify LiveEdit.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/227483007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+250, -221 lines):
M src/liveedit.h
M src/liveedit.cc
M src/runtime.cc
On 2014/04/07 11:08:02, Yang wrote:
Most of the changes are caused by moving the class definitions for
FunctionInfoWrapper and SharedInfoWrapper to the header file.
https://codereview.chromium.org/227483007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #2 manually as r20539 (presubmit successful).
https://codereview.chromium.org/225723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20539
Author: yang...@chromium.org
Date: Mon Apr 7 11:11:25 2014 UTC
Log: Deprecate Context::HasOutOfMemoryException.
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/225723004
http://code.google.com/p/v8/source/detail?r=20539
Modified:
A VACCINE SUPPLIER IS
NEEDED VERY URGENT
Mr. Roland Thierry Georges
Rud 78 Avn 55 Zone-3 Marcory
Abidjan Cote d'Ivoire.
West Africa.
Dear Sir,
Please permit me your
attention to introduce to your organization a very lucrative business. I'm the
Executive
corporate affairs Manager in a
lgtm
https://codereview.chromium.org/227483007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen,
Description:
Handlify i18n.cc.
R=joc...@chromium.org
Please review this at https://codereview.chromium.org/226543003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -10 lines):
M src/i18n.cc
Index: src/i18n.cc
diff --git
lgtm
https://codereview.chromium.org/226543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mvstanton,
Description:
Handlify ten allocator functions from the Heap.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/227623002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+28, -144 lines):
M src/factory.h
M
Revision: 20540
Author: yang...@chromium.org
Date: Mon Apr 7 11:32:32 2014 UTC
Log: Handlify LiveEdit.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/227483007
http://code.google.com/p/v8/source/detail?r=20540
Modified:
/branches/bleeding_edge/src/liveedit.cc
Committed patchset #1 manually as r20540 (presubmit successful).
https://codereview.chromium.org/227483007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20541
Author: yang...@chromium.org
Date: Mon Apr 7 11:36:33 2014 UTC
Log: Handlify i18n.cc.
R=joc...@chromium.org
Review URL: https://codereview.chromium.org/226543003
http://code.google.com/p/v8/source/detail?r=20541
Modified:
/branches/bleeding_edge/src/i18n.cc
Committed patchset #1 manually as r20541 (presubmit successful).
https://codereview.chromium.org/226543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Benedikt Meurer,
Message:
As discussed offline, no test case attached, it would break quite soon,
anyway.
Description:
Fixed flooring division by -1 on ARM.
We should avoid ASR #0 on ARM. Simplified and improved code a bit
while we're there on all platforms. Human brains are very
Reviewers: Michael Starzinger,
Description:
Handlify TypeFeedbackOracle::SetInfo.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/226623007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -8 lines):
M src/type-info.cc
On 2014/04/07 11:51:49, Yang wrote:
The DisallowHeapAllocation scope is mostly for documentation, since we
already
have it in TypeFeedbackOracle::BuildDictionary.
https://codereview.chromium.org/226623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM
https://codereview.chromium.org/227553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc#newcode622
src/arm64/macro-assembler-arm64.cc:622: int
Reviewers: ulan,
Description:
Add missing runtime assert for LiveEdit.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/227043009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M src/runtime.cc
Index: src/runtime.cc
lgtm
https://codereview.chromium.org/227043009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20542
Author: yang...@chromium.org
Date: Mon Apr 7 12:00:53 2014 UTC
Log: Add missing runtime assert for LiveEdit.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/227043009
http://code.google.com/p/v8/source/detail?r=20542
Modified:
Committed patchset #1 manually as r20542 (tree was closed).
https://codereview.chromium.org/227043009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20543 (presubmit successful).
https://codereview.chromium.org/225743004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20543
Author: alexandre.ra...@arm.com
Date: Mon Apr 7 12:06:54 2014 UTC
Log: ARM64: Fix disassembly of branch targets.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/225743004
http://code.google.com/p/v8/source/detail?r=20543
Modified:
Committed patchset #2 manually as r20544 (presubmit successful).
https://codereview.chromium.org/227553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20544
Author: svenpa...@chromium.org
Date: Mon Apr 7 12:08:40 2014 UTC
Log: Fixed flooring division by -1 on ARM.
We should avoid ASR #0 on ARM. Simplified and improved code a bit
while we're there on all platforms. Human brains are very bad at
understanding nested
Comment #2 on issue 3261 by mathi...@opera.com:
`String.prototype.contains(regex)` should throw as per latest ES6 draft
http://code.google.com/p/v8/issues/detail?id=3261
Committed: https://code.google.com/p/v8/source/detail?r=20534
This issue can be closed now.
--
You received this message
Updates:
Status: Fixed
Comment #3 on issue 3259 by svenpa...@chromium.org: Floor of div on ARM
returns incorrect results.
http://code.google.com/p/v8/issues/detail?id=3259
Fixed in https://code.google.com/p/v8/source/detail?r=20544. We should
probably back-merge this to M35 after
Reviewers: Michael Starzinger, jarin,
Message:
There a two problems with that cl:
1) The instance size accessors are part of the objects API. We should remove
these accessors as soon as we have the proper abstractions on the GC side.
2) The atomic byte accessors are ugly, but we cannot make them
LGTM.
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc
File src/type-info.cc (left):
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc#oldcode499
src/type-info.cc:499: // Dictionary has been allocated with sufficient
size for all elements.
nit: Can we preserve
Nice cleanup! lgtm.
https://codereview.chromium.org/227623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/227133007/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/227133007/diff/20001/src/objects-inl.h#newcode4075
src/objects-inl.h:4075: size_field = 8;
Do you prefer masking ifdef style?
Committed patchset #2 manually as r20545 (presubmit successful).
https://codereview.chromium.org/222433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20545
Author: alexandre.ra...@arm.com
Date: Mon Apr 7 12:33:03 2014 UTC
Log: ARM64: Introduce a version of ADR handling distant targets.
This fixes an out-of-range label error for an ADR instruction in the
mozilla/data/js1_5/Regress/regress-280769-2.js test.
LGTM. Just one comment.
https://codereview.chromium.org/225183009/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/225183009/diff/1/src/objects.h#newcode1080
src/objects.h:1080: V(OrderedHashTable) \
Since the OrderedHashTable is just
Revision: 20546
Author: mstarzin...@chromium.org
Date: Mon Apr 7 12:43:35 2014 UTC
Log: Handlify ten allocator functions from the Heap.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/227623002
http://code.google.com/p/v8/source/detail?r=20546
Modified:
Committed patchset #1 manually as r20546 (presubmit successful).
https://codereview.chromium.org/227623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/225753004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/225753004/diff/1/src/parser.cc#newcode230
src/parser.cc:230: if (length % sizeof(unsigned) != 0) {
Why do we silently return here? Wouldn't an ASSERT be better?
Reviewers: ulan,
Message:
Exceptions can no longer be a failure. This change is to reflect that.
Description:
Change exception type to Object.
Please review this at https://codereview.chromium.org/227163008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+27,
Reviewers: ulan, jochen,
Message:
This patch diminishes the regression observed at
https://codereview.chromium.org/209333004 .
With this patch applied, the timings for
make -j32 arm64.release.check TESTFLAGS=--time
TESTJOBS=mozilla/js1_5/Regress/regress-280769-2
become:
Without the regexp
Committed patchset #2 manually as r20547 (presubmit successful).
https://codereview.chromium.org/226623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20547
Author: yang...@chromium.org
Date: Mon Apr 7 12:55:06 2014 UTC
Log: Handlify TypeFeedbackOracle::SetInfo.
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/226623007
http://code.google.com/p/v8/source/detail?r=20547
Modified:
1 - 100 of 145 matches
Mail list logo
