lgtm
https://codereview.chromium.org/263923004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
PTAL
Description:
Next bunch of fixes for check elimination.
- Canonicalize HCheckMapValue with constant map to
HCheckMaps, and get rid of the special treatment
during check elimination.
- Track only stable object maps for HConstants and
add CHECK()s to ver
Reviewers: Toon Verwaest,
Description:
Pass dependency to HLoadNamedField for array length load
BUG=
Please review this at https://codereview.chromium.org/267773004/
SVN Base: https://github.com/v8/v8.git@bleeding_edge
Affected files (+1, -1 lines):
M src/hydrogen.cc
Index: src/hydrogen.c
Status: New
Owner:
New issue 3311 by c...@imvu.com: "return null" returns a 0 to caller
http://code.google.com/p/v8/issues/detail?id=3311
https://github.com/joyent/node/issues/7564
See the linked Node.js bug. Given the attached a.out.js, running "node
a.out.js" illustrates a JavaScript
Revision: 21153
Author: machenb...@chromium.org
Date: Tue May 6 00:06:44 2014 UTC
Log: Tagging version 3.26.31
http://code.google.com/p/v8/source/detail?r=21153
Added:
/tags/3.26.31
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Comment #4 on issue 3301 by anton.gr...@gmail.com: repeatedly allocation
causes segfault
http://code.google.com/p/v8/issues/detail?id=3301
Still having problems with this segfault..
Here is more information on environments where segfault occurs:
- use libc 2.11 or 2.13
- use only ia32 build
Reviewers: Toon Verwaest,
Description:
Clean up hash creation code to use Handle where possible
Also remove apparently-bogus TODO and reorder arguments in
Object::GetOrCreateHash to put Isolate first (as seems to
be the custom).
R=verwa...@chromium.org
Please review this at https://codereview.
Committed patchset #1 manually as r21151 (presubmit successful).
https://codereview.chromium.org/261773006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21151
Author: ad...@chromium.org
Date: Mon May 5 21:44:36 2014 UTC
Log: Tighten up Object.observe code to ASSERT that it never deals with
globals
After r21126, Object.observe no longer allows observing the global proxy
object. This patch replaces codepaths that used to ha
lgtm
https://codereview.chromium.org/261773006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Tighten up Object.observe code to ASSERT that it never deals with globals
After r21126, Object.observe no longer allows observing the global proxy
object. This patch replaces codepaths that used to handle that case with
asserts showing that no such observat
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/a...@chromium.org/263883008/1
https://codereview.chromium.org/263883008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/263833007/diff/80001/src/runtime.cc#newcode15003
src/runtime.cc:15003: CONVERT_ARG_HANDLE_CHECKED(Object, callback, 1);
On 2014/05/03 05:28:26, Toon Verwaest wrote:
I
Status: New
Owner:
CC: ad...@chromium.org, rafa...@chromium.org, rossb...@chromium.org,
verwa...@chromium.org
Labels: Type-Bug Priority-Medium Harmony
New issue 3310 by ad...@chromium.org: Object.observe does not play well
with JSProxy and JSFunctionProxy
http://code.google.com/p/v8
Revision: 21150
Author: ad...@chromium.org
Date: Mon May 5 18:27:57 2014 UTC
Log: Store JSGlobalProxy's identity hash directly on the proxy itself
Previously, the hash was stored on the underlying global object, since
it was stored in the hidden property table. This patch moves to an
Committed patchset #4 manually as r21150 (presubmit successful).
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/05/03 05:44:42, Toon Verwaest wrote:
Still LGTM. I don't see a security issue with this patch.
Good. I didn't either, but thought another pair of eyes was good given last
week...
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups
lgtm
https://codereview.chromium.org/263883008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/265823006/diff/1/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/265823006/diff/1/include/v8-util.h#newcode288
include/v8-util.h:288: RELEASE_ASSERT(!persistent->IsEmpty());
the v8 equivalent to RELEASE_ASSERT() is CHECK(), howeve
On 2014/05/05 08:52:24, Dmitry Lomov (chromium) wrote:
On 2014/05/05 08:28:41, Jakob wrote:
> DBC: I'm not convinced that removing this test is a good idea.
> Yes, bumping the limit every so often is annoying and kind of defeats
the
> purpose of the test. On the other hand, we put in a lot of
Revision: 21149
Author: hpa...@chromium.org
Date: Mon May 5 16:48:33 2014 UTC
Log: Set max new space size in tests to proper MB value.
Revert "Limit old space size in test which require a large new space."
This reverts commit r21103.
Revert "Remove max space limits in tests."
This
Committed patchset #2 manually as r21149 (presubmit successful).
https://codereview.chromium.org/263103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
In the mjsunit tests you'll have to convert the sizes to MB.
Also, please use SVN revision numbers instead of git commit hashes in the CL
description.
Other than that LGTM.
https://codereview.chromium.org/263103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gro
Reviewers: Jakob,
Description:
Set max new space size in tests to proper MB value.
Revert "Limit old space size in test which require a large new space."
This reverts commit b9c4ecd019caebbf28480d124e8649ae411876c8.
Revert "Remove max space limits in tests."
This reverts commit d5e8afac2d4e8c
Revision: 21148
Author: hpa...@chromium.org
Date: Mon May 5 16:33:23 2014 UTC
Log: FLAG_max_new_space_size is in MB.
Plus, cleanup of the space - generation mess. More to do there...
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/268073004
http://code.goog
Committed patchset #4 manually as r21148 (presubmit successful).
https://codereview.chromium.org/268073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Nah, it's fine. I will land it.
https://codereview.chromium.org/268073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
lgtm
https://codereview.chromium.org/261203003/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/261203003/diff/1/BUILD.gn#newcode47
BUILD.gn:47: visibility = ":*" # Only targets in this file can depend
on this.
Below here you'll want to say:
defines = []
And then turn
lgtm with comments:
https://codereview.chromium.org/263083008/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/263083008/diff/1/src/factory.cc#newcode1210
src/factory.cc:1210: Handle
context(isolate()->context()->native_context());
Does it make sense to add ASS
Revision: 21147
Author: machenb...@chromium.org
Date: Mon May 5 15:16:26 2014 UTC
Log: Remove old branch logic from push scripts.
The old temporary branch is not needed anymore. All scripts create a
different branch after creating the temporary branch.
This also fixes logging subp
lgtm
https://codereview.chromium.org/261103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
This change needs more thought... I have to re-do it, properly.
https://codereview.chromium.org/268073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #2 manually as r21147 (presubmit successful).
https://codereview.chromium.org/266083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/266083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 21146
Author: ma...@chromium.org
Date: Mon May 5 14:55:13 2014 UTC
Log: Remove symbol preparse data altogether.
Removing it seems to be a clear win on mobile: producing symbol data makes
cold
parsing 20-30% slower, and having symbol data doesn't make warm parsing any
fast
Committed patchset #3 manually as r21146 (presubmit successful).
https://codereview.chromium.org/261273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21145
Author: wi...@igalia.com
Date: Mon May 5 14:31:51 2014 UTC
Log: Relocate suspended generator activations when enabling debug mode
R=yang...@chromium.org
BUG=v8:3289
LOG=N
Review URL: https://codereview.chromium.org/264973014
http://code.google.com/p/v8/source/detail?r
Committed patchset #1 manually as r21145 (presubmit successful).
https://codereview.chromium.org/264973014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/266823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/05/05 13:56:24, wingo wrote:
The difference between this and r21141 is a static_cast(Address -
Address)
in debug.cc.
lgtm.
https://codereview.chromium.org/264973014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
lgtm
https://codereview.chromium.org/263883008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Description:
Fix cctest.status typo
TBR=ish...@chromium.org
BUG=none
LOG=n
Please review this at https://codereview.chromium.org/266823004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M test/cctest/cctest.status
I
The difference between this and r21141 is a static_cast(Address -
Address)
in debug.cc.
https://codereview.chromium.org/264973014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Gro
Committed patchset #1 manually as r21144 (tree was closed).
https://codereview.chromium.org/266823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 21144
Author: joc...@chromium.org
Date: Mon May 5 13:56:39 2014 UTC
Log: Fix cctest.status typo
TBR=ish...@chromium.org
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/266823004
http://code.google.com/p/v8/source/detail?r=21144
Modified:
/branches/bleeding_edge
Reviewers: yurys, Benedikt Meurer,
Message:
ptal
Description:
Make sure CPU profiler collects a sample on start.
BUG=369035
LOG=N
Please review this at https://codereview.chromium.org/263883008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+24, -22 lines):
Reviewers: Yang,
Description:
Relocate suspended generator activations when enabling debug mode
R=yang...@chromium.org
BUG=v8:3289
LOG=N
Please review this at https://codereview.chromium.org/264973014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+241, -72 li
Status: Accepted
Owner: mvstan...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3309 by mvstan...@chromium.org: out of bounds array elements can
be set when length is read-only
http://code.google.com/p/v8/issues/detail?id=3309
Simple repro from verwa...@chromium.org:
var a = [];
Ob
lgtm
https://codereview.chromium.org/261273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
lgtm
https://codereview.chromium.org/261273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Revision: 21143
Author: joc...@chromium.org
Date: Mon May 5 13:29:10 2014 UTC
Log: Mark test-cpu-profiler/JsNativeJsRuntimeJsSample as flaky
BUG=v8:3308
LOG=n
TBR=yu...@chromium.org
Review URL: https://codereview.chromium.org/268093002
http://code.google.com/p/v8/source/detail?r=2114
On 2014/05/05 13:28:29, jochen wrote:
Committed patchset #1 manually as r21142 (tree was closed).
Lgtm
https://codereview.chromium.org/262193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Committed patchset #1 manually as r21143 (presubmit successful).
https://codereview.chromium.org/268093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21142
Author: joc...@chromium.org
Date: Mon May 5 13:28:21 2014 UTC
Log: Revert r21141.
Relocate suspended generator activations when enabling debug mode
BUG=v8:3289
LOG=N
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/262193003
http://code.google.com/p
On 2014/05/05 13:26:34, Yang wrote:
On 2014/05/05 13:25:47, Yang wrote:
> On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a provisio
Reviewers: dcarney,
Message:
dcarney@, ptal, jochen@, fyi.
Let's stop the symbol data madness now!
Some measurements on mobile. These were done with parser shell.
Data set 1 (20 M, contains some lazy functions).
Baseline cold: ~8400 ms
Baseline warm: ~6000 ms
Without symbol data cold: ~7000
Committed patchset #1 manually as r21142 (tree was closed).
https://codereview.chromium.org/262193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: Yang,
Description:
Revert r21141.
Relocate suspended generator activations when enabling debug mode
BUG=v8:3289
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/262193003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
On 2014/05/05 13:25:47, Yang wrote:
On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star commi
On 2014/05/05 13:25:12, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-
Reviewers: yurys,
Description:
Mark test-cpu-profiler/JsNativeJsRuntimeJsSample as flaky
BUG=v8:3308
LOG=n
TBR=yu...@chromium.org
Please review this at https://codereview.chromium.org/268093002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M
Status: Accepted
Owner: yu...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3308 by joc...@chromium.org:
test-cpu-profiler/JsNativeJsRuntimeJsSample is flaky
http://code.google.com/p/v8/issues/detail?id=3308
sample output
--- stderr ---
#
# Fatal error in ../test/cctest/test-cpu-pr
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/wi...@igalia.com/265303002/1
https://codereview.chromium.org/265303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do
A revert of this CL has been created in
https://codereview.chromium.org/265303002/ by wi...@igalia.com.
The reason for reverting is: Rolling out for build breakage ('Tree is closed
(Automatic: "compile" on "V8 Win64" from 21141: wi...@igalia.com)').
https://codereview.chromium.org/260423002/
--
Reviewers: Yang, Michael Starzinger,
Message:
Created Revert of Relocate suspended generator activations when enabling
debug
mode
Description:
Revert of Relocate suspended generator activations when enabling debug mode
(https://codereview.chromium.org/260423002/)
Reason for revert:
Rolling o
Reviewers: Michael Starzinger,
Description:
Move generated math methods from platform to codegen
BUG=none
R=mstarzin...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/269823006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+77, -106
Revision: 21141
Author: wi...@igalia.com
Date: Mon May 5 12:57:14 2014 UTC
Log: Relocate suspended generator activations when enabling debug mode
R=yang...@chromium.org
BUG=v8:3289
LOG=N
Review URL: https://codereview.chromium.org/260423002
http://code.google.com/p/v8/source/detail?r
Committed patchset #3 manually as r21141 (presubmit successful).
https://codereview.chromium.org/260423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: brettw,
Description:
Import features.gypi into BUILD.gn
BUG=none
R=bre...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/261203003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+88, -8 lines):
M BUILD.gn
Index: BUILD.g
On 2014/05/05 11:21:18, wingo wrote:
Updated patch to iterate heap only once. PTAL :)
lgtm.
https://codereview.chromium.org/260423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Goog
Updated patch to iterate heap only once. PTAL :)
https://codereview.chromium.org/260423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
lgtm, bots use Android NDK r9, which has platform-14.
https://codereview.chromium.org/267873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
https://codereview.chromium.org/260423002/diff/20001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/260423002/diff/20001/src/debug.cc#newcode2104
src/debug.cc:2104: CollectSuspendedGenerators(&suspended_generators);
On 2014/05/05 09:40:15, Yang wrote:
Do we really need
LGTM. Do you want to land the corresponding ARM change too?
https://codereview.chromium.org/261933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 21140
Author: joc...@chromium.org
Date: Mon May 5 11:06:26 2014 UTC
Log: Add a basic gn file for V8
Currently, the gn support is incomplete and only works from within a
chromium checkout.
See https://code.google.com/p/chromium/wiki/gn for details
We move the BUILD.gn file
Committed patchset #1 manually as r21140 (presubmit successful).
https://codereview.chromium.org/259233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21139
Author: bmeu...@chromium.org
Date: Mon May 5 11:03:14 2014 UTC
Log: Don't add code dependencies eagerly for HCheckMaps.
Instead of adding code dependencies on stable during
graph creation, we now add them during code generation
for those HCheckMaps that survived dead c
Committed patchset #3 manually as r21139 (presubmit successful).
https://codereview.chromium.org/264973013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/264973013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
Related to bug 3289; depends on changes in
https://codereview.chromium.org/260423002/.
Description:
Prevent liveedit on or under generators with open activations
R=yang...@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=
Please review this at
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Only force creating initial maps when we have prototypes.
BUG=
Please review this at https://codereview.chromium.org/261983007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -6 lines):
M src/factory.c
Reviewers: Sven Panne,
Message:
PTAL
Description:
Don't add code dependencies eagerly for HCheckMaps.
Instead of adding code dependencies on stable during
graph creation, we now add them during code generation
for those HCheckMaps that survived dead code elimination.
Please review this at http
Rubberstamp lgtm.
https://codereview.chromium.org/259233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving e
lgtm
https://codereview.chromium.org/268073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 21138
Author: ish...@chromium.org
Date: Mon May 5 09:57:45 2014 UTC
Log: Map::TransitionElementsTo() extracted from
JSObject::GetElementsTransitionMap().
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/260803002
http://code.google.com/p/v8/source/deta
Committed patchset #1 manually as r21138 (presubmit successful).
https://codereview.chromium.org/260803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: mvstanton, Michael Starzinger,
Description:
FLAG_max_new_space_size is in MB.
Plus, cleanup of the space - generation mess. More to do there...
BUG=
Please review this at https://codereview.chromium.org/268073004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affe
Revision: 21137
Author: svenpa...@chromium.org
Date: Mon May 5 09:52:03 2014 UTC
Log: Inlined IsFoundByRuntimeProbingOnly.
It is only used internally at a single place.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/265243004
http://code.google.com/p/v8/source/de
Committed patchset #1 manually as r21137 (presubmit successful).
https://codereview.chromium.org/265243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Nice refactoring. Looking good so far, but I have one comment.
Also sorry for the delay. Had vacation/holidays.
https://codereview.chromium.org/260423002/diff/20001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/260423002/diff/20001/src/debug.cc#newcode2104
src/debug.cc
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Pass in the map while creating JSFunction, and set prototype in the client.
BUG=
Please review this at https://codereview.chromium.org/263083008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+146, -152 lin
On 2014/05/05 09:27:09, Sven Panne wrote:
lgtm.
https://codereview.chromium.org/265243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
lgtm
https://codereview.chromium.org/260803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
Inlined IsFoundByRuntimeProbingOnly.
It is only used internally at a single place.
Please review this at https://codereview.chromium.org/265243004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -32 lines):
M src/arm/assembl
I like the idea. I think we can make the implementation less fragile.
If someone adds masm load/store to the gap resolver without checking for
pending
operation, this might result in a hard to find bug.
It would be nice to have some kind of bottleneck between the gap resolver
and
the masm.
On 2014/05/05 08:28:41, Jakob wrote:
DBC: I'm not convinced that removing this test is a good idea.
Yes, bumping the limit every so often is annoying and kind of defeats the
purpose of the test. On the other hand, we put in a lot of work to get
boot-up
memory use low (IIRC the effort at the tim
lgtm
https://codereview.chromium.org/263083007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
DBC: I'm not convinced that removing this test is a good idea.
Yes, bumping the limit every so often is annoying and kind of defeats the
purpose of the test. On the other hand, we put in a lot of work to get
boot-up
memory use low (IIRC the effort at the time brought it from ~20 to ~2 MB),
and
1 - 100 of 119 matches
Mail list logo
