[v8-dev] Re: When flag --nouse-osr is set, don't allow osr from hidden runtime calls. (issue 310773003)

2014-06-03 Thread yangguo
LGTM, but the test case can be a *lot* simpler. Something like Flags: --nouse-osr function f() { %OptimizeFunctionOnNextCall(f, "osr"); for (var i = 0; i < 1000; i++); } f(); https://codereview.chromium.org/310773003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chr

[v8-dev] Re: Trigonometric functions using fdlibm. (issue 303753002)

2014-06-03 Thread yangguo
Reviewers: Raymond Toy, https://codereview.chromium.org/303753002/diff/40001/src/math.js File src/math.js (right): https://codereview.chromium.org/303753002/diff/40001/src/math.js#newcode262 src/math.js:262: } On 2014/06/02 17:26:11, Raymond Toy wrote: As you mentioned via email, you've remove

<    1   2   3