Reviewers: Toon Verwaest,
Description:
Optimize various forms of slice.call(arguments, ...)
BUG=v8:3037
LOG=n
R=verwa...@chromium.org
TEST=mjsunit/compiler/slice-call-arguments
Please review this at https://codereview.chromium.org/327173002/
SVN Base: https://github.com/v8/v8.git@master
Reviewers: Sven Panne,
Message:
PTAL, patch applied cleanly.
Description:
Version 3.26.31.3 (merged r21299)
Skip write barriers when updating the weak hash table.
BUG=359401,378206
LOG=N
Please review this at https://codereview.chromium.org/329063002/
SVN Base:
LGTM (rubber-stamped)
https://codereview.chromium.org/329063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #2 manually as r21756 (presubmit successful).
https://codereview.chromium.org/326943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21756
Author: yang...@chromium.org
Date: Wed Jun 11 06:59:25 2014 UTC
Log: Simplify string copy in SubStringStub.
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.
R=bmeu...@chromium.org
BUG=352155
LOG=N
Review URL:
Revision: 21757
Author: u...@chromium.org
Date: Wed Jun 11 07:07:52 2014 UTC
Log: Version 3.26.31.3 (merged r21299)
Skip write barriers when updating the weak hash table.
BUG=359401,378206
LOG=N
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/329063002
Committed patchset #1 manually as r21757.
https://codereview.chromium.org/329063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 21758
Author: u...@chromium.org
Date: Wed Jun 11 07:08:06 2014 UTC
Log: Tagging version 3.26.31.3
http://code.google.com/p/v8/source/detail?r=21758
Added:
/tags/3.26.31.3
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
lgtm
https://codereview.chromium.org/323303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
The latest patch set matches the disallowed characters and whitespace
handling
of ContentSearchUtils, even though it's pretty arbitrary regarding what
characters it allows in the URL and what not (disallows ' which is a valid
URL
character, allows ^ which is not a valid URL character).
Feedback addressed, please take another look.
https://codereview.chromium.org/57123002/diff/1520001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/57123002/diff/1520001/src/code-stubs-hydrogen.cc#newcode1670
src/code-stubs-hydrogen.cc:1670:
Reviewers: Michael Achenbach,
Message:
Highly complex CL, for a deep technical issue.
Description:
Fix GN build.
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/328883005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -0
LGTM.
https://codereview.chromium.org/326323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
After intensive and thorough review I decided to give you an lgtm!
https://codereview.chromium.org/328883005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r21759 (presubmit successful).
https://codereview.chromium.org/328883005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21759
Author: mstarzin...@chromium.org
Date: Wed Jun 11 08:31:13 2014 UTC
Log: Fix GN build.
R=machenb...@chromium.org
Review URL: https://codereview.chromium.org/328883005
http://code.google.com/p/v8/source/detail?r=21759
Modified:
/branches/bleeding_edge/BUILD.gn
Revision: 21760
Author: machenb...@chromium.org
Date: Wed Jun 11 08:48:10 2014 UTC
Log: Version 3.27.25 (based on bleeding_edge revision r21759)
Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detail?r=21760
Modified:
/trunk/BUILD.gn
Revision: 21761
Author: machenb...@chromium.org
Date: Wed Jun 11 08:48:29 2014 UTC
Log: Tagging version 3.27.25
http://code.google.com/p/v8/source/detail?r=21761
Added:
/tags/3.27.25
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: Jakob,
Description:
Fix unsigned comparisons.
Instead of marking the comparison instruction itself as Uint32, we
look at its arguments. This is more consistent what HChange does.
BUG=v8:3380
TEST=mjsunit/regress/regress-3380
LOG=y
Please review this at
Reviewers: ulan,
Description:
Removed dead API entries.
Please review this at https://codereview.chromium.org/322293003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -10 lines):
M include/v8-debug.h
Index: include/v8-debug.h
diff --git
lgtm
https://codereview.chromium.org/325133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/322293003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Invalid
Comment #1 on issue 3386 by jkumme...@chromium.org: Patch for
/codereview.settings
http://code.google.com/p/v8/issues/detail?id=3386
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
Revision: 21762
Author: svenpa...@chromium.org
Date: Wed Jun 11 09:09:15 2014 UTC
Log: Fix unsigned comparisons.
Instead of marking the comparison instruction itself as Uint32, we
look at its arguments. This is more consistent what HChange does.
BUG=v8:3380
Committed patchset #3 manually as r21762 (presubmit successful).
https://codereview.chromium.org/325133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Updates:
Status: Fixed
Comment #2 on issue 3380 by svenpa...@chromium.org: Bug with x64
http://code.google.com/p/v8/issues/detail?id=3380
Fixed in https://code.google.com/p/v8/source/detail?r=21762
--
You received this message because this project is configured to send all
issue
Committed patchset #1 manually as r21763 (presubmit successful).
https://codereview.chromium.org/322293003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21763
Author: svenpa...@chromium.org
Date: Wed Jun 11 09:12:35 2014 UTC
Log: Removed dead API entries.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/322293003
http://code.google.com/p/v8/source/detail?r=21763
Modified:
I like this! lgtm
https://codereview.chromium.org/314953006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2014/06/11 09:27:04, Igor Sheludko wrote:
I like this! lgtm
Please remove declaration of FetchDetails() from the header.
https://codereview.chromium.org/314953006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM, will land this for you.
https://codereview.chromium.org/326193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: ulan,
Message:
Committed patchset #1 manually as r21764 (tree was closed).
Description:
Unbreak build.
TBR=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21764
Please review this at https://codereview.chromium.org/329053005/
SVN Base:
Revision: 21764
Author: svenpa...@chromium.org
Date: Wed Jun 11 09:34:25 2014 UTC
Log: Unbreak build.
TBR=u...@chromium.org
Review URL: https://codereview.chromium.org/329053005
http://code.google.com/p/v8/source/detail?r=21764
Modified:
Revision: 21765
Author: mstarzin...@chromium.org
Date: Wed Jun 11 09:42:48 2014 UTC
Log: Fix typos in BUILD.gn source lists
foo,cc is not the same as foo.cc
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/326193002
Patch from James Robinson
Committed patchset #1 manually as r21765 (presubmit successful).
https://codereview.chromium.org/326193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21766
Author: svenpa...@chromium.org
Date: Wed Jun 11 09:44:14 2014 UTC
Log: Set SAHF flag correctly for ia32
sahf flag will not be set for ia32 on some old platform because some old
processors does not support CPUID's extended features.
This also avoids redundant cpuid
Committed patchset #2 manually as r21766 (presubmit successful).
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/326333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #7 manually as r21767 (presubmit successful).
https://codereview.chromium.org/314953006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21767
Author: verwa...@chromium.org
Date: Wed Jun 11 09:59:14 2014 UTC
Log: Implement LookupIterator designed to replace LookupResult
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/314953006
http://code.google.com/p/v8/source/detail?r=21767
Added:
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-arm.cc#newcode809
src/arm/lithium-arm.cc:809: constant_value = constant-Integer32Value()
0x1f;
On 2014/06/10 11:53:37,
Uploaded the patch with your comments addressed. Could you confirm it is
still
ok to go in? Thanks
https://codereview.chromium.org/312173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
On 2014/06/11 09:44:25, Sven Panne wrote:
Committed patchset #2 manually as r21766 (presubmit successful).
huh? I thought this CL has been dismissed after Weiliang's last comment.
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: ulan,
Description:
Ignore live_edit_ flag when when dealing with LiveEdit in a debug break.
LiveEdit maybe disabled when we enter the break and again when we
leave it, but enabled in between.
TEST=https://codereview.chromium.org/329533002
R=u...@chromium.org
Please review this at
lgtm! (with 2 last nits)
https://codereview.chromium.org/57123002/diff/1540001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/57123002/diff/1540001/src/hydrogen.cc#newcode1425
src/hydrogen.cc:1425: AddHLoadNamedField(map,
static_castHValue*(NULL), access);
nit:
On 2014/06/11 10:49:28, Yang wrote:
On 2014/06/11 09:44:25, Sven Panne wrote:
Committed patchset #2 manually as r21766 (presubmit successful).
huh? I thought this CL has been dismissed after Weiliang's last comment.
Hmmm, reading it again, it seems that this CL was really not necessary.
LGTM
On 2014/06/11 07:40:53, marja wrote:
The latest patch set matches the disallowed characters and whitespace
handling
of ContentSearchUtils, even though it's pretty arbitrary regarding what
characters it allows in the URL and what not (disallows ' which is a
valid URL
character, allows
lgtm
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/264333007/diff/150001/src/debug.h
File src/debug.h (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.h#oldcode368
src/debug.h:368: NO_AFTER_COMPILE_FLAGS,
It might make sense to do this clean-up in a separate change.
lgtm
https://codereview.chromium.org/325183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Yang, could you do OWNER review?
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Updates:
Cc: amikhayl...@google.com
Comment #2 on issue 3291 by aand...@chromium.org: Implement mirror objects
for WeakSets and WeakMaps
http://code.google.com/p/v8/issues/detail?id=3291
(No comment was entered for this change.)
--
You received this message because this project is
Revision: 21768
Author: machenb...@chromium.org
Date: Wed Jun 11 12:16:14 2014 UTC
Log: Whitespace change to trigger bots.
BUG=
TBR=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/324373002
http://code.google.com/p/v8/source/detail?r=21768
Modified:
Reviewers: Jakob,
Message:
Committed patchset #1 manually as r21768 (presubmit successful).
Description:
Whitespace change to trigger bots.
BUG=
TBR=jkumme...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21768
Please review this at
LGTM, though it's not used yet, is it?
https://codereview.chromium.org/328093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
I'm fine reverting it
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Yang,
Description:
Fixed flooring division by a power of 2, once again...
Avoid right shifts by zero bits: On ARM it actually means shifting by
32 bits (correctness issue) and on other platforms they are useless
(performance issue). This is fix for the fix in r20544.
BUG=v8:3259
On 2014/06/11 13:10:34, Sven Panne wrote:
lgtm!
https://codereview.chromium.org/324403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
svenpanne@, ulan@, could you do the V8 side review?
svenpanne: API additions
ulan: the rest
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Comment #2 on issue 3381 by builder...@gmail.com: new
Date().getFullYear().toLocaleString('ar or kr') The results are displayed
in a comma.
http://code.google.com/p/v8/issues/detail?id=3381
Yeah, maybe. The whole bunch of my mistake.
I am .getFullYear() thought I did not know the return
Revision: 21769
Author: svenpa...@chromium.org
Date: Wed Jun 11 13:29:25 2014 UTC
Log: Fixed flooring division by a power of 2, once again...
Avoid right shifts by zero bits: On ARM it actually means shifting by
32 bits (correctness issue) and on other platforms they are useless
Committed patchset #1 manually as r21769 (presubmit successful).
https://codereview.chromium.org/324403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Yang.
please help to review this porting patch for X87.
thanks
Description:
X87: Simplify string copy in SubStringStub.
port r21756.
original commit message:
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.
Updates:
Status: Fixed
Comment #5 on issue 3259 by svenpa...@chromium.org: Floor of div on ARM
returns incorrect results.
http://code.google.com/p/v8/issues/detail?id=3259
Fixed in https://code.google.com/p/v8/source/detail?r=21769 (hopefully ;-).
--
You received this message
On 2014/06/11 13:32:55, chunyang.dai wrote:
Yang.
please help to review this porting patch for X87.
thanks
lgtm.
https://codereview.chromium.org/326353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #3 on issue 3381 by builder...@gmail.com: new
Date().getFullYear().toLocaleString('ar or kr') The results are displayed
in a comma.
http://code.google.com/p/v8/issues/detail?id=3381
Yeah, maybe. The whole bunch of my mistake.
I am .getFullYear() thought I did not know the return
Revision: 21770
Author: yang...@chromium.org
Date: Wed Jun 11 13:40:18 2014 UTC
Log: Ignore live_edit_ flag when when dealing with LiveEdit in a debug
break.
LiveEdit maybe disabled when we enter the break and again when we
leave it, but enabled in between.
Committed patchset #1 manually as r21770 (presubmit successful).
https://codereview.chromium.org/325183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Hi Alexey,
I fixed the issue in V8 r21770. But due to r21767, the test will fail at a
different spot, for now. This is being solved as we speak though. I'm
fairly certain that you can land your CL after the next V8 roll.
Regards,
Yang
On Tue, Jun 10, 2014 at 4:45 PM, Yang Guo
Reviewers: rossberg,
Message:
On 2014/06/11 12:24:57, rossberg wrote:
LGTM, though it's not used yet, is it?
Correct; it just needed to be in place for for-of to keep on working when I
add
@@iterator support there.
Description:
Add @@iterator for generator objects
R=rossb...@chromium.org
Reviewers: Yang, Igor Sheludko,
Message:
PTAL
Description:
Correctly lookup starting at the holder
BUG=
Please review this at https://codereview.chromium.org/329153002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M src/api.cc
Index:
On 2014/06/11 13:56:36, Toon Verwaest wrote:
PTAL
LGTM.
https://codereview.chromium.org/329153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: danno, Yang, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Simplify string copy in SubStringStub.
Port r21756 (3d58e58)
Original commit message:
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.
BUG=352155
LOG=N
Please review
Revision: 21771
Author: verwa...@chromium.org
Date: Wed Jun 11 14:03:13 2014 UTC
Log: Correctly lookup starting at the holder
BUG=
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/329153002
http://code.google.com/p/v8/source/detail?r=21771
Modified:
Committed patchset #1 manually as r21771 (presubmit successful).
https://codereview.chromium.org/329153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21772
Author: weiliang@intel.com
Date: Wed Jun 11 14:09:05 2014 UTC
Log: X87: Simplify string copy in SubStringStub.
port r21756.
original commit message:
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.
Committed as r21772
https://codereview.chromium.org/326353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
I think, for the future, if the changes only affect files in the x87 port,
it's fine to do the review without a general v8 OWNER. This is the case for
the MIPS port.
Regards,
Yang
On Wed, Jun 11, 2014 at 4:12 PM, weiliang@intel.com wrote:
Committed as r21772
LGTM
I was on the fence whether to use `symbolIterator` or
`InternalSymbol('Symbol.iterator')`. I think we might want to rename
`symbolIterator` to `$SymbolIterator` to match the naming conventions of
variable references between files.
https://codereview.chromium.org/328093002/
--
--
v8-dev
lgtm
https://codereview.chromium.org/324373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/326413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc
File src/debug.cc (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc#oldcode2705
src/debug.cc:2705: if (was_in_scope (after_compile_flags
SEND_WHEN_DEBUGGING) == 0) return;
Is it guaranteed that when
Revision: 21773
Author: plin...@gmail.com
Date: Wed Jun 11 14:44:13 2014 UTC
Log: MIPS: Simplify string copy in SubStringStub.
Port r21756 (3d58e58)
Original commit message:
The optimizations are unnecessary since the maximum
string length they operate on is currently 12.
BUG=352155
Committed as r21773.
https://codereview.chromium.org/326413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #30 manually as r21774 (presubmit successful).
https://codereview.chromium.org/57123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21774
Author: da...@chromium.org
Date: Wed Jun 11 14:56:38 2014 UTC
Log: Generate KeyedLoadGeneric with Hydrogen
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/57123002
http://code.google.com/p/v8/source/detail?r=21774
Added:
Looks mostly good. My only concern is with the name AstStringTable and its
construction API for AstValues.
https://codereview.chromium.org/314603004/diff/1/src/ast-string-table.cc
File src/ast-string-table.cc (right):
Hello, Daniel Yang.
We will do it according to your suggestion.
Thanks.
Chunyang
• (86)-21-6116 6158
iNet: 8821 6158
•: chunyang@intel.commailto:chunyang@intel.com
From: yang...@google.com [mailto:yang...@google.com] On Behalf Of Yang Guo
Sent: Wednesday, June 11, 2014 10:57 PM
I just talked to Danno. We think it's fine to have you create a OWNERS file
similar to the one in src/mips/ for src/x87, with an entry for Weiliang.
That way you can land patches that affect only x87 without further approval
from the V8 team.
Regards,
Yang
On Wed, Jun 11, 2014 at 4:16 PM, Yang
On 2014/06/11 14:33:37, Yang wrote:
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc
File src/debug.cc (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc#oldcode2705
src/debug.cc:2705: if (was_in_scope (after_compile_flags
SEND_WHEN_DEBUGGING) == 0)
On 2014/06/11 15:07:22, kozyatinskiy wrote:
On 2014/06/11 14:33:37, Yang wrote:
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc
File src/debug.cc (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc#oldcode2705
src/debug.cc:2705: if (was_in_scope
Reviewers: rossberg,
Message:
Seemed like a good idea. Should it be behind a flag? What am I forgetting
to
test?
There's a pending TODO that I don't plan on doing: computed names for
getters/setters.
Description:
Add support for computed property names in object literals
So much better! I have a few naming quibbles, though.
https://codereview.chromium.org/314953006/diff/180001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/314953006/diff/180001/src/lookup.cc#newcode72
src/lookup.cc:72: state_ = NOT_FOUND;
Might be clearer to not
Reviewers: danno, Yang,
Description:
X87: add OWNERS file
BUG=
Please review this at https://codereview.chromium.org/323413002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
A src/x87/OWNERS
Index: src/x87/OWNERS
diff --git a/src/x87/OWNERS
On 2014/06/05 11:52:37, Yang wrote:
On 2014/06/05 11:44:03, vsevik wrote:
Now that I looked closer at this API, I see (if I'm not mistaken) two
ways
to
get the script name of where the exception was thrown:
- Through the script in the Message object, like exposed in this CL.
- Through
Reviewers: danno, Paul Lind, palfia, kisg, dusmil,
Description:
MIPS: Generate KeyedLoadGeneric with Hydrogen.
Port r21774 (f0462b8)
BUG=
Please review this at https://codereview.chromium.org/328173002/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+10, -0 lines):
M
lgtm
https://codereview.chromium.org/328173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/323413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/314953006/diff/180001/src/lookup.h
File src/lookup.h (right):
https://codereview.chromium.org/314953006/diff/180001/src/lookup.h#newcode96
src/lookup.h:96: HandleJSReceiver GetOrigin() const;
On 2014/06/11 15:37:00, rossberg wrote:
Hm, origin is a bit confusing
Revision: 21775
Author: plin...@gmail.com
Date: Wed Jun 11 16:28:30 2014 UTC
Log: MIPS: Generate KeyedLoadGeneric with Hydrogen.
Port r21774 (f0462b8)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/328173002
Patch from Balazs Kilvady kilva...@homejinni.com.
1 - 100 of 154 matches
Mail list logo
