lgtm
https://codereview.chromium.org/368783006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/07/02 23:04:32, adamk wrote:
I'll have to defer to yangguo for the debugger stuff. Just want to note
that
the
approach taken here only logs a debug event for the
ObserveMicrotaskRunner,
which itself will run a variety of callbacks. It's not clear to me whether
that's the right
Committed patchset #3 manually as r22179 (presubmit successful).
https://codereview.chromium.org/334763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Updates:
Owner: da...@chromium.org
Comment #1 on issue 1298 by yang...@chromium.org: Do we need source
positions in the optimized code
http://code.google.com/p/v8/issues/detail?id=1298
(No comment was entered for this change.)
--
You received this message because this project is
https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h#newcode201
src/code-stubs.h:201: virtual OStream PrintName(OStream os) const; //
NOLINT
On 2014/07/02 15:14:58, Michael
Updates:
Owner: yang...@chromium.org
Comment #2 on issue 1298 by yang...@chromium.org: Do we need source
positions in the optimized code
http://code.google.com/p/v8/issues/detail?id=1298
We might be able to do it without the deoptimizer now.
--
You received this message because this
Revision: 22180
Author: joc...@chromium.org
Date: Thu Jul 3 07:37:27 2014 UTC
Log: Split out libplatform into a separate libary
Also remove the use default platform compile flag. Instead, the embedder
has to provide the platform.
Change all binaries to use the default platfrom from
Committed patchset #1 manually as r22180 (presubmit successful).
https://codereview.chromium.org/345903004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Description:
Buildfix for windows after r22180
TBR=yang...@chromium.org
LOG=n
BUG=none
Please review this at https://codereview.chromium.org/367293002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -14 lines):
M
rossberg@, btw, one thing:
This CL makes V8 crash if the arrow function allowing flag is passed, since
the
actual implementation is missing (this will return NULL expressions, and if
the
upper layer tries to use them, it'll crash). Is this okay, or will we be
burned
by this because of
Committed patchset #1 manually as r22181 (tree was closed).
https://codereview.chromium.org/367293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/07/03 07:55:09, jochen wrote:
lgtm.
https://codereview.chromium.org/367293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 22181
Author: joc...@chromium.org
Date: Thu Jul 3 07:57:29 2014 UTC
Log: Buildfix for windows after r22180
TBR=yang...@chromium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/367293002
http://code.google.com/p/v8/source/detail?r=22181
Modified:
On 2014/07/02 15:41:36, jarin wrote:
Could you have another look at this, please?
lgtm.
https://codereview.chromium.org/367033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
LGTM. I hope this works :-)
https://codereview.chromium.org/368053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Toon Verwaest,
Message:
ptal
Description:
add GetOwnPropertyDescriptor to api
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/364923006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+53, -0 lines):
M
Reviewers: Yang,
Description:
Don't even include v8.h from libbase or libplatform
BUG=none
R=yang...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/369073002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -23 lines):
M
Reviewers: Yang,
Message:
Yang: PTAL.
Danno: FYI.
Description:
Hydrogenized KeyedLoadGeneric stub: Fix string hash retrieval
Please review this at https://codereview.chromium.org/363293002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M
On 2014/07/03 08:38:01, Jakob wrote:
Yang: PTAL.
Danno: FYI.
lgtm.
https://codereview.chromium.org/363293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Yang,
Message:
PTAL.
For reference, the C++ implementation is:
static T decode(U value) {
return static_castT((value kMask) shift);
}
Description:
Hydrogenized KeyedLoadGeneric stub: Fix BuildDecodeField
Please review this at https://codereview.chromium.org/369673007/
SVN
Reviewers: Michael Achenbach,
Description:
Version 3.28.10.1 (merged r22168, r22170)
MIPS: KeyedLoadIC should have same register spec as LoadIC.
MIPS: Clean up the global object naming madness.
R=machenb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/367313003/
On 2014/07/03 08:46:25, Jakob wrote:
PTAL.
For reference, the C++ implementation is:
static T decode(U value) {
return static_castT((value kMask) shift);
}
lgtm.
https://codereview.chromium.org/369673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
PTAL.
https://codereview.chromium.org/367313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/07/03 08:24:47, jochen wrote:
lgtm.
https://codereview.chromium.org/369073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 22182
Author: joc...@chromium.org
Date: Thu Jul 3 08:50:52 2014 UTC
Log: Don't even include v8.h from libbase or libplatform
BUG=none
R=yang...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/369073002
http://code.google.com/p/v8/source/detail?r=22182
Committed patchset #1 manually as r22182 (presubmit successful).
https://codereview.chromium.org/369073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22183
Author: ish...@chromium.org
Date: Thu Jul 3 08:52:28 2014 UTC
Log: Stack overflow checkers are now compatible with ASAN's
detect_stack_use_after_return mode.
BUG=chromium:376287
BUG=chromium:376262
BUG=chromium:369962
LOG=N
R=jkumme...@chromium.org
Review URL:
Reviewers: jarin,
Message:
PTAL.
Description:
Fix deopt reason printing to print stub failure reason with
--trace-stub-failures --code-comments
Please review this at https://codereview.chromium.org/369843002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6,
Committed patchset #1 manually as r22183 (presubmit successful).
https://codereview.chromium.org/368053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22184 (presubmit successful).
https://codereview.chromium.org/363293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22184
Author: jkumme...@chromium.org
Date: Thu Jul 3 08:55:42 2014 UTC
Log: Hydrogenized KeyedLoadGeneric stub: Fix string hash retrieval
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/363293002
http://code.google.com/p/v8/source/detail?r=22184
Committed patchset #1 manually as r22185 (presubmit successful).
https://codereview.chromium.org/369673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22185
Author: jkumme...@chromium.org
Date: Thu Jul 3 08:58:03 2014 UTC
Log: Hydrogenized KeyedLoadGeneric stub: Fix BuildDecodeField
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/369673007
http://code.google.com/p/v8/source/detail?r=22185
Modified:
On 2014/07/03 07:57:14, marja wrote:
This CL makes V8 crash if the arrow function allowing flag is passed,
since
the
actual implementation is missing (this will return NULL expressions, and
if
the
upper layer tries to use them, it'll crash). Is this okay, or will we be
burned
by this
Comment #3 on issue 3419 by math...@qiwi.be: Object.freeze should ignore
private properties
http://code.google.com/p/v8/issues/detail?id=3419
Patch: https://codereview.chromium.org/355123006
Commit: https://code.google.com/p/v8/source/detail?r=22132
--
You received this message because this
Reviewers: Jakob,
Message:
PTAL
Description:
Fix result status of rerun flaky tests.
Tests that pass on reruns where wrongly treated as failures. Now the result
state can include any of (PASS, FAIL, CRASH, TIMEOUT)
BUG=374134
LOG=n
Please review this at
I reviewed the remaining GetRelocatedValue and load_bool changes.
All changes lgtm.
https://codereview.chromium.org/356393003/diff/60001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
lgtm
https://codereview.chromium.org/364923006/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/364923006/diff/1/include/v8.h#newcode2119
include/v8.h:2119: * Returns Object.GetOwnPropertyDescriptor as per ES5
section 15.2.3.3.
Object.getOwnPropertyDescriptor
Reviewers: marja,
Description:
Add an API to pump the message loop to libplatform
BUG=none
LOG=n
R=ma...@chromium.org
Please review this at https://codereview.chromium.org/363303002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+84, -6 lines):
M
lgtm
https://codereview.chromium.org/363883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/363303002/diff/1/include/libplatform/libplatform.h
File include/libplatform/libplatform.h (right):
https://codereview.chromium.org/363303002/diff/1/include/libplatform/libplatform.h#newcode29
include/libplatform/libplatform.h:29: * not block if not task
大多数外贸业务员有通过GOOGLE搜索客户信息
但能坚持下来并且开发到客户的很少。
原因 1 、效率太低，严重影响业务员积极性。
2、 无法精准搜索到目标客户信息，需要大量时间筛选。
双喜外贸客户搜索与开发系统。通过全球各大搜索引擎，快速搜索全球潜在客户信
息。
内置五重过滤功能，根据您到需要，呈现出精准的信息。
自动一对一发送邮件，每天联系上万目标客户。
软件功能演示：QQ 2538209225
邮件请回复到QQ邮箱。
顺祝
商祺
我已邀请您填写表单 未命名的表单。 要填写此表单，请访问：
LGTM, couple comments.
https://codereview.chromium.org/368783006/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/368783006/diff/1/src/objects.cc#newcode3094
src/objects.cc:3094: *done = result.IsReadOnly();
How about *done = false, because result.IsReadOnly()
Committed patchset #1 manually as r22186 (presubmit successful).
https://codereview.chromium.org/363883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22187 (presubmit successful).
https://codereview.chromium.org/363303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22186
Author: machenb...@chromium.org
Date: Thu Jul 3 09:33:22 2014 UTC
Log: Fix result status of rerun flaky tests.
Tests that pass on reruns where wrongly treated as failures. Now the result
state can include any of (PASS, FAIL, CRASH, TIMEOUT)
BUG=374134
LOG=n
Revision: 22187
Author: joc...@chromium.org
Date: Thu Jul 3 09:33:36 2014 UTC
Log: Add an API to pump the message loop to libplatform
BUG=none
LOG=n
R=ma...@chromium.org
Review URL: https://codereview.chromium.org/363303002
http://code.google.com/p/v8/source/detail?r=22187
Added:
Thanks Dan!
https://codereview.chromium.org/364923006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/367313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Status: Fixed
Comment #1 on issue 3015 by joc...@chromium.org: Introduce a v8::Platform
class
http://code.google.com/p/v8/issues/detail?id=3015
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
Revision: 22188
Author: pal...@homejinni.com
Date: Thu Jul 3 09:57:50 2014 UTC
Log: Version 3.28.10.1 (merged r22168, r22170)
MIPS: KeyedLoadIC should have same register spec as LoadIC.
MIPS: Clean up the global object naming madness.
R=machenb...@chromium.org
BUG=
Review URL:
Committed patchset #1 manually as r22188.
https://codereview.chromium.org/367313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 22189
Author: pal...@homejinni.com
Date: Thu Jul 3 09:58:12 2014 UTC
Log: Tagging version 3.28.10.1
http://code.google.com/p/v8/source/detail?r=22189
Added:
/tags/3.28.10.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Status: Assigned
Owner: a...@chromium.org
CC: yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3421 by mvstan...@chromium.org: Profiler issues on mac
http://code.google.com/p/v8/issues/detail?id=3421
A host of tests are failing on mac buildbots:
Revision: 22190
Author: dcar...@chromium.org
Date: Thu Jul 3 10:04:57 2014 UTC
Log: add GetOwnPropertyDescriptor to api
R=verwa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/364923006
http://code.google.com/p/v8/source/detail?r=22190
Modified:
Committed patchset #1 manually as r22190 (presubmit successful).
https://codereview.chromium.org/364923006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/363293004/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (left):
https://codereview.chromium.org/363293004/diff/1/src/arm64/assembler-arm64.cc#oldcode3115
src/arm64/assembler-arm64.cc:3115: // add rd, rd, scratch
Why not remove
https://codereview.chromium.org/363293004/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (left):
https://codereview.chromium.org/363293004/diff/1/src/arm64/assembler-arm64.cc#oldcode3115
src/arm64/assembler-arm64.cc:3115: // add rd, rd, scratch
On 2014/07/03 10:46:06,
Committed patchset #1 manually as r22191.
https://codereview.chromium.org/369503006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 22191
Author: mvstan...@chromium.org
Date: Thu Jul 3 11:11:39 2014 UTC
Log: Error in CallFunctionNoFeedback ia32 made less efficient code.
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/369503006
https://codereview.chromium.org/363833006/diff/20001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/363833006/diff/20001/src/harmony-array.js#newcode182
src/harmony-array.js:182: array = new $Array(len);
On 2014/07/02 19:29:09, arv wrote:
On 2014/07/02
Reviewers: danno, Sven Panne, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Start using OStreams.
Port r22179 (01402bc)
Original commit message:
Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
On 2014/07/03 11:04:32, vincent.belliard.arm wrote:
With veneers, we can now do direct conditional branches.
If applied with the Adr patch, the total improvement (including the Adr
improvement) is 19% for Sunspider/dna and 7.5% for Octane/regexp.
lgtm
This is the same as
Updates:
Status: WorkingAsIntended
Comment #3 on issue 1298 by yang...@chromium.org: Do we need source
positions in the optimized code
http://code.google.com/p/v8/issues/detail?id=1298
Nope. Debugger needs the deoptimizer through FrameInspector since we need
more than just the
lgtm
https://codereview.chromium.org/369843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Cc: joc...@chromium.org ish...@chromium.org
Comment #1 on issue 3421 by yang...@chromium.org: Profiler issues on mac
http://code.google.com/p/v8/issues/detail?id=3421
Igor suspects that it's caused by r22167.
--
You received this message because this project is configured to
Reviewers: Hannes Payer,
Description:
Turn old space cons strings into regular external strings (not short).
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/368223002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -18 lines):
LGTM
https://codereview.chromium.org/368223002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/368223002/diff/1/src/objects.cc#newcode1071
src/objects.cc:1071: // string occupies is too small for a regular
external string.
minus one blank before external
https://codereview.chromium.org/368223002/diff/1/test/mjsunit/regress/regress-sliced-external-cons-regexp.js
File test/mjsunit/regress/regress-sliced-external-cons-regexp.js
(right):
On 2014/07/03 11:40:09, Hannes Payer wrote:
https://codereview.chromium.org/368223002/diff/1/test/mjsunit/regress/regress-sliced-external-cons-regexp.js
File test/mjsunit/regress/regress-sliced-external-cons-regexp.js (right):
Committed patchset #1 manually as r22192 (presubmit successful).
https://codereview.chromium.org/368223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22192
Author: yang...@chromium.org
Date: Thu Jul 3 11:46:31 2014 UTC
Log: Turn old space cons strings into regular external strings (not
short).
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/368223002
http://code.google.com/p/v8/source/detail?r=22192
Committed patchset #2 manually as r22193 (presubmit successful).
https://codereview.chromium.org/369843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22193
Author: jkumme...@chromium.org
Date: Thu Jul 3 11:47:31 2014 UTC
Log: Fix deopt reason printing to print stub failure reason with
--trace-stub-failures --code-comments
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/369843002
Reviewers: ulan,
Description:
Remove unnecessary check in RegExpExecStub.
R=u...@chromium.org
BUG=v8:592
LOG=N
Please review this at https://codereview.chromium.org/363313002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+31, -29 lines):
M
Reviewers: Hannes Payer,
Description:
Fix changed expectation in Heap::AllowToBeMigrated.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/364173004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -3 lines):
M src/heap-inl.h
lgtm
https://codereview.chromium.org/364173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r22194 (tree was closed).
https://codereview.chromium.org/364173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22194
Author: yang...@chromium.org
Date: Thu Jul 3 12:01:34 2014 UTC
Log: Fix changed expectation in Heap::AllowToBeMigrated.
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/364173004
http://code.google.com/p/v8/source/detail?r=22194
Modified:
Reviewers: Yang,
Description:
Avoid brittle use of .bind in Promise.all
R=yang...@chromium.org
BUG=v8:3420
LOG=Y
Please review this at https://codereview.chromium.org/366103005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -5 lines):
M src/promise.js
On 2014/07/03 12:04:27, rossberg wrote:
lgtm.
https://codereview.chromium.org/366103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
LGTM
https://codereview.chromium.org/369873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Owner: joc...@chromium.org
Comment #2 on issue 3421 by mvstan...@chromium.org: Profiler issues on mac
http://code.google.com/p/v8/issues/detail?id=3421
Indeed. I managed to get an instructive call stack on the bot. It shows
that we are releasing the process-wide isolate
Reviewers: Hannes Payer,
Description:
Revert Turn old space cons strings into regular external strings (not
short).
This reverts commits r22192 and r22194.
TBR=hpa...@chromium.org
Please review this at https://codereview.chromium.org/367113003/
SVN Base:
Committed patchset #1 manually as r22195 (tree was closed).
https://codereview.chromium.org/367113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22195
Author: yang...@chromium.org
Date: Thu Jul 3 12:24:41 2014 UTC
Log: Revert Turn old space cons strings into regular external strings
(not short).
This reverts commits r22192 and r22194.
TBR=hpa...@chromium.org
Review URL: https://codereview.chromium.org/367113003
Revision: 22196
Author: kilva...@homejinni.com
Date: Thu Jul 3 12:27:23 2014 UTC
Log: MIPS: Start using OStreams.
Port r22179 (01402bc)
Original commit message:
Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few
Committed patchset #1 manually as r22196.
https://codereview.chromium.org/369873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: jochen,
Description:
Revert Reland^2 r22105 Remove static initializer from isolate
This reverts r22167.
BUG=v8:3421
LOG=N
R=joc...@chromium.org
Please review this at https://codereview.chromium.org/366123002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Revision: 22197
Author: yang...@chromium.org
Date: Thu Jul 3 12:33:16 2014 UTC
Log: Revert Reland^2 r22105 Remove static initializer from isolate
This reverts r22167.
BUG=v8:3421
LOG=N
TBR=joc...@chromium.org
Review URL: https://codereview.chromium.org/366123002
Committed patchset #1 manually as r22197 (tree was closed).
https://codereview.chromium.org/366123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Comment #2 on issue 3420 by math...@qiwi.be: Unchecked call to
Function.prototype.bind in PromiseAll
http://code.google.com/p/v8/issues/detail?id=3420
Patch: https://codereview.chromium.org/366103005/
--
You received this message because this project is configured to send all
issue
DBC: Should we also add a test to avoid regressions?
https://codereview.chromium.org/366103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
On 2014/07/03 13:05:53, mathiasb wrote:
DBC: Should we also add a test to avoid regressions?
That would make sense. Please do!
https://codereview.chromium.org/366103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Revision: 22198
Author: m.m.capew...@googlemail.com
Date: Thu Jul 3 13:08:15 2014 UTC
Log: ARM64: improve Adr patching
R=u...@chromium.org, bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/363293004
http://code.google.com/p/v8/source/detail?r=22198
Modified:
Revision: 22199
Author: m.m.capew...@googlemail.com
Date: Thu Jul 3 13:16:51 2014 UTC
Log: ARM64: use direct conditional branches for regexp
R=u...@chromium.org, bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/370553002
lgtm
https://codereview.chromium.org/363313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno,
Message:
PTAL.
Description:
HGraphBuilder::BuildJSObjectCheck: Tighten instance type comparison
Please review this at https://codereview.chromium.org/366083005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/hydrogen.cc
Reviewers: danno,
Message:
PTAL.
Description:
Hydrogen LoopBuilder: add support for while(true) {...} loops
Please review this at https://codereview.chromium.org/368243002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+55, -26 lines):
M src/hydrogen.h
M
Revision: 22201
Author: yang...@chromium.org
Date: Thu Jul 3 13:33:58 2014 UTC
Log: Tagging version 3.28.11
http://code.google.com/p/v8/source/detail?r=22201
Added:
/tags/3.28.11
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
1 - 100 of 147 matches
Mail list logo
