Comment #9 on issue 3348 by srl...@gmail.com: v8 Intl doesn't handle
failure conditions
http://code.google.com/p/v8/issues/detail?id=3348
renamed patch
Attachments:
patch-3348.patch 1.9 KB
--
You received this message because this project is configured to send all
issue notificat
Comment #8 on issue 3348 by srl...@gmail.com: v8 Intl doesn't handle
failure conditions
http://code.google.com/p/v8/issues/detail?id=3348
Here you go
Attachments:
patch-3344.patch 1.9 KB
--
You received this message because this project is configured to send all
issue notificatio
Comment #7 on issue 3345 by srl...@gmail.com: i18n: Make break iterator use
optional
http://code.google.com/p/v8/issues/detail?id=3345
To test this patch:
* add "#define UCONFIG_NO_BREAK_ITERATION 1" to the top
of ./third_party/icu/source/common/unicode/uconfig.h
* build v8
* run "d8 bt
Revision: 22578
Author: machenb...@chromium.org
Date: Thu Jul 24 00:05:54 2014 UTC
Log: Tagging version 3.28.35
http://code.google.com/p/v8/source/detail?r=22578
Added:
/tags/3.28.35
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Switching to use a LookupIterator cleaned this up a bit.
https://codereview.chromium.org/384963002/diff/190001/src/unscopables.h
File src/unscopables.h (right):
https://codereview.chromium.org/384963002/diff/190001/src/unscopables.h#newcode24
src/unscopables.h:24: if (it->state() == LookupItera
Comment #9 on issue 3463 by verwa...@chromium.org: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
No, just interesting to see.
The reason why you are getting the ASSERT is because we let interceptors
through on the prototype only if it's on the glo
Comment #8 on issue 3463 by fedor.in...@gmail.com: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
They are just no-ops right now, as far as I can see. Not sure why they were
introduced in first place... Are they causing the problem right now?
--
Y
lgtm
https://codereview.chromium.org/417793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #7 on issue 3463 by verwa...@chromium.org: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
You guys also use access checks? Do you have a document on how they are
used? We are thinking of alternatives for use in chrome. We kinda expected
th
Comment #6 on issue 3463 by verwa...@chromium.org: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
Yes that's exactly what I meant. The load receiver is the global proxy, but
the interceptor holder behind it is a global object.
In blink there's an
object-observe test looks good to me, I'll leave accessors.cc for verwaest
https://codereview.chromium.org/417793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
PTAL
https://codereview.chromium.org/384963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Comment #5 on issue 3463 by fedor.in...@gmail.com: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
Ah, actually it is not a JSGlobalProxy, sorry! It is just a Global object
with interceptors:
https://github.com/joyent/node/blob/61ddad1314824ac32bb2
Adding Adam to look at the O.o related changes.
https://codereview.chromium.org/417793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Comment #4 on issue 3463 by fedor.in...@gmail.com: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
Hah, it kind of does. This is not the part of code that I wrote, so I have
incomplete understanding of the reasoning behind this choices. But I will
Comment #3 on issue 3463 by verwa...@chromium.org: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
OK, that assert is benign. I'll extend it with an assert for that
particular case tomorrow. Interesting that you have named interceptor
setters on th
Comment #2 on issue 3463 by fedor.in...@gmail.com: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
The receiver is most likely a JSGlobalProxy, AFAIK.
--
You received this message because this project is configured to send all
issue notifications to
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Fix issue with setters and their holders in accessors.cc
BUG=3462
LOG=Y
Please review this at https://codereview.chromium.org/417793002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+86, -21 lines):
M src
Updates:
Status: Accepted
Owner: verwa...@chromium.org
Comment #1 on issue 3463 by verwa...@chromium.org: Crash with named
interceptor (3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
Is the receiver perhaps the JSGlobalProxy, and do you guys install an
intercepto
Committed patchset #1 manually as r22576 (presubmit successful).
https://codereview.chromium.org/411983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 22576
Author: verwa...@chromium.org
Date: Wed Jul 23 20:27:32 2014 UTC
Log: Fix ArrayLengthSetter to not throw on non-extensible receivers.
BUG=v8:3460
LOG=n
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/411983003
http://code.google.com/p/v8/source/detail
lgtm
https://codereview.chromium.org/411983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
What if the instance has a non writable length property?
https://codereview.chromium.org/411983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Fix ArrayLengthSetter to not throw on non-extensible receivers.
BUG=v8:3460
Please review this at https://codereview.chromium.org/411983003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -5 lines):
M
Revision: 22575
Author: verwa...@chromium.org
Date: Wed Jul 23 20:11:33 2014 UTC
Log: The accessors should get the value from the holder and not from
this.
These are all data properties and if they get invoked it means that
they should just return the value of the property from the
Landed that other CL for you, so it's unblocked ;)
On Wed, Jul 23, 2014 at 8:13 PM, wrote:
> This is now blocked by https://codereview.chromium.org/410923003
>
> https://codereview.chromium.org/384963002/
>
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
Committed patchset #3 manually as r22575 (presubmit successful).
https://codereview.chromium.org/410923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Igor Sheludko, mvstanton,
Message:
PTAL
Description:
Restructure the IC / Handler compilers
BUG=
Please review this at https://codereview.chromium.org/411973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+886, -1533 lines):
M src/arm/code-stu
Status: New
Owner:
New issue 3463 by fedor.in...@gmail.com: Crash with named interceptor
(3.26.33)
http://code.google.com/p/v8/issues/detail?id=3463
When running following chunk of code on the latest node.js master
(v0.11.14-pre):
vm = require('vm');
ctx = vm.createContext({console:
Reviewers: ,
Message:
Committed patchset #1 manually as r22574 (tree was closed).
Description:
Whitespace change to trigger bots.
TBR=machenb...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22574
Please review this at https://codereview.chromium.org/417593004/
SVN Bas
Revision: 22574
Author: machenb...@chromium.org
Date: Wed Jul 23 18:58:43 2014 UTC
Log: Whitespace change to trigger bots.
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/417593004
http://code.google.com/p/v8/source/detail?r=22574
Modified:
/branches/bleeding
Status: Accepted
Owner: a...@chromium.org
CC: verwa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3462 by a...@chromium.org: FunctionPrototypeSetter is not correct
http://code.google.com/p/v8/issues/detail?id=3462
var o = {__proto__: function() {}};
o.prototype = 42;
assert(o.hasOwn
This is now blocked by https://codereview.chromium.org/410923003
https://codereview.chromium.org/384963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
DBC: Please update BUILD.gn too.
https://codereview.chromium.org/416543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
DBC: when reverting commits, please mention the SVN revision being reverted
rather than the git hash. Due to the way git-svn works, the git hash is
unique
to your checkout.
https://codereview.chromium.org/410083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
Revision: 22573
Author: n...@chromium.org
Date: Wed Jul 23 17:17:48 2014 UTC
Log: Minor clarifications and simplifications as well as additional
checks.
R=rossb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/417553003
http://code.google.com/p/v8/source/detail?r=22
Committed patchset #1 manually as r22573 (presubmit successful).
https://codereview.chromium.org/417553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/417553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Description:
Minor clarifications and simplifications as well as additional checks.
R=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/417553003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -28 lines)
Updated.
Would you mind landing this for me when you get the chance?
Thanks.
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc#newcode250
src/accessors.cc:250: ASSERT(value
LGTM if you fix the test failure (test/mjsunit/regress/regress-1062422.js)
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc#newcode250
src/accessors.cc:250: ASSERT(value->Is
PTAL
This now passes all the unscopables test I have in 384963002 as well as all
the
tests in debug mode (I'll run the webkit tests too now)
Please pay extra attention to StringLengthGetter. Everything else was
straight
forward.
https://codereview.chromium.org/410923003/
--
--
v8-dev mai
Reviewers: Toon Verwaest,
Message:
Hello. Toon & Danno.
Please help to review and commit this porting patch.
thanks.
Description:
X87: Always use the LoadStubCompiler for Load handlers, also for keyedload
handlers
port r22551.
original commit message:
Always use the LoadStubCompiler for Loa
Reviewers: Toon Verwaest,
Message:
Hello. Toon & Danno.
Please help to review and commit this porting patch.
The owner of X87 port asked for annual leave and I have to ask for help from
you.
thanks.
Description:
X87: Only to the relevant checks in LoadFunctionPrototype
port r22550.
original co
Reviewers: Toon Verwaest,
Message:
Hello. Toon & Danno.
Please help to review and commit this porting patch.
The owner of X87 port asked for annual leave and I have to ask for help form
you.
thanks.
Description:
X87: Move function prototype handling into a special handler rather than IC
port r2
Revision: 22572
Author: machenb...@chromium.org
Date: Wed Jul 23 16:12:02 2014 UTC
Log: Revert "Track history of events in GCTracer."
This reverts commit 22567 for breaking win64 compile.
BUG=
TBR=ern...@chromium.org
Review URL: https://codereview.chromium.org/414743002
http://code.g
Reviewers: ernstm,
Message:
Committed patchset #1 manually as r22572 (presubmit successful).
Description:
Revert "Track history of events in GCTracer."
This reverts commit 22567 for breaking win64 compile.
BUG=
TBR=ern...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22
Revision: 22571
Author: machenb...@chromium.org
Date: Wed Jul 23 15:56:57 2014 UTC
Log: [Auto-roll] Bump up version to 3.28.34.0
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/411003002
http://code.google.com/p/v8/source/detail?r=22571
Modified:
/branches/bl
Committed patchset #1 manually as r22571.
https://codereview.chromium.org/411003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Reviewers: Michael Achenbach,
Description:
[Auto-roll] Bump up version to 3.28.34.0
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/411003002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/version.cc
I
Revision: 22570
Author: balazs.kilv...@imgtec.com
Date: Wed Jul 23 15:53:00 2014 UTC
Log: MIPS: Always use the LoadStubCompiler for Load handlers, also for
keyedload handlers.
Port r22551 (0cc23b1)
BUG=
R=paul.l...@imgtec.com
Review URL: https://codereview.chromium.org/415623002
h
Committed patchset #1 manually as r22570 (tree was closed).
https://codereview.chromium.org/415623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Move GCTracer to separate files.
- No functional changes.
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/416543003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+548, -521
No sure, go ahead.
On Wed, Jul 23, 2014 at 5:34 PM, Erik Arvidsson wrote:
> Do you mind if I bundle these up into one CL? (I'll update the description)
>
>
> On Wed, Jul 23, 2014 at 11:10 AM, wrote:
>
>> lgtm
>>
>>
>>
>> https://codereview.chromium.org/410923003/
>>
>>
>> --
>> --
>> v8-dev ma
Revision: 22569
Author: n...@chromium.org
Date: Wed Jul 23 15:39:08 2014 UTC
Log: Revert "Minor clarifications and simplifications as well as
additional checks."
This reverts commit d32eacbdea3fc0c119da06abe95b07a83c67aa48.
TBR=rossb...@chromium.org
BUG=
Review URL: https://codere
Committed patchset #1 manually as r22569 (presubmit successful).
https://codereview.chromium.org/410083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: rossberg,
Description:
Revert "Minor clarifications and simplifications as well as additional
checks."
This reverts commit d32eacbdea3fc0c119da06abe95b07a83c67aa48.
TBR=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/410083005/
SVN Base: https://
Do you mind if I bundle these up into one CL? (I'll update the description)
On Wed, Jul 23, 2014 at 11:10 AM, wrote:
> lgtm
>
>
>
> https://codereview.chromium.org/410923003/
>
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---You received
Revision: 22568
Author: n...@chromium.org
Date: Wed Jul 23 15:30:34 2014 UTC
Log: Minor clarifications and simplifications as well as additional
checks.
R=rossb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/409743004
http://code.google.com/p/v8/source/detail?r=22
lgtm
https://codereview.chromium.org/415623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 22567
Author: ern...@chromium.org
Date: Wed Jul 23 15:16:53 2014 UTC
Log: Track history of events in GCTracer.
- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- va
Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Always use the LoadStubCompiler for Load handlers, also for keyedload
handlers.
Port r22551 (0cc23b1)
BUG=
Please review this at https://codereview.chromium.org/415623002/
SV
Committed patchset #6 manually as r22567 (presubmit successful).
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Comment #2 on issue 3461 by a...@chromium.org: ArrayLengthGetter uses the
wrong object
http://code.google.com/p/v8/issues/detail?id=3461
And FunctionNameGetter... Probably anything that use This()/GetThisFrom in
accessors.cc.
--
You received this message because this project is configured
Comment #1 on issue 3461 by a...@chromium.org: ArrayLengthGetter uses the
wrong object
http://code.google.com/p/v8/issues/detail?id=3461
FunctionLengthGetter has the same problem
--
You received this message because this project is configured to send all
issue notifications to this address
Committed patchset #1 manually as r22566 (presubmit successful).
https://codereview.chromium.org/416513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 22566
Author: balazs.kilv...@imgtec.com
Date: Wed Jul 23 15:12:40 2014 UTC
Log: MIPS: Only to the relevant checks in LoadFunctionPrototype.
Port r22550 (c5209a6)
BUG=
R=paul.l...@imgtec.com
Review URL: https://codereview.chromium.org/416513002
http://code.google.com/p/v8/so
Care about fixing all the other getters as well? Shouldn't be too much
work...
On Wed, Jul 23, 2014 at 5:10 PM, Toon Verwaest
wrote:
> Ok, great. Thanks for the report ;)
>
>
> On Wed, Jul 23, 2014 at 4:53 PM, 'Erik Arvidsson' via v8-dev <
> v8-dev@googlegroups.com> wrote:
>
>> > I can't do it
lgtm
https://codereview.chromium.org/410923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: Accepted
Owner: a...@chromium.org
CC: verwa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3461 by a...@chromium.org: ArrayLengthGetter uses the wrong object
http://code.google.com/p/v8/issues/detail?id=3461
We should get the value off of the holder and not from the receiver.
Ok, great. Thanks for the report ;)
On Wed, Jul 23, 2014 at 4:53 PM, 'Erik Arvidsson' via v8-dev <
v8-dev@googlegroups.com> wrote:
> > I can't do it yet, since I'm waiting for dom accessors to be turned
> into real JS accessors
>
> Get in line ;-)
>
> I made the change to ArrayLengthGetter and a
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc#newcode6082
src/heap.cc:6082: Max(current_.start_time - previous_.end_time, 0.0);
On 2014/07/23 14:35:15, Hannes Payer wrote:
Can this line
https://codereview.chromium.org/409743004/diff/1/src/types.h
File src/types.h (right):
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode71
src/types.h:71: // UntaggedInt = UntaggedInt8 \/ UntaggedInt16 \/
UntaggedInt32)
Should include Int1 now. Also, spurious paren.
https:/
Reviewers: Toon Verwaest,
Description:
Fix ArrayLengthGetter
Get the length from the holder instead of manually walking the prototype
chain.
BUG=None
LOG=N
Please review this at https://codereview.chromium.org/410923003/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Revision: 22565
Author: paul.l...@imgtec.com
Date: Wed Jul 23 14:54:12 2014 UTC
Log: Fix cross-compilation in Makefile.
Fix r22531, I dropped a necessary pair of parens.
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/410003003
http://code.google.com/p/v8/so
> I can't do it yet, since I'm waiting for dom accessors to be turned into
real JS accessors
Get in line ;-)
I made the change to ArrayLengthGetter and all tests still pass. However,
the ArrayLengthSetter has some issues and I ran into a new bug (3460).
On Wed, Jul 23, 2014 at 10:27 AM, Toon Ve
Committed patchset #1 manually as r22565 (presubmit successful).
https://codereview.chromium.org/410003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/416513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: Assigned
Owner: ma...@chromium.org
CC: rossb...@chromium.org, sigu...@chromium.org,
mstarzin...@chromium.org, yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3459 by rossb...@chromium.org: AstValueFactory bypasses regular
string internalization
http://code.google.
LGTM, just nits.
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc#newcode6082
src/heap.cc:6082: Max(current_.start_time - previous_.end_time, 0.0);
Can this line be negative? That's strang
Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Only to the relevant checks in LoadFunctionPrototype.
Port r22550 (c5209a6)
BUG=
Please review this at https://codereview.chromium.org/416513002/
SVN Base: https://v8.googlec
Yeah I think so.
I'm actually kinda surprised that the getters are implemented in this way
at this point. I'd update all those methods to use the Holder() they get
from the info. In GetPropertyWithAccessor you can see that the holder
passed to the PropertyCallbackArguments is the holder of the acc
Known problem, people are working on it.
On Jul 23, 2014 4:01 PM, "Andy Wingo" wrote:
> Hi,
>
> I am seeing some failures in the intl tests. I have done a fresh clone
> and make dependencies.
>
> One of the failing tests is intl/number-format/parse-percent.js. It
> starts off like this:
>
> v
I made once some tries to optimize the constants pool. I had this message
when, during serialization, I mixed relocations within the code and
relocations within the constants pool. To avoid the problem, during
serialization, all the relocations should be in the constant pool.
I hope that will he
On Wed, Jul 23, 2014 at 8:08 AM, wrote:
> My comment below is based on a short explanation of the problem by
> rossberg. Let
> me know if some things are still unclear.
>
> Overall: Please don't work around "bugs" (wasn't really a bug until
> unscopable
> since it wasn't observable in any way) in
Committed patchset #1 manually as r22564 (presubmit successful).
https://codereview.chromium.org/415603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 22564
Author: n...@chromium.org
Date: Wed Jul 23 14:11:30 2014 UTC
Log: Fix Handle-related bug in RangeType constructor.
R=rossb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/415603002
http://code.google.com/p/v8/source/detail?r=22564
Modified:
/branches
lgtm
https://codereview.chromium.org/415603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #1 on issue 3458 by rono.mu...@gmail.com: Object.freeze fails to
work in certain cases in version 3.26 and 3.27
http://code.google.com/p/v8/issues/detail?id=3458
The faulty frozen object allows to 'delete container.field;' (it deletes
the field) and then 'Object.isFrozen(test())' re
Reviewers: rossberg,
Description:
Fix Handle-related bug in RangeType constructor.
R=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/415603002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -2 lines):
M src/types.h
Inde
Status: New
Owner:
New issue 3458 by rono.mu...@gmail.com: Object.freeze fails to work in
certain cases in version 3.26 and 3.27
http://code.google.com/p/v8/issues/detail?id=3458
Recently, since the release of Chrome 36, we started having an issue with
frozen objects not always being f
Hi,
I am seeing some failures in the intl tests. I have done a fresh clone
and make dependencies.
One of the failing tests is intl/number-format/parse-percent.js. It
starts off like this:
var nf = new Intl.NumberFormat(['en'], {style: 'percent'});
assertEquals(1.2343, nf.v8Parse('123.43%'
Comment #1 on issue 3457 by rodolph@gmail.com: Serializing code object
in ARM64 hits assertion.
http://code.google.com/p/v8/issues/detail?id=3457
It doesn't sounds familiar to me.
--
You received this message because this project is configured to send all
issue notifications to this ad
On 2014/07/23 13:36:50, aperez wrote:
Agreed, while making the fix I was thinking that it would be nice to use
the
BitField template from "src/utils.h"... anyway, the idea was to have this
fix
applied ASAP, so let's leave cleanups for another day.
Yes, using BitField would be much better, a
Revision: 22563
Author: yang...@chromium.org
Date: Wed Jul 23 13:40:01 2014 UTC
Log: Mark mjsunit/deserialize-reference as PASS, FAIL on arm64.
R=svenpa...@chromium.org
BUG=v8:3457
LOG=N
Review URL: https://codereview.chromium.org/415583002
http://code.google.com/p/v8/source/detail?r=
Committed patchset #1 manually as r22563 (presubmit successful).
https://codereview.chromium.org/415583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/415583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: wingo, rossberg, Sven Panne, mstarzinger, Dmitry Lomov
(chromium),
Message:
On 2014/07/23 13:26:06, Sven Panne wrote:
LGTM, http://wowhead.com has been resurrected by this patch, I'll land it
for
you.
https://codereview.chromium.org/410873004/diff/1/src/preparser.h
File src/prep
Reviewers: Sven Panne,
Description:
Mark mjsunit/deserialize-reference as PASS, FAIL on arm64.
R=svenpa...@chromium.org
BUG=v8:3457
LOG=N
Please review this at https://codereview.chromium.org/415583002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -0 line
Comment #13 on issue 3456 by svenpa...@chromium.org: Prefix operation
parsing broken
http://code.google.com/p/v8/issues/detail?id=3456
Issue chromium:396432 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to t
1 - 100 of 207 matches
Mail list logo
