https://codereview.chromium.org/391413006/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc#newcode6082
src/heap.cc:6082: Max(current_.start_time - previous_.end_time, 0.0);
On 2014/07/23 14:35:15, Hannes Payer wrote:
Can this line be negative? That's strange, it should always be a
positive value.
This was migrated from the old implementation of GCTracer. Not all
clocks are monotonic. Maybe this showed up as an issue when two events
were back to back? I'll leave it for now. We can still remove it in a
subsequent CL.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode550
src/heap.h:550: // TODO(ernstm): Move into GCTracer
On 2014/07/23 14:35:15, Hannes Payer wrote:
"."
Done.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode634
src/heap.h:634: // TODO(ernstm): unit tests. move to separate file.
On 2014/07/23 14:35:15, Hannes Payer wrote:
Unit tests. Move to separate file.
Done.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode748
src/heap.h:748: typedef RingBuffer<Event, 10> EventBuffer;
On 2014/07/23 14:35:15, Hannes Payer wrote:
Can we make 10 a proper constant.
Done.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode765
src/heap.h:765: // TODO(ernstm): move to Heap.
On 2014/07/23 14:35:15, Hannes Payer wrote:
"Move"
Done.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode769
src/heap.h:769: // TODO(ernstm): move to Heap.
On 2014/07/23 14:35:15, Hannes Payer wrote:
"Move"
Done.
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
