[v8-dev] Issue 3519 in v8: W200000: Error handling externals definition for 'testing/gmock/gtest':

2014-08-18 Thread codesite-noreply via v8-dev
Status: New Owner: New issue 3519 by davwe...@gmail.com: W20: Error handling externals definition for 'testing/gmock/gtest': http://code.google.com/p/v8/issues/detail?id=3519 Detailed description of the issue. Attempting to install V8 via SVN on Linux Mint 17 (x64) My install

[v8-dev] Re: Issue 3519 in v8: W200000: Error handling externals definition for 'testing/gmock/gtest':

2014-08-18 Thread codesite-noreply via v8-dev
Comment #1 on issue 3519 by davwe...@gmail.com: W20: Error handling externals definition for 'testing/gmock/gtest': http://code.google.com/p/v8/issues/detail?id=3519 SVN checkout: svn checkout https://v8.googlecode.com/svn/trunk/ v8 -- You received this message because this project is

[v8-dev] Refactor ChangeLowering class to avoid template specialization. (issue 480863002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: jarin, Message: PTAL Description: Refactor ChangeLowering class to avoid template specialization. Also refactor the unit tests and add support to easily match DAGs using CaptureEq() matcher. TEST=compiler-unittests BUG=v8:3489 LOG=n Please review this at

[v8-dev] Re: Issue 3519 in v8: W200000: Error handling externals definition for 'testing/gmock/gtest':

2014-08-18 Thread codesite-noreply via v8-dev
Comment #2 on issue 3519 by bmeu...@chromium.org: W20: Error handling externals definition for 'testing/gmock/gtest': http://code.google.com/p/v8/issues/detail?id=3519 Looks like a firewall problem to me. In either case this issue has to be fixed in gmock. Please file a bug report for

[v8-dev] Re: ARM64: Refactor instruction selection unit tests. (issue 475823002 by rodolph.perfe...@arm.com)

2014-08-18 Thread bmeurer
Ok, I've looked into this again, and I think you are right. We can avoid the possible name collision using an anonymous namespace, i.e. namespace { class MyTest : public InstructionSelectorTestWithParamParamType {}; TEST_P(MyTest, A) {...} TEST_P(MyTest, B) {...} }

[v8-dev] [arm] Shorter test names for parameterized tests. (issue 483643002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: jarin, Description: [arm] Shorter test names for parameterized tests. See https://codereview.chromium.org/475823002 for the discussion. TEST=compiler-unittests R=ja...@chromium.org BUG=v8:3489 LOG=n Please review this at https://codereview.chromium.org/483643002/ SVN Base:

[v8-dev] Re: Refactor ChangeLowering class to avoid template specialization. (issue 480863002 by bmeu...@chromium.org)

2014-08-18 Thread jarin
lgtm https://codereview.chromium.org/480863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r23140 committed - Refactor ChangeLowering class to avoid template specialization....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23140 Author: bmeu...@chromium.org Date: Mon Aug 18 06:54:07 2014 UTC Log: Refactor ChangeLowering class to avoid template specialization. Also refactor the unit tests and add support to easily match DAGs using CaptureEq() matcher. TEST=compiler-unittests BUG=v8:3489 LOG=n

[v8-dev] Re: Refactor ChangeLowering class to avoid template specialization. (issue 480863002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Committed patchset #2 manually as 23140 (tree was closed). https://codereview.chromium.org/480863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Issue 3489 in v8: Support use of Google/Chrome testing infrastructure in V8

2014-08-18 Thread codesite-noreply via v8-dev
Comment #5 on issue 3489 by bugdro...@chromium.org: Support use of Google/Chrome testing infrastructure in V8 http://code.google.com/p/v8/issues/detail?id=3489#c5 The following revision refers to this bug:

[v8-dev] Re: Parse 'super' keyword. (issue 480543002 by dslo...@chromium.org)

2014-08-18 Thread marja
parser parts lgtm https://codereview.chromium.org/480543002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] [arm] Recognize comparisons of shifts with zero. (issue 478233002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: jarin, Description: [arm] Recognize comparisons of shifts with zero. For example, recognize 0 == r1 r2 and generate a single MOVS rt, r1, lsl r2 instruction. TEST=cctest,compiler-unittests R=ja...@chromium.org Please review this at

[v8-dev] Re: [arm] Recognize comparisons of shifts with zero. (issue 478233002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
PTAL https://codereview.chromium.org/478233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: [arm] Shorter test names for parameterized tests. (issue 483643002 by bmeu...@chromium.org)

2014-08-18 Thread jarin
lgtm https://codereview.chromium.org/483643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 3514 in v8: Message::GetLineNumber() returns 0 when it's called at the first time

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Owner: yang...@chromium.org Comment #2 on issue 3514 by yang...@chromium.org: Message::GetLineNumber() returns 0 when it's called at the first time http://code.google.com/p/v8/issues/detail?id=3514 (No comment was entered for this change.) -- You

[v8-dev] Re: Issue 3513 in v8: Test runner does not work with new Test262 format

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Owner: machenb...@chromium.org Comment #6 on issue 3513 by yang...@chromium.org: Test runner does not work with new Test262 format http://code.google.com/p/v8/issues/detail?id=3513 Michael, is there anything actionable left? -- You received this message because this project

[v8-dev] Re: Issue 3504 in v8: V8 not building

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Status: PendingFurtherInfo Comment #2 on issue 3504 by yang...@chromium.org: V8 not building http://code.google.com/p/v8/issues/detail?id=3504 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue

[v8-dev] Re: Issue 3501 in v8: CHECK(!already_resolved()) failed when parsing let/const arrow function expression

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Owner: ma...@chromium.org Comment #1 on issue 3501 by yang...@chromium.org: CHECK(!already_resolved()) failed when parsing let/const arrow function expression http://code.google.com/p/v8/issues/detail?id=3501 (No comment was entered for this

[v8-dev] Re: Issue 3501 in v8: CHECK(!already_resolved()) failed when parsing let/const arrow function expression

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Cc: wi...@igalia.com ape...@igalia.com Comment #2 on issue 3501 by ma...@chromium.org: CHECK(!already_resolved()) failed when parsing let/const arrow function expression http://code.google.com/p/v8/issues/detail?id=3501 (No comment was entered for this change.) -- You

[v8-dev] Re: Issue 3505 in v8: Are limits on FixedArray etc really needed?

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Owner: hpa...@chromium.org Comment #1 on issue 3505 by yang...@chromium.org: Are limits on FixedArray etc really needed? http://code.google.com/p/v8/issues/detail?id=3505 That is true. {String,FixedArray,FixedDoubleArray,ByteArray}::kMaxLength are

[v8-dev] [v8] r23141 committed - Purge unused internalized string accessors....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23141 Author: yang...@chromium.org Date: Mon Aug 18 07:54:19 2014 UTC Log: Purge unused internalized string accessors. R=ma...@chromium.org Review URL: https://codereview.chromium.org/471923002 http://code.google.com/p/v8/source/detail?r=23141 Modified:

[v8-dev] Re: Purge unused internalized string accessors. (issue 471923002 by yang...@chromium.org)

2014-08-18 Thread yangguo
Committed patchset #1 manually as 23141 (tree was closed). https://codereview.chromium.org/471923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: [arm] Shorter test names for parameterized tests. (issue 483643002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Committed patchset #1 manually as 23142 (tree was closed). https://codereview.chromium.org/483643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23142 committed - [arm] Shorter test names for parameterized tests....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23142 Author: bmeu...@chromium.org Date: Mon Aug 18 07:56:14 2014 UTC Log: [arm] Shorter test names for parameterized tests. See https://codereview.chromium.org/475823002 for the discussion. TEST=compiler-unittests R=ja...@chromium.org BUG=v8:3489 LOG=n Review URL:

[v8-dev] Re: Issue 3489 in v8: Support use of Google/Chrome testing infrastructure in V8

2014-08-18 Thread codesite-noreply via v8-dev
Comment #6 on issue 3489 by bugdro...@chromium.org: Support use of Google/Chrome testing infrastructure in V8 http://code.google.com/p/v8/issues/detail?id=3489#c6 The following revision refers to this bug:

[v8-dev] Re: Removed DCHECK to allow external code to check if v8 platform is initialized. (issue 476913002 by vitalyb...@chromium.org)

2014-08-18 Thread yangguo
https://codereview.chromium.org/476913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: Removed DCHECK to allow external code to check if v8 platform is initialized. (issue 476913002 by vitalyb...@chromium.org)

2014-08-18 Thread bmeurer
lgtm https://codereview.chromium.org/476913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [arm] Recognize comparisons of shifts with zero. (issue 478233002 by bmeu...@chromium.org)

2014-08-18 Thread jarin
lgtm https://codereview.chromium.org/478233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Removed DCHECK to allow external code to check if v8 platform is initialized. (issue 476913002 by vitalyb...@chromium.org)

2014-08-18 Thread vitalybuka
On 2014/08/18 08:06:02, Benedikt Meurer wrote: lgtm I am not going to implement workaround as suggested in attached bug. Still I think this DCHECK is unnecessary. Should I submit or delete this patch? https://codereview.chromium.org/476913002/ -- -- v8-dev mailing list

[v8-dev] Remove dead data structure in Scheduler. (issue 478253002 by tit...@chromium.org)

2014-08-18 Thread titzer
Reviewers: jarin, Description: Remove dead data structure in Scheduler. R=ja...@chromium.org BUG= Please review this at https://codereview.chromium.org/478253002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+0, -2 lines): M src/compiler/scheduler.h M

[v8-dev] Re: Removed DCHECK to allow external code to check if v8 platform is initialized. (issue 476913002 by vitalyb...@chromium.org)

2014-08-18 Thread yangguo
On 2014/08/18 08:37:55, Vitaly Buka wrote: On 2014/08/18 08:06:02, Benedikt Meurer wrote: lgtm I am not going to implement workaround as suggested in attached bug. Still I think this DCHECK is unnecessary. Should I submit or delete this patch? Let's not land this. DCHECKs are debug mode

[v8-dev] Re: Fix PromiseHasRejectHandler. (issue 473803003 by yang...@chromium.org)

2014-08-18 Thread yangguo
On 2014/08/17 17:47:29, aandrey wrote: lgtm https://codereview.chromium.org/473803003/diff/20001/test/mjsunit/es6/debug-promises/throw-eventually-caught.js File test/mjsunit/es6/debug-promises/throw-eventually-caught.js (right):

[v8-dev] Re: Fix PromiseHasRejectHandler. (issue 473803003 by yang...@chromium.org)

2014-08-18 Thread yangguo
Committed patchset #3 manually as 23143 (tree was closed). https://codereview.chromium.org/473803003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23143 committed - Fix PromiseHasRejectHandler....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23143 Author: yang...@chromium.org Date: Mon Aug 18 08:43:11 2014 UTC Log: Fix PromiseHasRejectHandler. The odd-numbered items in the queue are deferred objects, not promises. R=aand...@chromium.org Review URL: https://codereview.chromium.org/473803003

[v8-dev] Re: Issue 3491 in v8: Debugger cannot evaluate stack-allocated local variables from outer scopes.

2014-08-18 Thread codesite-noreply via v8-dev
Comment #6 on issue 3491 by yang...@chromium.org: Debugger cannot evaluate stack-allocated local variables from outer scopes. http://code.google.com/p/v8/issues/detail?id=3491 The only solution I could think of is that whenever devtools is on, we would deopt all code and recompile with

[v8-dev] Re: Remove dead data structure in Scheduler. (issue 478253002 by tit...@chromium.org)

2014-08-18 Thread jarin
lgtm https://codereview.chromium.org/478253002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Correctly handle holes when concat()ing double arrays (issue 468863003 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Committed patchset #1 manually as 23144 (tree was closed). https://codereview.chromium.org/468863003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23144 committed - Correctly handle holes when concat()ing double arrays...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23144 Author: jkumme...@chromium.org Date: Mon Aug 18 08:51:35 2014 UTC Log: Correctly handle holes when concat()ing double arrays BUG=chromium:403409 LOG=y R=verwa...@chromium.org Review URL: https://codereview.chromium.org/468863003

[v8-dev] Re: Remove dead data structure in Scheduler. (issue 478253002 by tit...@chromium.org)

2014-08-18 Thread titzer
Committed patchset #1 manually as 23145 (tree was closed). https://codereview.chromium.org/478253002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23145 committed - Remove dead data structure in Scheduler....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23145 Author: tit...@chromium.org Date: Mon Aug 18 08:59:55 2014 UTC Log: Remove dead data structure in Scheduler. R=ja...@chromium.org BUG= Review URL: https://codereview.chromium.org/478253002 http://code.google.com/p/v8/source/detail?r=23145 Modified:

[v8-dev] Re: Refactor ParseObjectLiteral (issue 458613004 by a...@chromium.org)

2014-08-18 Thread dslomov
lgtm https://codereview.chromium.org/458613004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Work-around weird GCC 4.6 linker issue with SmiTagging template. (issue 485653002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: rossberg, Message: Committed patchset #1 manually as 23146 (tree was closed). Description: Work-around weird GCC 4.6 linker issue with SmiTagging template. TBR=rossb...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23146 Please review this at

[v8-dev] [v8] r23146 committed - Work-around weird GCC 4.6 linker issue with SmiTagging template....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23146 Author: bmeu...@chromium.org Date: Mon Aug 18 09:12:12 2014 UTC Log: Work-around weird GCC 4.6 linker issue with SmiTagging template. TBR=rossb...@chromium.org Review URL: https://codereview.chromium.org/485653002 http://code.google.com/p/v8/source/detail?r=23146

[v8-dev] Re: `1..isPrototypeOf.call(null)` should return false, not throw TypeError. (issue 433413002 by l446240...@gmail.com)

2014-08-18 Thread yangguo
On 2014/08/14 04:21:07, ziyunfei wrote: On 2014/08/13 09:25:07, Yang wrote: On 2014/08/04 09:18:03, mathiasb wrote: Drive-by comment: no test? Yup. Test case would be great. You also haven't seem to have signed the individual contributors CLA:

[v8-dev] Re: Issue 3505 in v8: Are limits on FixedArray etc really needed?

2014-08-18 Thread codesite-noreply via v8-dev
Comment #2 on issue 3505 by jkumme...@chromium.org: Are limits on FixedArray etc really needed? http://code.google.com/p/v8/issues/detail?id=3505 Frankly, I'd rather not touch array limits. There are lots and lots of places in the code that have to perform size checks and potentially have

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread yangguo
On 2014/08/17 17:38:16, aandrey wrote: lgtm https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170 include/v8-debug.h:170: // Check if a debugger break is scheduled

[v8-dev] Re: Load global object and builtins from activation. (issue 474633003 by sigu...@chromium.org)

2014-08-18 Thread sigurds
https://codereview.chromium.org/474633003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: [Auto-roll] Bump up version to 3.29.4.0 (issue 482693002 by machenb...@chromium.org)

2014-08-18 Thread machenbach
Committed patchset #1 manually as 23147 (tree was closed). https://codereview.chromium.org/482693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23147 committed - [Auto-roll] Bump up version to 3.29.4.0...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23147 Author: machenb...@chromium.org Date: Mon Aug 18 09:34:17 2014 UTC Log: [Auto-roll] Bump up version to 3.29.4.0 TBR=machenb...@chromium.org Review URL: https://codereview.chromium.org/482693002 http://code.google.com/p/v8/source/detail?r=23147 Modified:

[v8-dev] [Auto-roll] Bump up version to 3.29.4.0 (issue 482693002 by machenb...@chromium.org)

2014-08-18 Thread machenbach
Reviewers: Michael Achenbach (OOO), Description: [Auto-roll] Bump up version to 3.29.4.0 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/482693002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M

[v8-dev] Re: Load global object and builtins from activation. (issue 474633003 by sigu...@chromium.org)

2014-08-18 Thread titzer
I like the direction of this. As with context specialization, this closure specialization should probably be configurable. Consider adding a flag to turn it on/off. https://codereview.chromium.org/474633003/diff/20001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc

[v8-dev] Re: Issue 3487 in v8: BinaryOpICStub(SHR:Smi*Smi-Number) produces a smi result (or deoptimizes).

2014-08-18 Thread codesite-noreply via v8-dev
Updates: Cc: u...@chromium.org bmeu...@chromium.org jkumme...@chromium.org Comment #1 on issue 3487 by jacob.bram...@arm.com: BinaryOpICStub(SHR:Smi*Smi-Number) produces a smi result (or deoptimizes). http://code.google.com/p/v8/issues/detail?id=3487 (No comment was entered for

[v8-dev] [turbofan] Add new ControlEffect and Finish operators. (issue 479163002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: jarin, Message: PTAL Description: [turbofan] Add new ControlEffect and Finish operators. Fix the ChangeLowering to properly use ControlEffect nodes to turn the control output of IfTrue nodes into an effect input for the Load nodes, and to properly use Finish nodes to ensure that

[v8-dev] [v8] r23148 committed - [arm] Recognize comparisons of shifts with zero....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23148 Author: bmeu...@chromium.org Date: Mon Aug 18 11:10:01 2014 UTC Log: [arm] Recognize comparisons of shifts with zero. For example, recognize 0 == r1 r2 and generate a single MOVS rt, r1, lsl r2 instruction. TEST=cctest,compiler-unittests R=ja...@chromium.org

[v8-dev] Re: [arm] Recognize comparisons of shifts with zero. (issue 478233002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Committed patchset #1 manually as 23148 (tree was closed). https://codereview.chromium.org/478233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Contribution of PowerPC port. (issue 422063005 by andrew_...@ca.ibm.com)

2014-08-18 Thread rmcilroy
On 2014/08/15 20:34:34, andrew_low wrote: Finally got caught up to bleeding edge again. Code is again ready for tire-kicking. The architecture-independed constant pool changes look good to me, thanks! https://codereview.chromium.org/422063005/ -- -- v8-dev mailing list

[v8-dev] Re: Issue 3505 in v8: Are limits on FixedArray etc really needed?

2014-08-18 Thread codesite-noreply via v8-dev
Comment #3 on issue 3505 by hpa...@chromium.org: Are limits on FixedArray etc really needed? http://code.google.com/p/v8/issues/detail?id=3505 I cannot think of a reason why we need the limits. However, it may be problematic to remove them as Jakob pointed out. One could give it a try.

[v8-dev] Re: Contribution of PowerPC port. (issue 422063005 by andrew_...@ca.ibm.com)

2014-08-18 Thread rmcilroy
The architecture-indepent constant pool changes look good to me (with a comment on object-printer.cc), thanks! https://codereview.chromium.org/422063005/diff/40001/src/objects-printer.cc File src/objects-printer.cc (right):

[v8-dev] Re: [turbofan] Add new ControlEffect and Finish operators. (issue 479163002 by bmeu...@chromium.org)

2014-08-18 Thread jarin
lgtm https://codereview.chromium.org/479163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Modify SizeOfFirstPage to take ool constant pool into account. (issue 479553002 by rmcil...@chromium.org)

2014-08-18 Thread hpayer
lgtm https://codereview.chromium.org/479553002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] Add new ControlEffect and Finish operators. (issue 479163002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Committed patchset #1 manually as 23149 (tree was closed). https://codereview.chromium.org/479163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23149 committed - [turbofan] Add new ControlEffect and Finish operators....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23149 Author: bmeu...@chromium.org Date: Mon Aug 18 11:36:06 2014 UTC Log: [turbofan] Add new ControlEffect and Finish operators. Fix the ChangeLowering to properly use ControlEffect nodes to turn the control output of IfTrue nodes into an effect input for the Load nodes,

[v8-dev] test/test262: update testcfg.py for new test262 (issue 478163002 by sam.mi...@gmail.com)

2014-08-18 Thread jkummerow
IIUC, not all tests in this test262 revision currently pass with V8. Tests that don't pass must be annotated accordingly in test/test262/test262.status, so that running the suite finishes without errors. https://codereview.chromium.org/478163002/diff/1/test/test262/harness-adapt.js File

[v8-dev] Version 3.28.71.3 (merged r23081) (issue 484643002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Reviewers: Yang, Description: Version 3.28.71.3 (merged r23081) Fix newly discovered presubmit errors. R=yang...@chromium.org BUG= Please review this at https://codereview.chromium.org/484643002/ SVN Base: https://v8.googlecode.com/svn/branches/3.28 Affected files (+127, -126 lines): M

[v8-dev] [v8] r23150 committed - Tagging version 3.29.3

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23150 Author: machenb...@chromium.org Date: Mon Aug 18 12:09:18 2014 UTC Log: Tagging version 3.29.3 http://code.google.com/p/v8/source/detail?r=23150 Added: /tags/3.29.3 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Version 3.28.71.3 (merged r23081) (issue 484643002 by jkumme...@chromium.org)

2014-08-18 Thread yangguo
lgtm https://codereview.chromium.org/484643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 3.28.71.3 (merged r23081) (issue 484643002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Committed patchset #1 manually as 23151 (tree was closed). https://codereview.chromium.org/484643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23151 committed - Version 3.28.71.3 (merged r23081)...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23151 Author: jkumme...@chromium.org Date: Mon Aug 18 12:10:20 2014 UTC Log: Version 3.28.71.3 (merged r23081) Fix newly discovered presubmit errors. R=yang...@chromium.org BUG= Review URL: https://codereview.chromium.org/484643002

[v8-dev] [v8] r23152 committed - Tagging version 3.28.71.3

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23152 Author: jkumme...@chromium.org Date: Mon Aug 18 12:10:58 2014 UTC Log: Tagging version 3.28.71.3 http://code.google.com/p/v8/source/detail?r=23152 Added: /tags/3.28.71.3 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Disable handle zapping on 3.28 branch (issue 480043002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Reviewers: Yang, Description: Disable handle zapping on 3.28 branch BUG=318206 LOG=y Please review this at https://codereview.chromium.org/480043002/ SVN Base: https://v8.googlecode.com/svn/branches/3.28 Affected files (+2, -2 lines): M build/features.gypi M src/version.cc Index:

[v8-dev] Re: Disable handle zapping on 3.28 branch (issue 480043002 by jkumme...@chromium.org)

2014-08-18 Thread yangguo
On 2014/08/18 12:14:11, Jakob wrote: lgtm. https://codereview.chromium.org/480043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r23153 committed - Disable handle zapping on 3.28 branch...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23153 Author: jkumme...@chromium.org Date: Mon Aug 18 12:16:05 2014 UTC Log: Disable handle zapping on 3.28 branch BUG=318206 LOG=y R=yang...@chromium.org Review URL: https://codereview.chromium.org/480043002 http://code.google.com/p/v8/source/detail?r=23153 Modified:

[v8-dev] Re: Disable handle zapping on 3.28 branch (issue 480043002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Committed patchset #1 manually as 23153 (tree was closed). https://codereview.chromium.org/480043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread sergeyv
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170 include/v8-debug.h:170: // Check if a debugger break is scheduled in the given isolate On 2014/08/17 21:38:16,

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread commit-bot
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread commit-bot
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/serg...@chromium.org/473913002/20001 https://codereview.chromium.org/473913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread yangguo
On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread sergeyv
On 2014/08/18 12:25:41, Yang wrote: On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star

[v8-dev] Fix invalid ASSERT on 3.27 branch (issue 483603005 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Reviewers: Toon Verwaest, Description: Fix invalid ASSERT on 3.27 branch Please review this at https://codereview.chromium.org/483603005/ SVN Base: https://v8.googlecode.com/svn/branches/3.27 Affected files (+3, -3 lines): M src/objects.cc M src/version.cc Index: src/objects.cc diff

[v8-dev] Re: Fix invalid ASSERT on 3.27 branch (issue 483603005 by jkumme...@chromium.org)

2014-08-18 Thread verwaest
lgtm https://codereview.chromium.org/483603005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r23154 committed - Fix invalid ASSERT on 3.27 branch...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23154 Author: jkumme...@chromium.org Date: Mon Aug 18 12:30:21 2014 UTC Log: Fix invalid ASSERT on 3.27 branch R=verwa...@chromium.org Review URL: https://codereview.chromium.org/483603005 http://code.google.com/p/v8/source/detail?r=23154 Modified:

[v8-dev] Re: Fix invalid ASSERT on 3.27 branch (issue 483603005 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Committed patchset #1 manually as 23154 (tree was closed). https://codereview.chromium.org/483603005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Use actual incremental marking throughput in IdleNotification to estimate marking step size. (issue 465473002 by hpa...@chromium.org)

2014-08-18 Thread ulan
https://codereview.chromium.org/465473002/diff/60001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/465473002/diff/60001/src/heap/heap.cc#newcode4274 src/heap/heap.cc:4274: return static_castintptr_t(marking_speed_in_bytes_per_millisecond * Potential integer

[v8-dev] [v8] r23155 committed - Tagging version 3.27.34.13

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23155 Author: jkumme...@chromium.org Date: Mon Aug 18 12:33:31 2014 UTC Log: Tagging version 3.27.34.13 http://code.google.com/p/v8/source/detail?r=23155 Added: /tags/3.27.34.13 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] [v8] r23156 committed - Tagging version 3.28.71.4

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23156 Author: jkumme...@chromium.org Date: Mon Aug 18 12:34:39 2014 UTC Log: Tagging version 3.28.71.4 http://code.google.com/p/v8/source/detail?r=23156 Added: /tags/3.28.71.4 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Parse 'super' keyword. (issue 480543002 by dslo...@chromium.org)

2014-08-18 Thread dslomov
Committed patchset #4 manually as 23157 (tree was closed). https://codereview.chromium.org/480543002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23157 committed - Parse 'super' keyword....

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23157 Author: dslo...@chromium.org Date: Mon Aug 18 12:35:34 2014 UTC Log: Parse 'super' keyword. BUG=v8:3330 LOG=N R=a...@chromium.org, ma...@chromium.org Review URL: https://codereview.chromium.org/480543002 http://code.google.com/p/v8/source/detail?r=23157 Modified:

[v8-dev] Re: Issue 3330 in v8: Implement ES6 classes

2014-08-18 Thread codesite-noreply via v8-dev
Comment #6 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes http://code.google.com/p/v8/issues/detail?id=3330#c6 The following revision refers to this bug: https://chromium.googlesource.com/external/v8.git/+/65ae6e92abc42bb86017d680803c6180e033c39b commit

[v8-dev] [turbofan] Support lowering of ChangeFloat64ToTagged/ChangeTaggedToInt32. (issue 481903002 by bmeu...@chromium.org)

2014-08-18 Thread bmeurer
Reviewers: jarin, Message: PTAL Description: [turbofan] Support lowering of ChangeFloat64ToTagged/ChangeTaggedToInt32. Adds new ValueEffect operator to ensure proper scheduling of AllocateHeapNumber call nodes. Also does some refactoring to reduce code duplication. TEST=compiler-unittests

[v8-dev] Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now t... (issue 474983003 by tit...@chromium.org)

2014-08-18 Thread titzer
Reviewers: Benedikt Meurer, Description: Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now these methods take a Node* parameter, as decisions relating floating control need distinguish not just operators but nodes. R=bmeu...@chromium.org BUG=

[v8-dev] Re: Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now t... (issue 474983003 by tit...@chromium.org)

2014-08-18 Thread bmeurer
lgtm https://codereview.chromium.org/474983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: ARM64: Refactor instruction selection unit tests. (issue 475823002 by rodolph.perfe...@arm.com)

2014-08-18 Thread rodolph . perfetta
On 2014/08/18 06:38:20, Benedikt Meurer wrote: Ok, I've looked into this again, and I think you are right. We can avoid the possible name collision using an anonymous namespace, i.e. namespace { class MyTest : public InstructionSelectorTestWithParamParamType {}; TEST_P(MyTest, A)

[v8-dev] Version 3.27.34.14 (merged r23084) (issue 486693002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Reviewers: Hannes Payer, Description: Version 3.27.34.14 (merged r23084) Old space cannot be assumed to be iterable between GCs, even if swept precisely. R=hpa...@chromium.org BUG= Please review this at https://codereview.chromium.org/486693002/ SVN Base:

[v8-dev] Re: Version 3.27.34.14 (merged r23084) (issue 486693002 by jkumme...@chromium.org)

2014-08-18 Thread jkummerow
Committed patchset #1 manually as 23158 (tree was closed). https://codereview.chromium.org/486693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23158 committed - Version 3.27.34.14 (merged r23084)...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23158 Author: jkumme...@chromium.org Date: Mon Aug 18 13:07:39 2014 UTC Log: Version 3.27.34.14 (merged r23084) Old space cannot be assumed to be iterable between GCs, even if swept precisely. R=hpa...@chromium.org BUG= Review URL:

[v8-dev] Re: Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now t... (issue 474983003 by tit...@chromium.org)

2014-08-18 Thread titzer
Committed patchset #1 manually as 23160 (tree was closed). https://codereview.chromium.org/474983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r23159 committed - Tagging version 3.27.34.14

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23159 Author: jkumme...@chromium.org Date: Mon Aug 18 13:07:56 2014 UTC Log: Tagging version 3.27.34.14 http://code.google.com/p/v8/source/detail?r=23159 Added: /tags/3.27.34.14 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] [v8] r23160 committed - Move some methods from OperatorProperties into Scheduler that are only...

2014-08-18 Thread codesite-noreply via v8-dev
Revision: 23160 Author: tit...@chromium.org Date: Mon Aug 18 13:09:06 2014 UTC Log: Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now these methods take a Node* parameter, as decisions relating floating control need distinguish not

[v8-dev] Re: Version 3.27.34.14 (merged r23084) (issue 486693002 by jkumme...@chromium.org)

2014-08-18 Thread hpayer
lgtm https://codereview.chromium.org/486693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Finish TODO in Schedule. s/entry/start/g and s/exit/end/g to be more regular. (issue 484653002 by tit...@chromium.org)

2014-08-18 Thread titzer
Reviewers: jarin, Description: Finish TODO in Schedule. s/entry/start/g and s/exit/end/g to be more regular. R=ja...@chromium.org BUG= Please review this at https://codereview.chromium.org/484653002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+79, -85

  1   2   >