[v8-dev] [v8] r24752 committed - d8: create compile cache in a separate isolate....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24752 Author: yang...@chromium.org Date: Tue Oct 21 06:40:15 2014 UTC Log: d8: create compile cache in a separate isolate. R=vogelh...@chromium.org Review URL: https://codereview.chromium.org/670433003 https://code.google.com/p/v8/source/detail?r=24752 Modified: /branches/

[v8-dev] Re: d8: create compile cache in a separate isolate. (issue 670433003 by yang...@chromium.org)

2014-10-20 Thread yangguo
Committed patchset #1 (id:1) manually as 24752 (presubmit successful). https://codereview.chromium.org/670433003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Issue 2861 in v8: timezone offset and timezone string may become inconsistent if timezone changes.

2014-10-20 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Comment #4 on issue 2861 by yang...@chromium.org: timezone offset and timezone string may become inconsistent if timezone changes. https://code.google.com/p/v8/issues/detail?id=2861 Never mind. Issue 3116 was the fixed one. This is unrelated. -- You received

[v8-dev] Re: Issue 2861 in v8: timezone offset and timezone string may become inconsistent if timezone changes.

2014-10-20 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #3 on issue 2861 by yang...@chromium.org: timezone offset and timezone string may become inconsistent if timezone changes. https://code.google.com/p/v8/issues/detail?id=2861 I think r24499 is supposed to fix this. It has already been merged to M39 (V8

[v8-dev] Re: Classes: Add basic support for properties (issue 639123009 by a...@chromium.org)

2014-10-20 Thread dslomov
https://codereview.chromium.org/639123009/diff/40001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/639123009/diff/40001/src/ia32/full-codegen-ia32.cc#newcode2446 src/ia32/full-codegen-ia32.cc:2446: __ CallRuntime(Runtime::kDefineDataPro

[v8-dev] Re: Update ObjectToString to Harmony-draft algorithm (issue 546803003 by caitpotte...@gmail.com)

2014-10-20 Thread dslomov
Comments - we should make things safe. Also, please rebase this patch (you will need some changes due to https://code.google.com/p/v8/source/detail?r=24743 https://codereview.chromium.org/546803003/diff/380001/src/messages.js File src/messages.js (right): https://codereview.chromium.org/5468030

[v8-dev] Re: Fix NoSideEffectToString. (issue 649203004 by dslo...@chromium.org)

2014-10-20 Thread dslomov
On 2014/10/21 01:09:37, caitp wrote: https://codereview.chromium.org/649203004/diff/1/src/messages.js File src/messages.js (right): https://codereview.chromium.org/649203004/diff/1/src/messages.js#newcode229 src/messages.js:229: if (IS_OBJECT(obj)) { So, this will cause arrays to always be rep

[v8-dev] [v8] r24751 committed - Visual Studio provides stdint.h these days....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24751 Author: bmeu...@chromium.org Date: Tue Oct 21 04:55:49 2014 UTC Log: Visual Studio provides stdint.h these days. R=svenpa...@chromium.org Review URL: https://codereview.chromium.org/667573005 https://code.google.com/p/v8/source/detail?r=24751 Modified: /branches/blee

[v8-dev] Re: [turbofan] cleanup InstructionSequence (issue 664123002 by dcar...@chromium.org)

2014-10-20 Thread bmeurer
LGTM with nits. https://codereview.chromium.org/664123002/diff/60001/src/compiler/code-generator.h File src/compiler/code-generator.h (right): https://codereview.chromium.org/664123002/diff/60001/src/compiler/code-generator.h#newcode120 src/compiler/code-generator.h:120: Frame* frame_; Nit: Fra

[v8-dev] Re: lazy (issue 667703002 by rossb...@chromium.org)

2014-10-20 Thread bmeurer
https://codereview.chromium.org/667703002/diff/1/src/interface.h File src/interface.h (right): https://codereview.chromium.org/667703002/diff/1/src/interface.h#newcode9 src/interface.h:9: #include "src/base/lazy-instance.h" No need for this include, see comment below. https://codereview.chromiu

[v8-dev] X87: vector-based ICs did not update type feedback counts correctly. (issue 669823002 by chunyang....@intel.com)

2014-10-20 Thread chunyang . dai
Reviewers: Weiliang, mvstanton, Message: WL. PTAL. Description: X87: vector-based ICs did not update type feedback counts correctly. port r24732. original commit message: vector-based ICs did not update type feedback counts correctly. BUG= Please review this at https://codereview.chromiu

[v8-dev] Re: Issue 2861 in v8: timezone offset and timezone string may become inconsistent if timezone changes.

2014-10-20 Thread codesite-noreply via v8-dev
Comment #2 on issue 2861 by fuk...@chromium.org: timezone offset and timezone string may become inconsistent if timezone changes. https://code.google.com/p/v8/issues/detail?id=2861 Is this bug going to be fixed? Chrome OS file manager have issue chromium:379595, which is waiting this issue

[v8-dev] Re: Array.prototype.{slice,splice} should use [[DefineOwnProperty]] to generate return value (issue 649063003 by ad...@chromium.org)

2014-10-20 Thread adamk
Ping? https://codereview.chromium.org/649063003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: Classes: Add basic support for properties (issue 639123009 by a...@chromium.org)

2014-10-20 Thread Dmitry Lomov
[+v8-dev] On Oct 20, 2014 11:45 PM, "Dmitry Lomov" wrote: > > On Oct 20, 2014 9:38 PM, "Erik Arvidsson" wrote: > > > > > > > > On Sat, Oct 18, 2014 at 2:30 PM, Dmitry Lomov > wrote: > >> > >> On Sat, Oct 18, 2014 at 7:56 PM, Erik Arvidsson > wrote: > >>> > >>> I don't think an access check is

[v8-dev] [v8] r24750 committed - Tagging version 3.29.88.10

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24750 Author: ad...@chromium.org Date: Mon Oct 20 21:44:44 2014 UTC Log: Tagging version 3.29.88.10 https://code.google.com/p/v8/source/detail?r=24750 Added: /tags/3.29.88.10 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You re

[v8-dev] [v8] r24749 committed - Tagging version 3.28.71.17

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24749 Author: ad...@chromium.org Date: Mon Oct 20 21:43:54 2014 UTC Log: Tagging version 3.28.71.17 https://code.google.com/p/v8/source/detail?r=24749 Added: /tags/3.28.71.17 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You re

[v8-dev] Re: Version 3.29.88.10 (merged r24706, r24708) (issue 667033002 by ad...@chromium.org)

2014-10-20 Thread adamk
Committed patchset #1 (id:1) manually as 24748. https://codereview.chromium.org/667033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from t

[v8-dev] 10 CUC GRATIS para el teléfono de Cuba que quieras: pagas 20 cuc y en Cuba reciben 50 cuc

2014-10-20 Thread DimeCuba
--==h64625381289648343=Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [![](https://gallery.mailchimp.com/7ab07f3e867ec9cb09df8f06d/images/ce152bdc-88a8-4e3a-ae42-1211ee7f5579.png)](http://acumbamail.com/url/ver/6949303/3963c8c4-588

[v8-dev] [v8] r24748 committed - Version 3.29.88.10 (merged r24706, r24708)...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24748 Author: ad...@chromium.org Date: Mon Oct 20 21:00:30 2014 UTC Log: Version 3.29.88.10 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409

[v8-dev] Re: Version 3.29.88.10 (merged r24706, r24708) (issue 667033002 by ad...@chromium.org)

2014-10-20 Thread danno
lgtm https://codereview.chromium.org/667033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Version 3.29.88.10 (merged r24706, r24708) (issue 667033002 by ad...@chromium.org)

2014-10-20 Thread adamk
Reviewers: danno, Description: Version 3.29.88.10 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409858 LOG=N R=da...@chromium.org Please review this at https://

[v8-dev] Re: Classes: Add basic support for properties (issue 639123009 by a...@chromium.org)

2014-10-20 Thread arv
https://codereview.chromium.org/639123009/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/639123009/diff/1/src/ia32/full-codegen-ia32.cc#newcode2446 src/ia32/full-codegen-ia32.cc:2446: __ CallRuntime(Runtime::kSetProperty, 4); On 2

[v8-dev] [v8] r24747 committed - Version 3.28.71.17 (merged r24706, r24708)...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24747 Author: ad...@chromium.org Date: Mon Oct 20 20:15:35 2014 UTC Log: Version 3.28.71.17 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409

[v8-dev] Re: Version 3.28.71.17 (merged r24706, r24708) (issue 670533003 by ad...@chromium.org)

2014-10-20 Thread adamk
Committed patchset #1 (id:1) manually as 24747. https://codereview.chromium.org/670533003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from t

[v8-dev] Re: Version 3.28.71.17 (merged r24706, r24708) (issue 670533003 by ad...@chromium.org)

2014-10-20 Thread danno
lgtm https://codereview.chromium.org/670533003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 3.28.71.17 (merged r24706, r24708) (issue 670533003 by ad...@chromium.org)

2014-10-20 Thread adamk
https://codereview.chromium.org/670533003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Version 3.28.71.17 (merged r24706, r24708) (issue 670533003 by ad...@chromium.org)

2014-10-20 Thread adamk
Reviewers: danno, Description: Version 3.28.71.17 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409858 LOG=N R=da...@chromium.org Please review this at https://

[v8-dev] Re: Classes: Add basic support for properties (issue 639123009 by a...@chromium.org)

2014-10-20 Thread Erik Arvidsson
On Sat, Oct 18, 2014 at 2:30 PM, Dmitry Lomov wrote: > On Sat, Oct 18, 2014 at 7:56 PM, Erik Arvidsson wrote: > >> I don't think an access check is needed. The function and prototype are >> both new objects created by the class definition evaluation. >> > I see, you are right. This code is scary

[v8-dev] Re: Update ObjectToString to Harmony-draft algorithm (issue 546803003 by caitpotte...@gmail.com)

2014-10-20 Thread dslomov
Looks like you have not run make quickcheck on this patch; if you do, test/webkit/fast/js/Promise-resolve-with-itself.js fails. I am fixing the underlying issue in https://codereview.chromium.org/649203004/, so this cannot land before that lands. (not sure why our trybots do not execute tho

[v8-dev] Re: Issue 3640 in v8: Shipping/unshipping a feature should be a one-line low-risk CL.

2014-10-20 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Comment #7 on issue 3640 by dslo...@chromium.org: Shipping/unshipping a feature should be a one-line low-risk CL. https://code.google.com/p/v8/issues/detail?id=3640 Consider this done; closing bug. Example shipping CL is here: https://codereview.chromium.org/658

[v8-dev] Re: Classes: static should still be treated as a strict reserved word (issue 652743009 by a...@chromium.org)

2014-10-20 Thread arv
On 2014/10/20 17:44:29, arv wrote: On 2014/10/20 17:16:21, rossberg wrote: > On 2014/10/20 17:02:44, arv wrote: > > I'm confused. I can repro the error when running test262-es6 but it does not > > reproduce anywhere else. I'll bang my head for a little longer > > Hm, I could produce it quite

[v8-dev] Re: Refine typing of addition, subtraction, multiplication, and division. (issue 658743002 by n...@chromium.org)

2014-10-20 Thread neis
Just for the record, several changes should be made to weakening. - It must be monotone. - It should only return range types. - These range types should include some that don't have a corresponding bitset type. E.g. the range of "safe" integers. - If only the minimum has changed, then probabl

[v8-dev] Re: Issue 3605 in v8: TypeFeedbackInfo somehow getting more than 100% of ICs with typeinfo

2014-10-20 Thread codesite-noreply via v8-dev
Comment #8 on issue 3605 by bugdro...@chromium.org: TypeFeedbackInfo somehow getting more than 100% of ICs with typeinfo https://code.google.com/p/v8/issues/detail?id=3605#c8 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a1ba9fb06f48a7a373c246cb0

[v8-dev] Re: Issue 3605 in v8: TypeFeedbackInfo somehow getting more than 100% of ICs with typeinfo

2014-10-20 Thread codesite-noreply via v8-dev
Comment #7 on issue 3605 by bugdro...@chromium.org: TypeFeedbackInfo somehow getting more than 100% of ICs with typeinfo https://code.google.com/p/v8/issues/detail?id=3605#c7 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a1ba9fb06f48a7a373c246cb0

[v8-dev] [v8] r24746 committed - MIPS64: vector-based ICs did not update type feedback counts correctly...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24746 Author: balazs.kilv...@imgtec.com Date: Mon Oct 20 17:59:59 2014 UTC Log: MIPS64: vector-based ICs did not update type feedback counts correctly. Port r24732 (83e975b) BUG=v8:3605 LOG=N R=paul.l...@imgtec.com Review URL: https://codereview.chromium.org/670543002 ht

[v8-dev] Re: MIPS64: vector-based ICs did not update type feedback counts correctly. (issue 670543002 by balazs.kilv...@imgtec.com)

2014-10-20 Thread balazs . kilvady
Committed patchset #1 (id:1) manually as 24746 (presubmit successful). https://codereview.chromium.org/670543002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread Adam Klein
Ah, I misunderstood, still lgtm. On Mon, Oct 20, 2014 at 10:49 AM, Dmitry Lomov wrote: > No, this is now complete. The example patch for shipping a feature is: > https://codereview.chromium.org/658563004/ > I don't think we can make it smaller > > On Mon, Oct 20, 2014 at 7:44 PM, wrote: > >> Am

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread Dmitry Lomov
No, this is now complete. The example patch for shipping a feature is: https://codereview.chromium.org/658563004/ I don't think we can make it smaller On Mon, Oct 20, 2014 at 7:44 PM, wrote: > Am I reading this patch right that it's simply refactoring, and not yet > getting > us to a place where

[v8-dev] Re: Classes: static should still be treated as a strict reserved word (issue 652743009 by a...@chromium.org)

2014-10-20 Thread arv
On 2014/10/20 17:16:21, rossberg wrote: On 2014/10/20 17:02:44, arv wrote: > I'm confused. I can repro the error when running test262-es6 but it does not > reproduce anywhere else. I'll bang my head for a little longer Hm, I could produce it quite easily by running d8 --harmony and just en

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread adamk
Am I reading this patch right that it's simply refactoring, and not yet getting us to a place where we can enable-by-default features that have experimental natives? https://codereview.chromium.org/642233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-d

[v8-dev] Re: MIPS64: vector-based ICs did not update type feedback counts correctly. (issue 670543002 by balazs.kilv...@imgtec.com)

2014-10-20 Thread paul . lind
LGTM. https://codereview.chromium.org/670543002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] [v8] r24745 committed - Fix gc mole test failure....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24745 Author: mvstan...@chromium.org Date: Mon Oct 20 17:32:06 2014 UTC Log: Fix gc mole test failure. TBR=u...@chromium.org Review URL: https://codereview.chromium.org/651683003 https://code.google.com/p/v8/source/detail?r=24745 Modified: /branches/bleeding_edge/test/ccte

[v8-dev] Re: Fix gc mole test failure. (issue 651683003 by mvstan...@chromium.org)

2014-10-20 Thread mvstanton
Committed patchset #1 (id:1) manually as 24745 (presubmit successful). https://codereview.chromium.org/651683003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Fix gc mole test failure. (issue 651683003 by mvstan...@chromium.org)

2014-10-20 Thread mvstanton
Reviewers: ulan, Message: Hi Ulan, Here is a gc mole failure, PTAL, thx! --michael Description: Fix gc mole test failure. BUG= Please review this at https://codereview.chromium.org/651683003/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+2, -1 lines): M te

[v8-dev] Re: Classes: static should still be treated as a strict reserved word (issue 652743009 by a...@chromium.org)

2014-10-20 Thread rossberg
On 2014/10/20 17:02:44, arv wrote: I'm confused. I can repro the error when running test262-es6 but it does not reproduce anywhere else. I'll bang my head for a little longer Hm, I could produce it quite easily by running d8 --harmony and just entering the decl from the bug report. https:

[v8-dev] MIPS64: vector-based ICs did not update type feedback counts correctly. (issue 670543002 by balazs.kilv...@imgtec.com)

2014-10-20 Thread balazs . kilvady
Reviewers: danno, mvstanton, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec, dusmil.imgtec, Description: MIPS64: vector-based ICs did not update type feedback counts correctly. Port r24732 (83e975b) BUG=v8:3605 LOG=N Please review this at https://codereview.chromium.org/670543002/ Base UR

[v8-dev] Re: Classes: static should still be treated as a strict reserved word (issue 652743009 by a...@chromium.org)

2014-10-20 Thread arv
I'm confused. I can repro the error when running test262-es6 but it does not reproduce anywhere else. I'll bang my head for a little longer https://codereview.chromium.org/652743009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this me

[v8-dev] Classes: static should still be treated as a strict reserved word (issue 652743009 by a...@chromium.org)

2014-10-20 Thread arv
Reviewers: rossberg, Description: Classes: static should still be treated as a strict reserved word When --harmony-classes is enabled we did not treat static as a strict reserved word. BUG=v8:3642 LOG=Y Please review this at https://codereview.chromium.org/652743009/ Base URL: https://v8.goog

[v8-dev] Avoid multiple failures to inline functions (issue 668663003 by wi...@igalia.com)

2014-10-20 Thread wingo
Reviewers: Michael Starzinger, Message: This looks right to me, or at least I can't convince myself it's wrong. WDYT? Description: Avoid multiple failures to inline functions R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/668663003/ Base URL: https:/

[v8-dev] Fix NoSideEffectToString. (issue 649203004 by dslo...@chromium.org)

2014-10-20 Thread dslomov
Reviewers: Yang, Message: PTAL Description: Fix NoSideEffectToString. Remove unneccessary check for non-overridden toString - it will not be called anyway. R=yang...@chromium.org Please review this at https://codereview.chromium.org/649203004/ Base URL: https://v8.googlecode.com/svn/branc

[v8-dev] Re: d8: create compile cache in a separate isolate. (issue 670433003 by yang...@chromium.org)

2014-10-20 Thread vogelheim
lgtm Thanks! Looks nicer this way... :) https://codereview.chromium.org/670433003/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/670433003/diff/1/src/d8.cc#newcode180 src/d8.cc:180: ScriptCompiler::CachedData* Shell::CompileCachedData( nitpick: I suspect this shouldn'

[v8-dev] Re: Issue 3641 in v8: Promise with custom |then| method is interpreted incorrectly

2014-10-20 Thread codesite-noreply via v8-dev
Comment #1 on issue 3641 by dome...@domenicdenicola.com: Promise with custom |then| method is interpreted incorrectly https://code.google.com/p/v8/issues/detail?id=3641 Boris assembled a good set of test cases that seem to show Chrome failing to respect thenables entirely: https://bugzill

[v8-dev] [turbofan] cleanup InstructionSequence (issue 664123002 by dcar...@chromium.org)

2014-10-20 Thread dcarney
Reviewers: Benedikt Meurer, Message: ptal Description: [turbofan] cleanup InstructionSequence R=bmeu...@chromium.org BUG= Please review this at https://codereview.chromium.org/664123002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+88, -76 lines): M src/

[v8-dev] Re: Issue 3642 in v8: Static not allowed as variable with --harmony-classes

2014-10-20 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Comment #2 on issue 3642 by a...@chromium.org: Static not allowed as variable with --harmony-classes https://code.google.com/p/v8/issues/detail?id=3642 (No comment was entered for this change.) -- You received this message because this project is configured

[v8-dev] [v8] r24744 committed - Remove deprecated Ascii-related identifiers from include/v8.h...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24744 Author: yang...@chromium.org Date: Mon Oct 20 15:07:27 2014 UTC Log: Remove deprecated Ascii-related identifiers from include/v8.h R=dcar...@chromium.org Review URL: https://codereview.chromium.org/665883002 https://code.google.com/p/v8/source/detail?r=24744 Modified:

[v8-dev] Re: Remove deprecated Ascii-related identifiers from include/v8.h (issue 665883002 by yang...@chromium.org)

2014-10-20 Thread yangguo
Committed patchset #1 (id:1) manually as 24744 (presubmit successful). https://codereview.chromium.org/665883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] d8: create compile cache in a separate isolate. (issue 670433003 by yang...@chromium.org)

2014-10-20 Thread yangguo
Reviewers: vogelheim, Description: d8: create compile cache in a separate isolate. R=vogelh...@chromium.org Please review this at https://codereview.chromium.org/670433003/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+68, -22 lines): M src/d8.h M src/d8.

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread jochen
https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc#newcode256 src/global-handles.cc:256: DCHECK(*handle == Smi::FromInt(kPhantomReferenceZap)); On 2014/10/20 at

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread ulan
https://codereview.chromium.org/649563006/diff/20001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/649563006/diff/20001/test/cctest/test-api.cc#newcode7492 test/cctest/test-api.cc:7492: Could you please also test we don't mark through a dying phant

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread erik . corry
https://codereview.chromium.org/649563006/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/649563006/diff/20001/include/v8.h#newcode520 include/v8.h:520: V8_INLINE void SetPhantom(P* parameter, On 2014/10/20 14:03:10, ulan wrote: Shouldn't phantom reference be

[v8-dev] Re: Assign bailout and type feedback IDs in a post-pass (issue 636403003 by wi...@igalia.com)

2014-10-20 Thread rossberg
On 2014/10/20 11:32:10, wingo wrote: The end result here is that now the time for my --no-lazy benchmark is 0.124s, rather than 0.128 before (and compared to 0.122 before the patch). I'm running the fuzzer now but I think everything's going to go well, and these new numbers are close enoug

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread jochen
https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc#newcode256 src/global-handles.cc:256: DCHECK(*handle == Smi::FromInt(kPhantomReferenceZap)); should we set han

[v8-dev] Make sure floating phi nodes are coupled to their control. (issue 669683002 by mstarzin...@chromium.org)

2014-10-20 Thread mstarzinger
Reviewers: jarin, Description: Make sure floating phi nodes are coupled to their control. R=ja...@chromium.org Please review this at https://codereview.chromium.org/669683002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+101, -94 lines): M src/compiler/sch

[v8-dev] Re: Preserve order of fields when doing slow-to-fast object migration. (issue 614883003 by ish...@chromium.org)

2014-10-20 Thread ishell
https://codereview.chromium.org/614883003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/614883003/diff/1/src/objects.cc#newcode14918 src/objects.cc:14918: Handle Dictionary::BuildNewIterationIndices( On 2014/10/06 11:47:35, Jakob wrote: naming: BuildNewItera

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread ulan
https://codereview.chromium.org/649563006/diff/20001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/649563006/diff/20001/include/v8.h#newcode520 include/v8.h:520: V8_INLINE void SetPhantom(P* parameter, Shouldn't phantom reference be in its own class, separate from Persi

[v8-dev] Re: [turbofan] delete graph and schedule before register allocation. (issue 662513005 by dcar...@chromium.org)

2014-10-20 Thread titzer
+mstarzinger https://codereview.chromium.org/662513005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Assign bailout and type feedback IDs in a post-pass (issue 636403003 by wi...@igalia.com)

2014-10-20 Thread wingo
On 2014/10/20 13:55:04, wingo wrote: Patchset 4 is just patchset 3, rebased. Er, um. I obviously meant patchset 5 is patchset 4, rebased. https://codereview.chromium.org/636403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread erik . corry
I'll make the change so it does not need to be cleared. https://codereview.chromium.org/649563006/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/649563006/diff/1/src/compiler.cc#newcode1286 src/compiler.cc:1286: // the inner function must be allowed to be c

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread jochen
if it compiles on windows, i'm fine with the zap value. ideally, the comment fixes should go to a different cl, but I don't really care, so lgtm either way https://codereview.chromium.org/649563006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev ---

[v8-dev] Re: Assign bailout and type feedback IDs in a post-pass (issue 636403003 by wi...@igalia.com)

2014-10-20 Thread wingo
Patchset 4 is just patchset 3, rebased. https://codereview.chromium.org/636403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this grou

[v8-dev] Re: Introduce phantom weak handles in the API and use them internally for debug info (issue 649563006 by erikco...@chromium.org)

2014-10-20 Thread jochen
can we change it such that the phantom callback does not have to clear the persistent, but just clear it internally anyways? https://codereview.chromium.org/649563006/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/649563006/diff/1/src/compiler.cc#newcode128

[v8-dev] Re: Issue 2700 in v8: Implement arrow functions

2014-10-20 Thread codesite-noreply via v8-dev
Comment #25 on issue 2700 by kevin...@kevincox.ca: Implement arrow functions https://code.google.com/p/v8/issues/detail?id=2700 No problem, I'm just pointing it out to hopefully save a little confusion. -- You received this message because this project is configured to send all issue notifica

[v8-dev] Re: Issue 2700 in v8: Implement arrow functions

2014-10-20 Thread codesite-noreply via v8-dev
Comment #24 on issue 2700 by rossb...@chromium.org: Implement arrow functions https://code.google.com/p/v8/issues/detail?id=2700 #23: see my earlier comment (#19). This is work in progress and behind a flag. Don't expect it to do anything sensible yet. -- You received this message becaus

[v8-dev] Re: Issue 3640 in v8: Shipping/unshipping a feature should be a one-line low-risk CL.

2014-10-20 Thread codesite-noreply via v8-dev
Comment #6 on issue 3640 by dslo...@chromium.org: Shipping/unshipping a feature should be a one-line low-risk CL. https://code.google.com/p/v8/issues/detail?id=3640 After #4, the CL to enable the feature is not one-line, but close to that: - move the feature flag to SHIPPING_FEATURES - update

[v8-dev] Re: Issue 2700 in v8: Implement arrow functions

2014-10-20 Thread codesite-noreply via v8-dev
Comment #23 on issue 2700 by kevin...@kevincox.ca: Implement arrow functions https://code.google.com/p/v8/issues/detail?id=2700 It appears that chromium 38 has half of an arrow function implementation. You can define arrow functions but they don't have a lexical this. function Foo() { this.

[v8-dev] Re: Issue 3640 in v8: Shipping/unshipping a feature should be a one-line low-risk CL.

2014-10-20 Thread codesite-noreply via v8-dev
Comment #4 on issue 3640 by bugdro...@chromium.org: Shipping/unshipping a feature should be a one-line low-risk CL. https://code.google.com/p/v8/issues/detail?id=3640#c4 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6ae42d9171f563374091f14e0b4d21

[v8-dev] Re: Issue 3640 in v8: Shipping/unshipping a feature should be a one-line low-risk CL.

2014-10-20 Thread codesite-noreply via v8-dev
Comment #5 on issue 3640 by bugdro...@chromium.org: Shipping/unshipping a feature should be a one-line low-risk CL. https://code.google.com/p/v8/issues/detail?id=3640#c5 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6ae42d9171f563374091f14e0b4d21

[v8-dev] [v8] r24743 committed - Simplify language feature management....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24743 Author: dslo...@chromium.org Date: Mon Oct 20 13:33:34 2014 UTC Log: Simplify language feature management. R=rossb...@chromium.org BUG=v8:3640 LOG=N Review URL: https://codereview.chromium.org/642233003 https://code.google.com/p/v8/source/detail?r=24743 Modified: /br

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread dslomov
Committed patchset #9 (id:160001) manually as 24743 (presubmit successful). https://codereview.chromium.org/642233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" g

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread dslomov
Comments addressed, landing. https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h#newcode158 src/flag-definitions.h:158: V(scoping, "harmony block scoping")

[v8-dev] [turbofan] delete graph and schedule before register allocation. (issue 662513005 by dcar...@chromium.org)

2014-10-20 Thread dcarney
Reviewers: titzer, Message: ptal Description: [turbofan] delete graph and schedule before register allocation. R=tit...@chromium.org BUG= Please review this at https://codereview.chromium.org/662513005/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+223, -10

[v8-dev] Re: Unship ES6 iteration and unscopables on 3.2 (issue 658423002 by joc...@chromium.org)

2014-10-20 Thread jochen
not needed... closing https://codereview.chromium.org/658423002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] lazy (issue 667703002 by rossb...@chromium.org)

2014-10-20 Thread rossberg
Reviewers: Benedikt Meurer, Description: lazy Fix data race R=bmeu...@chromium.org BUG= Please review this at https://codereview.chromium.org/667703002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+77, -31 lines): M src/interface.h M src/interface.cc

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread rossberg
LGTM with comment https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/642233003/diff/140001/src/flag-definitions.h#newcode158 src/flag-definitions.h:158: V(scoping, "harmony block scoping")

[v8-dev] Re: Simplify language feature management. (issue 642233003 by dslo...@chromium.org)

2014-10-20 Thread dslomov
This is now ready for review. Review patch set 7, patch set 8 is an example of shipping a feature (changes only in flag-definitions.h and v8.gyp) https://codereview.chromium.org/642233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received t

[v8-dev] Visual Studio provides stdint.h these days. (issue 667573005 by bmeu...@chromium.org)

2014-10-20 Thread bmeurer
Reviewers: Sven Panne, Description: Visual Studio provides stdint.h these days. R=svenpa...@chromium.org Please review this at https://codereview.chromium.org/667573005/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -18 lines): M include/v8stdint.h Ind

[v8-dev] [v8] r24742 committed - Drop obsolete misc-intrinsics.h file....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24742 Author: bmeu...@chromium.org Date: Mon Oct 20 12:37:48 2014 UTC Log: Drop obsolete misc-intrinsics.h file. R=svenpa...@chromium.org Review URL: https://codereview.chromium.org/648643003 https://code.google.com/p/v8/source/detail?r=24742 Deleted: /branches/bleeding_ed

[v8-dev] Re: Drop obsolete misc-intrinsics.h file. (issue 648643003 by bmeu...@chromium.org)

2014-10-20 Thread bmeurer
Committed patchset #1 (id:1) manually as 24742 (presubmit successful). https://codereview.chromium.org/648643003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Remove dead GeneralizeFieldRepresentation (issue 668663002 by verwa...@chromium.org)

2014-10-20 Thread verwaest
Committed patchset #1 (id:1) manually as 24741 (presubmit successful). https://codereview.chromium.org/668663002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r24741 committed - Remove dead GeneralizeFieldRepresentation...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24741 Author: verwa...@chromium.org Date: Mon Oct 20 12:32:23 2014 UTC Log: Remove dead GeneralizeFieldRepresentation BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/668663002 https://code.google.com/p/v8/source/detail?r=24741 Modified: /branches/ble

[v8-dev] Re: Use smi zero instead of undefine_value to zap dead weak cells. (issue 637253004 by u...@chromium.org)

2014-10-20 Thread ulan
Thanks, landing. https://codereview.chromium.org/637253004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/637253004/diff/1/src/heap/mark-compact.cc#newcode2748 src/heap/mark-compact.cc:2748: if (!MarkCompactCollector::IsMarked(value)) { On

[v8-dev] Re: Drop obsolete misc-intrinsics.h file. (issue 648643003 by bmeu...@chromium.org)

2014-10-20 Thread svenpanne
lgtm https://codereview.chromium.org/648643003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r24740 committed - Upgrade test262-es6...

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24740 Author: rossb...@chromium.org Date: Mon Oct 20 12:17:12 2014 UTC Log: Upgrade test262-es6 R=dslo...@chromium.org BUG= Review URL: https://codereview.chromium.org/639373005 https://code.google.com/p/v8/source/detail?r=24740 Modified: /branches/bleeding_edge/test/test2

[v8-dev] Re: Upgrade test262-es6 (issue 639373005 by rossb...@chromium.org)

2014-10-20 Thread rossberg
Committed patchset #1 manually as 24740 (presubmit successful). https://codereview.chromium.org/639373005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Drop obsolete misc-intrinsics.h file. (issue 648643003 by bmeu...@chromium.org)

2014-10-20 Thread bmeurer
Reviewers: Sven Panne, Description: Drop obsolete misc-intrinsics.h file. R=svenpa...@chromium.org Please review this at https://codereview.chromium.org/648643003/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+3, -69 lines): D src/misc-intrinsics.h M src/

[v8-dev] [v8] r24739 committed - Remove fuzz-natives tests....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24739 Author: yang...@chromium.org Date: Mon Oct 20 12:14:26 2014 UTC Log: Remove fuzz-natives tests. R=jkumme...@chromium.org Review URL: https://codereview.chromium.org/663043003 https://code.google.com/p/v8/source/detail?r=24739 Deleted: /branches/bleeding_edge/test/fuz

[v8-dev] Re: Remove fuzz-natives tests. (issue 663043003 by yang...@chromium.org)

2014-10-20 Thread yangguo
Committed patchset #1 (id:1) manually as 24739 (presubmit successful). https://codereview.chromium.org/663043003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Remove dead GeneralizeFieldRepresentation (issue 668663002 by verwa...@chromium.org)

2014-10-20 Thread ishell
lgtm https://codereview.chromium.org/668663002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Annotate PromotionQueue::RelocateQueueHead for MemorySanitizer. (issue 603633002 by u...@chromium.org)

2014-10-20 Thread ulan
Committed patchset #1 (id:1) manually as 24738 (presubmit successful). https://codereview.chromium.org/603633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r24738 committed - Annotate PromotionQueue::RelocateQueueHead for MemorySanitizer....

2014-10-20 Thread codesite-noreply via v8-dev
Revision: 24738 Author: u...@chromium.org Date: Mon Oct 20 12:12:51 2014 UTC Log: Annotate PromotionQueue::RelocateQueueHead for MemorySanitizer. BUG=chromium:416875 LOG=N R=earth...@chromium.org, jkumme...@chromium.org Review URL: https://codereview.chromium.org/603633002 https://cod

  1   2   >