Reviewers: vogelheim,
Message:
This is actually long overdue.
Description:
Disable experimental natives when creating a start-up snapshot.
Re-installing experimental natives after deserialization causes failures if
said experimental native is already included in the snapshot. However, there
is
https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h
File src/base/bits.h (right):
https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h#newcode151
src/base/bits.h:151: // Precondition: 0 <= shift < 32
On 2015/03/04 06:02:51, hans wrote:
Any reason the preconditio
https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h
File src/base/bits.h (right):
https://codereview.chromium.org/975283002/diff/20001/src/base/bits.h#newcode151
src/base/bits.h:151: // Precondition: 0 <= shift < 32
Any reason the preconditions are not some kind of assert or che
Committed patchset #1 (id:1)
https://codereview.chromium.org/969653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/30b995fc1bf6dfffaefdb1d6796d55c4493a8be0
Cr-Commit-Position: refs/heads/master@{#26976}
https://codereview.chromium.org/969653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Patchset 2 (id:??) landed as
https://crrev.com/b97df837524de92ef91aa9b1639e1d02101769ff
Cr-Commit-Position: refs/heads/master@{#26975}
https://codereview.chromium.org/975283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/975283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/975283002/20001
https://codereview.chromium.org/975283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
LGTM. Thanks for the cleanup.
https://codereview.chromium.org/975283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/969653004/1
https://codereview.chromium.org/969653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
LGTM, very nice.
https://codereview.chromium.org/969653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
Reviewers: jochen (traveling),
Description:
When using ninja and clang, make sure diagnostics are colored.
BUG=none
LOG=N
Please review this at https://codereview.chromium.org/969653004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -0 lines):
M build/stan
Reviewers: jochen (traveling),
Message:
Small follow-up.
Description:
Use Rotate*() functions instead of doing this manually.
Shouldn't make a difference in practice, but it's a bit more readable and it
gets the case of a 0 shift correct without undefined behavior.
BUG=463436
LOG=N
Please rev
LGTM
https://codereview.chromium.org/961973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1932)
v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3499)
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/981453002/1
https://codereview.chromium.org/981453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/build/gyp to 4a9b712d5cb4a5ba7a9950128a7219569caf7263
Rolling v8/buildtools to d4dd4f79f60bf019625b3a1436979b0a42c892df
Rolling v8/third_party/icu to db16fd86566ffdecce9d4b8e61e21d5316626537
Rolling v8/tools/clang to c61424
On 2015/03/04 at 03:25:19, hans wrote:
Thanks!
Who can help getting this merged to and rolled into Chromium?
It should auto-roll
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
@arv re: chat on IRC, I've tried the last rebased patchset with 1604bd4
reverted
and without, all tests pass regardless. I think the newTarget testing is
probably adequate like this (although more is always good too, I guess).
If it looks okay to you guys, I'll start writing ports tomorrow
htt
Thanks!
Who can help getting this merged to and rolled into Chromium?
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Committed patchset #1 (id:1)
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/721fdb56e0fc92c662c7d8b42be8a1d689c3b535
Cr-Commit-Position: refs/heads/master@{#26974}
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/979633002/1
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
On 2015/03/04 at 01:31:24, thakis wrote:
On 2015/03/04 01:21:41, jochen (traveling) wrote:
> lgtm
Can someone land?
Let me press the button for you...
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
On 2015/03/04 01:21:41, jochen (traveling) wrote:
lgtm
Can someone land?
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
LGTM
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
lgtm
https://codereview.chromium.org/979633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Nico, jochen (traveling), ulan,
Message:
This is blocking the Clang roll. It would be great if someone could review
this,
and ideally help getting it rolled into Chromium too.
Description:
ARM assembler: fix undefined behaviour in fits_shifter
Bit-shifts have undefined behaviour i
Reviewers: marja,
Message:
PTAL
Description:
Speed up string scanning
BUG=
Please review this at https://codereview.chromium.org/975043002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -7 lines):
M src/scanner.h
M src/scanner.cc
Index: src/scanner.c
Comment #13 on issue 3754 by jmed...@chromium.org: ES6 Computed property
names
https://code.google.com/p/v8/issues/detail?id=3754
What version of Chrome is getting this?
--
You received this message because this project is configured to send all
issue notifications to this address.
You ma
Updates:
Status: Fixed
Comment #3 on issue 3938 by rossb...@chromium.org: const bindings in for
loop: invalid assignment in next expression
https://code.google.com/p/v8/issues/detail?id=3938
Fixed by https://crrev.com/054989bd04f9bb4e73e2c243dfb48ebd3ac048e7
--
You received this mess
Reviewers: dcarney,
Message:
Created Revert of [x86] Use better left operand heuristic for Float64Add and
Float64Mul.
Description:
Revert of [x86] Use better left operand heuristic for Float64Add and
Float64Mul.
(patchset #1 id:1 of https://codereview.chromium.org/958583003/)
Reason for reve
Patchset 1 (id:??) landed as
https://crrev.com/3709b9254e9d054796f6735b0f5cefed65ce69d3
Cr-Commit-Position: refs/heads/master@{#26973}
https://codereview.chromium.org/972243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/972243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/972243002/ by bmeu...@chromium.org.
The reason for reverting is: Tanks on Atom and Haswell.
https://codereview.chromium.org/958583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/972243002/1
https://codereview.chromium.org/972243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Committed patchset #9 (id:150001)
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 9 (id:??) landed as
https://crrev.com/1604bd46bf7fe0a8f7cd7780174030e26b93ab37
Cr-Commit-Position: refs/heads/master@{#26972}
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/977543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/054989bd04f9bb4e73e2c243dfb48ebd3ac048e7
Cr-Commit-Position: refs/heads/master@{#26971}
https://codereview.chromium.org/977543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Patchset 1 (id:??) landed as
https://crrev.com/b1d2097dcadaa13aac8cddcf09bc2a087e11249c
Cr-Commit-Position: refs/heads/master@{#26970}
https://codereview.chromium.org/975003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/975003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/975003002/1
https://codereview.chromium.org/975003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/974943003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Dmitry Lomov (chromium),
Description:
[turbofan] Disable test-run-jsexceptions/DeoptFinallyReturn
Reason for disabling failure on ARM64 simulator in no-snap mode.
TBR=dslo...@chromium.org
TEST=cctest/test-run-jsexceptions/DeoptFinallyReturn
NOTREECHECKS=true
NOTRY=true
Please review
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/975463002/150001
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
lgtm
https://codereview.chromium.org/960263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc#newcode1167
src/runtime/runtime-array.cc:1167: CHECK(args_length >= 2);
On 2015/03/03 1
LGTM
https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc
File src/runtime/runtime-array.cc (right):
https://codereview.chromium.org/975463002/diff/150001/src/runtime/runtime-array.cc#newcode1167
src/runtime/runtime-array.cc:1167: CHECK(args_length >= 2);
Does this
arv@ could you take a look at this another attempt at fixing arm?
I have validated locally that it builds with a cross-compiler.
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message becau
Reviewers: jarin,
Description:
[turbofan] Fix exception being re-thrown after finally-block.
This makes sure that the implicit exception edges in the graph pass
the correct exception object and also fixes a bug in the dominance
relationship of the value entering the finally block and it's uses.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/977543002/1
https://codereview.chromium.org/977543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/976693002/1
https://codereview.chromium.org/976693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Patchset 1 (id:??) landed as
https://crrev.com/9ff21de54860f1d768942b09b673fc9a3dc1778c
Cr-Commit-Position: refs/heads/master@{#26969}
https://codereview.chromium.org/976693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/976693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
A revert of this CL (patchset #8 id:130001) has been created in
https://codereview.chromium.org/976693002/ by dslo...@chromium.org.
The reason for reverting is: Arm compilation again.
Aaaarghh!!!.
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.
Reviewers: arv, mvstanton, rossberg,
Message:
Created Revert of Implement subclassing Arrays.
Description:
Revert of Implement subclassing Arrays. (patchset #8 id:130001 of
https://codereview.chromium.org/975463002/)
Reason for revert:
Arm compilation again.
Aaaarghh!!!
Original issue
Reviewers: jochen (traveling),
Description:
Fix Initialize & Dispose for external snapshot. Make sure
v8::V8::(Initialize|Dispose) can be called in any order.
This is a follow-on to crrev.com/960883003, which fixed a memory leak in
this
code, but uncovered another, more subtle bug:
Previou
Status: Accepted
Owner: ad...@chromium.org
CC: a...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3940 by a...@chromium.org: Scope::AllocateModulesRecursively -
modules are never nested
https://code.google.com/p/v8/issues/detail?id=3940
In scopes.cc we currently have Scope::Allocate
Patchset 8 (id:??) landed as
https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43
Cr-Commit-Position: refs/heads/master@{#26966}
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/972943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/972943004/1
https://codereview.chromium.org/972943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Patchset 1 (id:??) landed as
https://crrev.com/d016387e816a744a0a95fa1932cb672e34624f48
Cr-Commit-Position: refs/heads/master@{#26968}
https://codereview.chromium.org/972943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/974873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Patchset 2 (id:??) landed as
https://crrev.com/978c7a8280d3220604ad054a70431c4cbf8a9282
Cr-Commit-Position: refs/heads/master@{#26967}
https://codereview.chromium.org/974873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #8 (id:130001)
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/975463002/130001
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
mvstanton@, PTAL at patch set 8. Argh.
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Committed patchset #1 (id:1)
https://codereview.chromium.org/974963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/974963002/1
https://codereview.chromium.org/974963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Patchset 1 (id:??) landed as
https://crrev.com/7bf9ef1e397267978fbc78dfd59421d10e0716be
Cr-Commit-Position: refs/heads/master@{#26965}
https://codereview.chromium.org/974963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/974963002/ by dslo...@chromium.org.
The reason for reverting is: Arm buildre complains again (why
v8_linux_arm_dbg
does not complain?).
https://codereview.chromium.org/975463002/
--
--
v8-dev mail
Reviewers: arv, mvstanton, rossberg,
Message:
Created Revert of Implement subclassing Arrays.
Description:
Revert of Implement subclassing Arrays. (patchset #7 id:110001 of
https://codereview.chromium.org/975463002/)
Reason for revert:
Arm buildre complains again (why v8_linux_arm_dbg does not
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-let-declaration.js
File test/mjsunit/harmony/block-let-declaration.js (right):
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-let-declaration.js#newcode152
test/mjsunit/harmony/block-let-decl
Reviewers: rossberg,
Message:
PTAL
Description:
Fix the order of experimenal global init/natives installation.
Just like for normal natives, we need to initialize the global object
first and install natives afterwards.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-let-declaration.js
File test/mjsunit/harmony/block-let-declaration.js (right):
https://codereview.chromium.org/964063003/diff/1/test/mjsunit/harmony/block-let-declaration.js#newcode152
test/mjsunit/harmony/block-let-decl
https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):
https://codereview.chromium.org/974873002/diff/1/src/mips/code-stubs-mips.cc#newcode1053
src/mips/code-stubs-mips.cc:1053: // Ask the runtime for help to
determine the handler.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/974873002/20001
https://codereview.chromium.org/974873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Committed patchset #3 (id:40001)
https://codereview.chromium.org/962963007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Thanks for catching comment mistakes.
https://codereview.chromium.org/974873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Patchset 3 (id:??) landed as
https://crrev.com/32979cf6d88b1d837ac4ba4b1ff6ee87acdba0f4
Cr-Commit-Position: refs/heads/master@{#26964}
https://codereview.chromium.org/962963007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Comment #5 on issue 3939 by waldron@gmail.com: Invalid source strings
for "Test function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
To clarify, the SyntaxError exceptions that should be tested for:
if (true) function g(
Reviewers: rossberg_chromium.orh, Rick Waldron,
Message:
PTAL
Description:
Fix test for function declarations syntax error.
R=waldron.r...@gmail.com,rossb...@chromium.orh
BUG=v8:3939
LOG=N
Please review this at https://codereview.chromium.org/964063003/
Base URL: https://chromium.googlesource
Patchset 7 (id:??) landed as
https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051
Cr-Commit-Position: refs/heads/master@{#26963}
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Comment #4 on issue 3939 by waldron@gmail.com: Invalid source strings
for "Test function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
Not correct, that's not the syntax error that's being tested.
--
You received this message
Committed patchset #7 (id:110001)
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/962963007/40001
https://codereview.chromium.org/962963007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Comment #3 on issue 3939 by dslo...@chromium.org: Invalid source strings
for "Test function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
No they are not since we want to report a specific syntax error.
--
You received this messa
lgtm
https://codereview.chromium.org/972943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Owner: dslo...@chromium.org
Labels: Component-Tests
Comment #1 on issue 3939 by habl...@chromium.org: Invalid source strings
for "Test function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
I assume this i
Routing offline discussion here:
https://codereview.chromium.org/968263002/diff/120001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/968263002/diff/120001/src/parser.cc#newcode4166
src/parser.cc:4166: // Unnamed classes should not have scopes (the class
scope will be
https://codereview.chromium.org/913073003/diff/60001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/913073003/diff/60001/src/runtime.js#newcode478
src/runtime.js:478: if (length > 0x80) {
On 2015/03/03 14:25:52, arv wrote:
maybe add a const/macro for this?
Rep
Comment #2 on issue 3939 by habl...@chromium.org: Invalid source strings
for "Test function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
I mean "the tests" are correct.
--
You received this message because this project is config
On 2015/03/03 15:43:45, vogelheim wrote:
lgtm
Just to double check my understanding:
- There's no way for an API user to create an Isolate with
serializer_enabled()
== true. The corresponding constructor isn't exposed.
- There's no internal creation of such an Isolate that gets passed out.
-
Status: New
Owner:
New issue 3939 by waldron@gmail.com: Invalid source strings for "Test
function declarations in statement position in strict mode." tests
https://code.google.com/p/v8/issues/detail?id=3939
https://github.com/v8/v8-git-mirror/blob/master/test/mjsunit/harmony/block-le
lgtm
Just to double check my understanding:
- There's no way for an API user to create an Isolate with
serializer_enabled()
== true. The corresponding constructor isn't exposed.
- There's no internal creation of such an Isolate that gets passed out.
- Therefore, this change shouldn't affect an
Committed patchset #3 (id:40001)
https://codereview.chromium.org/969353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
On 2015/03/03 14:25:52, arv wrote:
You should be able to test new.target by doing something like.
function C() {
this[9] = 1;
}
var o = Reflect.construct(C, [], Array);
assertSame(C.prototype, o.__proto__);
assertSame(10, o.length);
Well, this test makes sense, but doesn't actually wor
https://codereview.chromium.org/968263002/diff/120001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/968263002/diff/120001/src/parser.cc#newcode4166
src/parser.cc:4166: // Unnamed classes should not have scopes (the class
scope will be empty).
Unnamed classed do not ne
1 - 100 of 188 matches
Mail list logo
