On 2015/04/20 15:21:57, I haz the power (commit-bot) wrote:
Dry run: This issue passed the CQ dry run.
ping
https://codereview.chromium.org/1099573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: Jakob,
Description:
Wrap harmony implementations in functions.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1100673002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+87, -90 lines):
M src/ast-value-factory.h
M sr
Title: The core of the core of the big data solutions -- Map
Author: pengwenwei
Email: wenwei19710430
Language:c++
Platform:Windows, linux
Technology: Perfect hash algorithm
Level: Advanced
Description: Map algorithm with high performance
Section MFC c++ map st
On 2015/03/18 10:19:27, I haz the power (commit-bot) wrote:
Patchset 2 (id:??) landed as
https://crrev.com/15f8213809a57c2a163b500a732c9ffe5160a41a
Cr-Commit-Position: refs/heads/master@{#27263}
This change is responsible for a 70% drop in the ParserCombinators
benchmark.
Chrome is now slower
Patchset 2 (id:??) landed as
https://crrev.com/7ad9980d995b0381046ee8677861491ef6d234ed
Cr-Commit-Position: refs/heads/master@{#27950}
https://codereview.chromium.org/1096053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:40001)
https://codereview.chromium.org/1096053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1096053002/40001
https://codereview.chromium.org/1096053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Yeah this indeed breaks the entire optimization. If we really want to
support
the alternative, I guess we just need to revert the original change.
I'd prefer to what the spec requires though. If clients want to customize
what
they see, they should rely on harmony_tostring (toStringTag) at mos
lgtm
https://codereview.chromium.org/1092323003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
perfect, thanks!
On Mon, Apr 20, 2015 at 12:04 PM wrote:
> On 2015/04/20 18:31:44, Mircea Trofin wrote:
> > Updated after the refactoring.
>
> > Consolidated some common functionality into helper utility functions (see
> > GetRegisterCount and GetFixedRegisters).
>
> > Moved (opportunistically)
Patchset 1 (id:??) landed as
https://crrev.com/42415bf9bc5aa7266267e731140e5beed6909796
Cr-Commit-Position: refs/heads/master@{#27949}
https://codereview.chromium.org/1096763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1096763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
On 2015/04/20 18:31:44, Mircea Trofin wrote:
Updated after the refactoring.
Consolidated some common functionality into helper utility functions (see
GetRegisterCount and GetFixedRegisters).
Moved (opportunistically) stateless, live range-splitting APIs to
RegisterAllocationData, since they
Updated after the refactoring.
Consolidated some common functionality into helper utility functions (see
GetRegisterCount and GetFixedRegisters).
Moved (opportunistically) stateless, live range-splitting APIs to
RegisterAllocationData, since they need code-wide context, but are
independent
of
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1096763003/1
https://codereview.chromium.org/1096763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Michael Achenbach,
Message:
Committed patchset #1 (id:1) manually as
abb23b5284d94278f1c16a4e051b47cc44e993e8 (presubmit successful).
Description:
Disable mjsunit/es7/object-observe on gc-stress, due to flakiness.
TBR=machenb...@chromium.org
CC=ad...@chromium.org
BUG=478788
LOG=N
Co
Patchset 1 (id:??) landed as
https://crrev.com/abb23b5284d94278f1c16a4e051b47cc44e993e8
Cr-Commit-Position: refs/heads/master@{#27948}
https://codereview.chromium.org/1092323003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/04/20 17:57:48, adamk wrote:
lgtm
Thanks for the ping on this one, happy to see harmony-array complete
(modulo
typed arrays stuff).
Thanks for the review =) dslomov@ any other comments before landing?
https://codereview.chromium.org/376623004/
--
--
v8-dev mailing list
v8-dev@goo
>
>
>> [MT] OK, but at least for the interim, can we live with a virtual
> Allocate? Otherwise we pay for a test - in the same interim. Or are you
> suggesting I simply add "Greedy" members to the one and only
> RegisterAllocator?
>
Sorry, that's not what I was trying to say. I meant that I refact
lgtm
Thanks for the ping on this one, happy to see harmony-array complete (modulo
typed arrays stuff).
https://codereview.chromium.org/376623004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
https://codereview.chromium.org/376623004/diff/80001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/376623004/diff/80001/src/harmony-array.js#newcode16
src/harmony-array.js:16: var length = ToLength(array.length);
On 2015/04/20 17:26:14, adamk wrote:
Ple
On 2015/04/20 17:19:42, Jakob wrote:
I'm deferring to Ross here, who judging by
https://codereview.chromium.org/179813005 is more familiar with this code
than
I
am :-)
Now that I think about it, let's just delete both constant pool branches
(i.e.,
L4611->4623) and always add typed slots
On 2015/04/20 07:30:34, jochen wrote:
On 2015/04/15 at 22:24:53, adamk wrote:
> On 2015/04/15 19:52:45, dcarney wrote:
> > > It might be worth having a fast-path in C++ for the "no existing
property,
> > > extensible object" case. I don't think that's too much duplication,
really.
> >
> > while
Reviewers: mvstanton, titzer,
Description:
[turbofan] Use FastCloneShallow[Array|Object]Stub if possible.
This allows the JSIntrinsicLowering to optimize the cloning of literal
boilerplate objects using either the FastCloneShallowArrayStub or the
FastCloneShallowObjectStub when applicable.
R=
Looking good, just a few nits and one test request.
https://codereview.chromium.org/376623004/diff/20001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/376623004/diff/20001/src/harmony-array.js#newcode15
src/harmony-array.js:15: CHECK_OBJECT_COERCIBLE(th
On 2015/03/23 10:20:07, marja wrote:
Could you also add a description to describe exactly what is allowed now;
it's
sort of tedious to infer as the negation of the union of the added
errors :)
Done.
(I'm also slightly skeptical that there are no tests that assert that some
stuff
*is* all
Reviewers: Toon Verwaest,
Message:
PTAL.
See the referenced bug for background. Apparently this was broken by
https://codereview.chromium.org/942493002. I'm not entirely sure this is the
right fix; feel free to suggest something else.
AFAICT there's indeed no way to test this behavior from JS; h
I'm deferring to Ross here, who judging by
https://codereview.chromium.org/179813005 is more familiar with this code
than I
am :-)
https://codereview.chromium.org/1096053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Reviewers: rossberg,
Message:
On 2015/04/20 15:29:38, conradw wrote:
mailto:conr...@chromium.org changed reviewers:
+ mailto:rossb...@chromium.org
PTAL
Description:
[strong] Disallow implicit casts in subtraction
Implements the strong mode proposal's restrictions on implicit casts for the
su
Thanks, inline
On Mon, Apr 20, 2015 at 8:40 AM wrote:
> okay, phase one of the refactor is here and will land soon:
>
> https://codereview.chromium.org/1094063002/
>
> this is going to change some things for you:
>
> I was forced, due to no one coming up with a better name, to introduce a
> Regi
Updates:
Cc: -benc...@chromium.org bcch...@chromium.org
Comment #2 on issue 4049 by rmcil...@chromium.org: Enable fast collection
of run-once code objects with lightweight pre-aging
https://code.google.com/p/v8/issues/detail?id=4049
(No comment was entered for this change.)
--
You re
Patchset 2 (id:??) landed as
https://crrev.com/314e73d1ec93de843e9140f487159642fac66ede
Cr-Commit-Position: refs/heads/master@{#27947}
https://codereview.chromium.org/1098863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1098863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Michael Starzinger,
Description:
[turbofan] Optimize loads from the global object in
JSTypeFeedbackSpecializer.
Uses lazy deoptimization and code dependencies to introduce loads
from property cells and also to promote globals to constants.
R=mstarzin...@chromium.org
BUG=
Please r
Patchset 9 (id:??) landed as
https://crrev.com/497c537310d72064a23bb0ea3e4e708460b7dbf4
Cr-Commit-Position: refs/heads/master@{#27946}
https://codereview.chromium.org/1094063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #9 (id:150001)
https://codereview.chromium.org/1094063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Updates:
Cc: benc...@chromium.org
Comment #1 on issue 4049 by rmcil...@chromium.org: Enable fast collection
of run-once code objects with lightweight pre-aging
https://code.google.com/p/v8/issues/detail?id=4049
(No comment was entered for this change.)
--
You received this message be
Alright, I tried to fix all the cases you pointed out. ptal.
I'm adding extra stuff to Variable though and that's sad :(
https://codereview.chromium.org/1060913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because y
Alright, I tried to fix all the cases you pointed out. ptal.
I'm adding extra stuff to Variable though and that's sad :(
https://codereview.chromium.org/1060913005/diff/90001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1060913005/diff/90001/src/ast.h#newcode577
src/ast.
okay, phase one of the refactor is here and will land soon:
https://codereview.chromium.org/1094063002/
this is going to change some things for you:
I was forced, due to no one coming up with a better name, to introduce a
RegisterAllocationData class, which means there is no way you can have a
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1094133002/20001
https://codereview.chromium.org/1094133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Status: Accepted
Owner:
CC: rmcil...@chromium.org, erikco...@chromium.org,
verwa...@chromium.org, u...@chromium.org, hpa...@chromium.org,
joc...@chromium.org
Labels: Type-FeatureRequest Priority-Medium
New issue 4049 by rmcil...@chromium.org: Enable fast collection of run-once
co
LGTM with nit
https://codereview.chromium.org/1094133002/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/1094133002/diff/1/test/mjsunit/mjsunit.status#newcode307
test/mjsunit/mjsunit.status:307: # TODO(ishell): Requires invesigation.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1094063002/150001
https://codereview.chromium.org/1094063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Status: Accepted
Owner: hpa...@chromium.org
CC: joc...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4048 by joc...@chromium.org: When a gc is triggered from a weak
callback, gc-tracer gets confused
https://code.google.com/p/v8/issues/detail?id=4048
triggered by TestGCFromWeakCallba
LGTM with comments
https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/1098883002/diff/1/tools/run-tests.py#newcode115
tools/run-tests.py:115: # Normal trybot release configuraion. There,
dchecks are always on whi
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1099473004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/f557d75360d34d7d29834c4864f4154849ed404d
Cr-Commit-Position: refs/heads/master@{#27945}
https://codereview.chromium.org/1099473004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
lgtm
https://codereview.chromium.org/1096763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:130001)
https://codereview.chromium.org/1099633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/c12e8d889c282e9a8d1b63e616dbbdc976995f4d
Cr-Commit-Position: refs/heads/master@{#27944}
https://codereview.chromium.org/1099633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1099633002/130001
https://codereview.chromium.org/1099633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Patchset 4 (id:??) landed as
https://crrev.com/9987221c02b63bb93c6013e9706bd5e93322ef14
Cr-Commit-Position: refs/heads/master@{#27943}
https://codereview.chromium.org/1066003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1066003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Hannes Payer, Erik Corry Chromium.org,
Message:
Created Revert of Fix logic for doing incremental marking steps on tenured
allocation.
Description:
Revert of Fix logic for doing incremental marking steps on tenured
allocation.
(patchset #4 id:60001 of https://codereview.chromium.or
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1099633002/ by jkumme...@chromium.org.
The reason for reverting is: Suspected to trigger memory corruption issues,
e.g.
crbug.com/478401.
The testcase in
https://cluster-fuzz.appspot.com/testcase?
Failed to apply patch for src/heap/incremental-marking.cc:
While running git apply --index -3 -p1;
error: patch failed: src/heap/incremental-marking.cc:821
error: repository lacks the necessary blob to fall back on 3-way merge.
error: src/heap/incremental-marking.cc: patch does not apply
Pa
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1099633002/1
https://codereview.chromium.org/1099633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 2 (id:??) landed as
https://crrev.com/ad854ea11e787a673a40b7917a955bee6d7dc253
Cr-Commit-Position: refs/heads/master@{#27942}
https://codereview.chromium.org/1095083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Status: Accepted
Owner:
CC: rmcil...@chromium.org, erikco...@chromium.org,
verwa...@chromium.org, hpa...@chromium.org, u...@chromium.org,
joc...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4047 by rmcil...@chromium.org: Make stack_frames in
JSMessageObject point to co
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1095083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1099473004/20001
https://codereview.chromium.org/1099473004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
LGTM (rubber-stamped).
https://codereview.chromium.org/1099473004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop recei
LGTM although a struct would be s much nicer
https://codereview.chromium.org/1094063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Try jobs failed on following builders:
v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/4078)
https://codereview.chromium.org/1094863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Patchset 1 (id:??) landed as
https://crrev.com/8cf289ca4fcfb10c15d1840706f89a3636456f7e
Cr-Commit-Position: refs/heads/master@{#27941}
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1098863003/20001
https://codereview.chromium.org/1098863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Feedback addressed, landing...
https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/1098863003/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode1103
src
On 2015/04/20 14:35:46, marja wrote:
> > but the cycle detection logic I proposed earlier doesn't cover it.
>
> Why not?
Meh, it does, I was just confused. B has an init-time dependency to A, so
doesn't matter which type of dependency A has to B.
... it just means we need to collect the refe
> but the cycle detection logic I proposed earlier doesn't cover it.
Why not?
Meh, it does, I was just confused. B has an init-time dependency to A, so
doesn't matter which type of dependency A has to B.
https://codereview.chromium.org/1060913005/
--
--
v8-dev mailing list
v8-dev@googlegro
On 2015/04/20 14:21:13, marja wrote:
Oh my, this is exponentially more complicated than I thought.
I would think it's actually simpler. It certainly is more regular, which
means
no special hacks.
All we need is a generic method that, given two scopes S1 and S2, finds the
binding in S1 that
Oh my, this is exponentially more complicated than I thought.
Then this should be forbidden:
class A {
static sm() { class C extends B { } ... }
}
class B {
[A.sm()]() { ... }
}
but the cycle detection logic I proposed earlier doesn't cover it.
https://codereview.chromium.org/1060913005/
Reviewers: titzer,
Message:
On 2015/04/20 13:33:53, titzer wrote:
Looks good, just one more slice.
https://codereview.chromium.org/1094063002/diff/11/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1094063002/diff/1
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1077153003/1
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1094863002/20001
https://codereview.chromium.org/1094863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
On 2015/04/20 13:59:46, marja wrote:
I don't think this should work though:
class A {
m() { class C extends B {} }
}
class B {}
since we should allow init-time references only to already declared
things.
No, that should definitely work. Any example of the form
class A {
m() { ...B.
Committed patchset #1 (id:1)
https://codereview.chromium.org/1067523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/f66a31282afc26d3c5ca477a4409e43faabb6029
Cr-Commit-Position: refs/heads/master@{#27940}
https://codereview.chromium.org/1067523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Thanks Jakob, nits addressed...
https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc#newcode12748
src/objects.cc:12748: PrintF("Deopting\n");
On 2015/04/20 10:52:05, Jakob wrote:
d
Yup, I'm still unsure whether the inability to find a class variable in the
following cases causes any practical problems:
let A = class { ... }
let A = class B { ... }
I don't think this should work though:
class A {
m() { class C extends B {} }
}
class B {}
since we should allow init-time
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1066003003/60001
https://codereview.chromium.org/1066003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2137)
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Reland "Refactor compilation dependency handling."
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1099473004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+243, -2
Reviewers: Jakob,
Description:
Small polishing changes to the native js.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1096763003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+13, -20 lines):
M src/i18n.js
M src/macros.py
On 2015/04/20 12:37:30, marja wrote:
omg, turns out the counterexample
let A = class { m(){B} }
class B {}
was working (as in, we were producing an error), but it was working by
accident:
when looking for a class variable for m() we didn't find A. In fact we
didn't
find anything.
Idk
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1077153003/1
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1067523003/1
https://codereview.chromium.org/1067523003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/04/20 13:31:11, marja wrote:
Hmm, still seems to be a regression though :( (Around 3-4%.)
Humm! How bizarre. Weirddd.
https://codereview.chromium.org/1064433008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message be
Looks good, just one more slice.
https://codereview.chromium.org/1094063002/diff/11/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1094063002/diff/11/src/compiler/register-allocator.h#newcode533
src/compiler/register-all
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1095083002/20001
https://codereview.chromium.org/1095083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Patchset 1 (id:??) landed as
https://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef
Cr-Commit-Position: refs/heads/master@{#27939}
https://codereview.chromium.org/1092923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1092923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Hmm, still seems to be a regression though :( (Around 3-4%.)
https://codereview.chromium.org/1064433008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
I think it's cleaner now.
https://codereview.chromium.org/1064433008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop re
Patchset 3 (id:??) landed as
https://crrev.com/36f17ed0305017547fce39cb6a53c1c2ba79b3d8
Cr-Commit-Position: refs/heads/master@{#27938}
https://codereview.chromium.org/1080633006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1080633006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Tx for review and for poking the perf trybot. Updated patch fixes nit (and
a
couple of formatting issues).
https://codereview.chromium.org/1064433008/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1064433008/diff/60001/src/parser.cc#newcode3945
src/parse
lgtm
https://codereview.chromium.org/1077153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Description:
Throw when attaching a stack trace to an object fails.
R=ja...@chromium.org
BUG=chromium:478011
Please review this at https://codereview.chromium.org/1077153003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+23, -15 lines):
M sr
1 - 100 of 211 matches
Mail list logo
