Comment #6 on issue 3417 by mvstan...@chromium.org: When we fail to grow an
array in new space, maybe don't deopt
https://code.google.com/p/v8/issues/detail?id=3417
I'll try and reland this...
--
You received this message because this project is configured to send all
issue notifications t
Committed patchset #1 (id:1) manually as
2a2fc95c25c9af929ccbb22a9453c65ffd4950bc.
https://codereview.chromium.org/1110343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: dcarney, jochen,
Description:
Version 4.4.41.1 (cherry-pick)
Merged 4c1f9d53cfad64731d3323f437f1e696ddcf17f4
Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of
https://codereview.chromium.org/1103173002/)
TBR=dcar...@chromium.org, joc...@chromium.org
BUG=
Please re
Thanks for the comments Paul, uploaded fixes.
https://codereview.chromium.org/1114563003/diff/20001/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/1114563003/diff/20001/src/mips/lithium-codegen-mips.cc#newcode5561
src/mips/lithium
lgtm
https://codereview.chromium.org/1104073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Started
Owner: caitpott...@gmail.com
Comment #5 on issue 2160 by caitpott...@gmail.com: Add support for default
parameters
https://code.google.com/p/v8/issues/detail?id=2160
(No comment was entered for this change.)
--
You received this message because this p
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1117623002/1
https://codereview.chromium.org/1117623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/4c1f9d53cfad64731d3323f437f1e696ddcf17f4
Cr-Commit-Position: refs/heads/master@{#28121}
https://codereview.chromium.org/1117623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1117623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1117623002/ by machenb...@chromium.org.
The reason for reverting is: [Sheriff] This is still used and now blocks the
roll here:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compi
Reviewers: jochen, dcarney,
Message:
Created Revert of deprecate non-phantom weak callbacks
Description:
Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of
https://codereview.chromium.org/1103173002/)
Reason for revert:
[Sheriff] This is still used and now blocks the roll here:
Committed patchset #6 (id:11)
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 6 (id:??) landed as
https://crrev.com/bc7f79a67042de6255e09c984b4196f3eef6b2d6
Cr-Commit-Position: refs/heads/master@{#28120}
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1053123006/11
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Comment #4 on issue 2160 by aneesiqb...@gmail.com: Add support for default
parameters
https://code.google.com/p/v8/issues/detail?id=2160
a friendly bump
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your not
https://codereview.chromium.org/1069883002/diff/220001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1069883002/diff/220001/src/bootstrapper.cc#newcode1377
src/bootstrapper.cc:1377: is_shared ? JS_SHARED_TYPED_ARRAY_TYPE :
JS_TYPED_ARRAY_TYPE;
change to (i
On 2015/04/28 19:42:09, jochen wrote:
On 2015/04/28 at 19:39:05, dslomov wrote:
> On 2015/04/28 18:31:46, jochen wrote:
> > some comments
> >
> > it's unfortunate that the shared thingies have a different map - that
means
that
> > code that handles both regular and shared typed arrays will go
Comment #9 on issue 3846 by bmeu...@chromium.org: AVX really slow
https://code.google.com/p/v8/issues/detail?id=3846
Johann: Thanks for the pointer.
Weiliang: Can you shed some light on this? Our detection code is in
src/base/cpu.cc.
--
You received this message because this project is conf
Comment #14 on issue 3952 by bmeu...@chromium.org: Support for inlining
builtins in TurboFan
https://code.google.com/p/v8/issues/detail?id=3952
I'd leave it open.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjus
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h#newcode20
src/compiler/pipeline.h:20: kToNativeContext = 1 << 1, // to a
specific native context.
We
https://codereview.chromium.org/1108563002/diff/60001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/1108563002/diff/60001/src/compiler/instruction-selector.cc#newcode1046
src/compiler/instruction-selector.cc:1046: static N
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.h#newcode1456
src/heap/heap.h:1456: struct StrongRootsList {
Style nit: Please forward declare struct and the two methods below
On 2015/04/27 07:57:51, titzer wrote:
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h#newcode68
src/heap/identity-map.h:68: return static_cast((raw_address
Patchset 1 (id:??) landed as
https://crrev.com/7b9debd09b4dae961a50d4dacae0b7c1c57e4b19
Cr-Commit-Position: refs/heads/master@{#28119}
https://codereview.chromium.org/1108203005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1108203005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1108203005/1
https://codereview.chromium.org/1108203005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/tools/clang to 44f7f0bbbce9e581d9328e80d5b0ae88efbc3db4
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1108203005/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files
https://codereview.chromium.org/1110273002/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/1110273002/diff/1/src/x64/full-codegen-x64.cc#newcode194
src/x64/full-codegen-x64.cc:194: } else if
(info->scope()->is_module_scope()) {
This co
Comment #8 on issue 3846 by johannko...@google.com: AVX really slow
https://code.google.com/p/v8/issues/detail?id=3846
FYI (because I couldn't find the cpuid(...) call specifically when looking
at the code to check if it was guarded) if you see strange AVX2 crashes
similar to http://code.goo
https://codereview.chromium.org/1098123002/diff/80001/tools/release/search_related_commits.py
File tools/release/search_related_commits.py (right):
https://codereview.chromium.org/1098123002/diff/80001/tools/release/search_related_commits.py#newcode162
tools/release/search_related_commits.py:162
Reviewers: rossberg, arv,
Message:
Not much to review here (it's mostly deletion), but I could probably do with
improving the CL description. Suggestions welcome.
Description:
Simplify module context allocation for context-independent module
compilation
The old module context allocation code
https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py
File tools/release/releases.py (right):
https://codereview.chromium.org/1090183002/diff/1/tools/release/releases.py#newcode464
tools/release/releases.py:464: if v8_version.split(".")[3]== "0":
On 2015/04/20 12:29:34, Hab
On 2015/04/28 19:22:56, mtbrandyberry wrote:
I think you actually want lw when accessing
JSArrayBuffer::kBitFieldOffset.
Although it's really only important for big-endian mips64 (not sure if
this is
supported).
You're correct Matt, thanks for the comment! We don't support mips64
big-endi
Patchset 1 (id:??) landed as
https://crrev.com/f76fd06d11b9da091af920a240875826fc5ab52c
Cr-Commit-Position: refs/heads/master@{#28118}
https://codereview.chromium.org/1108373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1108373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
note to self...
https://codereview.chromium.org/1114563002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1114563002/diff/60001/src/heap/heap.cc#newcode1326
src/heap/heap.cc:1326: not_yet_discovered_array_buffers_ =
live_array_buffers_;
so the bug is
On 2015/04/28 at 19:39:05, dslomov wrote:
On 2015/04/28 18:31:46, jochen wrote:
> some comments
>
> it's unfortunate that the shared thingies have a different map - that
means
that
> code that handles both regular and shared typed arrays will go
polymorphic
(i.e.
> ultra slow)
Different
On 2015/04/28 18:31:46, jochen wrote:
some comments
it's unfortunate that the shared thingies have a different map - that
means
that
code that handles both regular and shared typed arrays will go polymorphic
(i.e.
ultra slow)
Different maps (and having different code) is very much just
On 2015/04/28 16:56:18, paul.l... wrote:
LGTM.
I think you actually want lw when accessing JSArrayBuffer::kBitFieldOffset.
Although it's really only important for big-endian mips64 (not sure if this
is
supported).
https://codereview.chromium.org/003002/
--
--
v8-dev mailing list
v8-dev
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1108373002/1
https://codereview.chromium.org/1108373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/04/28 16:27:04, rossberg wrote:
I wonder if the natural solution wouldn't be to pre-allocate
global 'this' in
the global context? There is no reason to re-allocate it for every
script, it
logically scopes over all scripts.
Interesting idea. How would that be reflected in the scope
lgtm
https://codereview.chromium.org/1108373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
ptal!
https://codereview.chromium.org/1100993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
some comments
it's unfortunate that the shared thingies have a different map - that means
that
code that handles both regular and shared typed arrays will go polymorphic
(i.e.
ultra slow)
https://codereview.chromium.org/1069883002/diff/220001/include/v8.h
File include/v8.h (right):
https:
Patchset 1 (id:??) landed as
https://crrev.com/29bee1604f93341e9f0a564a16a8fc74546a9aa4
Cr-Commit-Position: refs/heads/master@{#28117}
https://codereview.chromium.org/003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/b108f4615cf161f6caa6ebde4627e9ac0b9ca36c
Cr-Commit-Position: refs/heads/master@{#28116}
https://codereview.chromium.org/1108363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1108363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Comment #5 on issue 4062 by cl...@ripple.com: Math.exp(-1) !== 1/Math.E
https://code.google.com/p/v8/issues/detail?id=4062
Limited-precision floating point is not quite the same as math theory.
Yes, but even in floating point there is a right and a wrong answer. If you
return the wrong answ
Michael - a couple build problems to address ... looks like the trybots show
them ...
https://codereview.chromium.org/1114563003/diff/20001/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/1114563003/diff/20001/src/mips/lithium-code
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/003002/1
https://codereview.chromium.org/003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
LGTM.
https://codereview.chromium.org/003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/04/28 16:26:59, mtbrandyberry wrote:
Please TAL. This follows the example of Name::kHashFieldOffset for
endian-neutral accessors.
lgtm
https://codereview.chromium.org/1108373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1108363002/1
https://codereview.chromium.org/1108363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: rmcilroy, Yang,
Message:
- Since we're not sure whether this is a good idea in the first place,
please do
suggest alternatives if it isn't.
- I removed the 'effective age' function. It assumed the 'virtual' states
could
be mapped to a proper state for IsOld and MakeOlder, but thi
Reviewers: danno, jochen, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS: Fix 'Add HArrayBufferNotNeutered instruction'.
BUG=
Please review this at https://codereview.chromium.org/003002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -4 l
On 2015/04/28 16:15:54, mtbrandyberry wrote:
Please TAL
lgtm
https://codereview.chromium.org/1108363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Yang,
Message:
PTAL.
Regression test: failing try jobs on
https://codereview.chromium.org/1097113003/
Description:
Fix stale pointer issue in heap snapshot generator
Please review this at https://codereview.chromium.org/1109153002/
Base URL: https://chromium.googlesource.com/v8/
Status: New
Owner:
New issue 4064 by d...@domenic.me: jsmin.py not safe for ES6 object literals {
x, y }
https://code.google.com/p/v8/issues/detail?id=4064
jsmin.py when applied to something like
function EnqueueValueWithSize(queue, value, size) {
size = TO_NUMBER_INLINE(siz
Committed patchset #3 (id:80001)
https://codereview.chromium.org/1109783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb
Cr-Commit-Position: refs/heads/master@{#28115}
https://codereview.chromium.org/1109783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
PTAL because the owner of X87 (Weiliang) asked for annual leave.
Thanks.
https://codereview.chromium.org/1104073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
Reviewers: Toon Verwaest,
Message:
Hi Toon,
Here is the CL we discussed, providing some performance gains. PTAL,
--Michael
ps - I cc'd MIPS folks in case they have comments.
Description:
Optimize the typeof operator.
typeof was implemented as a runtime function. Calling it in
optimized code wi
Comment #4 on issue 4062 by r...@chromium.org: Math.exp(-1) !== 1/Math.E
https://code.google.com/p/v8/issues/detail?id=4062
FWIW, the correctly rounded values for both Math.exp(-1) and 1/Math.E are
the same value: 0.36787944117144233. (Obtained from maxima)
I find it's really a disservice t
Reviewers: dcarney, dstence, jochen, michael_dawson,
Message:
Please TAL. This follows the example of Name::kHashFieldOffset for
endian-neutral accessors.
Description:
Fix JSArrayBuffer for big endian.
BUG=
R=joc...@chromium.org, dcar...@chromium.org, dste...@us.ibm.com,
michael_daw...@ca.ibm.
On 2015/04/28 08:02:17, wingo wrote:
Yesterday Andreas asked me to figure out what was happening
with "this" and "with" in script scopes -- why that mozilla
test was failing before the latest patch.
Of course, before my patch entirely, each "eval" scope
declared a "this" binding, which was pro
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1109783003/80001
https://codereview.chromium.org/1109783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: Benedikt Meurer, dstence, jochen, michael_dawson,
Message:
Please TAL
Description:
PPC: Fix HArrayBufferNotNeutered instruction
Fix faulty condition register usage after andi introduced by commit
a2e6f970c766c4e197a20eb7badd251757249355
BUG=
R=dste...@us.ibm.com, michael_daw...@ca.i
Updates:
Status: Fixed
Comment #5 on issue 4061 by a...@chromium.org: Derived class constructor
with return is not working as expected
https://code.google.com/p/v8/issues/detail?id=4061
(No comment was entered for this change.)
--
You received this message because this project is con
Comment #4 on issue 4061 by bugdro...@chromium.org: Derived class
constructor with return is not working as expected
https://code.google.com/p/v8/issues/detail?id=4061#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/baddc25eb2fa797649f92ba4a8fa7
Patchset 3 (id:??) landed as
https://crrev.com/baddc25eb2fa797649f92ba4a8fa7603ce38d49a
Cr-Commit-Position: refs/heads/master@{#28114}
https://codereview.chromium.org/1107203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1107203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1107203002/40001
https://codereview.chromium.org/1107203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1109783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1107053002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1107053002/diff/40001/test/cctest/test-parsing.cc#newcode6369
test/cctest/test-parsing.cc:6369: "[{x:x, y:y}, [a,b,c]]",
On 2015/04/28 16:01
lgtm
https://codereview.chromium.org/1107203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
This is based on https://codereview.chromium.org/1107203002/
The webkit tests have no copyright headers. I used the same header as on the
other webkit tests. Not sure if that is correct?
PTAL
https://codereview.chromium.org/1109783003/diff/60001/test/webkit/class-syntax-declaration-expected.tx
https://codereview.chromium.org/1107053002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1107053002/diff/40001/test/cctest/test-parsing.cc#newcode6369
test/cctest/test-parsing.cc:6369: "[{x:x, y:y}, [a,b,c]]",
On 2015/04/28 13:42
Status: Accepted
Owner: a...@chromium.org
CC: rossb...@chromium.org, dslo...@chromium.org
Labels: Type-Bug Priority-Medium Harmony
New issue 4063 by a...@chromium.org: Class declaration in sloppy harmony is
not visible?
https://code.google.com/p/v8/issues/detail?id=4063
From the webkit test:
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h#newcode22
src/compiler/pipeline.h:22: kToClosure = 1 << 3, // to a
specific function closure.
Gentle ping.
Ben plans to rebase as jochen refactors.
More feedback would be helpful.
Thanks :-)
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Go
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):
https://codereview.chromium.org/1113453003/diff/1/src/compiler/pipeline.h#newcode20
src/compiler/pipeline.h:20: kToNativeContext = 1 << 1, // to a
specific native context.
I
Adding Toon for high-level feedback.
https://codereview.chromium.org/1113453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Patchset 2 (id:??) landed as
https://crrev.com/a601987024aaaf13aebadb29ffba3613738a128a
Cr-Commit-Position: refs/heads/master@{#28113}
https://codereview.chromium.org/633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
I'm warming to this change/coming to terms with its inevitability.
Some non-blocking comments to consider.
* Please reconsider the 4x growth factor. It's caused by the resizing
heuristic
which is an unusual feature.
* Currently you can have a resize during a rehash. You should either be
s
My mistake. I had missed that the Rehash takes place on the compiler thread
after a failed lookup. Tricky!
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.cc#newcode5034
s
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1107053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Debug assert fixed.
Dmitry, can you take a look too?
https://codereview.chromium.org/1107203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Patchset 4 (id:??) landed as
https://crrev.com/80bf5686fa78cacf49200c6a15b249aa61ded25e
Cr-Commit-Position: refs/heads/master@{#28112}
https://codereview.chromium.org/1107053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
lgtm
https://codereview.chromium.org/1053123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1097283003/diff/21/src/scopeinfo.cc
File src/scopeinfo.cc (right):
https://codereview.chromium.org/1097283003/diff/21/src/scopeinfo.cc#newcode321
src/scopeinfo.cc:321:
name->Equals(*GetIsolate()->factory()->this_string());
On 2015/04/28 14:26:18, arv wrote
Patchset 1 (id:??) landed as
https://crrev.com/f39707cd964b27b11a996d72c898b0b6dbc0ab4a
Cr-Commit-Position: refs/heads/master@{#28111}
https://codereview.chromium.org/1110963003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1110963003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Hannes Payer, Dmitry Lomov (chromium),
Message:
+dslomov
Description:
Remove the weak list of array buffers
Instead, collect live array buffers during marking and free pointers we
no longer found.
BUG=v8:3996
R=hpa...@chromium.org
LOG=n
Please review this at https://codereview.chro
Committed patchset #1 (id:1)
https://codereview.chromium.org/1113593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/8a89a4a5ceeb58303cd9bc2d3e8d362742d59c96
Cr-Commit-Position: refs/heads/master@{#28110}
https://codereview.chromium.org/1113593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Updates:
Status: Fixed
Comment #5 on issue 3880 by mstarzin...@chromium.org: Linking binaries
takes ages
https://code.google.com/p/v8/issues/detail?id=3880
Using the gold linker (see comment #2) brought link time down to acceptable
levels again. I think the situation is acceptable a
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/633002/20001
https://codereview.chromium.org/633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Updates:
Status: WorkingAsIntended
Labels: -Priority-High Priority-Low
Comment #5 on issue 2144 by a...@chromium.org: Provide a way to create
ObjectEnvironmentRecords in the V8 API
https://code.google.com/p/v8/issues/detail?id=2144
I filed this because the code in Blink is ver
1 - 100 of 256 matches
Mail list logo
