Committed patchset #3 (id:40001)
https://codereview.chromium.org/1143993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/e56585077bdc3f6ce9990c86c00858c62eae790d
Cr-Commit-Position: refs/heads/master@{#28533}
https://codereview.chromium.org/1143993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1143993003/40001
https://codereview.chromium.org/1143993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
LGTM.
https://codereview.chromium.org/1148133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/05/20 15:39:39, bbudge wrote:
This seems to work, but it's complex code, so unit tests are needed. I
will
try
to add some, but am publishing now to get some early feedback on the
approach.
Any feedback on how to approach unit testing here is welcome. I don't see
any
Heap usage in e
LGTM with nit.
https://codereview.chromium.org/1145213004/diff/20001/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1145213004/diff/20001/include/v8config.h#newcode281
include/v8config.h:281: #endif
Nit: keep the empty line before the #endif.
https://codere
Comment #9 on issue 4121 by andreasl...@gmail.com: Regression: Memory leak
since at least 3.26.33
https://code.google.com/p/v8/issues/detail?id=4121
I had the same issue of the heap snapshots being just a few mb while the
process kept growing in size. Specifically, if you serve html files
Patchset 1 (id:??) landed as
https://crrev.com/a80d14b2b5fd57d6a1457395e7512b05862780e2
Cr-Commit-Position: refs/heads/master@{#28532}
https://codereview.chromium.org/1152473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1152473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1146103003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/5299d17733ab29377a86bd8569329c2ba29071e6
Cr-Commit-Position: refs/heads/master@{#28531}
https://codereview.chromium.org/1146103003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/d14a189c638b29b2e850d46a3ecfd15d2744ebe0
Cr-Commit-Position: refs/heads/master@{#28530}
https://codereview.chromium.org/1151753004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1151753004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1152473003/1
https://codereview.chromium.org/1152473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1146103003/1
https://codereview.chromium.org/1146103003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1152473003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1146103003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Cleanup interface descriptors to reflect that vectors are part of
loads.
port 09aaf003a93162420de88a5449f7de6e7eb04815 (r28516).
original commit message:
Also removed ornamentation like "VectorRaw" from stub names.
BUG=
Please revi
Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: [strong] Function arity check should be based on required parameters
port 78f0452d310221ac74b6221140d376d8302c4579 (r28491)
original commit message:
Also check whether the arguments count is smaller than the number of
required para
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/buildtools to dc487f429cb90cac92ec7a9cd9d49db13648064d
Rolling v8/tools/clang to c8d44a19b3bc34fe17b9b0361edebee4b9a70fdb
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1151753004/
Base U
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1151753004/1
https://codereview.chromium.org/1151753004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Comment #21 on issue 3578 by bugdro...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578#c21
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f6af3a492df73332ec
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1145013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/f6af3a492df73332ec5eadf5dd39664ac6d871da
Cr-Commit-Position: refs/heads/master@{#28529}
https://codereview.chromium.org/1145013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1145013002/20001
https://codereview.chromium.org/1145013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1145013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/05/20 20:21:15, hans wrote:
New patch uploaded.
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h#newcode273
include/v8config.h:273: #elif defined(_MSC_VER)
On 2
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33
src/harmony-typedarray.js:33: function ConstructTypedArray(constructor,
array) {
On 2015/05/20
I've cleanly applied the patch now.
There is some problem related to call spread.
test/mjsunit/harmony/spread-call-super-property.js is failing now.
I'm also seeing an invalid BailoutId in the same test with TF.
I'll look closer tomorrow.
https://codereview.chromium.org/1135243004/
--
--
v8
My responses below. Highlights are that I agree with most of the comments
and
have provided clarifications for a small number. I'll work on providing the
unittest now (but wanted to address the others and get the re-review
started in
parallel).
https://codereview.chromium.org/1131783003/d
Comment #34 on issue 811 by spen...@elastic.co: Implement destructuring
https://code.google.com/p/v8/issues/detail?id=811
Woohoo!!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
Status: Assigned
Owner: verwa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 4133 by verwa...@chromium.org: instanceof broken in crankshaft
https://code.google.com/p/v8/issues/detail?id=4133
There's an invalid one-element cache in crankshaft that breaks when you
1) Swap an indirect
Updates:
Status: Assigned
Comment #8 on issue 3967 by a...@chromium.org: CpuProfiler: Consumes 100%
of one core busy looping in ProfilerEventsProcessor::Run()
https://code.google.com/p/v8/issues/detail?id=3967
Ahh, the Windows case has not yet addressed.
--
You received this message
Try jobs failed on following builders:
v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2715)
https://codereview.chromium.org/1144883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Updates:
Status: Fixed
Comment #7 on issue 3967 by a...@chromium.org: CpuProfiler: Consumes 100%
of one core busy looping in ProfilerEventsProcessor::Run()
https://code.google.com/p/v8/issues/detail?id=3967
(No comment was entered for this change.)
--
You received this message becaus
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1144883002/50001
https://codereview.chromium.org/1144883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
I'll wait for Michael to take a final look. Michael, if everything looks
good
feel free to CQ.
https://codereview.chromium.org/1125183008/diff/11/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/1125183008/diff/11/src/ia32/full-
We do not assign issues to non-project members.
But feel free to indicate interest in comments to the issue you want to
work on and submit patches.
Best of luck!
Dmitry
On Wed, May 20, 2015 at 9:08 PM, Juan Vercellone wrote:
> Hi there,
>
> In order to start working on an issue, how can I assig
You can't, and you don't need to. Just leave a comment on the bug saying
that you're working on it.
On Wed, May 20, 2015 at 9:08 PM, Juan Vercellone wrote:
> Hi there,
>
> In order to start working on an issue, how can I assign it to myself?
>
> Thanks!!
>
> On Monday, July 26, 2010 at 3:41:37 P
Neat! lgtm % TF (looks good to me too but I am no expert)
https://codereview.chromium.org/1125183008/diff/11/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/1125183008/diff/11/src/ia32/full-codegen-ia32.cc#newcode1863
src/ia32/fu
New patch uploaded.
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h#newcode273
include/v8config.h:273: #elif defined(_MSC_VER)
On 2015/05/20 19:28:22, Nico (afk until Thu M
https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-builder.cc#newcode738
src/compiler/ast-graph-builder.cc:738:
DCHECK(!IsLivenessAnal
checked myself now that i'm on a laptop – I didn't change this as much as I
wanted.
In general, I think __clang__ checks should be kept to a minimum and the
gcc and
msvc macro checks should instead mostly do the right thing in clang mode
too. In
this case:
https://codereview.chromium.org/1
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33
src/harmony-typedarray.js:33: function ConstructTypedArray(constructor,
array) {
Also, this fu
Hi there,
In order to start working on an issue, how can I assign it to myself?
Thanks!!
On Monday, July 26, 2010 at 3:41:37 PM UTC-3, Rico Wind wrote:
>
> Suman,
>
> Please see:
> http://code.google.com/p/v8/wiki/Contributing
>
> Bugs are at:
> http://code.google.com/p/v8/issues
>
> Cheers,
> R
PTAL
This is now ready.
https://codereview.chromium.org/1125183008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33
src/harmony-typedarray.js:33: function ConstructTypedArray(constructor,
array) {
Where is this
Reviewers: Michael Starzinger,
Description:
[turbofan] Add bounds check to Node::InputAt(index) and fix tests that go
out of
bounds.
BUG=
Please review this at https://codereview.chromium.org/1149563004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+72, -45
On 2015/05/20 18:40:17, Nico (afk until Thu May 21) wrote:
On 2015/05/20 18:18:39, Reid Kleckner wrote:
> lgtm
Can you check where that explicit clang check for added? Iirc I removed
that a
while ago, but maybe I'm misremembering what exactly I did here.
Looks like it's been there since ht
On 2015/05/20 18:18:39, Reid Kleckner wrote:
lgtm
Can you check where that explicit clang check for added? Iirc I removed
that a
while ago, but maybe I'm misremembering what exactly I did here.
https://codereview.chromium.org/1145213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1144263002/1
https://codereview.chromium.org/1144263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Michael Achenbach,
Description:
Dropping iterations and speedup from perf results.
The dashboard displays everything on one scale.
This isn't very useful.
Dropping these two fields as they're not really that
interesting anyway.
BUG=https://code.google.com/p/v8/issues/detail?id=4124
L
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
https:/
Patchset 3 (id:??) landed as
https://crrev.com/37706b3ddf4597b3322f7ab4d2c767ad3503fe12
Cr-Commit-Position: refs/heads/master@{#28528}
https://codereview.chromium.org/1149723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1149723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149723002/40001
https://codereview.chromium.org/1149723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
https:/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149723002/40001
https://codereview.chromium.org/1149723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py
File test/simdjs/generate.py (right):
https://codereview.chromium.org/1149723002/diff/40001/test/simdjs/generate.py#newcode62
test/simdjs/generate.py:62: with open(os.path.join(SCRIPT_DIR,
'SimdJs.json'), 'w')
PTAL at patch 3
https://codereview.chromium.org/1149723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
Reviewers: bradnelson, bbudge,
Message:
PTAL. Feel free to hit the CQ if this looks alright.
Description:
[test] Fix simdjs perf tests.
- Missing resource on android
- Higher timeout on arm
- Fewer runs on arm
- Drop total
- Rename suite so that it fits to the naming scheme (this
means that the
lgtm
https://codereview.chromium.org/1145213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Reid Kleckner, Benedikt Meurer,
Message:
This should fix link errors such as
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/441/steps/gclient%20runhooks/logs/stdio
Description:
Set V8_HAS_DECLSPEC_SELECTANY for clang-cl
This macro is used for defining st
https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-builder.cc#newcode738
src/compiler/ast-graph-builder.cc:738:
DCHECK(!IsLivenessAnal
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Avoid excessive GCs in small heaps.
Small heaps and small heap growing factor can lead to excessive GCs in
corner
cases.
Consider function F(old_gen_size, factor) that returns the number of bytes
that
have to be allocated in the old gen
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
[turbofan] Fix variable liveness control structure creation.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1148133002/
Base URL: https://chromium.googlesource.com/v8/v8.git@mas
lgtm
https://codereview.chromium.org/1146113004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: titzer,
Description:
Remove obsolete JSFunction::IsOptimizable predicate.
This just delegates to SharedFunctionInfo::optimization_disabled and
was primarily used for assertions. Removing it due to misleading name
because already optimized functions reported being "non-optimizable".
R
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1148093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/3cc9c0e36f5ccd483e7611b0f98d1ff390b7628a
Cr-Commit-Position: refs/heads/master@{#28527}
https://codereview.chromium.org/1148093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
https://codereview.chromium.org/1127063003/diff/21/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1127063003/diff/21/src/scopes.cc#newcode1433
src/scopes.cc:1433: if (IsLexicalVariableMode(var->mode())) {
So this approach doesn't work --- it causes the
`DCHECK(
Comment #4 on issue 4130 by bugdro...@chromium.org: Proxy enumeration with
elements broken
https://code.google.com/p/v8/issues/detail?id=4130#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/de23dd280980bc2ae3e8f9a5a490e65e46cfc15b
commit de23d
Patchset 3 (id:??) landed as
https://crrev.com/de23dd280980bc2ae3e8f9a5a490e65e46cfc15b
Cr-Commit-Position: refs/heads/master@{#28526}
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Committed patchset #1 (id:1)
https://codereview.chromium.org/1145223003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/4a1ab1cac471f2fa5741723f174bb336e77eeda0
Cr-Commit-Position: refs/heads/master@{#28524}
https://codereview.chromium.org/1145143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/b4feaaccc3a432334f33eb737bccaddc631153c3
Cr-Commit-Position: refs/heads/master@{#28525}
https://codereview.chromium.org/1145223003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1145143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1148093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1148093002/20001
https://codereview.chromium.org/1148093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1145143002/1
https://codereview.chromium.org/1145143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: rossberg,
Message:
PTAL
Description:
Fix ToNameArray
BUG=
Please review this at https://codereview.chromium.org/1146113004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -2 lines):
M src/v8natives.js
M test/mjsunit/harmony/proxies-for.js
In
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1145223003/1
https://codereview.chromium.org/1145223003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1145223003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1148863002/40001
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
On 2015/05/20 14:32:12, rmcilroy wrote:
This is looking great Matthew, this is exaclty the direction I was hoping
for
-
thanks!
I have a load of comments but most are just nits. I've not looked closely
in
the
PPC port, I'm assuming you know what your doing here ;). In general, I
would
Updates:
Status: Assigned
Cc: mvstan...@chromium.org
Comment #8 on issue 4121 by ish...@chromium.org: Regression: Memory leak
since at least 3.26.33
https://code.google.com/p/v8/issues/detail?id=4121
That's an allocation site pretenuring mechanism that causes this.
Currently
Reviewers: dstence, michael_dawson, mvstanton,
Description:
PPC: Cleanup interface descriptors to reflect that vectors are part of
loads.
Port 09aaf003a93162420de88a5449f7de6e7eb04815
R=mvstan...@chromium.org, dste...@us.ibm.com, michael_daw...@ca.ibm.com
BUG=
Please review this at https://
Patchset 1 (id:??) landed as
https://crrev.com/1ec55616854380350e8f7f29dc5a5eb7bd9ecec5
Cr-Commit-Position: refs/heads/master@{#28523}
https://codereview.chromium.org/1144163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1144163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1144163002/1
https://codereview.chromium.org/1144163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Yang,
Message:
Created Revert of Use shared container to manage imports/exports.
Description:
Revert of Use shared container to manage imports/exports. (patchset #2
id:20001
of https://codereview.chromium.org/1143993003/)
Reason for revert:
Breaks nosnap bots
Original issue's des
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1144163002/ by jkumme...@chromium.org.
The reason for reverting is: Breaks nosnap bots.
https://codereview.chromium.org/1143993003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.goog
Try jobs failed on following builders:
v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2703)
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Reviewers: Hannes Payer, Benedikt Meurer,
Message:
This seems to work, but it's complex code, so unit tests are needed. I will
try
to add some, but am publishing now to get some early feedback on the
approach.
Any feedback on how to approach unit testing here is welcome. I don't see
any
He
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1148863002/1
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Updates:
Status: Fixed
Owner: verwa...@chromium.org
Cc: -verwa...@chromium.org
Comment #3 on issue 4130 by verwa...@chromium.org: Proxy enumeration with
elements broken
https://code.google.com/p/v8/issues/detail?id=4130
Will be fixed by https://codereview.chromium.org/
Reviewers: mvstanton,
Description:
Add a TurboFan skeleton for StringAddStub.
Currently the stub simply calls out to the runtime, this will be
improved in a later CLs. The current state at least avoids bit-rot and
later merging horror.
Contains quite a few tiny cleanups in stub-land, too.
Plea
lgtm
https://codereview.chromium.org/1148863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #32 on issue 811 by aneesiqb...@gmail.com: Implement destructuring
https://code.google.com/p/v8/issues/detail?id=811
I LOVE YOU GUYS! <3 <3 <3
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notifica
1 - 100 of 294 matches
Mail list logo
