https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc#newcode43
src/interpreter/interpreter.cc:43: if (initialized_) return;
On
Status: Untriaged
Owner:
Labels: Type-Bug Priority-Medium
New issue 4366 by tha...@chromium.org: clang/win: runtime-atomics.cc
doesn't build with -Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
..\..\v8\src\runtime\runtime-atomics.cc(161,15) : error(clang):
This is great! LGTM!
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/08/10 13:53:52, Hannes Payer wrote:
Committed patchset #1 (id:1) manually as
6575237d3d0d9a8ef065c488db4ec4d742bc124b (tree was closed).
lgtm, thank for merging!
https://codereview.chromium.org/1284673002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1281233003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1281233003/1
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/65c8ecc65ec8a6a95b7a1fdb96499dd1fbcd21aa
Cr-Commit-Position: refs/heads/master@{#30092}
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM
https://codereview.chromium.org/1278413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Issue 4366: clang/win: runtime-atomics.cc doesn't build with
-Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
This issue is now blocking issue chromium:505316.
See https://code.google.com/p/chromium/issues/detail?id=505316
--
You received this message because you are
lgtm
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
[heap] Avoid inclusion of heap internals in v8.h header.
R=mlippa...@chromium.org
Please review this at https://codereview.chromium.org/1283833002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -8 lines):
M
lgtm, thanks!
https://codereview.chromium.org/1283833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Comment #2 on issue 4366 by tha...@chromium.org: clang/win:
runtime-atomics.cc doesn't build with -Wunused-function
https://code.google.com/p/v8/issues/detail?id=4366
Hm, some of the uint64_ts are seem to be used for doubles. But the signed
int64_ts look like they're always unused.
--
https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc#newcode43
src/interpreter/interpreter.cc:43: if (initialized_) return;
What is
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
Patchset 1 (id:??) landed as
https://crrev.com/1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca
Cr-Commit-Position: refs/heads/master@{#30095}
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1278413002/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1278413002/80001
https://codereview.chromium.org/1278413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1283833002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1283833002/1
https://codereview.chromium.org/1283833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc#newcode86
src/debug/debug-scopes.cc:86: HandleScopeInfo
scope_info(shared_info-scope_info());
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1283513003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1283513003/1
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #53 on issue 2700 by lewisw...@gmail.com: Implement arrow functions
https://code.google.com/p/v8/issues/detail?id=2700
This issue should not be marked as `Fixed` until it's available in a stable
version. I've tested on Chrome 45Beta and the lexical `this` feature are
not supported.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1279613005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1279613005/1
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/34c564095685e997f1b14143994f6c26a13dc615
Cr-Commit-Position: refs/heads/master@{#30094}
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #20 on issue 4280 by bugdro...@chromium.org: Ignition interpreter
tracking bug
https://code.google.com/p/v8/issues/detail?id=4280#c20
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/cc74437ba70633fcee817a45aca74b41fec37d38
commit
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
Reviewers: Benedikt Meurer, Hannes Payer, titzer,
Message:
PTAL all reviewers, I would like to get sign-of on the below steps (1)-(3)
from
all reviewers. The optional step (4) only needs to be done once. Thanks!
Review-Instructions:
1) Read CL description of what the goal is.
2) Look at DEPS
Patchset 1 (id:??) landed as
https://crrev.com/3444bb6485036dd09635feca34b0a14050f4c374
Cr-Commit-Position: refs/heads/master@{#30097}
https://codereview.chromium.org/1283593005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Ping?
https://codereview.chromium.org/1282013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Description:
[heap] Avoid inclusion of objects-visiting-inl.h header.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/1272933004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+138, -143 lines):
M src/DEPS
Reviewers: Jakob, adamk,
Message:
Created Revert of Make run-tests.py warn when it's not testing anything
Description:
Revert of Make run-tests.py warn when it's not testing anything (patchset #1
id:1 of https://codereview.chromium.org/1283513003/ )
Reason for revert:
Some bots that don't run
Committed patchset #1 (id:1)
https://codereview.chromium.org/1283593005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1283593005/ by machenb...@chromium.org.
The reason for reverting is: Some bots that don't run tests (by design)
don't
return the test results json anymore which makes the infrastructure side
fail
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
Committed patchset #1 (id:1)
https://codereview.chromium.org/1283833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/986f1c10a1824030c7464baae6493696e11b4ace
Cr-Commit-Position: refs/heads/master@{#30093}
https://codereview.chromium.org/1283833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 5 (id:??) landed as
https://crrev.com/cc74437ba70633fcee817a45aca74b41fec37d38
Cr-Commit-Position: refs/heads/master@{#30096}
https://codereview.chromium.org/1278413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1278413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1283593005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1283593005/1
https://codereview.chromium.org/1283593005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Jakob, Michael Achenbach (OOO),
Description:
run-tests.py: warn when no tests were run
The previous approach to this (in 1b1de2d22) did not work well with
bots that intentionally run no tests. But I think this warning message
is still useful for developers.
Please review this at
On 2015/08/10 18:55:18, Michael Starzinger wrote:
PTAL all reviewers, I would like to get sign-of on the below steps (1)-(3)
from
all reviewers. The optional step (4) only needs to be done once. Thanks!
Review-Instructions:
1) Read CL description of what the goal is.
2) Look at DEPS for the
Sorry for the breakage, this one should have gone without NOTRY=true I
guess.
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Comment #55 on issue 2700 by aneesiqb...@gmail.com: Implement arrow
functions
https://code.google.com/p/v8/issues/detail?id=2700
Arrow functions are working flawlessly for me on nightly by the way.
--
You received this message because this project is configured to send all
issue
https://codereview.chromium.org/1284683004/diff/1/test/mjsunit/regress/regress-crbug-518748.js
File test/mjsunit/regress/regress-crbug-518748.js (right):
https://codereview.chromium.org/1284683004/diff/1/test/mjsunit/regress/regress-crbug-518748.js#newcode8
On 2015/08/10 at 21:57:37, mstarzinger wrote:
LGTM. Should we add a regression test?
Whoops, forgot to git add. :)
https://codereview.chromium.org/1277543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
LGTM on the limit in d8.cc, just a reliable test case is needed.
https://codereview.chromium.org/1284683004/diff/1/test/mjsunit/regress/regress-crbug-518748.js
File test/mjsunit/regress/regress-crbug-518748.js (right):
LGTM. Should we add a regression test?
https://codereview.chromium.org/1277543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
https://codereview.chromium.org/1284683004/diff/1/test/mjsunit/regress/regress-crbug-518748.js
File test/mjsunit/regress/regress-crbug-518748.js (right):
https://codereview.chromium.org/1284683004/diff/1/test/mjsunit/regress/regress-crbug-518748.js#newcode8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1282013002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1282013002/1
https://codereview.chromium.org/1282013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1282013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1277543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1282013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #4 on issue 4304 by bugdro...@chromium.org:
String.prototype.normalize should return abrupt completion from
ToString(this) (object or Symbol)
https://code.google.com/p/v8/issues/detail?id=4304#c4
The following revision refers to this bug:
Patchset 1 (id:??) landed as
https://crrev.com/f2acba0e8c0adc16fe6235f74067df771f500092
Cr-Commit-Position: refs/heads/master@{#30098}
https://codereview.chromium.org/1282013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1277543006/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1277543006/20001
https://codereview.chromium.org/1277543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Michael Achenbach (OOO),
Description:
Use TimeTicks instead of Time in FutexEmulation::Wait.
BUG=v8:4357
R=machenb...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1285723003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
https://codereview.chromium.org/1274193004/diff/20001/test/webkit/class-syntax-name-expected.txt
File test/webkit/class-syntax-name-expected.txt (right):
https://codereview.chromium.org/1274193004/diff/20001/test/webkit/class-syntax-name-expected.txt#newcode111
Reviewers: Michael Starzinger,
Description:
[d8 Workers] Add max worker count, throw an exception if too many.
BUG=chromium:518748
R=mstarzin...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1284683004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1281053003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1281053003/1
https://codereview.chromium.org/1281053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Michael Achenbach (OOO),
Description:
Update V8 DEPS.
Rolling v8/tools/clang to b66ad18bb147f02b74b207358140371382b0ef35
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1281053003/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected
Patchset 1 (id:??) landed as
https://crrev.com/a946401a7db1b4279cb53f53ab4fadbb8dcdd2e8
Cr-Commit-Position: refs/heads/master@{#30100}
https://codereview.chromium.org/1281053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1281053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #56 on issue 2700 by lewisw...@gmail.com: Implement arrow functions
https://code.google.com/p/v8/issues/detail?id=2700
@ross: I tried this code.
class Animal{
cat(){
new Sea().water(() = console.log(typeof this.water));
/*
* Result of `console.log(typeof
Comment #57 on issue 2700 by lewisw...@gmail.com: Implement arrow functions
https://code.google.com/p/v8/issues/detail?id=2700
@ross: I tried this code.
class Animal{
cat(){
new Sea().water(() = console.log(typeof this.water));
/*
* Result of `console.log(typeof
Reviewers: Michael Starzinger,
Description:
[d8 Workers] Make Worker prototype read-only
BUG=chromium:518747
R=mstarzin...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1277543006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -0
Comment #54 on issue 2700 by rossb...@chromium.org: Implement arrow
functions
https://code.google.com/p/v8/issues/detail?id=2700
@ #53: What have you tried? The feature should work in Chrome 45. If not
that would be a bug.
Regardless, please keep in mind that this is the V8 bug tracker,
Reviewers: adamk,
Description:
Use a new lexical context for sloppy-mode eval
In ES6, direct eval() in sloppy mode uses the enclosing function-level
(var) scope for var-style bindings and a new lexical scope for lexical
bindings like let and class. This patch implements that feature by making
https://codereview.chromium.org/1274193004/diff/40001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1274193004/diff/40001/src/parser.cc#newcode2016
src/parser.cc:2016: // Similarly, strict mode eval scope does not leak
variable declarations to
This comment's getting
Updates:
Status: Fixed
Comment #5 on issue 4304 by ad...@chromium.org: String.prototype.normalize
should return abrupt completion from ToString(this) (object or Symbol)
https://code.google.com/p/v8/issues/detail?id=4304
(No comment was entered for this change.)
--
You received this
Patchset 2 (id:??) landed as
https://crrev.com/cd9293445e69c51846795fe9f526e970585a1423
Cr-Commit-Position: refs/heads/master@{#30099}
https://codereview.chromium.org/1277543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 3 (id:??) landed as
https://crrev.com/be5c115952cfd53072bbac3c4f2b6dd068dfde53
Cr-Commit-Position: refs/heads/master@{#30089}
https://codereview.chromium.org/1257653011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Michael Lippautz,
Description:
[heap] Remove obsolete constructors from SemiSpaceIterator.
R=mlippa...@chromium.org
Please review this at https://codereview.chromium.org/1284643003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -21 lines):
M
lgtm
https://codereview.chromium.org/1284643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1284643003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1284643003/1
https://codereview.chromium.org/1284643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #60 on issue 4137 by raphael.kubo.da.co...@intel.com: Support
elements in the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137
Did the test case help? Is there anything else I can do?
--
You received this message because this project is configured to send all
Committed patchset #1 (id:1)
https://codereview.chromium.org/1284643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/0988f364a89b7cebf77b33a09e614b747fa41b9f
Cr-Commit-Position: refs/heads/master@{#30090}
https://codereview.chromium.org/1284643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1281923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Disable --global-var-shortcuts.
R=jkumme...@chromium.org
BUG=chromium:517778
LOG=Y
Please review this at https://codereview.chromium.org/1278353002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M
Reviewers: danno,
Description:
Add more OWNERS and set noparent for some sub-directories.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/1285543002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+20, -0 lines):
M
Reviewers: Yang,
Description:
[runtime] Remove unused %ToBool runtime function.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1277693004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -25 lines):
M src/runtime/runtime.h
M
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1278353002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1278353002/1
https://codereview.chromium.org/1278353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM, let's hope the bots have no objections.
https://codereview.chromium.org/1278353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
On 2015/08/10 09:04:05, Yang wrote:
On 2015/08/08 21:56:09, Jakob wrote:
Looks good. I have a couple of nits, and one high-level comment:
IIUC, this doesn't distinguish between getters and data properties. So
if
you
had this:
var error = /* some internally thrown error */
delete
On 2015/08/08 21:56:09, Jakob wrote:
Looks good. I have a couple of nits, and one high-level comment:
IIUC, this doesn't distinguish between getters and data properties. So if
you
had this:
var error = /* some internally thrown error */
delete error.message;
error.__proto__ =
lgtm
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/83c91aaf7bdec94d9862766cfd72b07917290052
Cr-Commit-Position: refs/heads/master@{#30084}
https://codereview.chromium.org/1278353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1278353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1285543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Comment #4 on issue 4359 by mlippa...@chromium.org: Crash in
v8::internal::MemoryChunk::IsEvacuationCandidate on arm64 in
mjsunit/strong/load-proxy.js
https://code.google.com/p/v8/issues/detail?id=4359
(No comment was entered for this change.)
--
You
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1281923002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1281923002/1
https://codereview.chromium.org/1281923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/6a8cb1756a0f6c3deee9db0fb968cf145f2b1582
Cr-Commit-Position: refs/heads/master@{#30083}
https://codereview.chromium.org/1281923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1281923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1277943003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Hey Yang,
Obvious one. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1277693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Jarin,
Description:
[turbofan] Drop V8_TURBOFAN_BACKEND and V8_TURBOFAN_TARGET defines.
TurboFan is now a requirement and supported by all backends, so we don't
need those macros (plus all the machinery on top) anymore.
R=ja...@chromium.org
Please review this at
Patchset 1 (id:??) landed as
https://crrev.com/6db78c8065855a1ffb3cfbf79406f51d1163102e
Cr-Commit-Position: refs/heads/master@{#30082}
https://codereview.chromium.org/1282763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
1 - 100 of 146 matches
Mail list logo
