LGTM.
https://codereview.chromium.org/1322623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jarin,
Description:
Version 4.6.85.9 (cherry-pick)
Merged 7fb31bdba4f2a0320507956a085f083d76bce48c
Merged bcc9df92734786e2c3dc51eca7ee684cf8e930cd
Make Simulator respect C stack limits as well.
PPC: Make Simulator respect C stack limits as well.
BUG=chromium:522380,chromium:522380
On 2015/08/31 06:06:30, mvstanton wrote:
lgtm (rubber-stamp)
https://codereview.chromium.org/1326463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Committed patchset #1 (id:1) manually as
f99d436a97b5e8264071ad950ef5923b7b0f7cda.
https://codereview.chromium.org/1326463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
On 2015/08/28 20:49:41, fedor.indutny wrote:
The results of benchmarks are:
./node-slow 1 && ./node-no-inline-fast 1 && ./node-fast 1
4997.4 ns/op
4701.6 ns/op
4685.7 ns/op
NOTE: `no-inline-fast` is the initial version of patch, `fast` - is
current,
`slow` - vanilla v8.
Please add the
lgtm with comments.
The next step would be moving the logic out of Heap into an
ArrayBufferTracker
that lives in heap/ and finally add some tests. It would probably have to
be a
cctest that checks the transitions from one map into another.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1322623007/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1322623007/1
https://codereview.chromium.org/1322623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1316873004/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1316873004/60001
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9247)
v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
On 2015/08/31 06:31:58, Michael Lippautz wrote:
On 2015/08/28 20:49:41, fedor.indutny wrote:
> The results of benchmarks are:
>
> ./node-slow 1 && ./node-no-inline-fast 1 && ./node-fast 1
> 4997.4 ns/op
> 4701.6 ns/op
> 4685.7 ns/op
>
> NOTE: `no-inline-fast` is the initial version of patch,
Made a typo in debug-only line. Going to rebuild it on my machine, and
resubmit
it again. Sorry about this!
(Also sounds like a good chance to update the description)
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1316873004/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1316873004/80001
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Try jobs failed on following builders:
v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/6081)
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1322623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/1d9642d37fdbbd27d12c3ba99e96912447ce78e0
Cr-Commit-Position: refs/heads/master@{#30456}
https://codereview.chromium.org/1322623007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Michael,
Looks like there is some issue on linux buildbot. I will investigate it, and
will try to submit a fix as soon as possible.
So far it looks like a double-free error to me.
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/31 06:45:29, fedor.indutny wrote:
On 2015/08/31 06:31:58, Michael Lippautz wrote:
> On 2015/08/28 20:49:41, fedor.indutny wrote:
> > I guess making them a scavenges might be the next step to improve the
> > performance.
> >
>
> I don't think there's much to improve on here with the
On 2015/08/31 07:16:39, Michael Lippautz wrote:
On 2015/08/31 06:45:29, fedor.indutny wrote:
> On 2015/08/31 06:31:58, Michael Lippautz wrote:
> > On 2015/08/28 20:49:41, fedor.indutny wrote:
> > > I guess making them a scavenges might be the next step to improve
the
> > > performance.
> > >
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING
builtin.
port 09de997b3504368d40644afa7310b90faff5d09c (r30442).
original commit message:
This adds a new ToString runtime function and a fast-path ToStringStub
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1314863003/140001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1314863003/140001
https://codereview.chromium.org/1314863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM.
https://codereview.chromium.org/1304873011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM. Thanks!
https://codereview.chromium.org/1325643002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1325643002/diff/1/src/api.cc#newcode6876
src/api.cc:6876: DCHECK(heap->gc_state() == i::Heap::NOT_IN_GC);
nit: DCHECK_EQ?
lgtm
https://codereview.chromium.org/1319423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1319423003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1319423003/1
https://codereview.chromium.org/1319423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Michael Starzinger,
https://codereview.chromium.org/1325643002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1325643002/diff/1/src/api.cc#newcode6876
src/api.cc:6876: DCHECK(heap->gc_state() == i::Heap::NOT_IN_GC);
On 2015/08/31 14:42:48, Michael
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1325643002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1325643002/20001
https://codereview.chromium.org/1325643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1323663003/60001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1323663003/60001
https://codereview.chromium.org/1323663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/31 03:43:05, paul.l... wrote:
Windows builds are not happy, will investigate further on Monday.
__declspec(align) will not take symbols, only numbers, according to this old
post: http://computer-programming-forum.com/7-vc.net/fbdd26987ff6f71e.htm.
I didn't find a suitable
Patchset 1 (id:??) landed as
https://crrev.com/8ff59e8d39df3d0a76d5192cbfdb3497a17f2d04
Cr-Commit-Position: refs/heads/master@{#30476}
https://codereview.chromium.org/1319423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1319423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Benedikt Meurer,
Message:
Benedikt: PTAL.
Igor: Please provide "ic" OWNER review.
Also, I am looking for a "regexp" OWNER that is _not_ on vacation right
now. :(
Description:
Make isolate.h usable without objects-inl.h header.
This CL us a pure refactoring that makes an empty
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1325483002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1325483002/40001
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 3 (id:??) landed as
https://crrev.com/ca8134c834e96eacb3c7756683fdf8220ba5054a
Cr-Commit-Position: refs/heads/master@{#30477}
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: Benedikt Meurer, Rodolph Perfetta (ARM),
Description:
Version 4.6.85.10 (cherry-pick)
Merged 434a291a0a05015d247c3604c27f88caaa181a51
Make FlushICache NOP for Nvidia Denver 1.0 only
R=bmeu...@chromium.org, rodolph.perfe...@arm.com
BUG=v8:4398
NOTRY=true
NOPRESUBMIT=true
Please
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1325643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/1a8c38c50513f9af07ada479629a653e1cf36ff3
Cr-Commit-Position: refs/heads/master@{#30478}
https://codereview.chromium.org/1325643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 4 (id:??) landed as
https://crrev.com/445747ad203d2b5bd0626af81dc17ba89723290b
Cr-Commit-Position: refs/heads/master@{#30479}
https://codereview.chromium.org/1323663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1323663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
I finished the mips ports and simplified the full-codegen changes.
https://codereview.chromium.org/1317383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/1306953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1306953005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1306953005/1
https://codereview.chromium.org/1306953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Besides fixing the double free, please also rebase on master. We had to land
https://codereview.chromium.org/1325643002/ as a bugfix today.
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1306683003/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1306683003/20001
https://codereview.chromium.org/1306683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1306953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/8b781ecc5df89b083428fb28912c330ed331a79d
Cr-Commit-Position: refs/heads/master@{#30480}
https://codereview.chromium.org/1306953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:20001)
https://codereview.chromium.org/1306683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/4d3a0a7ce69c6ac3210018664368f0e29da6df0d
Cr-Commit-Position: refs/heads/master@{#30481}
https://codereview.chromium.org/1306683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #6 on issue 4203 by bugdro...@chromium.org: Validate asm.js code
and use type information
https://code.google.com/p/v8/issues/detail?id=4203#c6
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/4d3a0a7ce69c6ac3210018664368f0e29da6df0d
Reviewers: titzer,
Description:
Drop region parameter to Unbounded, as it can be done without.
Unbounded is defined in terms of None any Any,
which don't require an explicit zone.
Switching Unbounded to be the same.
BUG= None
TEST= trybots
R= tit...@chromium.org
LOG=N
Please review this at
Reviewers: Benedikt Meurer,
https://codereview.chromium.org/1321223002/diff/1/src/unique.h
File src/unique.h (left):
https://codereview.chromium.org/1321223002/diff/1/src/unique.h#oldcode12
src/unique.h:12: #include "src/objects-inl.h" // TODO(everyone): Fix
our inl.h crap
Please appreciate
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1298973007/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1298973007/1
https://codereview.chromium.org/1298973007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/31 11:54:08, Michael Achenbach wrote:
lgtm - note that this string is just used for printing in the end. It
makes no
functional difference.
Yup, I understand. I noticed when I copied and pasted the commits to double
check with git show.
https://codereview.chromium.org/1298973007/
PTAL
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
On 2015/08/31
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1322003002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1322003002/1
https://codereview.chromium.org/1322003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1322003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Updates:
Cc: caitpott...@gmail.com
Comment #13 on issue 4307 by ad...@chromium.org: Implement well-known
symbol `Symbol.toPrimitive`
https://code.google.com/p/v8/issues/detail?id=4307
The trouble is that the behavior has yet to be specced. There was some
discussion on
Committed patchset #1 (id:1)
https://codereview.chromium.org/1322003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/204b6ff066eb735fe183783dc5b6d7ca14777867
Cr-Commit-Position: refs/heads/master@{#30482}
https://codereview.chromium.org/1322003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1298973007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6
Cr-Commit-Position: refs/heads/master@{#30483}
https://codereview.chromium.org/1298973007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #14 on issue 4307 by caitpott...@gmail.com: Implement well-known
symbol `Symbol.toPrimitive`
https://code.google.com/p/v8/issues/detail?id=4307
Just fyi, bz seems to agree with werwast's approach. Not sure if it was
ever concluded, but probably the way it will go for all well known
PTAL
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h#newcode17
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h#newcode17
PTAL
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h#newcode17
Updates:
Status: Assigned
Owner: little...@chromium.org
Cc: bmeu...@chromium.org
Comment #9 on issue 3822 by ad...@chromium.org: Optimize functions with
for-of
https://code.google.com/p/v8/issues/detail?id=3822
(No comment was entered for this change.)
--
You
Comment #15 on issue 4307 by bmeu...@google.com: Implement well-known
symbol `Symbol.toPrimitive`
https://code.google.com/p/v8/issues/detail?id=4307
Maybe I'm missing something, but the problem was already there with valueOf
and toString? @@toPrimitive just adds a new hook before them.
Comment #10 on issue 3822 by ad...@chromium.org: Optimize functions with
for-of
https://code.google.com/p/v8/issues/detail?id=3822
Dan was going to take a look at actually optimizing for-of (probably
starting with the built-ins: Arrays, Sets, and Maps).
bmeurer: this might already be on
LGTM! Ship it!
https://codereview.chromium.org/1321223002/diff/1/src/unique.h
File src/unique.h (left):
https://codereview.chromium.org/1321223002/diff/1/src/unique.h#oldcode12
src/unique.h:12: #include "src/objects-inl.h" // TODO(everyone): Fix
our inl.h crap
Appreciated!
Also, I am looking for a "regexp" OWNER that is _not_ on vacation right
now.
:(
Hm, wait I think I mentioned that this "process thing" will cause exactly
these
kinds of problems, yeah I'm pretty sure I did. I guess there is only one
word to
describe the outcome: "Haha!" (Nelson)
But
On 2015/08/31 19:10:57, Benedikt Meurer wrote:
> Also, I am looking for a "regexp" OWNER that is _not_ on vacation right
now.
:(
Hm, wait I think I mentioned that this "process thing" will cause exactly
these
kinds of problems, yeah I'm pretty sure I did. I guess there is only one
word
Comment #11 on issue 3822 by mstarzin...@chromium.org: Optimize functions
with for-of
https://code.google.com/p/v8/issues/detail?id=3822
I had some brief thoughts/ideas about this for the TurboFan part of things.
Nothing concrete yet, but very interested in this topic. Happy to
lgtm
https://codereview.chromium.org/1319983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1319983004/80001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1319983004/80001
https://codereview.chromium.org/1319983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
Is this also true? I
Committed patchset #4 (id:80001)
https://codereview.chromium.org/1319983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
LGTM from my side.
https://codereview.chromium.org/1320363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Benedikt Meurer, paul.l..., balazs.kilvady, gergely.kis.imgtec,
Message:
PTAL.
Description:
MIPS: [builtins] Pass correct number of arguments after adapting arguments.
Port fbad63669e309e8c5c3f2ecf503df2fefaac79bb
Original commit message:
The call protocol requires that the
Patchset 4 (id:??) landed as
https://crrev.com/ffa5e5fc3972eed63d477e09752abde69d6ad0b1
Cr-Commit-Position: refs/heads/master@{#30484}
https://codereview.chromium.org/1319983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #7 on issue 4203 by bugdro...@chromium.org: Validate asm.js code
and use type information
https://code.google.com/p/v8/issues/detail?id=4203#c7
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/ffa5e5fc3972eed63d477e09752abde69d6ad0b1
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1320363002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1320363002/20001
https://codereview.chromium.org/1320363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
All required reviewers (with asterisk prefixes) have not yet approved this
CL.
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See
LGTM.
https://codereview.chromium.org/1322953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
PTAL
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
On 2015/08/31
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1322953002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1322953002/1
https://codereview.chromium.org/1322953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #19 on issue 3087 by ape...@igalia.com: ES6: Array.prototype.slice
and friends should use ToLength instead of ToUint32
https://code.google.com/p/v8/issues/detail?id=3087
@ #18: I have ran the Octane benchmarks without and with the patch, and
there is no significative difference.
On 2015/08/31 20:00:14, aperez wrote:
mailto:ape...@igalia.com changed reviewers:
+ mailto:a...@chromium.org, mailto:dslo...@chromium.org,
mailto:rossb...@chromium.org,
mailto:wi...@igalia.com
PTAL. Also, if you see my latest comment in the bug, there does not seem to
be
any performance
Reviewers: wingo, arv (Not doing code reviews), rossberg, Dmitry Lomov (no
reviews),
Message:
On 2015/08/31 20:00:14, aperez wrote:
mailto:ape...@igalia.com changed reviewers:
+ mailto:a...@chromium.org, mailto:dslo...@chromium.org,
mailto:rossb...@chromium.org,
mailto:wi...@igalia.com
Committed patchset #1 (id:1)
https://codereview.chromium.org/1322953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/2b4ebd90430cab18a0d0b5dff779159b69bb095a
Cr-Commit-Position: refs/heads/master@{#30485}
https://codereview.chromium.org/1322953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #16 on issue 4307 by ad...@chromium.org: Implement well-known
symbol `Symbol.toPrimitive`
https://code.google.com/p/v8/issues/detail?id=4307
FWIW stable Firefox also throws for my test case, so I think it's not too
likely to break the web.
On a separate note, the HTML spec needs
Updates:
Cc: ad...@chromium.org
Comment #3 on issue 4400 by ad...@chromium.org: Default parameters segfault
when lazily parsed
https://code.google.com/p/v8/issues/detail?id=4400
(No comment was entered for this change.)
--
You received this message because this project is configured
Updates:
Blockedon: v8:2160
Comment #54 on issue 811 by ad...@chromium.org: Implement destructuring
https://code.google.com/p/v8/issues/detail?id=811
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
Issue 2160: Add support for default parameters
https://code.google.com/p/v8/issues/detail?id=2160
This issue is now blocking issue v8:811.
See https://code.google.com/p/v8/issues/detail?id=811
--
You received this message because you are listed in the owner
or CC fields of this issue, or
Updates:
Blockedon: v8:4395 v8:4400
Comment #16 on issue 2160 by ad...@chromium.org: Add support for default
parameters
https://code.google.com/p/v8/issues/detail?id=2160
(No comment was entered for this change.)
--
You received this message because this project is configured to
On 2015/08/27 13:05:52, dsinclair wrote:
On 2015/08/27 10:48:56, Yang wrote:
> On 2015/08/25 22:02:46, caseq wrote:
> >
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
> > File include/v8-tracing.h (right):
> >
> >
>
Issue 4400: Default parameters segfault when lazily parsed
https://code.google.com/p/v8/issues/detail?id=4400
This issue is now blocking issue v8:2160.
See https://code.google.com/p/v8/issues/detail?id=2160
--
You received this message because you are listed in the owner
or CC fields of this
Issue 4395: assignments in default parameter initializers
https://code.google.com/p/v8/issues/detail?id=4395
This issue is now blocking issue v8:2160.
See https://code.google.com/p/v8/issues/detail?id=2160
--
You received this message because you are listed in the owner
or CC fields of this
Reviewers: adamk,
Description:
Make Date.prototype an ordinary object
This is a change for ES2015. Date objects have mutable state, so having
a mutable prototype is bad for SES requirements, and it is an
inconsistency from the typical ES2015 class style of objects
BUG=v8:4004
LOG=Y
R=adamk
1 - 100 of 323 matches
Mail list logo
