[v8-dev] Re: Unify ElementsAccessor Array Builtins (issue 1302413006 by cbr...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302413006/1 https://codereview.chromium.org/1302413006/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

lgtm with a nit. https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js File src/array-iterator.js (right): https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82 src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator, arrayIteratorNextIndexSymbol))

[v8-dev] Re: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (issue 1316183004 by mlippa...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316183004/20001 https://codereview.chromium.org/1316183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [turbofan] Greedy: Unset hints at eviction. (issue 1313023003 by mtro...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313023003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313023003/60001 https://codereview.chromium.org/1313023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [turbofan] Greedy: Unset hints at eviction. (issue 1313023003 by mtro...@chromium.org)

LGTM https://codereview.chromium.org/1313023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [arm64] Don't try convert binary operation to shifted form when both operands are the same. (issue 1304923003 by ish...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304923003/1 https://codereview.chromium.org/1304923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (issue 1308113007 by ofrob...@google.com)

Committed patchset #1 (id:1) https://codereview.chromium.org/1308113007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (issue 1308113007 by ofrob...@google.com)

Patchset 1 (id:??) landed as https://crrev.com/5434d052f138adc0933c20ad24cc3d84555be53d Cr-Commit-Position: refs/heads/master@{#30536} https://codereview.chromium.org/1308113007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [Interpreter] Add support for property load operations. (issue 1309843007 by rmcil...@chromium.org)

Looking good, just one issue about evaluation order. https://codereview.chromium.org/1309843007/diff/60001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right):

[v8-dev] Re: Revert of [turbofan] Greedy: using hints (issue 1324763005 by habl...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324763005/1 https://codereview.chromium.org/1324763005/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Revert of [turbofan] Greedy: using hints (issue 1324763005 by habl...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1324763005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Revert of [turbofan] Greedy: using hints (issue 1324763005 by habl...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/93f1f198a629420d416d9e4805b921a807b5b7d6 Cr-Commit-Position: refs/heads/master@{#30537} https://codereview.chromium.org/1324763005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] [strong] weak classes can't inherit from strong ones (issue 1316333002 by conr...@chromium.org)

Reviewers: rossberg, Benedikt Meurer, Message: PTAL Description: [strong] weak classes can't inherit from strong ones Prerequisite for sealing strong class instances. Depends on https://codereview.chromium.org/1314203002/ BUG=v8:3956 LOG=N Please review this at

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

All fixed! Let's Land Zis Thing! ;) Thanks! https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc#newcode1778 src/heap/heap.cc:1778: reinterpret_cast(isolate_)

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326613002/11 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326613002/11 https://codereview.chromium.org/1326613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [turbofan] Greedy: Unset hints at eviction. (issue 1313023003 by mtro...@chromium.org)

Reviewers: Benedikt Meurer, Jarin, Description: [turbofan] Greedy: Unset hints at eviction. BUG= Please review this at https://codereview.chromium.org/1313023003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+13, -5 lines): M src/compiler/greedy-allocator.cc

[v8-dev] Revert of [turbofan] Greedy: using hints (issue 1324763005 by habl...@chromium.org)

Reviewers: Jarin, Benedikt Meurer, Mircea Trofin, Message: Created Revert of [turbofan] Greedy: using hints Description: Revert of [turbofan] Greedy: using hints (patchset #2 id:60001 of https://codereview.chromium.org/1329493004/ ) Reason for revert:

[v8-dev] Re: [turbofan] Greedy: using hints (issue 1329493004 by mtro...@chromium.org)

A revert of this CL (patchset #2 id:60001) has been created in https://codereview.chromium.org/1324763005/ by habl...@chromium.org. The reason for reverting is: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1338.

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

lgtm -- let's try again; since we lack test coverage in this area be prepared that we might need to revert it The next steps (if you would like to continue on this topic) would be - Tests! (cannot emphasize this enough) - Refactoring out in a separate class that is not embedded -

[v8-dev] Re: Issue 3956 in v8: Implement strong mode

Updates: Blockedon: -chromium:506591 Comment #63 on issue 3956 by conr...@chromium.org: Implement strong mode https://code.google.com/p/v8/issues/detail?id=3956 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/7498) https://codereview.chromium.org/1326613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 3005 in v8: cctest/test-alloc/CodeRange flakes on Win32

Updates: Status: Fixed Comment #6 on issue 3005 by mlippa...@chromium.org: cctest/test-alloc/CodeRange flakes on Win32 https://code.google.com/p/v8/issues/detail?id=3005 (No comment was entered for this change.) -- You received this message because this project is configured to send

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

We're getting there. https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc#newcode1778 src/heap/heap.cc:1778: reinterpret_cast(isolate_)

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

Michael, I have pushed one more update, which removes extra `erase()` call. https://codereview.chromium.org/1326613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

Reviewers: Jarin, Description: [es6] Fix invalid ToObject in String/Array iterator next. The spec says that the "this value" has to be an Object. R=ja...@chromium.org Please review this at https://codereview.chromium.org/1325023003/ Base URL:

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

Hey Jaro, This is the fix we talked about. Pretty straight forward. Please take a look. Thanks, Benedikt https://codereview.chromium.org/1325023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (issue 1316183004 by mlippa...@chromium.org)

Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9342) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9259)

[v8-dev] Re: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (issue 1316183004 by mlippa...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316183004/40001 https://codereview.chromium.org/1316183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [turbofan] Greedy: using hints (issue 1329493004 by mtro...@chromium.org)

Committed patchset #2 (id:60001) https://codereview.chromium.org/1329493004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Greedy: using hints (issue 1329493004 by mtro...@chromium.org)

Patchset 2 (id:??) landed as https://crrev.com/038f5eaf3bd6796ed6b7519de83c21d4e1f54850 Cr-Commit-Position: refs/heads/master@{#30534} https://codereview.chromium.org/1329493004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

Will do the proper review soon. Thanks for hanging onto this! https://codereview.chromium.org/1326613002/diff/60001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1326613002/diff/60001/src/heap/heap.cc#newcode1774 src/heap/heap.cc:1774:

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/9427d3255b2eba784a6a61ea998b566ff7d07c4b Cr-Commit-Position: refs/heads/master@{#30533} https://codereview.chromium.org/1325023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (issue 1308113007 by ofrob...@google.com)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308113007/1 https://codereview.chromium.org/1308113007/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (issue 1316183004 by mlippa...@chromium.org)

Committed patchset #3 (id:40001) https://codereview.chromium.org/1316183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (issue 1316183004 by mlippa...@chromium.org)

Patchset 3 (id:??) landed as https://crrev.com/61d1cedfb81f302724bc1517ac3a43602efec8b5 Cr-Commit-Position: refs/heads/master@{#30535} https://codereview.chromium.org/1316183004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: heap: make array buffer maps disjoint (issue 1326613002 by fe...@indutny.com)

Done. https://codereview.chromium.org/1326613002/diff/60001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1326613002/diff/60001/src/heap/heap.cc#newcode1774 src/heap/heap.cc:1774: not_yet_discovered_buffers->erase(data); On 2015/09/02 06:16:14, Michael

[v8-dev] Re: Unify ElementsAccessor Array Builtins (issue 1302413006 by cbr...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/fb44484ffddf461923ffc9390c1dff632e188ff4 Cr-Commit-Position: refs/heads/master@{#30532} https://codereview.chromium.org/1302413006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js File src/array-iterator.js (right): https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82 src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator, arrayIteratorNextIndexSymbol)) { Yeah, I'll

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325023003/1 https://codereview.chromium.org/1325023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [turbofan] Greedy: using hints (issue 1329493004 by mtro...@chromium.org)

lgtm https://codereview.chromium.org/1329493004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [arm64] Don't try convert binary operation to shifted form when both operands are the same. (issue 1304923003 by ish...@chromium.org)

lgtm https://codereview.chromium.org/1304923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [turbofan] Greedy: using hints (issue 1329493004 by mtro...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329493004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329493004/60001 https://codereview.chromium.org/1329493004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Unify ElementsAccessor Array Builtins (issue 1302413006 by cbr...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1302413006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (issue 1308113007 by ofrob...@google.com)

lgtm https://codereview.chromium.org/1308113007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [es6] Fix invalid ToObject in String/Array iterator next. (issue 1325023003 by bmeu...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1325023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Adding ElementsAccessor::Shift (issue 1317053006 by cbr...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317053006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317053006/60001 https://codereview.chromium.org/1317053006/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 4406 in v8: profiler has huge impact on performance for some code (mac)

Comment #4 on issue 4406 by rsturg...@google.com: profiler has huge impact on performance for some code (mac) https://code.google.com/p/v8/issues/detail?id=4406 #3 - can you repro in chrome? And to clarify I meant I see a difference between using --prof and not (same as in chrome case:

[v8-dev] Re: [heap] Separate ObjectStats out into its own class. (issue 1326793002 by mstarzin...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326793002/1 https://codereview.chromium.org/1326793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [heap] Move ObjectStatsVisitor into the proper component. (issue 1310953008 by mstarzin...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/310f2ece0f78d698e606e8166cfb13107ebc65d2 Cr-Commit-Position: refs/heads/master@{#30548} https://codereview.chromium.org/1310953008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [heap] Move ObjectStatsVisitor into the proper component. (issue 1310953008 by mstarzin...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1310953008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: PPC: VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() (issue 1325103003 by mbra...@us.ibm.com)

lgtm https://codereview.chromium.org/1325103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [heap] Move ObjectStatsVisitor into the proper component. (issue 1310953008 by mstarzin...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310953008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310953008/1 https://codereview.chromium.org/1310953008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Move register-operand and parameter-operand conversion routines into (issue 1325983002 by o...@chromium.org)

Still lgtm, thanks! https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc File src/interpreter/bytecodes.cc (right): https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode183 src/interpreter/bytecodes.cc:183:

[v8-dev] Re: Issue 4280 in v8: Ignition interpreter tracking bug

Comment #39 on issue 4280 by bugdro...@chromium.org: Ignition interpreter tracking bug https://code.google.com/p/v8/issues/detail?id=4280#c39 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/22983f71f95140d75faf8d5d0b0b7fdd2624e675 commit

[v8-dev] Re: Move register-operand and parameter-operand conversion routines into (issue 1325983002 by o...@chromium.org)

Committed patchset #5 (id:80001) https://codereview.chromium.org/1325983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Move register-operand and parameter-operand conversion routines into (issue 1325983002 by o...@chromium.org)

Looks much cleaner, thanks. Lgtm once comments are addressed. https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc File src/interpreter/bytecodes.cc (right): https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode173

[v8-dev] Re: PPC: VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() (issue 1325103003 by mbra...@us.ibm.com)

Patchset 1 (id:??) landed as https://crrev.com/e5fc7fe5fdeb4ac6d3a6dc4278a157d2831b9847 Cr-Commit-Position: refs/heads/master@{#30545} https://codereview.chromium.org/1325103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Adding ElementsAccessor::Shift (issue 1317053006 by cbr...@chromium.org)

Patchset 4 (id:??) landed as https://crrev.com/a369ab1838180284f4bbb668dfe18e2497567867 Cr-Commit-Position: refs/heads/master@{#30546} https://codereview.chromium.org/1317053006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Adding ElementsAccessor::Shift (issue 1317053006 by cbr...@chromium.org)

Committed patchset #4 (id:60001) https://codereview.chromium.org/1317053006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] [heap] Move ObjectStatsVisitor into the proper component. (issue 1310953008 by mstarzin...@chromium.org)

Reviewers: Michael Lippautz, Description: [heap] Move ObjectStatsVisitor into the proper component. This is a follow-up to a previous change and moved object statistics tracking into its own component. It is no longer intertwinded with the normal marking logic, but separated out into

[v8-dev] Re: [heap] Separate ObjectStats out into its own class. (issue 1326793002 by mstarzin...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/c7de3e7f27fb4068191a6434f47d20191e676ed6 Cr-Commit-Position: refs/heads/master@{#30547} https://codereview.chromium.org/1326793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [heap] Separate ObjectStats out into its own class. (issue 1326793002 by mstarzin...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1326793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: PPC: VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() (issue 1325103003 by mbra...@us.ibm.com)

Committed patchset #1 (id:1) https://codereview.chromium.org/1325103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Issue 4409 in v8: ArrayBuffer API triggers unnecessary mark-and-sweep events

Status: Untriaged Owner: New issue 4409 by m...@artillery.com: ArrayBuffer API triggers unnecessary mark-and-sweep events https://code.google.com/p/v8/issues/detail?id=4409 Version: 4.4.63 OS: all Architecture: all What steps will reproduce the problem? - reproduction code and

[v8-dev] Re: Issue 4409 in v8: ArrayBuffer API triggers unnecessary mark-and-sweep events

Updates: Status: Fixed Owner: mlippa...@chromium.org Labels: Type-Bug Area-GC Comment #1 on issue 4409 by mlippa...@chromium.org: ArrayBuffer API triggers unnecessary mark-and-sweep events https://code.google.com/p/v8/issues/detail?id=4409 As I said on the mailing

[v8-dev] Re: Move register-operand and parameter-operand conversion routines into (issue 1325983002 by o...@chromium.org)

Patchset 5 (id:??) landed as https://crrev.com/22983f71f95140d75faf8d5d0b0b7fdd2624e675 Cr-Commit-Position: refs/heads/master@{#30549} https://codereview.chromium.org/1325983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Move register-operand and parameter-operand conversion routines into (issue 1325983002 by o...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325983002/80001 https://codereview.chromium.org/1325983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [heap] Move ObjectStatsVisitor into the proper component. (issue 1310953008 by mstarzin...@chromium.org)

lgtm, thanks a lot! https://codereview.chromium.org/1310953008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [heap] Separate ObjectStats out into its own class. (issue 1326793002 by mstarzin...@chromium.org)

lgtm https://codereview.chromium.org/1326793002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: [presubmit] Fix build/include linter violations. (issue 1318863004 by mstarzin...@chromium.org)

LGTM! https://codereview.chromium.org/1318863004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [heap] introduce ArrayBufferTracker (issue 1324023007 by fe...@indutny.com)

Reviewers: Michael Lippautz, Message: Hello Michael! The refactoring as previously discussed. Any suggestions on how to do regression testing for the problems that we have observed with this things at first? Thanks! Description: [heap] introduce ArrayBufferTracker Move various

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

LGTM from me on code-stubs (although the ia32 dance looks hairy; I bet we need to do something about that performance-wise...) https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: Issue 4231 in v8: Don't allow try-catch variable redeclaration in for-of statement

Comment #3 on issue 4231 by ejcar...@chromium.org: Don't allow try-catch variable redeclaration in for-of statement https://code.google.com/p/v8/issues/detail?id=4231 https://codereview.chromium.org/1318023004 -- You received this message because this project is configured to send all

[v8-dev] Do not permit binding over catch parameters in for-of (issue 1318023004 by ejcar...@chromium.org)

Hm, I don't quite understand this CL. It seems to special-case for-loops, but there are many other constructs that could introduce conflicting bindings. Shouldn't these conflicts be detected in a more central place? Specifically, I think you want to invoke something similar to the existing

[v8-dev] Issue 4410 in v8: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows

Status: Started Owner: a...@chromium.org Labels: Type-Bug Priority-Medium OS-Windows Merge-Request-4.6 New issue 4410 by a...@chromium.org: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows https://code.google.com/p/v8/issues/detail?id=4410 It was caused by a deadlock

[v8-dev] Re: Issue 4410 in v8: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows

Updates: Cc: yu...@chromium.org Comment #2 on issue 4410 by a...@chromium.org: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows https://code.google.com/p/v8/issues/detail?id=4410 (No comment was entered for this change.) -- You received this message because

[v8-dev] Re: Issue 4410 in v8: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows

Updates: Labels: Merge-Request-4.5 Comment #1 on issue 4410 by a...@chromium.org: V8 freezes when CPU profiler is started on certain AMD CPUs under Windows https://code.google.com/p/v8/issues/detail?id=4410 (No comment was entered for this change.) -- You received this message

[v8-dev] Re: Do not permit binding over catch parameters in for-of (issue 1318023004 by ejcar...@chromium.org)

Reviewers: Dan Ehrenberg, rossberg, Message: On 2015/09/03 00:10:29, rossberg wrote: Hm, I don't quite understand this CL. It seems to special-case for-loops, but there are many other constructs that could introduce conflicting bindings. Shouldn't these conflicts be detected in a more central

[v8-dev] Update V8 DEPS. (issue 1316403006 by v8-autor...@chromium.org)

Reviewers: Hablich, Michael Achenbach, vogelheim, Description: Update V8 DEPS. Rolling v8/tools/clang to 91e7a78800b5849e27e098daa42e6ae8650ad322 TBR=machenb...@chromium.org,vogelh...@chromium.org,habl...@chromium.org Please review this at https://codereview.chromium.org/1316403006/ Base

[v8-dev] Re: Update V8 DEPS. (issue 1316403006 by v8-autor...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316403006/1 https://codereview.chromium.org/1316403006/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] MIPS: Vector ICs: platform support for vector-based stores. (issue 1318353003 by paul.l...@imgtec.com)

Reviewers: mvstanton, balazs.kilvady, akos.palfi.imgtec, Message: Hey Michael - here are MIPS ports, l-g-t-m for inclusion in your https://codereview.chromium.org/1328603003/ Description: MIPS: Vector ICs: platform support for vector-based stores. Port of

[v8-dev] Re: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1316933002 by bmeu...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316933002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316933002/140001 https://codereview.chromium.org/1316933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Update V8 DEPS. (issue 1316403006 by v8-autor...@chromium.org)

Patchset 1 (id:??) landed as https://crrev.com/ddb1a6b37853a6f7ff95bd9d07f118b09e558a9e Cr-Commit-Position: refs/heads/master@{#30551} https://codereview.chromium.org/1316403006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Update V8 DEPS. (issue 1316403006 by v8-autor...@chromium.org)

Committed patchset #1 (id:1) https://codereview.chromium.org/1316403006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [Interpreter] Skeleton bytecode graph builder [NOT FOR COMMIT] (issue 1291693004 by o...@chromium.org)

Graph creation skeleton looks good to me. https://codereview.chromium.org/1291693004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this

[v8-dev] Re: Vector ICs: platform support for vector-based stores. (issue 1328603003 by mvstan...@chromium.org)

Hi Michael, the MIPS ports are ready in https://codereview.chromium.org/1318353003/ https://codereview.chromium.org/1328603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

https://codereview.chromium.org/1272673003/diff/230001/src/parser.h File src/parser.h (right): https://codereview.chromium.org/1272673003/diff/230001/src/parser.h#newcode1324 src/parser.h:1324: !is_rest && pattern->IsVariableProxy() && initializer == nullptr; This makes sure the empty string is

[v8-dev] Re: [presubmit] Fix whitespace/empty_loop_body linter violations. (issue 1327523003 by mstarzin...@chromium.org)

LGTM! https://codereview.chromium.org/1327523003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1272673003/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1272673003/230001 https://codereview.chromium.org/1272673003/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

https://codereview.chromium.org/1272673003/diff/230001/src/parser.h File src/parser.h (right): https://codereview.chromium.org/1272673003/diff/230001/src/parser.h#newcode1324 src/parser.h:1324: !is_rest && pattern->IsVariableProxy() && initializer == nullptr; On 2015/09/02 20:11:31, caitp

[v8-dev] [Tick processor] Add an option to the tick-processor to print the summary. (issue 1318933004 by gdee...@google.com)

Reviewers: Michael Achenbach, Description: [Tick processor] Add an option to the tick-processor to print the summary. - Print the summary excluding other tick information - Add test to verify that summary is printed correctly. BUG=None Log=N R=machenb...@chromium.org Please review this at

[v8-dev] Re: Simplify object stats tracker a bit. (issue 10802032)

Reviewers: danno, Message: Closing. Superseded by: https://codereview.chromium.org/1310953008/ Description: Simplify object stats tracker a bit. R=da...@chromium.org Please review this at https://codereview.chromium.org/10802032/ Base URL:

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

On 2015/09/02 00:55:27, rossberg wrote: Parser changes LGTM, haven't looked at the rest. Hey, I just made one quick adjustment to the parser, in addition to a few updates for mips to get tests passing on the mips bots. I'll leave an inline comment to explain it, it would be good to get a

[v8-dev] Re: Issue 2160 in v8: Add support for default parameters

Comment #17 on issue 2160 by bugdro...@chromium.org: Add support for default parameters https://code.google.com/p/v8/issues/detail?id=2160#c17 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/510baeacbab311798d5e8795800ff773d00d062c commit

[v8-dev] Re: Issue 2700 in v8: Implement arrow functions

Comment #60 on issue 2700 by bugdro...@chromium.org: Implement arrow functions https://code.google.com/p/v8/issues/detail?id=2700#c60 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/510baeacbab311798d5e8795800ff773d00d062c commit

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

Committed patchset #13 (id:230001) https://codereview.chromium.org/1272673003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group

[v8-dev] Re: [es6] re-implement rest parameters via desugaring (issue 1272673003 by caitpotte...@gmail.com)

Patchset 13 (id:??) landed as https://crrev.com/510baeacbab311798d5e8795800ff773d00d062c Cr-Commit-Position: refs/heads/master@{#30550} https://codereview.chromium.org/1272673003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Failing assert on ARM and MIPS during GC: DCHECK_TAG_ALIGNED

Hi, v8 developers! I was hoping to be able to get some guidance from you about a problem that we've been seeing. The problem is that we've seen a failing assert on two of our platforms, one is ARM based and one is MIPS based, so it seems that it is not specific to one architecture. This is the

[v8-dev] Re: [Interpreter] Add support for property load operations. (issue 1309843007 by rmcil...@chromium.org)

LGTM from my end. https://codereview.chromium.org/1309843007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: [strong] weak classes can't inherit from strong ones (issue 1316333002 by conr...@chromium.org)

Committed patchset #5 (id:80001) https://codereview.chromium.org/1316333002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

  1   2   >